Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDYHa-0000jj-Cy for pgadmin-hackers@arkaria.postgresql.org; Thu, 16 Jun 2016 14:28:34 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bDYHZ-00042J-VO for pgadmin-hackers@arkaria.postgresql.org; Thu, 16 Jun 2016 14:28:34 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bDYHZ-00042B-1K for pgadmin-hackers@postgresql.org; Thu, 16 Jun 2016 14:28:33 +0000 Received: from mail-it0-x233.google.com ([2607:f8b0:4001:c0b::233]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bDYHW-0003BZ-0i for pgadmin-hackers@postgresql.org; Thu, 16 Jun 2016 14:28:31 +0000 Received: by mail-it0-x233.google.com with SMTP id h190so46549373ith.1 for ; Thu, 16 Jun 2016 07:28:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=DdEbj8idV3MTUyzdUNnptFph6Q2IDrAus5Swj97NAAw=; b=B0+RcjTAzFy2RyCjNNYcdtpkImYZNn/FC99pQoB5yxGEt2xd4342/rzWJzUBfGEiyY 6WWpyEXzo4CzHoKlEQvfnW+Nli/JdLjvlJQy0/vU+9/RekjmjhphP9L4YuLGi5r5qsn5 nC0zpPTybOp6HBeHvlx2H6VC1SeZaV+XFK+VFwIF6y5IeLMUDYaYo0xR9iC9yo41L6sM tIw6vA9e5hxlrh749M/MhaZhGORr39ZW0jjIpzz+GqrtFGW3BUpCBTm5I4eVhj2d3u4K LLcScmY5D2fZH5PX6s2s+2BQq7KK937W8w+aizYhh/70Dhu6xQJZ8AEafArI/JveY3P8 V24g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DdEbj8idV3MTUyzdUNnptFph6Q2IDrAus5Swj97NAAw=; b=LEXz8eAMBNQ88phPUKB1LXzDYt6KyM7DOg3gDu9/R/OXVGDyd/g02LcQZqj1Aaomrd 0B8frdx4lBTfowExEo6FtxjW5UjA/rAfWF2DyZkazVeDrS9CF9EUPDwX2gBfAdc6dNWc 0JR3utpL40UZofEm72qK5XN5Fkg5Sh39ydV9P+2K9W4unt8VPHx3L/G7rBSbqhdrWLzV N4J761DofMycXfY/Za6abfK9RT/P5DuhD4SixTQeprTzX0kXEVyDDy79vx/wts5sURoT z7A21wi8OjXgvAHsf1YK/kRX+7Wl71owImT3+bbEE5FC199lqHBFtQO5T0vruWYcGt/W 6Pog== X-Gm-Message-State: ALyK8tJChOADfjO2hd9Lc6brGtjSbVpxviVgezAZodB/sH+KuemsttLg/T1Z8vqgBIRpYMLQRXImRkPl5cAaLU4i X-Received: by 10.36.55.15 with SMTP id r15mr8426229itr.73.1466087309010; Thu, 16 Jun 2016 07:28:29 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.133.217 with HTTP; Thu, 16 Jun 2016 07:28:09 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Thu, 16 Jun 2016 19:58:09 +0530 Message-ID: Subject: Re: Fix for issue RM1336 [pgadmin4] To: Dave Page Cc: Harshal Dhumal , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113fe67a43a3520535660d8a X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113fe67a43a3520535660d8a Content-Type: text/plain; charset=UTF-8 On Thu, Jun 16, 2016 at 5:10 PM, Dave Page wrote: > On Thu, Jun 16, 2016 at 12:14 PM, Harshal Dhumal > wrote: > > Hi, > > > > As per my offline discussion with Ashesh; He is suggesting not to use > > Function keys as shortcuts. > > Why? That is primarily what they are on the keyboard for. > F5 is always bind to refresh function of the browser on linux & windows. Similarly - many shortcuts of browser are bound to the function keys. Hence - I asked not to use F5. > > > And regarding configurable key options, I suspect It is going to be time > > consuming task, please let me know if you want me to start working it. Or > > can we keep current shortcuts from my last patch? > > Surely we can come up with some simple ones that will be intuitive and > work? > > > > > On Thu, Jun 16, 2016 at 4:19 PM, Dave Page wrote: > >> > >> Hi > >> > >> Hmm, I guess that's system dependent. What about Ctrl+F5? Or we bite > >> the bullet and make it configurable. > >> > >> On Thu, Jun 16, 2016 at 11:47 AM, Harshal Dhumal > >> wrote: > >> > Hi Dave, > >> > > >> > Function keys won't work properly with browser as they already have > >> > predefined bindings. > >> > > >> > e.g. > >> > > >> > F5 for refresh (standard) > >> > F7 for Caret Browsing in firefox > >> > > >> > > >> > -- > >> > Harshal Dhumal > >> > Software Engineer > >> > > >> > EnterpriseDB India: http://www.enterprisedb.com > >> > The Enterprise PostgreSQL Company > >> > > >> > On Thu, Jun 16, 2016 at 4:10 PM, Harshal Dhumal > >> > wrote: > >> >> > >> >> Hi Dave, > >> >> > >> >> Ok, I'll change shortcut keys > >> >> > >> >> New shortcuts would be: > >> >> > >> >> Execute --> F5 > >> >> Explain --> F7 > >> >> Explain analyze --> Shift+F7 > >> >> > >> >> > >> >> > >> >> -- > >> >> Harshal Dhumal > >> >> Software Engineer > >> >> > >> >> EnterpriseDB India: http://www.enterprisedb.com > >> >> The Enterprise PostgreSQL Company > >> >> > >> >> On Thu, Jun 16, 2016 at 4:03 PM, Dave Page > wrote: > >> >>> > >> >>> Hi, > >> >>> > >> >>> Can we not make them compatible with pgAdmin 3? Ctrl + Shift + E is > >> >>> significantly less convenient than F5. > >> >>> > >> >>> On Thu, Jun 16, 2016 at 11:28 AM, Harshal Dhumal > >> >>> wrote: > >> >>> > Hi, > >> >>> > > >> >>> > PAF patch for issue RM1336 > >> >>> > > >> >>> > Changes: Added keyboard shortcuts (static/non configurable) to > some > >> >>> > query > >> >>> > tool operations. > >> >>> > > >> >>> > Execute --> Ctrl + Shift + E > >> >>> > Explain --> Ctrl + Shift + X > >> >>> > Explain analyze --> Ctrl + Shift + A > >> >>> > > >> >>> > Note: Keyboard shortcuts do not work if focus is set on any > disabled > >> >>> > button > >> >>> > inside query tool or out side the query tool. > >> >>> > > >> >>> > > >> >>> > -- > >> >>> > Harshal Dhumal > >> >>> > Software Engineer > >> >>> > > >> >>> > EnterpriseDB India: http://www.enterprisedb.com > >> >>> > The Enterprise PostgreSQL Company > >> >>> > > >> >>> > > >> >>> > -- > >> >>> > Sent via pgadmin-hackers mailing list > >> >>> > (pgadmin-hackers@postgresql.org) > >> >>> > To make changes to your subscription: > >> >>> > http://www.postgresql.org/mailpref/pgadmin-hackers > >> >>> > > >> >>> > >> >>> > >> >>> > >> >>> -- > >> >>> Dave Page > >> >>> Blog: http://pgsnake.blogspot.com > >> >>> Twitter: @pgsnake > >> >>> > >> >>> EnterpriseDB UK: http://www.enterprisedb.com > >> >>> The Enterprise PostgreSQL Company > >> >> > >> >> > >> > > >> > >> > >> > >> -- > >> Dave Page > >> Blog: http://pgsnake.blogspot.com > >> Twitter: @pgsnake > >> > >> EnterpriseDB UK: http://www.enterprisedb.com > >> The Enterprise PostgreSQL Company > > > > > > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > --001a113fe67a43a3520535660d8a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On Thu, Jun 16, 2016 at 5:10 PM, Da= ve Page <dpage@pgadmin.org> wrote:

On Thu, Jun 16, 2016 at 12:14 PM, Harshal Dhumal
<harshal.dhumal@enter= prisedb.com> wrote:
> Hi,
>
> As per my offline discussion with Ashesh; He is suggesting not to use<= br> > Function keys as shortcuts.

Why? That is primarily what they are on the keyboard for.
F5 is always bind to refresh function of the browser on linux &a= mp; windows.
Similarly - many shortcuts of browser are bound to t= he function keys.

Hence - I asked not to use F5.

> And regarding configurable key options, I suspect It is going to be ti= me
> consuming task, please let me know if you want me to start working it.= Or
> can we keep current shortcuts from my last patch?

Surely we can come up with some simple ones that will be intuitive a= nd work?

>
> On Thu, Jun 16, 2016 at 4:19 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> Hmm, I guess that's system dependent. What about Ctrl+F5? Or w= e bite
>> the bullet and make it configurable.
>>
>> On Thu, Jun 16, 2016 at 11:47 AM, Harshal Dhumal
>> <harshal.dhu= mal@enterprisedb.com> wrote:
>> > Hi Dave,
>> >
>> > Function keys won't work properly with browser as they al= ready have
>> > predefined bindings.
>> >
>> > e.g.
>> >
>> > F5 for refresh (standard)
>> > F7 for Caret Browsing in firefox
>> >
>> >
>> > --
>> > Harshal Dhumal
>> > Software Engineer
>> >
>> > EnterpriseDB India: http://www.enterprisedb.com
>> > The Enterprise PostgreSQL Company
>> >
>> > On Thu, Jun 16, 2016 at 4:10 PM, Harshal Dhumal
>> > <harsha= l.dhumal@enterprisedb.com> wrote:
>> >>
>> >> Hi Dave,
>> >>
>> >> Ok, I'll change shortcut keys
>> >>
>> >> New shortcuts would be:
>> >>
>> >> Execute=C2=A0 -->=C2=A0 =C2=A0F5
>> >> Explain=C2=A0 -->=C2=A0 =C2=A0 F7
>> >> Explain analyze=C2=A0 --> Shift+F7
>> >>
>> >>
>> >>
>> >> --
>> >> Harshal Dhumal
>> >> Software Engineer
>> >>
>> >> EnterpriseDB India: http://www.enterprisedb.com
>> >> The Enterprise PostgreSQL Company
>> >>
>> >> On Thu, Jun 16, 2016 at 4:03 PM, Dave Page <dpage@pgadmin.org> wrote:
>> >>>
>> >>> Hi,
>> >>>
>> >>> Can we not make them compatible with pgAdmin 3? Ctrl = + Shift + E is
>> >>> significantly less convenient than F5.
>> >>>
>> >>> On Thu, Jun 16, 2016 at 11:28 AM, Harshal Dhumal
>> >>> <harshal.dhumal@enterprisedb.com> wrote:
>> >>> > Hi,
>> >>> >
>> >>> > PAF patch for issue RM1336
>> >>> >
>> >>> > Changes: Added keyboard shortcuts (static/non co= nfigurable) to some
>> >>> > query
>> >>> > tool operations.
>> >>> >
>> >>> > Execute=C2=A0 -->=C2=A0 =C2=A0Ctrl + Shift + = E
>> >>> > Explain=C2=A0 -->=C2=A0 =C2=A0 Ctrl + Shift += X
>> >>> > Explain analyze=C2=A0 -->=C2=A0 =C2=A0Ctrl + = Shift + A
>> >>> >
>> >>> > Note: Keyboard shortcuts do not work if focus is= set on any disabled
>> >>> > button
>> >>> > inside query tool or out side the query tool. >> >>> >
>> >>> >
>> >>> > --
>> >>> > Harshal Dhumal
>> >>> > Software Engineer
>> >>> >
>> >>> > EnterpriseDB India: http://www.enterprisedb.co= m
>> >>> > The Enterprise PostgreSQL Company
>> >>> >
>> >>> >
>> >>> > --
>> >>> > Sent via pgadmin-hackers mailing list
>> >>> > (pgadmin-hackers@postgresql.org)
>> >>> > To make changes to your subscription:
>> >>> > http://www.postgresql.o= rg/mailpref/pgadmin-hackers
>> >>> >
>> >>>
>> >>>
>> >>>
>> >>> --
>> >>> Dave Page
>> >>> Blog: http://pgsnake.blogspot.com
>> >>> Twitter: @pgsnake
>> >>>
>> >>> EnterpriseDB UK: http://www.enterprisedb.com >> >>> The Enterprise PostgreSQL Company
>> >>
>> >>
>> >
>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=

--001a113fe67a43a3520535660d8a--