Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b01qv-0005Q6-Md for pgadmin-hackers@arkaria.postgresql.org; Tue, 10 May 2016 07:13:09 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1b01qv-00031F-9R for pgadmin-hackers@arkaria.postgresql.org; Tue, 10 May 2016 07:13:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1b01qi-0002nG-5g for pgadmin-hackers@postgresql.org; Tue, 10 May 2016 07:12:56 +0000 Received: from mail-ig0-x233.google.com ([2607:f8b0:4001:c05::233]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1b01qe-00026U-7e for pgadmin-hackers@postgresql.org; Tue, 10 May 2016 07:12:55 +0000 Received: by mail-ig0-x233.google.com with SMTP id u5so18396398igk.1 for ; Tue, 10 May 2016 00:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=dx2w8obPMum9QyHTS0lP2/tqaSaCy3ATTLmTjZntEH4=; b=vmQ3yr2dnhjy/PaivvSJW/FFyqu6IFi0QkbPYb80oBtX1XLkHYnrgWiBbO9kMNWsM0 9Bo6vQ15jIx708A0V1GTkwH6kndBtQDOQdhUIsUWP0dujNh/tXJois1RHKugbEp8skLZ 0cjerMPzBoLsGllYWVhpbODkY29ZevNta+0MgTBrWuu8jQ9jAliPpYbwBCnq/uVCGNXo SQgadDYuex3wu7gTSMnIPFSE1tHGv6JASRLmQ2Wf+wZ8QKaWfvV7SbhpKUPAV6uF80br DvFs1ds1pCVtlVixxE92oPFARm0opv30UUIoaRr4XrWnPPb5HGrZVQJWdDDIo3tIKorp Y0aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dx2w8obPMum9QyHTS0lP2/tqaSaCy3ATTLmTjZntEH4=; b=h0UvJtSCV3BDqYQ0THkOSwBJCZSknxEf2ro5zLZxERcGNSh07b3VQQ+Fz+dOezJ4dn I4/NdhZtLPhN0j9N9fsfevwSRTWzrMygo81k0hfcjOd7roP+UtheAoYiI5Q7gk7xXf59 ACHIDdfGJiRDBLGZL03sshehLnewt48cU3teSTm4tcuwaaq5SNb/zN72DFQhJe6epUpO cCN0CvVQBS1q+gBKne9GDeS49x0lk9H7nJ0cGA1RdDwT/WvrrSF50kUUB/OlyFFApPrE Dja8f99avy4ZujpIvjw6Zr5hBec58ObtcIrrTgh8qMoI6WfALaMcSmsgurYbWy/N4F99 ANog== X-Gm-Message-State: AOPr4FXhuMIXzHWZKH/Nx4pPNXBmXZcEmGXiJtZJ65luQD6kdl9xU+wyO7QXCYAexWwcNO8IF23EwjGJFNc2uxYf X-Received: by 10.50.69.4 with SMTP id a4mr15137947igu.70.1462864370553; Tue, 10 May 2016 00:12:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.31.209 with HTTP; Tue, 10 May 2016 00:12:31 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Tue, 10 May 2016 12:42:31 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: Backgrid StringDepsCell To: Khushboo Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=047d7bfe9aba29a276053277a7d2 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --047d7bfe9aba29a276053277a7d2 Content-Type: text/plain; charset=UTF-8 Thanks - committed! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Mon, May 9, 2016 at 12:26 PM, Khushboo Vashi < khushboo.vashi@enterprisedb.com> wrote: > Hi, > > Please find the attached re-based patch. > > Thanks, > Khushboo > > On Wed, Apr 6, 2016 at 2:38 PM, Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> Hi Khushboo, >> >> >> On Tue, Apr 5, 2016 at 10:59 AM, Khushboo Vashi < >> khushboo.vashi@enterprisedb.com> wrote: >> >>> Hi Ashesh, >>> >>> I have changed the function name (from *render_deps* to *updateUIDeps*), >>> which will be called on the dependent field change, as per your suggestion. >>> >> I've updated the patch. >> Please try this. >> I think - 'updateUIDeps' is not the write name. >> A Cell can do anything, when dependent changed, hence - I renamed it with >> 'dependentChanged'. >> >> Also, The user is not going to extend existing cell from the >> DependendsCell, but - only going to use the functions. >> Hence - I have created a separate class for it instead of extend it from >> Backgrid.Cell. >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> >> >>> >>> Please find attached patch for the same. >>> >>> Thanks, >>> Khushboo >>> >>> On Fri, Apr 1, 2016 at 3:56 PM, Khushboo Vashi < >>> khushboo.vashi@enterprisedb.com> wrote: >>> >>>> Hi Ashesh, >>>> >>>> Yes, agreed. This implementation limits us to use only String Cell. >>>> So, I have modified the patch as you suggested. >>>> >>>> Please find the attachment for the same. >>>> >>>> Thanks, >>>> Khushboo >>>> >>>> On Fri, Apr 1, 2016 at 2:59 PM, Ashesh Vashi < >>>> ashesh.vashi@enterprisedb.com> wrote: >>>> >>>>> Hi Khushboo, >>>>> >>>>> I am reluctant to use this code as it is. >>>>> I would prefer you create just helper functions (i.e. initialize, >>>>> remove) for the dependents in Backgrid.Cell, and then use them directly >>>>> from the different cell itself. >>>>> Because - this functionality limits us to us only with the string type. >>>>> >>>>> Anyway - we will be using the dependent functionality for very >>>>> attributes. >>>>> >>>>> >>>>> You can extend them directly in the Node's model (schema). >>>>> >>>>> -- >>>>> >>>>> Thanks & Regards, >>>>> >>>>> Ashesh Vashi >>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>> >>>>> >>>>> >>>>> *http://www.linkedin.com/in/asheshvashi* >>>>> >>>>> >>>>> On Wed, Mar 30, 2016 at 6:39 PM, Khushboo Vashi < >>>>> khushboo.vashi@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> Please find the attached patch for the Backgrid *StringDepsCell.* >>>>>> >>>>>> The *StringDepsCell* displays HTML escaped strings and accepts anything typed in. >>>>>> Also, Listen to the dependent fields. >>>>>> >>>>>> >>>>>> Usage of the Backgrid Cell: >>>>>> >>>>>> If the Precision cell is dependent on the Datatype then: >>>>>> >>>>>> { >>>>>> id: 'precision', label:'{{ _('Precision') }}', type: 'test' >>>>>> cell: *Backgrid.Extension.StringDepsCell*, deps: ['datatype'] >>>>>> >>>>>> } >>>>>> >>>>>> >>>>>> Thanks, >>>>>> Khushboo >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org >>>>>> ) >>>>>> To make changes to your subscription: >>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>>> >>>>>> >>>>> >>>> >>> >> > --047d7bfe9aba29a276053277a7d2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks - committed!

--

Thanks & Regards,=

Ashesh Vashi
EnterpriseDB INDIA: <= a href=3D"http://www.enterprisedb.com" target=3D"_blank">Enterprise Postgre= SQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Mon, May 9, 2016 at 12:26 PM, Khushboo Va= shi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Pl= ease find the attached re-based patch.

Thanks,
Khushboo

On Wed, Apr 6, 2016 at 2:= 38 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Khushboo,<= div class=3D"gmail_extra">


<= /div>
On Tue, Apr 5, 2016 at 10:59 AM= , Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Ashesh,

=
I have changed the function name (from render_deps = to updateUIDeps), which will be called on the dependent field change= , as per your suggestion.
I've upda= ted the patch.
Please try this.
I think - 'updateUI= Deps' is not the write name.
A Cell can do anything, when dep= endent changed, hence - I renamed it with 'dependentChanged'.
=

Also, The user is not going to extend existing cell fro= m the DependendsCell, but - only going to use the functions.
Henc= e - I have created a separate class for it instead of extend it from Backgr= id.Cell.

--

Than= ks & Regards,

Ashesh Vashi
EnterpriseDB INDIA= :=C2=A0En= terprise PostgreSQL Company



Please find att= ached patch for the same.

Thanks,
Khushb= oo

On Fri, Apr 1, 2016 at 3:56 PM, Khushboo Vashi <= ;khush= boo.vashi@enterprisedb.com> wrote:
Hi Ashesh,

Yes, agreed. This implementation l= imits us to use only String Cell.
So, I have modified the patch a= s you suggested.

Please find the attachment for th= e same.

Thanks,
Khushboo
=

On Fri, Apr = 1, 2016 at 2:59 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.co= m> wrote:
Hi Khushboo,
I am reluctant to use this code as it is.
I wou= ld prefer you create just helper functions (i.e. initialize, remove) for th= e dependents in Backgrid.Cell, and then use them directly from the differen= t cell itself.
Because - this functionality limits us to us only with th= e string type.

Anyway - we will be using the depen= dent functionality for very attributes.


=
You can extend them directly in the Node's model (schema). =C2=A0= =C2=A0

--

<= span style=3D"font-family:'courier new',monospace">Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Wed, Mar 30, 2016 at 6:39 PM, K= hushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch for the Backgrid StringDepsCe= ll.
The StringDepsCell displays HTML escaped strings an=
d accepts anything typed in.
Also, Listen to the dependent fields.


If the Precision cell is dependent on the Data= type then:
{
  id: 'precision', label:'{{ _(=
9;Precision') }}', type: 'test'
  cell: Backgrid.Exte=
nsion.StringDepsCell, deps: ['data=
type']
}

Tha= nks,
Khushboo=C2=A0



--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=







--047d7bfe9aba29a276053277a7d2--