Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bL7eI-0005q4-BE for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jul 2016 11:39:18 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bL7eH-0003Eb-V3 for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jul 2016 11:39:17 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bL7eH-0003ES-3A for pgadmin-hackers@postgresql.org; Thu, 07 Jul 2016 11:39:17 +0000 Received: from mail-io0-x22c.google.com ([2607:f8b0:4001:c06::22c]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bL7e9-0008Bq-MW for pgadmin-hackers@postgresql.org; Thu, 07 Jul 2016 11:39:15 +0000 Received: by mail-io0-x22c.google.com with SMTP id l202so17237048ioe.3 for ; Thu, 07 Jul 2016 04:39:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=w8Me5YznOoOrGssVW6oMzEs2karsAl6g+m+EUg4OL+0=; b=lrBSlwTNExCJk0jfd4Nlj+e4thSNxe+3ibqoVwXxPQhDsjaW52qpN8Ul7XH4jgAYAI Obltd7CLZp8OgEnZGgimtCNDdENemiFEcE2qBIQ3QGgdL41V5ljTPTSw8No+Art3u0Gd PEch07JvZKMZz1b/PClyTd+ZW7ayF32G9reelWxVYyGm3XMGIA8yjwG1dmJGja/YdgIj mGcUZnIIfrnQyn7D+E2svvz4SrjWD0icyfNyeeDi1+8OAOlqkHU1Mhadzk7bVEzu+Y1W EDWwRkAdMSqD+LwvgLirFQIhNY0LYfoX41jXAzKtXq5DgxkS1yjmJ1UE0TzqbIGwMKa4 vBFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=w8Me5YznOoOrGssVW6oMzEs2karsAl6g+m+EUg4OL+0=; b=Z1Yg2pWQK7+97hFUDHfSSQlm4EOoX+A99UugA1rahzy0zj3MOxjaVdbYwpVzcHOJM0 YQH11arPi5mn422B+btOOE1dktNCtvSU/OW7V/Anit/e0xi34NVHvcZjT+oC4UwpZ7gu rA9kly1n8iUy4py4ZndM4YZx13lBmvqC+J6LIEWQ8udhJ2dOofLmEPti6PzajpTunUgq YroRYpX+oVZoWGm7e6jfXqOS2pkTM3xD7IzNDCSbVW3+K2MRf49IB1DY4CMzzShQ9jgj BPKpuLJcbdctZXDHqzG2/aSzqd+/QtiZkWaxa0bkVcioUEHeST5GlxMwhBDPjy2wDbie fwcQ== X-Gm-Message-State: ALyK8tIZZBYdrN4b2cBywSMKO6U2zien24XUJw4D6c39+gjQpNkm+80CTq1ZQlLBaQjAQ+KAh1yXH3+x0FclTvw5 X-Received: by 10.107.37.69 with SMTP id l66mr2121610iol.117.1467891548822; Thu, 07 Jul 2016 04:39:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.133.217 with HTTP; Thu, 7 Jul 2016 04:38:49 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Thu, 7 Jul 2016 17:08:49 +0530 Message-ID: Subject: Re: patch for issue RM1260 [pgAdmin4] To: Dave Page Cc: Harshal Dhumal , pgadmin-hackers Content-Type: multipart/alternative; boundary=001a1140ea02562e2805370a2242 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1140ea02562e2805370a2242 Content-Type: text/plain; charset=UTF-8 Sure - I will do. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Thu, Jul 7, 2016 at 2:33 PM, Dave Page wrote: > Ashesh, can you review/commit please? > > Thanks. > > On Thu, Jul 7, 2016 at 7:50 AM, Harshal Dhumal < > harshal.dhumal@enterprisedb.com> wrote: > >> Hi, >> >> By mistake I deleted a line which was not supposed to be deleted, and >> that line of code was initialization of select2. >> >> -- >> *Harshal Dhumal* >> *Software Engineer* >> >> EnterpriseDB India: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Thu, Jul 7, 2016 at 12:13 PM, Ashesh Vashi < >> ashesh.vashi@enterprisedb.com> wrote: >> >>> Hi Harshal, >>> >>> Can you please explain - what was missing in the last patch? >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> >>> >>> >>> *http://www.linkedin.com/in/asheshvashi* >>> >>> >>> On Thu, Jul 7, 2016 at 12:12 PM, Harshal Dhumal < >>> harshal.dhumal@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> PFA updated patch for issue RM1260 >>>> >>>> -- >>>> *Harshal Dhumal* >>>> *Software Engineer* >>>> >>>> EnterpriseDB India: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> On Thu, Jul 7, 2016 at 12:04 PM, Harshal Dhumal < >>>> harshal.dhumal@enterprisedb.com> wrote: >>>> >>>>> Hi, >>>>> Please ignore this patch as this has some minor issue. I'll sent >>>>> updated one. >>>>> >>>>> -- >>>>> *Harshal Dhumal* >>>>> *Software Engineer* >>>>> >>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>>> On Wed, Jul 6, 2016 at 5:30 PM, Harshal Dhumal < >>>>> harshal.dhumal@enterprisedb.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> PFA patch for issue RM1260. >>>>>> >>>>>> Changes: Issue wasn't related to foreign table but was due the >>>>>> Select2 control. Now I have improved select2 control to handle null value >>>>>> in multi-select mode. Initial it was returning "null" instead it should >>>>>> return [] (empty array). >>>>>> >>>>>> >>>>>> -- >>>>>> *Harshal Dhumal* >>>>>> *Software Engineer* >>>>>> >>>>>> EnterpriseDB India: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>> To make changes to your subscription: >>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>> >>>> >>> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a1140ea02562e2805370a2242 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Sure - I will do.

--

Thanks & Regards,

Ashes= h Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Thu, Jul 7, 2016 at 2:33 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">Ashesh, can you review/commit please?

Th= anks.

On Thu, Jul 7, 2016 at 7:50 AM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

By mistake = I deleted a line which was not supposed to be deleted, and that line of cod= e was initialization of select2.
=
--=C2=A0
Harshal = Dhumal
Software Engineer

EnterpriseDB Ind= ia:=C2=A0http://www.enterprisedb.com=
The Enterprise PostgreSQL Company
<= /div>

On Thu, Jul 7, 2016 at 12:1= 3 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Harshal,
Can you please explain - what was missing in the last patc= h?

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Thu, Jul 7, 2016 at 12:12 PM, H= arshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,

PFA updated patch for issue RM1260
=

=
--=C2=A0
Harshal Dhumal
Software Enginee= r

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
T= he Enterprise PostgreSQL Company

On Thu, Jul 7, 2016 at 12:04 PM= , Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:
Hi,
Plea= se ignore this patch as this has some minor issue. I'll sent updated on= e.

<= div>
--=C2=A0
Harshal Dhumal
Soft= ware Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Jul 6, 2016 at 5:30= PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com>= wrote:
Hi,

PFA patch for issue RM1260.

Changes: Issue w= asn't related to foreign table but was due the Select2 control. Now I h= ave improved select2 control to handle null value in multi-select mode. Ini= tial it was returning "null" instead it should return [] (empty a= rray).


--=C2=A0
Harshal Dhumal
=
Software Engineer

EnterpriseDB India:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers=






--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

E= nterpriseDB UK: h= ttp://www.enterprisedb.com
The Enterprise PostgreSQL Company

--001a1140ea02562e2805370a2242--