Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aw5nM-0006NK-TG for pgadmin-hackers@arkaria.postgresql.org; Fri, 29 Apr 2016 10:37:13 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1aw5nM-0004jC-G3 for pgadmin-hackers@arkaria.postgresql.org; Fri, 29 Apr 2016 10:37:12 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1aw5nM-0004j6-2a for pgadmin-hackers@postgresql.org; Fri, 29 Apr 2016 10:37:12 +0000 Received: from mail-ig0-x22d.google.com ([2607:f8b0:4001:c05::22d]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1aw5nJ-0007m2-AP for pgadmin-hackers@postgresql.org; Fri, 29 Apr 2016 10:37:10 +0000 Received: by mail-ig0-x22d.google.com with SMTP id u10so18131577igr.1 for ; Fri, 29 Apr 2016 03:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KQuOaoo9tyhvFPMRHOtojEOGoeoDWgYhQnwXL4DYP5M=; b=urXkenU4pODeAB5mXVNymAVfIhTC7uL/wUK9vLSWc2utlnx3uqmyrjSwYjZDNMU0mM BN2OzzVuB2v3++MCVJLc8bUIDAd9AquRVlq3/ModLe3jius9wYnHFu+LL1aWRNigy17z 3fdKg/8Aa0VF4dOuleJC/ZPM39L0S7KaEzJLrphtNyC3i+aA158ttGc8EjUzpk2KDcoB 9Ov9qAO10WWZqMykC1CHbh+AtIVSSWiFiimuEBfPxmul4Tx/zVg+DMYeeIahWVZIhXBb Pip5+z+I97MmzrFH7rH8pKeEWpRylOXdHX65VnT7k5tRU8lm0H96vYB4VS35PBsWtJK6 XYsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KQuOaoo9tyhvFPMRHOtojEOGoeoDWgYhQnwXL4DYP5M=; b=OjqSBTGOhwUE7FGSYRH7Z2VIHuaIAg4Ctan95iwzDOZz7Fj9rrJ2u8DcVRUNQ2vKge H5Guixtl7U7C6VM2zICMliDmbjcLZBt8QM/qDTDeRMcS3oiIY+PdRA4C0ZZko6X7CnuM ZhhTr/iIwVqxwZDGF+UBEtqQHBbfqODG6m64LtjBlow751aPL5nrfqmkKIJ6rBclQOaq M1Z4SgIPT4EmrX0D4T34URJ6iOC8urlqlhZTVQThzrWblqYce7KL5s9rHL/bWZBsryEC AZRkasls7gq1bKF37OeCiAK8o27D1TvPyRiIoHZvNyKYiPMlT+75vhdxOimreP25cmZ5 z7uA== X-Gm-Message-State: AOPr4FVX6Ao3q91ROD40KCFgbMOWsjC1sfwx7Gr6r/8+RhNWcaIIlFnZ7ccuivCeKsPLIvCRflf5np6vKHPq1Y2P X-Received: by 10.50.102.69 with SMTP id fm5mr3512211igb.70.1461926228724; Fri, 29 Apr 2016 03:37:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.39.5 with HTTP; Fri, 29 Apr 2016 03:36:49 -0700 (PDT) In-Reply-To: References: From: Ashesh Vashi Date: Fri, 29 Apr 2016 16:06:49 +0530 Message-ID: Subject: Re: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl To: Surinder Kumar , Arun Kollan Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=047d7b10ca098d58bd05319d3954 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --047d7b10ca098d58bd05319d3954 Content-Type: text/plain; charset=UTF-8 Thanks - committed! Thanks Arun for the quick review! -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company *http://www.linkedin.com/in/asheshvashi* On Fri, Apr 29, 2016 at 11:34 AM, Surinder Kumar < surinder.kumar@enterprisedb.com> wrote: > Hi, > > More specifically to the issue. > I am using SqlFieldControl in View for Definition Field which takes > default height of 300px which is set by Control as default height. but as > per dave's suggestion on thread > > > http://www.postgresql.org/message-id/CA+OCxozN++8sFqJwJZ5QSFBxa7p-47apohOLtSotPBK6N5vUJA@mail.gmail.com > > "The Definition box on the View dialogue should start at a single > line and expand as needed - see the Function dialogue". > > If user still need some height for control, It can be specified in* > extraclasses[]* parameter which will apply to the specific field. > > > > On Thu, Apr 28, 2016 at 7:02 PM, Surinder Kumar < > surinder.kumar@enterprisedb.com> wrote: > >> Hi, >> >> The *SqlFieldControl* is setting default height for textarea, which is >> not needed. >> It should expand as needed as similar in *SqlTabControl*. >> >> Please find the attached patch, review it. >> >> Thanks >> Surinder Kumar >> > > --047d7b10ca098d58bd05319d3954 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Thanks - committed!

Thanks Arun for the= quick review!

--

<= p style=3D"margin:0pt">Thanks & Regards,
Ashesh Vashi
<= span style=3D"font-style:italic">EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Fri, Apr 29, 2016 at 11:34 AM, Surinder K= umar <surinder.kumar@enterprisedb.com> wrote:<= br>
Hi,

M= ore specifically to the issue.
I am using SqlFieldControl in View= for Definition Field which takes default height of 300px which is set by C= ontrol as default height. but as per dave's suggestion on thread
<= div>

"= ;The Definition box on the View dialogue should start at a single
line and expand as needed - see the Function dialogue".

If user still need some height for control, It can be spe= cified in extraclasses[] parameter which will apply to the specific = field.



On T= hu, Apr 28, 2016 at 7:02 PM, Surinder Kumar <surinder.kuma= r@enterprisedb.com> wrote:
=
Hi,

The=C2=A0SqlFieldControl is = setting default height for textarea, which is not needed.
It shou= ld expand as needed as similar in=C2=A0SqlTabControl.

=
Please find the attached patch, review it.

<= div>Thanks
Surinder Kumar


--047d7b10ca098d58bd05319d3954--