Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fLsts-000262-VH for pgadmin-hackers@arkaria.postgresql.org; Thu, 24 May 2018 16:15:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fLstr-0001sg-JM for pgadmin-hackers@arkaria.postgresql.org; Thu, 24 May 2018 16:15:35 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fLstr-0001sO-AY for pgadmin-hackers@lists.postgresql.org; Thu, 24 May 2018 16:15:35 +0000 Received: from mx0a-00296801.pphosted.com ([148.163.150.38]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fLstj-0003dN-N1 for pgadmin-hackers@postgresql.org; Thu, 24 May 2018 16:15:33 +0000 Received: from pps.filterd (m0114581.ppops.net [127.0.0.1]) by mx0a-00296801.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4OGB9bI015274 for ; Thu, 24 May 2018 16:15:26 GMT Received: from mail-ot0-f200.google.com (mail-ot0-f200.google.com [74.125.82.200]) by mx0a-00296801.pphosted.com with ESMTP id 2j2bnr62ur-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 24 May 2018 16:15:26 +0000 Received: by mail-ot0-f200.google.com with SMTP id w12-v6so620194otg.2 for ; Thu, 24 May 2018 09:15:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EZcVIDIfOk1DgSxADJBEtR0AxUQtqDyu7ddd/yl4yYQ=; b=G+r89wIeRS3w7fUFvJKIQx5BojbvD2UVeJtw2IUm3YLymCeOb1e48sx10VArDn/EsU SYRof5wQvRGjde8rr2gw7eSk1sRizn3CxeI9qy61tn6MO/VkqAwDkzq1CaQAQZYWpU1L qPsMKibrBhvB7UnHpY9AICeuP5d2MmXJmUF1VyorHiEvn1dv3JY+Y76LPaCyPXsPXwFK UNly1mcys2IEJJo6DU9wdOQJjd5UBnEcuKFHxxWblepuxCPxZfkPitVcQsBj2eVJpUwa wxQrFtni8mFWBtsuYpWZnURtGUIjZcafb6ah950KVYpC4moCzj3eVg/dZmaPVFdYCRZL TbcA== X-Gm-Message-State: ALKqPwfRaFqTv0t1x9TkZlEYN9F2bAKsKBtFntx0y6nTVzvKUrY7NI+j McpwNF0LtPnHTo/hPZNhUz8cYzhU+BoaLvvUbpklonYxZ9T2XxS+rjSyCawpWUV4XurlR5LFPHW rOo2FgOk1IMPP/fFrmXQqodaF0YyXeTnOuCOX0N9OzHzwhNPrPQCDpgEsAIIDa4sg47J9 X-Received: by 2002:aca:db82:: with SMTP id s124-v6mr4541227oig.339.1527178524700; Thu, 24 May 2018 09:15:24 -0700 (PDT) X-Google-Smtp-Source: AB8JxZqZkn4nMScGjWNywspdJldmireTYYPJ1ulIiKRsVU90zSfDIPLPus0n5azxE48qdMuErY3YOe6GuyCenEWNpP0= X-Received: by 2002:aca:db82:: with SMTP id s124-v6mr4541211oig.339.1527178524210; Thu, 24 May 2018 09:15:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Anthony Emengo Date: Thu, 24 May 2018 12:14:47 -0400 Message-ID: Subject: Re: [pgadmin4][patch] Use pytest test runner for unit tests To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="000000000000721aba056cf5f5f6" X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-24_06:,, signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=696 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1805240186 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000721aba056cf5f5f6 Content-Type: multipart/alternative; boundary="000000000000721ab5056cf5f5f4" --000000000000721ab5056cf5f5f4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Here=E2=80=99s a followup patch with the relevant README and Makefile chang= es. To be clear, both patches need to be applied in succession to run the tests. The error that you were running into was because the appropriate PYTHONPATH environment variable was not set. We updated the README to reflect that, but haven=E2=80=99t done anything to the code for that Thanks Joao && Anthony =E2=80=8B --000000000000721ab5056cf5f5f4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Here=E2=80=99s a followup patch with th= e relevant README and Makefile changes. To be clear, both patches need to b= e applied in succession to run the tests.

The error that you were running= into was because the appropriate PYTHONPATH enviro= nment variable was not set. We updated the README to reflect that, but have= n=E2=80=99t done anything to the code for that

Thanks
Joao && Antho= ny

=E2=80=8B
--000000000000721ab5056cf5f5f4-- --000000000000721aba056cf5f5f6 Content-Type: application/octet-stream; name="0002-Use-Pytests.diff.ci-skip" Content-Disposition: attachment; filename="0002-Use-Pytests.diff.ci-skip" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jhkqj5s60 ZGlmZiAtLWdpdCBhL01ha2VmaWxlIGIvTWFrZWZpbGUKaW5kZXggZjE2MzgwNC4uZTcwMzg4YiAx MDA2NDQKLS0tIGEvTWFrZWZpbGUKKysrIGIvTWFrZWZpbGUKQEAgLTM4LDcgKzM4LDcgQEAgY2hl Y2stcGVwODoKIAljZCB3ZWIgJiYgcHljb2Rlc3R5bGUgLS1jb25maWc9LnB5Y29kZXN0eWxlIC4K IAogY2hlY2stcHl0aG9uOgotCWNkIHdlYiAmJiBweXRob24gcmVncmVzc2lvbi9ydW50ZXN0cy5w eSAtLWV4Y2x1ZGUgZmVhdHVyZV90ZXN0cworCVBZVEhPTlBBVEg9JChQV0QpL3dlYiBweXRlc3Qg LXEgd2ViL3BnYWRtaW4KIAogY2hlY2stZmVhdHVyZTogaW5zdGFsbC1ub2RlIGJ1bmRsZQogCWNk IHdlYiAmJiBweXRob24gcmVncmVzc2lvbi9ydW50ZXN0cy5weSAtLXBrZyBmZWF0dXJlX3Rlc3Rz CmRpZmYgLS1naXQgYS9SRUFETUUgYi9SRUFETUUKaW5kZXggMmIyY2RkYy4uNmFjZjk1MCAxMDA2 NDQKLS0tIGEvUkVBRE1FCisrKyBiL1JFQURNRQpAQCAtMTE2LDcgKzExNiw3IEBAIHByb2Nlc3Mg aXMgZmFpcmx5IHNpbXBsZSAtIGFkYXB0IGFzIHJlcXVpcmVkIGZvciB5b3VyIGRpc3RyaWJ1dGlv bjoKIAogICAgIChwZ2FkbWluNCkgJCBQQVRIPSRQQVRIOi91c3IvbG9jYWwvcGdzcWwvYmluIHBp cCBpbnN0YWxsIC1yICRQR0FETUlONF9TUkMvcmVxdWlyZW1lbnRzLnR4dAogCi0gICBJZiB5b3Ug YXJlIHBsYW5uaW5nIHRvIHJ1biB0aGUgcmVncmVzc2lvbiB0ZXN0cywgeW91IGFsc28gbmVlZCB0 byBpbnN0YWxsCisgICBUbyBydW4gdGhlIHJlZ3Jlc3Npb24gdGVzdHMsIHlvdSBhbHNvIG5lZWQg dG8gaW5zdGFsbAogICAgYWRkaXRpb25hbCByZXF1aXJlbWVudHMgZnJvbSB3ZWIvcmVncmVzc2lv bi9yZXF1aXJlbWVudHMudHh0OgogCiAgICAocGdhZG1pbjQpICQgcGlwIGluc3RhbGwgLXIgJFBH QURNSU40X1NSQy93ZWIvcmVncmVzc2lvbi9yZXF1aXJlbWVudHMudHh0CkBAIC0yMTgsNiArMjE4 LDM2IEBAIGNhbiBiZSB1c2VkOgogICAgIEM6XCRQR0FETUlONF9TUkNcd2ViPiB5YXJuIGluc3Rh bGwKICAgICBDOlwkUEdBRE1JTjRfU1JDXHdlYj4geWFybiBydW4gYnVuZGxlCiAKK1Rlc3Rpbmcg dGhlIGFwcGxpY2F0aW9uCistLS0tLS0tLS0tLS0tLS0tLS0tLQorCitUaGUgYXBwbGljYXRpb24g aGFzIHRlc3RzIGZvciB0aGUgSmF2YXNjcmlwdCBhbmQgUHl0aG9uIGNvZGUsIHRoZXkgY2FuIGJl IHJ1biBzZXBhcmF0bHkgb3IgYWxsIHRvZ2V0aGVyLgorVG8gZW5zdXJlIHRoYXQgdGhlIHB5dGhv biB0ZXN0cyBydW4gdGhlIFBZVEhPTlBBVEggdmFyaWFibGUgbmVlZCB0byBleGlzdCBpbiB0aGUg ZW52aXJvbm1lbnQsIGluIG9yZGVyIHRvIGNyZWF0ZSBpdAorZXhlY3V0ZSB0aGUgZm9sbG93aW5n IGNvbW1hbmQ6CisKKyAgICAkIGV4cG9ydCBQWVRIT05QQVRIPSRQR0FETUlONF9TUkMvd2ViCisg ICAgJCBjZCAkUFlUSE9OUEFUSAorCitUbyBydW4gdGhlIEphdmFzY3JpcHQgb25seSB0ZXN0IHRo ZSBmb2xsb3dpbmcgY29tbWFuZCBjYW4gYmUgdXNlZDoKKworICAgIChwZ2FkbWluNCkgJCB5YXJu IHRlc3Q6a2FybWEtb25jZQorCitUbyBydW4gdGhlIFVuaXQgVGVzdHMgb24gdGhlIHB5dGhvbiBj b2RlIHRoZSBmb2xsb3dpbmcgY29tbWFuZCBjYW4gYmUgdXNlZDoKKworICAgIChwZ2FkbWluNCkg JCB5YXJuIHJ1biB0ZXN0OnVuaXQKKworVG8gcnVuIHRoZSBGZWF0dXJlIFRlc3RzIG9uIHRoZSBw eXRob24gY29kZSB0aGUgZm9sbG93aW5nIGNvbW1hbmQgY2FuIGJlIHVzZWQ6CisKKyAgICAocGdh ZG1pbjQpICQgeWFybiBydW4gdGVzdDpmZWF0dXJlCisKK1RvIHJ1biB0aGUgQWxsIFB5dGhvbiBU ZXN0cyB0aGUgZm9sbG93aW5nIGNvbW1hbmQgY2FuIGJlIHVzZWQ6CisKKyAgICAocGdhZG1pbjQp ICQgcHl0ZXN0IC1xIHBnYWRtaW4KKworVG8gcnVuIHRoZSBBbGwgVGVzdHMgdGhlIGZvbGxvd2lu ZyBjb21tYW5kIGNhbiBiZSB1c2VkOgorCisgICAgKHBnYWRtaW40KSAkIHlhcm4gcnVuIHRlc3QK KwogQ29uZmlndXJpbmcgdGhlIFJ1bnRpbWUKIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAKZGlm ZiAtLWdpdCBhL3dlYi9wYWNrYWdlLmpzb24gYi93ZWIvcGFja2FnZS5qc29uCmluZGV4IGE4NmQx OTEuLjkwMjlhZTkgMTAwNjQ0Ci0tLSBhL3dlYi9wYWNrYWdlLmpzb24KKysrIGIvd2ViL3BhY2th Z2UuanNvbgpAQCAtOTksNyArOTksNyBAQAogICAgICJidW5kbGUiOiAiY3Jvc3MtZW52IE5PREVf RU5WPXByb2R1Y3Rpb24geWFybiBydW4gYnVuZGxlOmRldiIsCiAgICAgInRlc3Q6a2FybWEtb25j ZSI6ICJ5YXJuIHJ1biBsaW50ZXIgJiYgeWFybiBydW4ga2FybWEgc3RhcnQgLS1zaW5nbGUtcnVu IiwKICAgICAidGVzdDprYXJtYSI6ICJ5YXJuIHJ1biBsaW50ZXIgJiYgeWFybiBydW4ga2FybWEg c3RhcnQiLAotICAgICJ0ZXN0OnVuaXQiOiAieWFybiBydW4gbGludGVyICYmIHB5dGVzdCAtcSBw Z2FkbWluIiwKKyAgICAidGVzdDp1bml0IjogInlhcm4gcnVuIHBlcDggJiYgcHl0ZXN0IC1xIHBn YWRtaW4iLAogICAgICJ0ZXN0OmZlYXR1cmUiOiAieWFybiBydW4gYnVuZGxlICYmIHB5dGhvbiBy ZWdyZXNzaW9uL3J1bnRlc3RzLnB5IC0tcGtnIGZlYXR1cmVfdGVzdHMiLAogICAgICJ0ZXN0Ijog Inlhcm4gcnVuIHRlc3Q6a2FybWEtb25jZSAmJiB5YXJuIHJ1biBidW5kbGUgJiYgeWFybiB0ZXN0 OnVuaXQgJiYgcHl0aG9uIHJlZ3Jlc3Npb24vcnVudGVzdHMucHkgLS1wa2cgZmVhdHVyZV90ZXN0 cyIsCiAgICAgInBlcDgiOiAicHljb2Rlc3R5bGUgLS1jb25maWc9LnB5Y29kZXN0eWxlIC4iCg== --000000000000721aba056cf5f5f6--