public inbox for [email protected]  

help / color / mirror / Atom feed

From: Sarah McAlear <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [Patch] Rename feature test server
Date: Thu, 27 Apr 2017 17:22:45 -0400
Message-ID: <CAGRPzo-PYByzi70KRYYQKtvp2pevMmp1bopcF9-wvZbWqtCwyg@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi Hackers!

We realized that the feature tests and unit tests were using the same
server, which was causing some flakiness when running the tests. This patch
renames the server for the feature tests.

Thanks!
Joao & Sarah


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] 0001-Change-the-name-of-the-Server-created-for-Feature-te.patch (1.3K, 3-0001-Change-the-name-of-the-Server-created-for-Feature-te.patch)
  download | inline diff:
From 0672de780c506cd1ca885a55a7bf0cc5f2f9b0ab Mon Sep 17 00:00:00 2001
From: Joao Pereira and Sarah McAlear <[email protected]>
Date: Thu, 27 Apr 2017 17:14:10 -0400
Subject: [PATCH] Change the name of the Server created for Feature tests
 [#144055953]

---
 web/regression/feature_utils/base_feature_test.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/web/regression/feature_utils/base_feature_test.py b/web/regression/feature_utils/base_feature_test.py
index dc704e8e..89954290 100644
--- a/web/regression/feature_utils/base_feature_test.py
+++ b/web/regression/feature_utils/base_feature_test.py
@@ -13,6 +13,8 @@ import os
 
 from datetime import datetime
 
+from copy import deepcopy
+
 import config as app_config
 from pgadmin.utils.route import BaseTestGenerator
 from regression.feature_utils.pgadmin_page import PgadminPage
@@ -22,6 +24,8 @@ class BaseFeatureTest(BaseTestGenerator):
     CURRENT_PATH = os.path.dirname(os.path.realpath(__file__))
 
     def setUp(self):
+        self.server = deepcopy(self.server)
+        self.server['name'] += ' Feature Tests'
         if app_config.SERVER_MODE:
             self.skipTest("Currently, config is set to start pgadmin in server mode. "
                           "This test doesn't know username and password so doesn't work in server mode")
-- 
2.12.0

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [Patch] Rename feature test server
  In-Reply-To: <CAGRPzo-PYByzi70KRYYQKtvp2pevMmp1bopcF9-wvZbWqtCwyg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox