Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d5fAq-0006iN-Sr for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 May 2017 21:17:33 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d5fAq-0001Zu-FW for pgadmin-hackers@arkaria.postgresql.org; Tue, 02 May 2017 21:17:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d5fAq-0001Zl-1R for pgadmin-hackers@postgresql.org; Tue, 02 May 2017 21:17:32 +0000 Received: from mail-io0-x235.google.com ([2607:f8b0:4001:c06::235]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d5fAk-0006ap-54 for pgadmin-hackers@postgresql.org; Tue, 02 May 2017 21:17:31 +0000 Received: by mail-io0-x235.google.com with SMTP id k91so1713277ioi.1 for ; Tue, 02 May 2017 14:17:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Aq8zcdXQKLHpXBhO7R9DW3kH4QG8hR3iMAMFu02HouI=; b=lu9SOWx6GA1FxqasYM/DU3ZCyzfALTLQv2GraPLPKlmrKgPnUFDAOx3sdj4+sqVmnZ krzdIZimW0nPwmqzNFGCFZ058JX7pOuANDhizn2P+ZLbEGWKANndMLJAZ0hF+3YvJP2E Vhw5KKq1jGFtHWVXNqRHeotmVIzGocjPHGOdWM0aPmmN6nMOecDydnAZPAnWxZFtLhPc vzmJ1iDrYdm6k4MOcGA9wGUmyKrfyqVwyMwOM0ouwEuHVWcLpxbUtIaMYADouhSlLfZI NEZXaj7Wodmc/izJXk6OWSNGVZaFZiPAJwq5Vq0SmIHUK2GPkpqzXUCAK/OKonGewA0m 8Byw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Aq8zcdXQKLHpXBhO7R9DW3kH4QG8hR3iMAMFu02HouI=; b=GtCsTL7UoX8IBMmCLI2wuOB1Xxw0LEgwYgR2u/i2Vb9WjwA1eP5WB3z9QlwAMPnIns oBYpuVMv3iYWvjxlMcyKiIiIuxy6jb/e69TxnT6IRAPPDa6G5rXa0CHBrTjFmgxdA3Qh HABp0ierZfDzq7CkwkKtbiYRGn3TpDOUuluGLde5H5yy6E7YKk851tZSBHZwepa0vL3R bU9DIg5ZgiH5rcGp4PbTxYd05dUa/KAABGHsguS+BSOsUbfqMsEJQYvMl24063INk2mw vzqzkDtUchRGzlCS9ulkXRnmFX+p5Myzu7g5Ln1VX4tPvnnBoXKXj37M3AmycS0ixoBy SMkA== X-Gm-Message-State: AN3rC/6fq0bgHCJma/aE5JefTYkUBUjvwFPNa6DjSzpVdoWF1Qk02CjG J+E1L+EpjOP4eKzYypYWH5NaD6J+1+ev X-Received: by 10.107.130.99 with SMTP id e96mr30502974iod.38.1493759843735; Tue, 02 May 2017 14:17:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.169.216 with HTTP; Tue, 2 May 2017 14:17:03 -0700 (PDT) In-Reply-To: References: From: Sarah McAlear Date: Tue, 2 May 2017 17:17:03 -0400 Message-ID: Subject: Re: [patch] Dependents and Dependencies in GreenPlum To: Joao Pedro De Almeida Pereira Cc: Ashesh Vashi , Dave Page , pgadmin-hackers , Matthew Kleiman Content-Type: multipart/alternative; boundary=001a113f26a6ddc52c054e91108c X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113f26a6ddc52c054e91108c Content-Type: text/plain; charset=UTF-8 Hi Hackers & Ashesh! Is there anything else we can do for this? Thanks! Matt & Sarah On Thu, Apr 27, 2017 at 10:37 AM, Joao Pedro De Almeida Pereira < jdealmeidapereira@pivotal.io> wrote: > Thanks for reviewing, Ashesh. > > We have updated the patch. The headers are all consistent and we removed > the __init__.py files in directories containing only .sql. > > Thanks! > Joao & Matt > > On Wed, Apr 26, 2017 at 11:22 AM, Joao Pedro De Almeida Pereira < > jdealmeidapereira@pivotal.io> wrote: > >> Hello Ashesh, >> >> Thanks for reviewing the patch. >> >> We added the __init__.py files into templates to convert them into >> packages so that the tests inside of them can be found by the test runner. >> >> Thanks! >> Joao & Sarah >> >> On Wed, Apr 26, 2017 at 1:26 AM, Ashesh Vashi < >> ashesh.vashi@enterprisedb.com> wrote: >> >>> On Mon, Apr 24, 2017 at 4:43 PM, Dave Page wrote: >>> >>>> Ashesh, can you review/commit this please? >>>> >>>> On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira < >>>> jdealmeidapereira@pivotal.io> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> We found out that when you are connected to a GreenPlum database and >>>>> try to get Dependents and Dependencies of an object the application was >>>>> returning a SQL error. >>>>> >>>>> This patch splits the SQL query used to retrieve the Dependents, >>>>> Dependencies, and Roles SQL file into multiple versioned files. >>>>> Add Unit Tests for each file. >>>>> Also added __init__.py files to other test directories to run the >>>>> tests in them. >>>>> >>>> Hi Joao & Sarah, >>> >>> Why do we need to add __init__.py in the template directory? >>> I didn't understand the purpose of the adding __init__.py files in the >>> template directories. >>> >>> NOTE: The headers in those files are not consistent with the other >>> project files. >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> >>> >>> >>> *http://www.linkedin.com/in/asheshvashi* >>> >>> >>>> Add ORDER BY into Copy Selection Feature test to ensure the results are >>>>> retrieved always in the same order >>>>> Renamed the Scenario of the xss_checks_pgadmin_debugger_test and skip >>>>> it for versions less than 9.1 >>>>> >>>>> Thanks >>>>> >>>>> Joao & Sarah >>>>> >>>>> >>>>> -- >>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>>>> To make changes to your subscription: >>>>> http://www.postgresql.org/mailpref/pgadmin-hackers >>>>> >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >> > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > > --001a113f26a6ddc52c054e91108c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Hackers & Ashesh!

Is there anything els= e we can do for this?

Thanks!
Matt & Sarah<= /div>

On Thu= , Apr 27, 2017 at 10:37 AM, Joao Pedro De Almeida Pereira <jdea= lmeidapereira@pivotal.io> wrote:
Thanks for reviewing, Ashesh.

We = have updated the patch. The headers are all consistent and we removed the <= font face=3D"monospace, monospace">__init__.py files in directories = containing only .sql.
=
Thanks!
Joao & Matt

On Wed, Apr 26, 2017 at 11:22 AM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hello Ashesh,

Thanks fo= r reviewing the patch.

We added the __init__.py fi= les into templates to convert them into packages so that the tests inside o= f them can be found by the test runner.

Than= ks!
Joao & Sarah

On Wed, Apr 26, 2017 at 1:26 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Mon, Apr 24, 2017 at 4:43 PM, Dave Page <= dpage@pgadmin.org> wrote:
Ashesh, can you review/commit this pleas= e?

On Fri, Apr 21, 2017 at 8:42 PM, Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Hackers,

We found out that when you are = connected to a GreenPlum database and try to get Dependents and Dependencie= s of an object the application was returning a SQL error.

This patch splits the SQL query used to retrieve the Dependents, De= pendencies, and Roles SQL file into multiple versioned files.
Add= Unit Tests for each file.
Also added __init__.py files to other = test directories to run the tests in them.
Hi Joao & Sarah,

Why do we need to add __init__.py in the template directory?
I d= idn't understand the purpose of the adding __init__.py files in the tem= plate directories.

NOTE: The headers in those file= s are not consistent with the other project files.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company=


http://www.linkedin.com/in/ash= eshvashi

=
Add ORDER BY into Copy Selection Feature= test to ensure the results are retrieved always in the same order
Renamed the Scenario of the=C2=A0xss_checks_pgadmin_debugger_test an= d skip it for versions less than 9.1

Thanks
<= div>
Joao & Sarah


--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake=

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Compan= y





--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-ha= ckers


--001a113f26a6ddc52c054e91108c--