Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8YjD-0007Is-DV for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 May 2017 21:00:59 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d8YjC-0005oE-Qw for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 May 2017 21:00:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d8YjC-0005mi-CY for pgadmin-hackers@postgresql.org; Wed, 10 May 2017 21:00:58 +0000 Received: from mail-io0-x22f.google.com ([2607:f8b0:4001:c06::22f]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d8Yj7-000163-Ow for pgadmin-hackers@postgresql.org; Wed, 10 May 2017 21:00:57 +0000 Received: by mail-io0-x22f.google.com with SMTP id o12so9742023iod.3 for ; Wed, 10 May 2017 14:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=AOitcipRuRovwaJbPgON0p7QW0CABBExwnhhhJoSHVY=; b=vxBk3IhqE41wn5ehn8/vrJ4+t6tSazs8ZcMDHenhC7utK9GG+UiivZR/FLQvI2zMrz Ms69UHTwqKVnhI28iYrv33v5Dx5u2TC3FQHZfbV2hvqjMMZ9z5y0ARGkNIKPAreT2vys iva2lIckIuSZNZQL3/5usj6R0ZhSVZPOWfEYrJycU2RspjJ9M0PLFGCXVqNyjjyX8Rjh LeXSpocj7SQ/2fnNPxyBwWQg4cpR6SxxxkE0kMnx+G72DVDiAi2kjCreMsYaLAFm1pm2 J13tJhwlhHEXanL8RhMBd1kdBl93aAcx7GYxRCW7ZcAsnUP/9NEbZl3MBNspvvVOonYA jjHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AOitcipRuRovwaJbPgON0p7QW0CABBExwnhhhJoSHVY=; b=KqpTc9yNCRMZHl+CdzZgdF5hy/dJ0Z9F8SaZ0CJiH5D8oOS4hvjQ8ot3dv/9bjIJlo IT1SipqS37jNxKp++y+wela3JqQrdMpMF5/qH8mp83epzJeBJRIgORnNIOOQzRQQve5F xHqhn8L/numqD3ZR/ngGNROviGfJQ+v+QE1VR8jB3txHD0ILa7JK4fDUb5ieK+Pw+x/X /47HtZTjjnESHgT2MAJ/dj1DxOteXDU3HT3a4D1QQxMllIs6vUbjHPMPEla3PExpVs8+ kIBycpg/gE89Zz9oiz+D6/AX3IpDrbbhzL5kUBaXqy9Xe9LP6h5WNiLxPGFzsrxp6pw1 QuUQ== X-Gm-Message-State: AODbwcC9KxJwvjoRSrmBbrKGSkEbed8fuoRWrg7xrbOEuNKUau78iXiN r++sdY0b++yqmawYEyu3EGz+eF0itxF7 X-Received: by 10.107.175.37 with SMTP id y37mr5479915ioe.38.1494450050579; Wed, 10 May 2017 14:00:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.58.138 with HTTP; Wed, 10 May 2017 14:00:30 -0700 (PDT) In-Reply-To: References: From: Sarah McAlear Date: Wed, 10 May 2017 17:00:30 -0400 Message-ID: Subject: Re: [patch] Dependents and Dependencies in GreenPlum To: Akshay Joshi Cc: Joao Pedro De Almeida Pereira , Robert Eckhardt , Matthew Kleiman , Ashesh Vashi , pgadmin-hackers , Dave Page Content-Type: multipart/alternative; boundary=001a11445424667614054f31c476 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a11445424667614054f31c476 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Ashkay! TestTablesNodeSql hasn't failed but TestRoleDependenciesSql failed with > below error: > .....\test_role_dependencies_sql.py\", line 41, in assertions\n self.= assertEqual(1, > len(fetch_result))\nAssertionError: 1 !=3D 0 We experienced a similar problem when we started developing this patch. We noticed that we were connecting to the database with the super user (the db owner user), which did not create the role we are expecting when a table is created. To ensure that this role is created, we had to create a new user and use it to execute all the tests. After we made this change, the tests passed. Can you try to create a new user and use it to execute your tests? Thanks, Jo=C3=A3o & Sarah On Wed, May 10, 2017 at 1:56 PM, Akshay Joshi wrote: > > > On May 10, 2017 19:07, "Sarah McAlear" wrote: > > Hi Akshay! > > Does this error occur on 9.6 or 10.0? We tested it in 9.6 and all our > tests pass. > > > On both 9.6 and 10.0. Query returned 0 rows which is compared against > 1 in assert statement. > > > Thanks! > Jo=C3=A3o & Sarah > > On Wed, May 10, 2017 at 2:29 AM, Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Sarah >> >> On Tue, May 9, 2017 at 9:03 PM, Sarah McAlear >> wrote: >> >>> Hi Akshay! >>> >>> >>>> Some test file names ended with "*_sql_template.py*" do we need to add >>>> that string ? >>> >>> we added this suffix after moving the tests up a level to tables/tests >>> to clarify what subject they applied to. we changed the suffix to "_sql= .py" >>> >>> - Files "test_column_acl_sql_template.py" and "test_column_properties_ >>>> sql_template.py" should be moved from tables->tests to >>>> tables->column->tests. As it's related to column. >>>> - Files "test_trigger_get_oid_sql_template.py" and "test_trigger_nodes= _ >>>> sql_template.py" should be moved from tables->tests to >>>> tables->triggers->tests. As its related to triggers. >>> >>> these tests are related to the sql files in tables/templates/column, no= t >>> tables/column, so moving them into tables/column would be more confusin= g. >>> >>> Following test cases are failing >>> >>> Thank you, fixed, see new patch. Can you confirm that TestTablesNodeSql >>> doesn't fail in your environment? >>> >> >> TestTablesNodeSql hasn't failed but TestRoleDependenciesSql failed >> with below error: >> .....\test_role_dependencies_sql.py\", line 41, in assertions\n >> self.assertEqual(1, len(fetch_result))\nAssertionError: 1 !=3D 0 >> >> >>> Thanks, >>> George & Sarah >>> >>> >> >> >> -- >> *Akshay Joshi* >> *Principal Software Engineer * >> >> >> >> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-824= 6 >> <+91%2097678%2088246>* >> > > > --001a11445424667614054f31c476 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Ashkay!

TestTablesNodeSql hasn't failed but TestRoleDepen= denciesSql failed with below error:
=C2=A0 =C2=A0 .....\test_ro= le_dependencies_sql.py\", line 41= , in assertions\n=C2=A0self.assertEqual(1, = len(fetch_result))\nAssertionError: 1 = !=3D 0

We experienced a simila= r problem when we started developing this patch. We noticed that we were co= nnecting to the database with the super user (the db owner user), which did= not create the role we are expecting when a table is created. To ensure th= at this role is created, we had to create a new user and use it to execute = all the tests. After we made this change, the tests passed.=C2=A0

Can you try to create a new user and use it to execute your= tests?

Thanks,
Jo=C3=A3o & Sarah

On Wed, = May 10, 2017 at 1:56 PM, Akshay Joshi <akshay.joshi@enterprise= db.com> wrote:


On May 10, 2017 19:07, "Sarah McAlear" <smcalear@pivotal.io&g= t; wrote:
Hi Akshay!

Does this error occur on 9.6 or 10.0? We tested it in 9.6 and all our tes= ts pass.

=C2=A0 =C2=A0 On both 9.6 and 10.0. Query retu= rned 0 rows which is compared against 1 in assert statement.=C2=A0
=

Thanks!
Jo=C3=A3o & Sarah

On Wed, May 10, 2017 at 2:29 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Sarah
=
On Tue, May 9, 2017 at 9:03 PM, Sarah = McAlear <smcalear@pivotal.io> wrote:
=
Hi Akshay!
=C2=A0
Some test file names ended with "_sql_template.py" do we need to add = that string ?=C2=A0
we added this suffix aft= er moving the tests up a level to tables/tests to clarify what subject they= applied to. we changed the suffix to "_sql.py"

- Files "test_column_acl_sql_template.py&q= uot; and "test_column_properties_sql_template.py"= should be moved from tables->tests to tables->column->tests. As i= t's related to column.
- Files "test_t= rigger_get_o= id_sq= l_template.py" and "test_trigger_node= s_sql= _template.py" should be moved from tables->tests to tables->trig= gers->tests. As its related to triggers.
these t= ests are related to the sql files in tables/templates/column, not tables/co= lumn, so moving them into tables/column would be more confusing.=C2=A0

Following test cas= es are failing
Thank you, fixed, see new pat= ch. Can you confirm that TestTablesNodeSql doesn't fail in your environ= ment?
=C2=A0 =C2=A0
=C2=A0 = =C2=A0 TestTablesNodeSql hasn't failed but TestRoleDependenciesSql fail= ed with below error:
=C2=A0 =C2=A0 .....\test_role_depen= dencies_sql.py\", line 41, in ass= ertions\n self.assertEqual(1, len(fetch_= result))\nAssertionError: 1 !=3D 0

<= div>
Thanks,
George & Sarah




--
Akshay Joshi
Principal Software Engineer=C2=A0
<= br>



--001a11445424667614054f31c476--