Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d8RoQ-0001sI-P3 for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 May 2017 13:37:55 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d8RoQ-0006qa-Bw for pgadmin-hackers@arkaria.postgresql.org; Wed, 10 May 2017 13:37:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d8RoP-0006qR-Ua for pgadmin-hackers@postgresql.org; Wed, 10 May 2017 13:37:54 +0000 Received: from mail-it0-x22f.google.com ([2607:f8b0:4001:c0b::22f]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1d8RoH-0000zZ-8Q for pgadmin-hackers@postgresql.org; Wed, 10 May 2017 13:37:53 +0000 Received: by mail-it0-x22f.google.com with SMTP id g126so1355095ith.0 for ; Wed, 10 May 2017 06:37:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pivotal-io.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=M/yASdwrSAhQSP3ufsoU4Rp+3wzWdpXOiiZMQFco4bs=; b=i9toO83znFqLA074xOoX1JiX9OiseVxDInF8OOIfdJDNdF5bVu/1R8B0v42pqGmMnC H9QgF6wYQyuZIZEjRg2pVJRQKwaURVbwAwk4eeb8akQnzvLXybL/R8JTaRmQxkgtZVko +Y51hPRWQY6a1/5cLrJMChYznNoEIj6ol2E958e9FF7C3tvFZ/tRbaS6sOjP9XM4X+Xu 4GVmQmaH647RGL72z8Us3YLRICw+M28r5+7Xkw8NRRmmLzZM761ABwdfHSELtnaGkXXA wlsYFogMiEa1VwdfYRivkE+dLJ/7gmKRljqFIX4TEiiRP3LSpHtdrS/EssB+eMqyDmsg Qmzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=M/yASdwrSAhQSP3ufsoU4Rp+3wzWdpXOiiZMQFco4bs=; b=pH1iImv16AU5aiVwn9NFQGRDVJMg99fo0O5fm+NzGtLL52JA4mGe543imu5oxwQgbl hR84HeDB12pyKtt2WdfUvSz8uI0QZgvipaoaiuVU+akI1N+2tox8QMkUPs5NYUV1yhvj 2k1icIuw6J+NBu6+hPXNuVvEFvDGLAmKoMm/zaabAPgGlFsqVw92XNFCvW/lQzSatI3Z W8f8uRV42GK0fmTIhnLxcVLFDI/1Yg8KbhBzZVeJsIKyuSM0zicg4Ym5B9CNT6pvUxVE 8z9BpbdxDEHOe0weThst5bfEt4XX9cUjgjhh7fDAKmK0DwRdJyZn2ETzqCkc7Y1SSKIk 6aag== X-Gm-Message-State: AODbwcC4UZ58qmXzKi3Xsc4x981/9fanxr62TSxfe8N9NpmwxCPuFpJ8 OSGnmz/+D+3n2xcIPxX7viBRsTlEmRqU X-Received: by 10.36.90.210 with SMTP id v201mr5196516ita.83.1494423462074; Wed, 10 May 2017 06:37:42 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.58.138 with HTTP; Wed, 10 May 2017 06:37:21 -0700 (PDT) In-Reply-To: References: From: Sarah McAlear Date: Wed, 10 May 2017 09:37:21 -0400 Message-ID: Subject: Re: [patch] Dependents and Dependencies in GreenPlum To: Akshay Joshi Cc: Dave Page , Robert Eckhardt , Joao Pedro De Almeida Pereira , Ashesh Vashi , pgadmin-hackers , Matthew Kleiman Content-Type: multipart/alternative; boundary=001a1143d6e69a1e90054f2b933b X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1143d6e69a1e90054f2b933b Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Akshay! Does this error occur on 9.6 or 10.0? We tested it in 9.6 and all our tests pass. Thanks! Jo=C3=A3o & Sarah On Wed, May 10, 2017 at 2:29 AM, Akshay Joshi wrote: > Hi Sarah > > On Tue, May 9, 2017 at 9:03 PM, Sarah McAlear wrote= : > >> Hi Akshay! >> >> >>> Some test file names ended with "*_sql_template.py*" do we need to add >>> that string ? >> >> we added this suffix after moving the tests up a level to tables/tests t= o >> clarify what subject they applied to. we changed the suffix to "_sql.py" >> >> - Files "test_column_acl_sql_template.py" and "test_column_properties_sq= l >>> _template.py" should be moved from tables->tests to >>> tables->column->tests. As it's related to column. >>> - Files "test_trigger_get_oid_sql_template.py" and "test_trigger_nodes_ >>> sql_template.py" should be moved from tables->tests to >>> tables->triggers->tests. As its related to triggers. >> >> these tests are related to the sql files in tables/templates/column, not >> tables/column, so moving them into tables/column would be more confusing= . >> >> Following test cases are failing >> >> Thank you, fixed, see new patch. Can you confirm that TestTablesNodeSql >> doesn't fail in your environment? >> > > TestTablesNodeSql hasn't failed but TestRoleDependenciesSql failed > with below error: > .....\test_role_dependencies_sql.py\", line 41, in assertions\n > self.assertEqual(1, len(fetch_result))\nAssertionError: 1 !=3D 0 > > >> Thanks, >> George & Sarah >> >> > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246 > <+91%2097678%2088246>* > --001a1143d6e69a1e90054f2b933b Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Akshay!

Does this error occur on 9.6= or 10.0? We tested it in 9.6 and all our tests pass.

<= div>Thanks!
Jo=C3=A3o & Sarah
=
On Wed, May 10, 2017 at 2:29 AM, Akshay Josh= i <akshay.joshi@enterprisedb.com> wrote:
Hi Sarah

On Tue, May 9, 2017 at = 9:03 PM, Sarah McAlear <smcalear@pivotal.io> wrote:
Hi Akshay!
=C2=A0
Some test file names en= ded with "_sql_template.py" do we need to add that string ?=C2=A0
we added this suffix after moving the tests up a level to = tables/tests to clarify what subject they applied to. we changed the suffix= to "_sql.py"

- Files "test_column_acl_sql_template.py" an= d "test_column_properties_s= ql_template.py" should be mov= ed from tables->tests to tables->column->tests. As it's relate= d to column.
- Files "test_trigger_get_oid_sql_templat= e.py" and "test= _trigger_nodes_sql_template.py" should be moved from tables->tests to tables-&g= t;triggers->tests. As its related to triggers.
t= hese tests are related to the sql files in tables/templates/column, not tab= les/column, so moving them into tables/column would be more confusing.=C2= =A0

Following test cases are failing
Thank you, fixed, see new patch. Can you confirm that TestTabl= esNodeSql doesn't fail in your environment?
=C2=A0 =C2=A0
=C2=A0 =C2=A0 TestTablesNodeSql hasn't= failed but TestRoleDependenciesSql failed with below error:
=C2= =A0 =C2=A0 .....\test_role_dependencies_sql.py\", line 41, in assertions\n self.assertEqual(1, len(fetch_result))\n<= span style=3D"font-family:menlo;font-size:9pt;color:rgb(0,128,0);font-weigh= t:bold">AssertionError: 1 !=3D 0

=

Thanks,
George & Sarah




--=
<= div>Akshay Joshi
Principal Software Engineer=C2=A0



--001a1143d6e69a1e90054f2b933b--