MIME-Version: 1.0
In-Reply-To: 
 <CA+OCxoz2k6PjgGXo4H+h6JozOvLy5C_uGxU7+CjxVs0LoKL+zQ@mail.gmail.com>
References: 
 <CAHowoHY1hq-+ibR-+jkQxtGUr9T0Ov0XbFp6hW=KbV-euh=wZQ@mail.gmail.com>
 <CA+OCxoz2k6PjgGXo4H+h6JozOvLy5C_uGxU7+CjxVs0LoKL+zQ@mail.gmail.com>
From: George Gelashvili <ggelashvili@pivotal.io>
Date: Fri, 12 May 2017 10:54:13 -0400
Message-ID: 
 <CAHowoHbYyJ_hBshABhpEUCz2OGvda83pcLKjPyuzMvdbwnR2gA@mail.gmail.com>
Subject: Re: javascript and css minification process
To: Dave Page <dpage@pgadmin.org>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="f4030435ab2cfc39e4054f54e058"
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--f4030435ab2cfc39e4054f54e058
Content-Type: text/plain; charset="UTF-8"

>
> It's not yet. Those are utility scripts that I was eventually intending to
> call from appropriate make targets during package build. Before we get
> there though, we need code changes to ensure that we load minified code vs.
> debug code at the appropriate times. I haven't done much with it in a while
> as Tira had been talking about transpiling everything into a single blob
> (though that required us to ensure none of the JS files were Jinja
> templates any more).
>

Okay. We are thinking of using a javascript minification tool and run it as
part of the bundling process.
We are using grunt to bundle everything (such as react code and
dependencies). Other javascript and css files can be added to the bundling
process as we all see fit.

--f4030435ab2cfc39e4054f54e058
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_extra"><div class=3D"gmail_quote"><blo=
ckquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #c=
cc solid;padding-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_extra"><div=
 class=3D"gmail_quote"><span class=3D""><div>It&#39;s not yet. Those are ut=
ility scripts that I was eventually intending to call from appropriate make=
 targets during package build. Before we get there though, we need code cha=
nges to ensure that we load minified code vs. debug code at the appropriate=
 times. I haven&#39;t done much with it in a while as Tira had been talking=
 about transpiling everything into a single blob (though that required us t=
o ensure none of the JS files were Jinja templates any more).=C2=A0</div></=
span></div></div></div></blockquote><div><br></div><div>Okay. We are thinki=
ng of using a javascript minification tool and run it as part of the bundli=
ng process.</div><div>We are using grunt to bundle everything (such as reac=
t code and dependencies). Other javascript and css files can be added to th=
e bundling process as we all see fit.</div><div>=C2=A0<br></div></div></div=
></div>

--f4030435ab2cfc39e4054f54e058--