MIME-Version: 1.0
From: George Gelashvili <ggelashvili@pivotal.io>
Date: Fri, 26 May 2017 18:26:38 -0400
Message-ID: 
 <CAHowoHbxP5Y6cN+0tYMe9M13m0vaupqOwoUdKnoUuZm5qzSH2Q@mail.gmail.com>
Subject: feature test timeouts
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="001a11444168eeb068055074d5d4"
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--001a11444168eeb068055074d5d4
Content-Type: multipart/alternative; boundary="001a11444168eeb063055074d5d2"

--001a11444168eeb063055074d5d2
Content-Type: text/plain; charset="UTF-8"

Hello Hackers,

We are running tests including feature tests in Circle CI, and have been
seeing some flakiness due to what we believe are insufficient wait-for
timeouts.

This shouldn't increase the overall test time, but only allow waiting
longer for an element to appear, if needed.

We've also split out the app start timeout since that seemed to need more
time on CI.

Patch attached.

Thanks!
Joao, Matt, and George

--001a11444168eeb063055074d5d2
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hello Hackers,<div><br></div><div>We are running tests inc=
luding feature tests in Circle CI, and have been seeing some flakiness due =
to what we believe are insufficient wait-for timeouts.</div><div><br></div>=
<div>This shouldn&#39;t increase the overall test time, but only allow wait=
ing longer for an element to appear, if needed.</div><div><br></div><div>We=
&#39;ve also split out the app start timeout since that seemed to need more=
 time on CI.=C2=A0</div><div><br></div><div>Patch attached.</div><div><br><=
/div><div>Thanks!<br>Joao, Matt, and George</div></div>

--001a11444168eeb063055074d5d2--

--001a11444168eeb068055074d5d4
Content-Type: text/plain; charset="US-ASCII";
 name="change-some-feature-test-timeouts.diff"
Content-Disposition: attachment;
	filename="change-some-feature-test-timeouts.diff"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_j36f3xmv0

ZGlmZiAtLWdpdCBhL3dlYi9yZWdyZXNzaW9uL2ZlYXR1cmVfdXRpbHMvcGdh
ZG1pbl9wYWdlLnB5IGIvd2ViL3JlZ3Jlc3Npb24vZmVhdHVyZV91dGlscy9w
Z2FkbWluX3BhZ2UucHkKaW5kZXggYjFkZmExODIuLmI5YWJlN2NhIDEwMDY0
NAotLS0gYS93ZWIvcmVncmVzc2lvbi9mZWF0dXJlX3V0aWxzL3BnYWRtaW5f
cGFnZS5weQorKysgYi93ZWIvcmVncmVzc2lvbi9mZWF0dXJlX3V0aWxzL3Bn
YWRtaW5fcGFnZS5weQpAQCAtMjYsNyArMjYsOCBAQCBjbGFzcyBQZ2FkbWlu
UGFnZToKICAgICBkZWYgX19pbml0X18oc2VsZiwgZHJpdmVyLCBhcHBfY29u
ZmlnKToKICAgICAgICAgc2VsZi5kcml2ZXIgPSBkcml2ZXIKICAgICAgICAg
c2VsZi5hcHBfY29uZmlnID0gYXBwX2NvbmZpZwotICAgICAgICBzZWxmLnRp
bWVvdXQgPSAxMAorICAgICAgICBzZWxmLnRpbWVvdXQgPSAzMAorICAgICAg
ICBzZWxmLmFwcF9zdGFydF90aW1lb3V0ID0gNjAKIAogICAgIGRlZiByZXNl
dF9sYXlvdXQoc2VsZik6CiAgICAgICAgIHNlbGYuY2xpY2tfZWxlbWVudChz
ZWxmLmZpbmRfYnlfcGFydGlhbF9saW5rX3RleHQoIkZpbGUiKSkKQEAgLTE3
OCw4ICsxNzksMTAgQEAgY2xhc3MgUGdhZG1pblBhZ2U6CiAgICAgICAgICAg
ICAgICAgZHJpdmVyLnJlZnJlc2goKQogICAgICAgICAgICAgICAgIHJldHVy
biBGYWxzZQogCi0gICAgICAgIHNlbGYuX3dhaXRfZm9yKCJhcHAgdG8gc3Rh
cnQiLCBwYWdlX3Nob3dzX2FwcCkKKyAgICAgICAgc2VsZi5fd2FpdF9mb3Io
ImFwcCB0byBzdGFydCIsIHBhZ2Vfc2hvd3NfYXBwLCBzZWxmLmFwcF9zdGFy
dF90aW1lb3V0KQogCi0gICAgZGVmIF93YWl0X2ZvcihzZWxmLCB3YWl0aW5n
X2Zvcl9tZXNzYWdlLCBjb25kaXRpb25fbWV0X2Z1bmN0aW9uKToKLSAgICAg
ICAgcmV0dXJuIFdlYkRyaXZlcldhaXQoc2VsZi5kcml2ZXIsIHNlbGYudGlt
ZW91dCwgMC4wMSkudW50aWwoY29uZGl0aW9uX21ldF9mdW5jdGlvbiwKKyAg
ICBkZWYgX3dhaXRfZm9yKHNlbGYsIHdhaXRpbmdfZm9yX21lc3NhZ2UsIGNv
bmRpdGlvbl9tZXRfZnVuY3Rpb24sIHRpbWVvdXQgPSBOb25lKToKKyAgICAg
ICAgaWYgdGltZW91dCBpcyBOb25lOgorICAgICAgICAgICAgdGltZW91dCA9
IHNlbGYudGltZW91dAorICAgICAgICByZXR1cm4gV2ViRHJpdmVyV2FpdChz
ZWxmLmRyaXZlciwgdGltZW91dCwgMC4wMSkudW50aWwoY29uZGl0aW9uX21l
dF9mdW5jdGlvbiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIlRpbWVkIG91
dCB3YWl0aW5nIGZvciAiICsgd2FpdGluZ19mb3JfbWVzc2FnZSkK

--001a11444168eeb068055074d5d4
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--001a11444168eeb068055074d5d4--