MIME-Version: 1.0
References: 
 <CAJ9T6Su2_qaty3yABdEUgrJYnJDMrJHN2YWsd-vqQSMuY9hFfw@mail.gmail.com>
 <CANxoLDeS68-64kUGaAitwF7m9FfiCRbT9sHLYjo4uJeHD37uuw@mail.gmail.com>
In-Reply-To: 
 <CANxoLDeS68-64kUGaAitwF7m9FfiCRbT9sHLYjo4uJeHD37uuw@mail.gmail.com>
From: Pradip Parkale <pradip.parkale@enterprisedb.com>
Date: Mon, 26 Apr 2021 17:01:05 +0530
Message-ID: 
 <CAJ9T6SsDY1+D6MQckGmOeJMRKb0fmitCBD-ABMAp7DZ3nzJhPg@mail.gmail.com>
Subject: Re: [pgAdmin][RM6341] CSV download quotes numeric columns
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000db68e205c0de7b4e"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJ9T6SsDY1%2BD6MQckGmOeJMRKb0fmitCBD-ABMAp7DZ3nzJhPg%40mail.gmail.com>
Precedence: bulk

--000000000000db68e205c0de7b4e
Content-Type: multipart/alternative; boundary="000000000000db68e005c0de7b4c"

--000000000000db68e005c0de7b4c
Content-Type: text/plain; charset="UTF-8"

Hi Akshay,
Please find the updated patch for #6251. I have fixed the issue caused due
to my initial patch.

On Thu, Apr 22, 2021 at 5:42 PM Akshay Joshi <akshay.joshi@enterprisedb.com>
wrote:

> Thanks, patch applied.
>
> On Tue, Apr 20, 2021 at 10:54 AM Pradip Parkale <
> pradip.parkale@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch for #6341 CSV download quotes numeric
>> columns.
>> Initially, the double-precision value was getting typecast to a string.
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> Software Engineer | EnterpriseDB Corporation
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Principal Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>


-- 
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation

--000000000000db68e005c0de7b4c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Akshay,=C2=A0<div>Please find the updated patch for #62=
51. I have fixed the issue caused due to my initial patch.</div></div><br><=
div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, Apr=
 22, 2021 at 5:42 PM Akshay Joshi &lt;<a href=3D"mailto:akshay.joshi@enterp=
risedb.com" target=3D"_blank">akshay.joshi@enterprisedb.com</a>&gt; wrote:<=
br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e=
x;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,2=
04,204);padding-left:1ex"><div dir=3D"ltr">Thanks, patch applied.</div><br>=
<div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Tue, Ap=
r 20, 2021 at 10:54 AM Pradip Parkale &lt;<a href=3D"mailto:pradip.parkale@=
enterprisedb.com" target=3D"_blank">pradip.parkale@enterprisedb.com</a>&gt;=
 wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px =
0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:r=
gb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr">Hi Hack=
ers,<div><br></div><div>Please find the attached patch for #6341=C2=A0CSV d=
ownload quotes numeric columns.</div><div>Initially, the double-precision v=
alue was getting typecast to a string.</div><div><br></div><div><div><br></=
div>-- <br><div dir=3D"ltr"><div dir=3D"ltr"><div style=3D"font-size:12.8px=
">Thanks &amp; Regards,<br></div><div style=3D"font-size:12.8px">Pradip Par=
kale<br>Software Engineer | EnterpriseDB Corporation</div></div></div></div=
></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div d=
ir=3D"ltr"><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);=
font-family:arial,sans-serif;font-size:13px;border-collapse:collapse">Thank=
s &amp; Regards</span></b></font></div><div><font color=3D"#3333FF"><b><spa=
n style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;bor=
der-collapse:collapse">Akshay Joshi</span></b></font></div><div><font color=
=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-seri=
f;font-size:13px;border-collapse:collapse">pgAdmin Hacker | Principal Softw=
are Architect</span></b></font></div><font color=3D"#000000" face=3D"arial,=
 sans-serif"><b><a href=3D"http://edbpostgres.com" target=3D"_blank">EDB Po=
stgres</a></b></font><br><div><b style=3D"color:rgb(51,51,255)"><span style=
=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;border-col=
lapse:collapse">Mobile: +91 976-788-8246<br></span></b><br></div></div></di=
v></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
><div dir=3D"ltr"><div style=3D"font-size:12.8px">Thanks &amp; Regards,<br>=
</div><div style=3D"font-size:12.8px">Pradip Parkale<br>Software Engineer |=
 EnterpriseDB Corporation</div></div></div>

--000000000000db68e005c0de7b4c--

--000000000000db68e205c0de7b4e
Content-Type: application/octet-stream; name="RM6341_v2.patch"
Content-Disposition: attachment; filename="RM6341_v2.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_knyhp4mc0>
X-Attachment-Id: f_knyhp4mc0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3V0aWxzL2RyaXZlci9wc3ljb3BnMi9jb25uZWN0aW9u
LnB5IGIvd2ViL3BnYWRtaW4vdXRpbHMvZHJpdmVyL3BzeWNvcGcyL2Nvbm5lY3Rpb24ucHkKaW5k
ZXggYTlkNTVjNjM3Li43ODUyMTA3MmYgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL3V0aWxzL2Ry
aXZlci9wc3ljb3BnMi9jb25uZWN0aW9uLnB5CisrKyBiL3dlYi9wZ2FkbWluL3V0aWxzL2RyaXZl
ci9wc3ljb3BnMi9jb25uZWN0aW9uLnB5CkBAIC0xMiw3ICsxMiw2IEBAIEltcGxlbWVudGF0aW9u
IG9mIENvbm5lY3Rpb24uCiBJdCBpcyBhIHdyYXBwZXIgYXJvdW5kIHRoZSBhY3R1YWwgcHN5Y29w
ZzIgZHJpdmVyLCBhbmQgY29ubmVjdGlvbgogb2JqZWN0LgogIiIiCi0KIGltcG9ydCByYW5kb20K
IGltcG9ydCBzZWxlY3QKIGltcG9ydCBkYXRldGltZQpAQCAtMzAsNyArMjksNyBAQCBmcm9tIHBn
YWRtaW4udXRpbHMuZXhjZXB0aW9uIGltcG9ydCBDb25uZWN0aW9uTG9zdCwgQ3J5cHRLZXlNaXNz
aW5nCiBmcm9tIHBnYWRtaW4udXRpbHMgaW1wb3J0IGdldF9jb21wbGV0ZV9maWxlX3BhdGgKIGZy
b20gLi5hYnN0cmFjdCBpbXBvcnQgQmFzZUNvbm5lY3Rpb24KIGZyb20gLmN1cnNvciBpbXBvcnQg
RGljdEN1cnNvcgotZnJvbSAudHlwZWNhc3QgaW1wb3J0IHJlZ2lzdGVyX2Zsb2F0X3R5cGVjYXN0
ZXJzLCByZWdpc3Rlcl9nbG9iYWxfdHlwZWNhc3RlcnMsXAorZnJvbSAudHlwZWNhc3QgaW1wb3J0
IG51bWVyaWNfdHlwZWNhc3RlcnMsIHJlZ2lzdGVyX2dsb2JhbF90eXBlY2FzdGVycyxcCiAgICAg
cmVnaXN0ZXJfc3RyaW5nX3R5cGVjYXN0ZXJzLCByZWdpc3Rlcl9iaW5hcnlfdHlwZWNhc3RlcnMs
IFwKICAgICB1bnJlZ2lzdGVyX251bWVyaWNfdHlwZWNhc3RlcnMsIFwKICAgICByZWdpc3Rlcl9h
cnJheV90b19zdHJpbmdfdHlwZWNhc3RlcnMsIEFMTF9KU09OX1RZUEVTCkBAIC00NjIsNyArNDYx
LDYgQEAgY2xhc3MgQ29ubmVjdGlvbihCYXNlQ29ubmVjdGlvbik6CiAgICAgICAgIHNlbGYuX3Nl
dF9hdXRvX2NvbW1pdChrd2FyZ3MpCiAKICAgICAgICAgcmVnaXN0ZXJfc3RyaW5nX3R5cGVjYXN0
ZXJzKHNlbGYuY29ubikKLSAgICAgICAgcmVnaXN0ZXJfZmxvYXRfdHlwZWNhc3RlcnMoc2VsZi5j
b25uKQogCiAgICAgICAgIGlmIHNlbGYuYXJyYXlfdG9fc3RyaW5nOgogICAgICAgICAgICAgcmVn
aXN0ZXJfYXJyYXlfdG9fc3RyaW5nX3R5cGVjYXN0ZXJzKHNlbGYuY29ubikKQEAgLTg0NSw2ICs4
NDMsOCBAQCBXSEVSRSBkYi5kYXRuYW1lID0gY3VycmVudF9kYXRhYmFzZSgpIiIiKQogICAgICAg
ICAgICAgaWYgbm90IHJlc3VsdHM6CiAgICAgICAgICAgICAgICAgeWllbGQgZ2V0dGV4dCgnVGhl
IHF1ZXJ5IGV4ZWN1dGVkIGRpZCBub3QgcmV0dXJuIGFueSBkYXRhLicpCiAgICAgICAgICAgICAg
ICAgcmV0dXJuCisgICAgICAgICAgICAjIFR5cGUgY2FzdCB0aGUgbnVtZXJpYyB2YWx1ZXMKKyAg
ICAgICAgICAgIHJlc3VsdHMgPSBudW1lcmljX3R5cGVjYXN0ZXJzKHJlc3VsdHMpCiAKICAgICAg
ICAgICAgIGhlYWRlciA9IFtdCiAgICAgICAgICAgICBqc29uX2NvbHVtbnMgPSBbXQpAQCAtOTEy
LDggKzkxMiw2IEBAIFdIRVJFIGRiLmRhdG5hbWUgPSBjdXJyZW50X2RhdGFiYXNlKCkiIiIpCiAK
ICAgICAgICAgIyBSZWdpc3RlcmluZyBiYWNrIHR5cGUgY2FzdGVyIGZvciBsYXJnZSBzaXplIGRh
dGEgdHlwZXMgdG8gc3RyaW5nCiAgICAgICAgICMgd2hpY2ggd2FzIHVucmVnaXN0ZXJlZCBhdCBz
dGFydGluZwotICAgICAgICBpZiBhbnkodHlwZVsndHlwZV9jb2RlJ10gPT0gNzAxIGZvciB0eXBl
IGluIHNlbGYuY29sdW1uX2luZm8pOgotICAgICAgICAgICAgcmVnaXN0ZXJfZmxvYXRfdHlwZWNh
c3RlcnMoc2VsZi5jb25uKQogICAgICAgICByZWdpc3Rlcl9zdHJpbmdfdHlwZWNhc3RlcnMoc2Vs
Zi5jb25uKQogICAgICAgICByZXR1cm4gVHJ1ZSwgZ2VuCiAKZGlmZiAtLWdpdCBhL3dlYi9wZ2Fk
bWluL3V0aWxzL2RyaXZlci9wc3ljb3BnMi90eXBlY2FzdC5weSBiL3dlYi9wZ2FkbWluL3V0aWxz
L2RyaXZlci9wc3ljb3BnMi90eXBlY2FzdC5weQppbmRleCBhOTNhNTNkYTcuLmM2ZDA0M2U3YiAx
MDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdXRpbHMvZHJpdmVyL3BzeWNvcGcyL3R5cGVjYXN0LnB5
CisrKyBiL3dlYi9wZ2FkbWluL3V0aWxzL2RyaXZlci9wc3ljb3BnMi90eXBlY2FzdC5weQpAQCAt
MjIsNyArMjIsNiBAQCBmcm9tIC5lbmNvZGluZyBpbXBvcnQgY29uZmlndXJlX2RyaXZlcl9lbmNv
ZGluZ3MsIGdldF9lbmNvZGluZwogCiBjb25maWd1cmVfZHJpdmVyX2VuY29kaW5ncyhlbmNvZGlu
Z3MpCiAKLQogIyBPSURzIG9mIGRhdGEgdHlwZXMgd2hpY2ggbmVlZCB0byB0eXBlY2FzdCBhcyBz
dHJpbmcgdG8gYXZvaWQgSmF2YVNjcmlwdAogIyBjb21wYXRpYmlsaXR5IGlzc3Vlcy4KICMgZS5n
IEphdmFTY3JpcHQgZG9lcyBub3Qgc3VwcG9ydCA2NCBiaXQgaW50ZWdlcnMuIEl0IGhhcyA2NC1i
aXQgZG91YmxlCkBAIC02Nyw3ICs2Niw2IEBAIFRPX0FSUkFZX09GX1NUUklOR19EQVRBVFlQRVMg
PSAoCiAjIE9JRCBvZiByZWNvcmQgYXJyYXkgZGF0YSB0eXBlCiBSRUNPUkRfQVJSQVkgPSAoMjI4
NywpCiAKLQogIyBPSURzIG9mIGJ1aWx0aW4gYXJyYXkgZGF0YXR5cGVzIHN1cHBvcnRlZCBieSBw
c3ljb3BnMgogIyBPSUQgcmVmZXJlbmNlIHBzeWNvcGcyL3BzeWNvcGcvdHlwZWNhc3RfYnVpbHRp
bnMuYwogIwpAQCAtMTAzLDIyICsxMDEsMTggQEAgUFNZQ09QR19TVVBQT1JURURfSlNPTl9BUlJB
WV9UWVBFUyA9ICgxOTksIDM4MDcpCiBBTExfSlNPTl9UWVBFUyA9IFBTWUNPUEdfU1VQUE9SVEVE
X0pTT05fVFlQRVMgK1wKICAgICBQU1lDT1BHX1NVUFBPUlRFRF9KU09OX0FSUkFZX1RZUEVTCiAK
LQogIyBJTkVUW10sIENJRFJbXQogIyBPSUQgcmVmZXJlbmNlIHBzeWNvcGcyL2xpYi9faXBhZGRy
ZXNzLnB5CiBQU1lDT1BHX1NVUFBPUlRFRF9JUEFERFJFU1NfQVJSQVlfVFlQRVMgPSAoMTA0MSwg
NjUxKQogCi0KICMgdXVpZFtdCiAjIE9JRCByZWZlcmVuY2UgcHN5Y29wZzIvbGliL2V4dHJhcy5w
eQogUFNZQ09QR19TVVBQT1JURURfSVBBRERSRVNTX0FSUkFZX1RZUEVTID0gKDI5NTEsKQogCi0K
ICMgaW50NHJhbmdlLCBpbnQ4cmFuZ2UsIG51bXJhbmdlLCBkYXRlcmFuZ2UgdHNyYW5nZSwgdHN0
enJhbmdlW10KICMgT0lEIHJlZmVyZW5jZSBwc3ljb3BnMi9saWIvX3JhbmdlLnB5CiBQU1lDT1BH
X1NVUFBPUlRFRF9SQU5HRV9UWVBFUyA9ICgzOTA0LCAzOTI2LCAzOTA2LCAzOTEyLCAzOTA4LCAz
OTEwKQogCi0KICMgaW50NHJhbmdlW10sIGludDhyYW5nZVtdLCBudW1yYW5nZVtdLCBkYXRlcmFu
Z2VbXSB0c3JhbmdlW10sIHRzdHpyYW5nZVtdCiAjIE9JRCByZWZlcmVuY2UgcHN5Y29wZzIvbGli
L19yYW5nZS5weQogUFNZQ09QR19TVVBQT1JURURfUkFOR0VfQVJSQVlfVFlQRVMgPSAoMzkwNSwg
MzkyNywgMzkwNywgMzkxMywgMzkwOSwgMzkxMSkKQEAgLTIwNCwxMiArMTk4LDI2IEBAIGRlZiBy
ZWdpc3Rlcl9zdHJpbmdfdHlwZWNhc3RlcnMoY29ubmVjdGlvbik6CiAgICAgICAgIHBzeWNvcGcy
LmV4dGVuc2lvbnMucmVnaXN0ZXJfdHlwZSh1bmljb2RlX2FycmF5X3R5cGUsIGNvbm5lY3Rpb24p
CiAKIAotZGVmIHJlZ2lzdGVyX2Zsb2F0X3R5cGVjYXN0ZXJzKGNvbm5lY3Rpb24pOgotICAgICMg
VGhpcyBmdW5jdGlvbiBpcyB0byBjb252ZXJ0ICBwZyB0eXBlcyBpbnRvIGRlY2ltYWwgdHlwZQot
ICAgIHN0cmluZ190eXBlX3RvX2Zsb2F0ID0gXAotICAgICAgICBwc3ljb3BnMi5leHRlbnNpb25z
Lm5ld190eXBlKFRPX1NUUklOR19OVU1FUklDX0RBVEFUWVBFUywKLSAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAnVFlQRUNBU1RfVE9fREVDSU1BTCcsIF9ERUNJTUFMKQotICAg
IHBzeWNvcGcyLmV4dGVuc2lvbnMucmVnaXN0ZXJfdHlwZShzdHJpbmdfdHlwZV90b19mbG9hdCwg
Y29ubmVjdGlvbikKK2RlZiBpc19udW1lcmljKHZhbCk6CisgICAgIiIiQ2hlY2sgaWYgdmFsdWUg
aXMgbnVtZXJpYyBvciBub3QiIiIKKyAgICB0cnk6CisgICAgICAgIGlmICcuJyBpbiB2YWw6Cisg
ICAgICAgICAgICBmbG9hdCh2YWwpCisgICAgICAgIGVsc2U6CisgICAgICAgICAgICBpbnQodmFs
KQorICAgIGV4Y2VwdCBWYWx1ZUVycm9yOgorICAgICAgICByZXR1cm4gRmFsc2UKKyAgICByZXR1
cm4gVHJ1ZQorCisKK2RlZiBudW1lcmljX3R5cGVjYXN0ZXJzKHJlc3VsdHMpOgorICAgICMgVGhp
cyBmdW5jdGlvbiBpcyB0byBjb252ZXJ0IHBnIHR5cGVzIHRvIG51bWVpYyB0eXBlIGNhc3Rlcgor
CisgICAgZm9yIHJlc3VsdCBpbiByZXN1bHRzOgorICAgICAgICBmb3Iga2V5LCB2YWx1ZSBpbiBy
ZXN1bHQuaXRlbXMoKToKKyAgICAgICAgICAgIGlmIGlzaW5zdGFuY2UocmVzdWx0W2tleV0sIHN0
cikgYW5kIGlzX251bWVyaWMocmVzdWx0W2tleV0pOgorICAgICAgICAgICAgICAgIHJlc3VsdFtr
ZXldID0gZmxvYXQocmVzdWx0W2tleV0pCisgICAgcmV0dXJuIHJlc3VsdHMKIAogCiBkZWYgcmVn
aXN0ZXJfYmluYXJ5X3R5cGVjYXN0ZXJzKGNvbm5lY3Rpb24pOgo=
--000000000000db68e205c0de7b4e--