MIME-Version: 1.0
References: 
 <CANhjAHxpK_j_w1Zmu5Keofsqz4bbcpsnKR8ybNPZUqQNN-DANg@mail.gmail.com>
 <CANxoLDfvOYp=iyQ8Yqob6X7ywLKVe1xD=0u0YmaJ7X1p2WsA5A@mail.gmail.com>
In-Reply-To: 
 <CANxoLDfvOYp=iyQ8Yqob6X7ywLKVe1xD=0u0YmaJ7X1p2WsA5A@mail.gmail.com>
From: Pradip Parkale <pradip.parkale@enterprisedb.com>
Date: Mon, 21 Sep 2020 16:41:27 +0530
Message-ID: 
 <CAJ9T6SsYhopg_gboy+0Mt=6rGAhN141yDoam3qGpt470yRnNrQ@mail.gmail.com>
Subject: Re: RM5841: server.username can be empty when using .pg_service.conf
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>,
 Cyril Jouve <jv.cyril@gmail.com>
Content-Type: multipart/mixed; boundary="0000000000001c46b305afd0ea0b"
Precedence: bulk

--0000000000001c46b305afd0ea0b
Content-Type: multipart/alternative; boundary="0000000000001c46b005afd0ea09"

--0000000000001c46b005afd0ea09
Content-Type: text/plain; charset="UTF-8"

Hi Akshay,


On Mon, Sep 21, 2020 at 9:30 AM Akshay Joshi <akshay.joshi@enterprisedb.com>
wrote:

> Hi Pradip
>
> Can you please review the patch as that condition we have added for Shared
> Server implementation?
>
Yes, we have added this for the shared server implementation. Please find
the attached for this issue.

>
> On Sat, Sep 19, 2020 at 6:22 PM Cyril Jouve <jv.cyril@gmail.com> wrote:
>
>> fix for https://redmine.postgresql.org/issues/5841
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>


-- 
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation

--0000000000001c46b005afd0ea09
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Akshay,<div><br></div></div><br><div c=
lass=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, Sep 21, =
2020 at 9:30 AM Akshay Joshi &lt;<a href=3D"mailto:akshay.joshi@enterprised=
b.com" target=3D"_blank">akshay.joshi@enterprisedb.com</a>&gt; wrote:<br></=
div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bor=
der-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,20=
4);padding-left:1ex"><div dir=3D"ltr">Hi Pradip<div><br></div><div>Can you =
please review the patch as that condition we have added for Shared Server i=
mplementation?</div></div></blockquote><div>Yes, we have added this for the=
 shared server implementation. Please find the attached for this issue.</di=
v><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;borde=
r-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204)=
;padding-left:1ex"><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D=
"gmail_attr">On Sat, Sep 19, 2020 at 6:22 PM Cyril Jouve &lt;<a href=3D"mai=
lto:jv.cyril@gmail.com" target=3D"_blank">jv.cyril@gmail.com</a>&gt; wrote:=
<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8=
ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,=
204,204);padding-left:1ex"><div dir=3D"ltr">fix for <a href=3D"https://redm=
ine.postgresql.org/issues/5841" target=3D"_blank">https://redmine.postgresq=
l.org/issues/5841</a></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div d=
ir=3D"ltr"><div><font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);=
font-family:arial,sans-serif;font-size:13px;border-collapse:collapse">Thank=
s &amp; Regards</span></b></font></div><div><font color=3D"#3333FF"><b><spa=
n style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;bor=
der-collapse:collapse">Akshay Joshi</span></b></font></div><div><font color=
=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-seri=
f;font-size:13px;border-collapse:collapse">pgAdmin Hacker | Sr. Software Ar=
chitect</span></b></font></div><font color=3D"#000000" face=3D"arial, sans-=
serif"><b><a href=3D"http://edbpostgres.com" target=3D"_blank">EDB Postgres=
</a></b></font><br><div><b style=3D"color:rgb(51,51,255)"><span style=3D"co=
lor:rgb(0,0,0);font-family:arial,sans-serif;font-size:13px;border-collapse:=
collapse">Mobile: +91 976-788-8246<br></span></b><br></div></div></div></di=
v></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
><div dir=3D"ltr"><div style=3D"font-size:12.8px">Thanks &amp; Regards,<br>=
</div><div style=3D"font-size:12.8px">Pradip Parkale<br>Software Engineer |=
 EnterpriseDB Corporation</div></div></div></div>

--0000000000001c46b005afd0ea09--

--0000000000001c46b305afd0ea0b
Content-Type: application/x-patch; name="RM5841.patch"
Content-Disposition: attachment; filename="RM5841.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_kfcf4evf0>
X-Attachment-Id: f_kfcf4evf0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL19f
aW5pdF9fLnB5IGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvX19p
bml0X18ucHkKaW5kZXggZWQ4ZmFlMGYwLi4xMGVmYTRlODcgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2Fk
bWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL19faW5pdF9fLnB5CisrKyBiL3dlYi9w
Z2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL19faW5pdF9fLnB5CkBAIC0xOTQs
MTQgKzE5NCw2IEBAIGNsYXNzIFNlcnZlck1vZHVsZShzZy5TZXJ2ZXJHcm91cFBsdWdpbk1vZHVs
ZSk6CiAgICAgICAgICAgICAgICAgICAgICMgc2V0IHRvIHRydWUKICAgICAgICAgICAgICAgICAg
ICAgY29udGludWUKIAotICAgICAgICAgICAgICAgICMgaWYgaGlkZV9zaGFyZWRfc2VydmVyIG9y
IFwKLSAgICAgICAgICAgICAgICAjICAgICAgICAgc2hhcmVkX3NlcnZlci5uYW1lID09IGF1dG9f
ZGV0ZWN0ZWRfc2VydmVyOgotICAgICAgICAgICAgICAgICMgICAgICMgRG9uJ3QgaW5jbHVkZSBz
aGFyZWQgc2VydmVyIGlmIGhpZGUgc2hhcmVkIHNlcnZlciBpcwotICAgICAgICAgICAgICAgICMg
ICAgICMgc2V0IHRvIHRydWUKLSAgICAgICAgICAgICAgICAjICAgICBjb250aW51ZQotCi0gICAg
ICAgICAgICAgICAgIyBpZiBzaGFyZWRfc2VydmVyLm5hbWUgPT0gYXV0b19kZXRlY3RlZF9zZXJ2
ZXI6Ci0gICAgICAgICAgICAgICAgIyAgICAgY29udGludWUKICAgICAgICAgICAgICAgICBzZXJ2
ZXIgPSBzZWxmLmdldF9zaGFyZWRfc2VydmVyX3Byb3BlcnRpZXMoc2VydmVyLAogICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzaGFyZWRf
c2VydmVyKQogICAgICAgICAgICAgY29ubmVjdGVkID0gRmFsc2UKQEAgLTEyODEsNyArMTI3Myw3
IEBAIGNsYXNzIFNlcnZlck5vZGUoUEdDaGlsZE5vZGVWaWV3KToKICAgICAgICAgICAgIHJldHVy
biBiYWRfcmVxdWVzdChzZWxmLm5vdF9mb3VuZF9lcnJvcl9tc2coKSkKIAogICAgICAgICAjIFJl
dHVybiBpZiB1c2VybmFtZSBpcyBibGFuawotICAgICAgICBpZiBzZXJ2ZXIudXNlcm5hbWUgaXMg
Tm9uZToKKyAgICAgICAgaWYgc2VydmVyLnVzZXJuYW1lIGlzIE5vbmUgYW5kIG5vdCBzZXJ2ZXIu
c2VydmljZToKICAgICAgICAgICAgIHJldHVybiBtYWtlX2pzb25fcmVzcG9uc2UoCiAgICAgICAg
ICAgICAgICAgc3RhdHVzPTIwMCwKICAgICAgICAgICAgICAgICBzdWNjZXNzPTAsCmRpZmYgLS1n
aXQgYS93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9zdGF0aWMvanMv
c2VydmVyLmpzIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvc3Rh
dGljL2pzL3NlcnZlci5qcwppbmRleCAzNzk0MmRhMDguLjhhNGJlMjJiNCAxMDA2NDQKLS0tIGEv
d2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvc3RhdGljL2pzL3NlcnZl
ci5qcworKysgYi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9zdGF0
aWMvanMvc2VydmVyLmpzCkBAIC0xMjA4LDcgKzEyMDgsNyBAQCBkZWZpbmUoJ3BnYWRtaW4ubm9k
ZS5zZXJ2ZXInLCBbCiAgICAgICAkLmdldChzZXJ2ZXJfdXJsKQogICAgICAgICAuZG9uZShmdW5j
dGlvbihyZXMpIHsKICAgICAgICAgICBpZiAocmVzLnNoYXJlZCAmJiBfLmlzTnVsbChyZXMudXNl
cm5hbWUpICYmIGRhdGEudXNlcl9pZCAhPSBjdXJyZW50X3VzZXIuaWQpewotICAgICAgICAgICAg
aWYgKHNlbGVjdGVkVHJlZU5vZGVEYXRhLl90eXBlID09ICdzZXJ2ZXInKXsKKyAgICAgICAgICAg
IGlmIChzZWxlY3RlZFRyZWVOb2RlRGF0YS5fdHlwZSA9PSAnc2VydmVyJyAmJiAhcmVzLnNlcnZp
Y2UpewogICAgICAgICAgICAgICBwZ0FkbWluLkJyb3dzZXIuTm9kZS5jYWxsYmFja3Muc2hvd19v
YmpfcHJvcGVydGllcy5jYWxsKAogICAgICAgICAgICAgICAgIHBnQWRtaW4uQnJvd3Nlci5Ob2Rl
c1t0cmVlLml0ZW1EYXRhKGl0ZW0pLl90eXBlXSwge2FjdGlvbjogJ2VkaXQnfQogICAgICAgICAg
ICAgICApOwo=
--0000000000001c46b305afd0ea0b--