public inbox for [email protected]  
help / color / mirror / Atom feed
From: Pradip Parkale <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin][RM6835]: Unable to edit publication in properties dialog.
Date: Mon, 4 Oct 2021 13:33:43 +0530
Message-ID: <CAJ9T6SsqWvZWybHWBHuTZdwCd7A1396BuhokpnMAxMtKCXGjBg@mail.gmail.com> (raw)

Hi Hackers,

Please find the attached patch for 1st part of #6835.

   - Unable to edit publication in the subscription dialog.


-- 
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


Attachments:

  [application/octet-stream] RM6835.patch (882B, 3-RM6835.patch)
  download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/subscriptions/__init__.py b/web/pgadmin/browser/server_groups/servers/databases/subscriptions/__init__.py
index b3c096710..e1fbdfb5b 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/subscriptions/__init__.py
+++ b/web/pgadmin/browser/server_groups/servers/databases/subscriptions/__init__.py
@@ -410,10 +410,6 @@ class SubscriptionView(PGChildNodeView, SchemaDiffObjectCompare):
         )
 
         try:
-            if 'pub' in data:
-                data['pub'] = json.loads(
-                    data['pub'], encoding='utf-8'
-                )
             sql, name = self.get_sql(data, subid)
             # Most probably this is due to error
             if not isinstance(sql, str):
* Unmerged path web/pgadmin/browser/server_groups/servers/databases/subscriptions/static/js/subscription.js


view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin][RM6835]: Unable to edit publication in properties dialog.
  In-Reply-To: <CAJ9T6SsqWvZWybHWBHuTZdwCd7A1396BuhokpnMAxMtKCXGjBg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox