Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jErJo-0003kd-02 for pgadmin-hackers@arkaria.postgresql.org; Thu, 19 Mar 2020 09:18:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jErJm-0007p9-Mc for pgadmin-hackers@arkaria.postgresql.org; Thu, 19 Mar 2020 09:18:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jErJm-0007p1-FR for pgadmin-hackers@lists.postgresql.org; Thu, 19 Mar 2020 09:18:22 +0000 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jErJk-0005a2-5k for pgadmin-hackers@postgresql.org; Thu, 19 Mar 2020 09:18:21 +0000 Received: by mail-wm1-x334.google.com with SMTP id n8so1154760wmc.4 for ; Thu, 19 Mar 2020 02:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gvHMjYNGKs2dILyMowdx1iZxS+i6PEUblt5Sddm0/hI=; b=kzV1aIJqKDSZKUT0Rj3T88+mGDoU5lWn/u/U5fz1R4e2r4O6Yg4+PJiE3YK0iy3G44 wwtj0qew9wyZR+wO4q/Uf7PkpLHYlWy8TqH50rRbY3A76zIltUdrY+g2GNCYWUUYcDj2 SPjLvDGhMmYtzGS8J+ltOynxGHdrRcTKNBHXdRVoKOmm9GA4zHcHx4xomNovxOh2f+qF LBwCBJGdH5irZfckRl+HoxrIgFptEUA82tIxQEO0aLn37zjXyq6GlItsc8yjhxC6KaW/ Jr0ohGTTTYbLrxNBy9nB0CIpOWjXkCFaT84EtqtxdgBqegsZKdca5w7GUYKQiWDHNanf BHPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gvHMjYNGKs2dILyMowdx1iZxS+i6PEUblt5Sddm0/hI=; b=MjryGLrN+f36qZ0B5s0U1ZQayiCqFdL26QMTfsoRLbu3HWz35qC2tv6yPfFrtT/o2J Qh+Qey8quqK7orUD90ASTmkluoGqERgoSE++TvWMBvKjjmzxLQjwEnDyRI1C1sEINTSE NSqHn/VQxn7TbKYPa7NNDKKVABnlypr2liL0IUK38T0RjRrXtbhRpA/AdMQoPdRf8cHL QJ7ciU13WqmvxIc/lBHbG4PV0HEDHDAl5ujfVDy3oSKvo/hLmuEPoCmHtX4mO3gDMJgV bTTfcHFDTD5/2ZQusWXR6E5Tn+lXTmvIsJp+UsYpgdaxI+C+JYJ6iOgGqVuDEriUF/de lmmw== X-Gm-Message-State: ANhLgQ0xFb72A6GJO1L8FntdDNTTs4RrLw+M6nEO3dLIMbRTWunaH7as ppKygVaslRxcP2prPAi1jAreYChVP7IGU+yKm6RoslKRoJ+v2RHBVoYt0sYQcAZ0Ehjg/C5Maqv sFCwEp68gbSe6ICNKnfH/VRxdZ7cgqK8wFn1FeVMahm0XU7+PbQrZ9mUz0eZdzL+QPpwasWbV3O QNJ3Fc5+tHtOQELWnicas+ZWRUmxqsM+U+cvPbXhFv6roP3jqWynujog== X-Google-Smtp-Source: ADFU+vszNZsPjfbtLU7DHXpXOvP/sG842xY99Ovf1OvF3cy/wVSHN95+8uO5YmjSKpykOR3UDqy4mQNF1Ovg4NXjXgA= X-Received: by 2002:a05:600c:21d1:: with SMTP id x17mr2480833wmj.94.1584609499058; Thu, 19 Mar 2020 02:18:19 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Pradip Parkale Date: Thu, 19 Mar 2020 14:48:08 +0530 Message-ID: Subject: Re: [Accessibility] RM4608 Few issues in the dialogs. To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000004caaae05a131a6ba" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000004caaae05a131a6ba Content-Type: text/plain; charset="UTF-8" Hi Akshay, Please find the things which I have fixed in this patch. Fixed some accessibility issues: 1) Aria-label additions at few missing places. 2) Label additions with 'sr-only' class where hidden labels required. 3) Converted label to span to solve accessibility error. I also incorporated the review comments given by Khushboo related to RM4237. It was related to DateTime picker control using the keyboard. On Thu, Mar 19, 2020 at 2:32 PM Akshay Joshi wrote: > Hi Pradip > > Can you please list down the things that you have fixed in this patch. > > On Thu, Mar 19, 2020 at 2:26 PM Pradip Parkale < > pradip.parkale@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the patch for accessibility errors in some of the dialogs. >> >> >> -- >> Thanks & Regards, >> Pradip Parkale >> QMG, EnterpriseDB Corporation >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation --0000000000004caaae05a131a6ba Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Akshay,
Ple= ase find the things which I have fixed in this patch.

Fixed some accessibility issues:
1) Aria-label additions at few missing places.
2) Label additions with =C2=A0'sr-only' class where hidden label= s required.
3) Converted label to span to solve acces= sibility error.

I also incorporate= d the review comments=C2=A0given by Khushboo related to RM4237. It was rela= ted to DateTime picker control=C2=A0using the keyboard.
On Thu, = Mar 19, 2020 at 2:32 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrot= e:
Hi Pradip

= Can you please list down the things that you have fixed in this patch.=C2= =A0

On Thu, Mar 19, 2020 at 2:26 PM Pradip Parkale <pradip.parkale@enterp= risedb.com> wrote:
Hi Ha= ckers,

Please find the patch for accessibility=C2=A0erro= rs in some of the dialogs.


--
Thanks = & Regards,
Pradip Parkale
Q= MG, EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks & Regards,
=
Pradip Parkale
QMG, EnterpriseDB C= orporation
--0000000000004caaae05a131a6ba--