public inbox for [email protected]  

help / color / mirror / Atom feed

From: Pradip Parkale <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel.
Date: Wed, 16 Jun 2021 23:28:54 +0530
Message-ID: <CAJ9T6St7o5QTO1R2KSsvZAviCw0jK0u6MWsgUAtRzpkDQQpA+A@mail.gmail.com> (raw)

Hi Hackers,

Please find the attached patch for #6398.Detaching query editor panel gives
a blank white panel.


-- 
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


Attachments:

  [application/octet-stream] RM6398.patch (3.8K, 3-RM6398.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/datagrid/static/js/datagrid.js b/web/pgadmin/tools/datagrid/static/js/datagrid.js
index 36fd140a1..80ce35680 100644
--- a/web/pgadmin/tools/datagrid/static/js/datagrid.js
+++ b/web/pgadmin/tools/datagrid/static/js/datagrid.js
@@ -213,6 +213,19 @@ define('pgadmin.datagrid', [
         showQueryTool.showQueryTool(this, pgBrowser, alertify, url, aciTreeIdentifier, transId);
       },
 
+      resize_the_queryTool: function(){
+        var docker = this.docker(this._panel);
+        var dockerPos = docker.$container.offset();
+        var pos = this.$container.offset();
+        var width = this.$container.width();
+        var height = this.$container.height();
+
+        $(wcDocker).find('.wcIFrameFloating').css('top', pos.top - dockerPos.top);
+        $(wcDocker).find('.wcIFrameFloating').css('left', pos.left - dockerPos.left);
+        $(wcDocker).find('.wcIFrameFloating').css('width', width);
+        $(wcDocker).find('.wcIFrameFloating').css('height', height);
+      },
+
       launch_grid: function(trans_id, panel_url, is_query_tool, panel_title, sURL=null, sql_filter=null) {
 
         let queryToolForm = `
@@ -270,6 +283,20 @@ define('pgadmin.datagrid', [
             });
           });
 
+          queryToolPanel.on(wcDocker.EVENT.DETACHED, function() {
+            $(wcDocker).find('.wcIFrameFloating').attr({
+              style: 'z-index: 1200'
+            });
+          });
+
+          queryToolPanel.on(wcDocker.EVENT.ORDER_CHANGED, function() {
+            $(wcDocker).find('.wcIFrameFloating').attr({
+              style: 'z-index: 1200'
+            });
+          });
+
+          queryToolPanel.on(wcDocker.EVENT.ORDER_CHANGED, this.resize_the_queryTool);
+
           // Listen on the panelRename event.
           queryToolPanel.on(wcDocker.EVENT.RENAME, function(panel_data) {
             var temp_title = panel_data.$titleText[0].textContent;
diff --git a/web/pgadmin/tools/psql/static/js/psql_module.js b/web/pgadmin/tools/psql/static/js/psql_module.js
index 85bccb1a7..54b2d79c8 100644
--- a/web/pgadmin/tools/psql/static/js/psql_module.js
+++ b/web/pgadmin/tools/psql/static/js/psql_module.js
@@ -181,6 +181,20 @@ export function initialize(gettext, url_for, $, _, pgAdmin, csrfToken, Browser)
         var propertiesPanel = pgBrowser.docker.findPanels('properties');
         var psqlToolPanel = pgBrowser.docker.addPanel('frm_psqltool', wcDocker.DOCK.STACKED, propertiesPanel[0]);
 
+        psqlToolPanel.on(wcDocker.EVENT.DETACHED, function() {
+          $(wcDocker).find('.wcIFrameFloating').attr({
+            style: 'z-index: 1200'
+          });
+        });
+
+        psqlToolPanel.on(wcDocker.EVENT.ORDER_CHANGED, function() {
+          $(wcDocker).find('.wcIFrameFloating').attr({
+            style: 'z-index: 1200'
+          });
+        });
+
+        psqlToolPanel.on(wcDocker.EVENT.ORDER_CHANGED, this.resize_the_psql);
+
         // Set panel title and icon
         setPanelTitle(psqlToolPanel, panelTitle);
         psqlToolPanel.icon('fas fa-terminal psql-tab-style');
@@ -217,6 +231,18 @@ export function initialize(gettext, url_for, $, _, pgAdmin, csrfToken, Browser)
       }
 
     },
+    resize_the_psql: function(){
+      var docker = this.docker(this._panel);
+      var dockerPos = docker.$container.offset();
+      var pos = this.$container.offset();
+      var width = this.$container.width();
+      var height = this.$container.height();
+
+      $(wcDocker).find('.wcIFrameFloating').css('top', pos.top - dockerPos.top);
+      $(wcDocker).find('.wcIFrameFloating').css('left', pos.left - dockerPos.left);
+      $(wcDocker).find('.wcIFrameFloating').css('width', width);
+      $(wcDocker).find('.wcIFrameFloating').css('height', height);
+    },
     getPanelUrls: function(transId, panelTitle, parentData) {
       let openUrl = url_for('psql.panel', {
         trans_id: transId,

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel.
  In-Reply-To: <CAJ9T6St7o5QTO1R2KSsvZAviCw0jK0u6MWsgUAtRzpkDQQpA+A@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox