Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNfsI-0001Ul-8F for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Sep 2020 17:26:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kNfrl-0007oJ-Gx for pgadmin-hackers@arkaria.postgresql.org; Wed, 30 Sep 2020 17:26:09 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNfrl-0007oB-2s for pgadmin-hackers@lists.postgresql.org; Wed, 30 Sep 2020 17:26:09 +0000 Received: from mail-pg1-x533.google.com ([2607:f8b0:4864:20::533]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kNfrf-0004In-VG for pgadmin-hackers@postgresql.org; Wed, 30 Sep 2020 17:26:07 +0000 Received: by mail-pg1-x533.google.com with SMTP id 7so1471047pgm.11 for ; Wed, 30 Sep 2020 10:26:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xmHuLVr6mbnfjqtJiAufbScO8+3BQuxlcYTySXsgwR4=; b=ue/X5oKaG2VHoCoC7ldYDpeDG9kCrkZGmHDxXa4N/YGiuDZ8z+hTPi5LUcU6FfAvSs Z/4uql/WqK94zkdJqkJrE7r8z/Vj12R+diDPHhzSOaz9maMvP/s2k0i1NQsjf6W36GIu 3ugXAVSC3qy5DJnb/DXSlCbtAHVmWjZgyc8rzLvuz0Fnup88oioroxtCS4O1U9GEC7Pg PGK5yZQNJJSVxr2qievL8mph6kssvWdUttTAvvEqvJOWC4yk+e2iEpKEJPK+wTJ7yosO 2y1u60M+hwwKQsvcoPj0JrtkUUQ1kmGL2AEqwpye+qTYSEXH65vbSsbfKnUxR2GUhQXZ CVrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xmHuLVr6mbnfjqtJiAufbScO8+3BQuxlcYTySXsgwR4=; b=eT8dq8doGJUlncJLiL6YygA7uekZuevWxOuZ6z6KXo/ViE/HtJqKLMlyruX8v5Pc0t 46LRrDuYpgxFA4Iq6nkd4Gp0jr55KwRaueGaP+RCTwNLw+1F+9KCAHu1OMMfH5zLJXuz t5ZTdR20vnIV11XXuMFzySTbrvPhNlg/UFm8HRO/k9NjQl9FUfSzUu5TZINJcLBCnf6S 7Vwcxl9fUCAQq2GobYW+oEt52/rhoDNdBdbFIi3X2Qdns4K3IgF3gd/5ac1aoGXzo4jj 5IXzc8JAWVEtmyG+59+4laNsFlNiBypa04aZXDN766hBfE/esF7wuEgvNPZWCcMQV0WB O4YQ== X-Gm-Message-State: AOAM530vFGBiqSEcXImoHu6kU00mOPyHWl1766eIySSodr22i9gnOMZU Tqevxutpr39Zhp3XGTHA2GgBS2KKbFja9yfgqFl9yi5XdLJ73Q5ppBY8vIt1DvnciYMC7XAN0wF wUfIQcZWxu/UVaTa3upi6gB9NyrK4JW5oZda76+A66+ZI0KvD5zdU6UKDVv1lpdqvdrWbG0dUwS OAdx88W5uHnWHI0SomuvnBxrSKUgpnwqtm08NorQOJNOL7nSvHYEm7XtIgFw== X-Google-Smtp-Source: ABdhPJwKOfRKRm0TyOiFbu4TIBOX1OUXMblWjTYaHb+yYM/kQFBA8yIGfKyV/unq4CRSHrOAiClyoJIMbdYUCR6Y3Yw= X-Received: by 2002:a62:520e:0:b029:142:2501:3979 with SMTP id g14-20020a62520e0000b029014225013979mr3659194pfb.62.1601486762409; Wed, 30 Sep 2020 10:26:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Pradip Parkale Date: Wed, 30 Sep 2020 22:55:50 +0530 Message-ID: Subject: Re: [pgAdmin][RM5867]:Some properties are not getting updated correctly if the server is shared server. To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000009655e905b08b3125" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000009655e905b08b3125 Content-Type: multipart/alternative; boundary="0000000000009655e705b08b3123" --0000000000009655e705b08b3123 Content-Type: text/plain; charset="UTF-8" Hi Akshay, Please find the attached patch for the API failure issue. On Wed, Sep 30, 2020 at 12:34 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Sep 30, 2020 at 11:00 AM Pradip Parkale < > pradip.parkale@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch for the below issues. >> >> 1. Shared with all? changed to 'Shared?'. >> 2. Hide shared server? changed to 'Hide shared servers?'. >> 3. Some properties of the base server were getting updated if the >> user updated the shared server properties so I fixed this issue. >> 4. Fixed an issue where 'Later' and 'Refresh' button labels were >> getting override on disconnect server confirmation dialogue. >> 5. If the user shares an auto-detected server and other user log-in >> then the auto-detected server of the second user will not be visible, the >> second user will see a shared auto-detected server. >> >> >> -- >> Thanks & Regards, >> Pradip Parkale >> Software Engineer | EnterpriseDB Corporation >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Sr. Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation --0000000000009655e705b08b3123 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi=C2=A0Akshay,
Please find the attached patch for the= API failure issue.

On Wed, Sep 30, 2020 at 12:34 PM Akshay Joshi <= akshay.joshi@enterprisedb.= com> wrote:
Thanks, patch= applied.

On Wed, Sep 30, 2020 at 11:00 AM Pradip Parkale <pradip.parkale@enter= prisedb.com> wrote:
Hi Ha= ckers,

Please find the attached patch for the below issu= es.
  1. Shared with all? changed to 'Shared?'.
    2. Hide shared server? changed to 'Hide shared servers?'.
  2. So= me properties of the base server were getting updated if the user updated t= he shared server properties so I fixed this issue.
  3. Fixed an issue w= here 'Later' and 'Refresh' button labels were getting overr= ide on disconnect server confirmation dialogue.
  4. If the user shares = an auto-detected server and other user log-in then the auto-detected=C2=A0s= erver of the second user will not be visible, the second user will see a sh= ared auto-detected server.

--
=
Thanks & Regards,
<= /div>
Pradip Parkale
Software Engineer | = EnterpriseDB Corporation


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Ar= chitect
EDB Postgres=
Mobile: +91 976-788-8246



--
Thanks & Regards,
Pradip Park= ale
Software Engineer | EnterpriseDB Corporation
--0000000000009655e705b08b3123-- --0000000000009655e905b08b3125 Content-Type: application/octet-stream; name="jenkins_issue.patch" Content-Disposition: attachment; filename="jenkins_issue.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kfpnte8c0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL3Rl c3RzL3Rlc3RfYWxsX3NlcnZlcl9nZXQucHkgYi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9n cm91cHMvc2VydmVycy90ZXN0cy90ZXN0X2FsbF9zZXJ2ZXJfZ2V0LnB5CmluZGV4IGNkMzVhN2Ew NS4uYThkZTkwNTZmIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91 cHMvc2VydmVycy90ZXN0cy90ZXN0X2FsbF9zZXJ2ZXJfZ2V0LnB5CisrKyBiL3dlYi9wZ2FkbWlu L2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL3Rlc3RzL3Rlc3RfYWxsX3NlcnZlcl9nZXQu cHkKQEAgLTEyLDYgKzEyLDcgQEAgZnJvbSBwZ2FkbWluLnV0aWxzLnJvdXRlIGltcG9ydCBCYXNl VGVzdEdlbmVyYXRvcgogZnJvbSByZWdyZXNzaW9uIGltcG9ydCBwYXJlbnRfbm9kZV9kaWN0CiBm cm9tIHJlZ3Jlc3Npb24ucHl0aG9uX3Rlc3RfdXRpbHMgaW1wb3J0IHRlc3RfdXRpbHMgYXMgdXRp bHMKIGZyb20gLiBpbXBvcnQgdXRpbHMgYXMgc2VydmVyc191dGlscworaW1wb3J0IGpzb24KIAog CiBjbGFzcyBBbGxTZXJ2ZXJzR2V0VGVzdENhc2UoQmFzZVRlc3RHZW5lcmF0b3IpOgpAQCAtMjUs OCArMjYsMjIgQEAgY2xhc3MgQWxsU2VydmVyc0dldFRlc3RDYXNlKEJhc2VUZXN0R2VuZXJhdG9y KToKIAogICAgIGRlZiBzZXRVcChzZWxmKToKICAgICAgICAgIiIiVGhpcyBmdW5jdGlvbiBhZGQg dGhlIHNlcnZlciB0byB0ZXN0IHRoZSBHRVQgQVBJIiIiCi0gICAgICAgIHNlbGYuc2VydmVyWydw YXNzd29yZCddID0gJ2VkYicKLSAgICAgICAgc2VsZi5zZXJ2ZXJfaWQgPSB1dGlscy5jcmVhdGVf c2VydmVyKHNlbGYuc2VydmVyKQorCisgICAgICAgIHNlcnZlcl9kZXRhaWxzID0gc2VydmVyc191 dGlscy5nZXRfc2VydmVyX2RhdGEoc2VsZi5zZXJ2ZXIpCisgICAgICAgIHNlcnZlcl9kZXRhaWxz WydwYXNzd29yZCddID0gc2VsZi5zZXJ2ZXJbJ2RiX3Bhc3N3b3JkJ10KKyAgICAgICAgc2VydmVy X2RldGFpbHNbJ3NhdmVfcGFzc3dvcmQnXSA9IDEKKyAgICAgICAgc2VydmVyX2RldGFpbHNbJ2Nv bm5lY3Rfbm93J10gPSAxCisKKyAgICAgICAgdXJsID0gIi9icm93c2VyL3NlcnZlci9vYmovezB9 LyIuZm9ybWF0KHV0aWxzLlNFUlZFUl9HUk9VUCkKKworICAgICAgICByZXNwb25zZSA9IHNlbGYu dGVzdGVyLnBvc3QoCisgICAgICAgICAgICB1cmwsCisgICAgICAgICAgICBkYXRhPWpzb24uZHVt cHMoc2VydmVyX2RldGFpbHMpLAorICAgICAgICAgICAgY29udGVudF90eXBlPSdodG1sL2pzb24n CisgICAgICAgICkKKyAgICAgICAgcmVzcG9uc2VfZGF0YSA9IGpzb24ubG9hZHMocmVzcG9uc2Uu ZGF0YS5kZWNvZGUoJ3V0Zi04JykpCisgICAgICAgIHNlbGYuc2VydmVyX2lkID0gcmVzcG9uc2Vf ZGF0YVsnbm9kZSddWydfaWQnXQorCiAgICAgICAgIHNlcnZlcl9kaWN0ID0geyJzZXJ2ZXJfaWQi OiBzZWxmLnNlcnZlcl9pZH0KICAgICAgICAgdXRpbHMud3JpdGVfbm9kZV9pbmZvKCJzaWQiLCBz ZXJ2ZXJfZGljdCkKIApAQCAtNTMsNyArNjgsNyBAQCBjbGFzcyBBbGxTZXJ2ZXJzR2V0VGVzdENh c2UoQmFzZVRlc3RHZW5lcmF0b3IpOgogICAgICAgICAgICAgZWxpZiBoYXNhdHRyKHNlbGYsICdj aGlsZHJlbicpOgogCiAgICAgICAgICAgICAgICAgc2VsZi51cmwgPSBzZWxmLnVybCArICd7MH0v ezF9Jy5mb3JtYXQoCi0gICAgICAgICAgICAgICAgICAgIHV0aWxzLlNFUlZFUl9HUk9VUCwgc2Vy dmVyX2lkKQorICAgICAgICAgICAgICAgICAgICB1dGlscy5TRVJWRVJfR1JPVVAsIHNlbGYuc2Vy dmVyX2lkKQogICAgICAgICAgICAgZWxpZiBoYXNhdHRyKHNlbGYsICdzZXJ2ZXJfbGlzdCcpOgog ICAgICAgICAgICAgICAgIGlmIGhhc2F0dHIoc2VsZiwgJ3NlcnZlcnMnKToKICAgICAgICAgICAg ICAgICAgICAgc2VydmVyX2lkID0gJycKQEAgLTY0LDcgKzc5LDcgQEAgY2xhc3MgQWxsU2VydmVy c0dldFRlc3RDYXNlKEJhc2VUZXN0R2VuZXJhdG9yKToKICAgICAgICAgICAgICAgICAgICAgdXJs ID0gJy9icm93c2VyL3NlcnZlci9jb25uZWN0LycgKyAnezB9L3sxfScuZm9ybWF0KAogICAgICAg ICAgICAgICAgICAgICAgICAgdXRpbHMuU0VSVkVSX0dST1VQLAogICAgICAgICAgICAgICAgICAg ICAgICAgc2VsZi5zZXJ2ZXJfaWQpCi0gICAgICAgICAgICAgICAgICAgIHNlbGYuc2VydmVyWydw YXNzd29yZCddID0gJ2VkYicKKyAgICAgICAgICAgICAgICAgICAgc2VsZi5zZXJ2ZXJbJ3Bhc3N3 b3JkJ10gPSBzZWxmLnNlcnZlclsnZGJfcGFzc3dvcmQnXQogCiAgICAgICAgICAgICAgICAgICAg IHNlbGYuY29ubmVjdF90b19zZXJ2ZXIodXJsKQogICAgICAgICAgICAgICAgIHNlbGYudXJsID0g c2VsZi51cmwgKyAnezB9L3sxfT9fPXsyfScuZm9ybWF0KApkaWZmIC0tZ2l0IGEvd2ViL3BnYWRt aW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvdGVzdHMvdXRpbHMucHkgYi93ZWIvcGdh ZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy90ZXN0cy91dGlscy5weQppbmRleCA4 NjgwYjI5ZmIuLjU2ZDQ3NWE5MCAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2 ZXJfZ3JvdXBzL3NlcnZlcnMvdGVzdHMvdXRpbHMucHkKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nl ci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvdGVzdHMvdXRpbHMucHkKQEAgLTUwLDMgKzUwLDI1IEBA IGRlZiBjcmVhdGVfc2VydmVyX3dpdGhfYXBpKHNlbGYsIHVybCk6CiAgICAgICAgIHJldHVybiBz ZXJ2ZXJfaWQKICAgICBleGNlcHQgRXhjZXB0aW9uIGFzIGV4Y2VwdGlvbjoKICAgICAgICAgcmFp c2UgRXhjZXB0aW9uKCJFcnJvciB3aGlsZSBjcmVhdGluZyBzZXJ2ZXIuICVzIiAlIGV4Y2VwdGlv bikKKworCitkZWYgZ2V0X3NlcnZlcl9kYXRhKHNlcnZlcik6CisgICAgIiIiCisgICAgVGhpcyBm dW5jdGlvbiByZXR1cm5zIHRoZSBzZXJ2ZXIgZGV0YWlscworICAgIDpwYXJhbSBzZXJ2ZXI6Cisg ICAgOnJldHVybjogc2VydmVyIGRhdGEKKyAgICAiIiIKKworICAgIHNlcnZlcl9kYXRhID0gXAor ICAgICAgICB7CisgICAgICAgICAgICAibmFtZSI6IHNlcnZlclsnbmFtZSddLAorICAgICAgICAg ICAgImNvbW1lbnQiOiBzZXJ2ZXJbJ2NvbW1lbnQnXSwKKyAgICAgICAgICAgICJ1c2VybmFtZSI6 IHNlcnZlclsndXNlcm5hbWUnXSwKKyAgICAgICAgICAgICJob3N0Ijogc2VydmVyWydob3N0J10s CisgICAgICAgICAgICAiZGJfcGFzc3dvcmQiOiBzZXJ2ZXJbJ2RiX3Bhc3N3b3JkJ10sCisgICAg ICAgICAgICAicG9ydCI6IHNlcnZlclsncG9ydCddLAorICAgICAgICAgICAgInNzbG1vZGUiOiBz ZXJ2ZXJbJ3NzbG1vZGUnXSwKKyAgICAgICAgICAgICJkYiI6IHNlcnZlclsnZGInXQorICAgICAg ICB9CisKKyAgICByZXR1cm4gc2VydmVyX2RhdGEK --0000000000009655e905b08b3125--