Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMoqh-00082i-7X for pgadmin-hackers@arkaria.postgresql.org; Thu, 18 Mar 2021 09:21:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lMoqf-0006nS-7l for pgadmin-hackers@arkaria.postgresql.org; Thu, 18 Mar 2021 09:21:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMoqf-0006nL-1P for pgadmin-hackers@lists.postgresql.org; Thu, 18 Mar 2021 09:21:45 +0000 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lMoqb-0005uU-Sk for pgadmin-hackers@postgresql.org; Thu, 18 Mar 2021 09:21:44 +0000 Received: by mail-pf1-x429.google.com with SMTP id q5so3065954pfh.10 for ; Thu, 18 Mar 2021 02:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=FjXdyPb0g5tkaL9oUu/PyizZLEsivAkzwpnSAQKZ+uM=; b=gT2EDeYNlhHo7+tmz6U2p6+pVl1nbzV3ioP58fgs3gGHfWMwto6oNkWmPGSGuC0lyI TQvvlV71pgqKHd7fBxxx7b08W6GJkKzUhx58hEzGJgecccxzf3pw7bL0Hzmysg6ClwbA eMFw1UJAXNDRVfmJcfdovbs5YLTNZnyX5oeyThC2ZA0dtFV/2VAWJw99V7eCxLB04ine KSqmuAld3s7vFYlKNhM/apHnH+Ave97s842sDn+TcKfDbxmjAtcStJaLkzPIeDJH8q3N Dyz5eg5aPMcTk+sDc42nodXuW3Kqq+4mH5YHf8rxGerW+btzixP6tkdwXWVJYyIsAlbb AyCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=FjXdyPb0g5tkaL9oUu/PyizZLEsivAkzwpnSAQKZ+uM=; b=XSwVjd0HdLqCU6A919UwRhfGmnUJGsgxWFmNbII/rM/kggaBkERXS5wgY1Iwv8UIjm ITrV1IsmdwZSd8I5VQN8+IS6YJGdLNzOoIdSCxS/UWkcaMNvtr2bVeaoA12GIr+TLmBr 4/Xj7s+D1zFJ/GnV7ezCMFbGzZEkhSgb8veH79APJ53QAcD3L4Zp+QPRnLN33XZbT2CE bJnsUBCrpz/mwmVEJDYJiJyniJjo0+S97AMpvEHnAs00u7c9qmoYW2fqZcAaDg6GWjrZ a9ekIyArJkH66oYBT5CvDoiEK2uWk3TU10j1nOfDEQFaL7wJKUYxexU9QNIFFoZdaTNf ct5g== X-Gm-Message-State: AOAM532ZRlVlJ8/yWZTGq6t90UBYoigsQ6UfDuCnWt8+HrFAqlQss3hf qhA0FS1/I2RLNb7lHkDWKmkRmNUwcJDWje5uaaGP57MCdbpFO8QoBAO0Vbt9kL+iRvSqR1EMdZ7 tJsHlNpjX4BOR/u8nJPsvelqaldVinOSO9cjmpzF1R+9xv/FdgwTpSYkluZtAbo2BisFxg4+Q5V xKnsI4fS16NWug1SftW2zh6S2RlJ081FYrEZSFhyHFh0Ch8wq2yg96xZBaLE7a5/MRbA== X-Google-Smtp-Source: ABdhPJyYmSpYV6xubdORSZdiB4UZiDrJEJM/2y16HmUELPMNOtxXEkWwE77KTgeX3ctTnI6EmmRP2ilS8/7eqnCEdrY= X-Received: by 2002:a05:6a00:cd5:b029:20f:eaee:df1c with SMTP id b21-20020a056a000cd5b029020feaeedf1cmr2957866pfv.79.1616059299048; Thu, 18 Mar 2021 02:21:39 -0700 (PDT) MIME-Version: 1.0 From: Pradip Parkale Date: Thu, 18 Mar 2021 14:51:27 +0530 Message-ID: Subject: [pgAdmin]:Patch for SonarQube fixes. To: pgadmin-hackers Content-Type: multipart/mixed; boundary="00000000000074df0505bdcc2020" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000074df0505bdcc2020 Content-Type: multipart/alternative; boundary="00000000000074df0205bdcc201e" --00000000000074df0205bdcc201e Content-Type: text/plain; charset="UTF-8" Hi Hackers, I have fixed a few sonarQube issues.PFA patch. - Fts Configuration 1. Remove this commented-out code. - Funtion 1. Update this function so that its implementation is not identical to the one on line 51. 2. Unexpected empty method 'validate'. - Trigger function 1. Update this function so that its implementation is not identical to the one on line 41. - Exclusion constraint 1. Update this function so that its implementation is not identical to the one on line 128. - File manager 1. Remove the unused local variable "e". -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation --00000000000074df0205bdcc201e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hackers,

I have= fixed a few sonarQube issues.PFA patch.
  • Fts Configuration
  1. Remove this commented-out code.
<= div>
  • Funtion
  1. Update this function so that it= s implementation is not identical to the one on line 51.
  2. Unexpe= cted empty method 'validate'.
    <= li>Trigger function
  1. Update this function so that it= s implementation is not identical to the one on line 41.
  • Exclusion constraint
  1. Update t= his function so that its implementation is not identical to the one on line= 128.
  • File manager
  1. Remove the unused local variable "e".

--
Thanks & Regards,
Pradip= Parkale
Software Engineer | EnterpriseDB Corporation
<= /div>
--00000000000074df0205bdcc201e-- --00000000000074df0505bdcc2020 Content-Type: application/octet-stream; name="sonarqube.patch" Content-Disposition: attachment; filename="sonarqube.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kmeny7ik0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2Rh dGFiYXNlcy9zY2hlbWFzL2Z0c19jb25maWd1cmF0aW9ucy9zdGF0aWMvanMvZnRzX2NvbmZpZ3Vy YXRpb24uanMgYi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRh YmFzZXMvc2NoZW1hcy9mdHNfY29uZmlndXJhdGlvbnMvc3RhdGljL2pzL2Z0c19jb25maWd1cmF0 aW9uLmpzCmluZGV4IGZlZmUzMDliMS4uYjliMjRmZWU0IDEwMDY0NAotLS0gYS93ZWIvcGdhZG1p bi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy9mdHNfY29u ZmlndXJhdGlvbnMvc3RhdGljL2pzL2Z0c19jb25maWd1cmF0aW9uLmpzCisrKyBiL3dlYi9wZ2Fk bWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2RhdGFiYXNlcy9zY2hlbWFzL2Z0c19j b25maWd1cmF0aW9ucy9zdGF0aWMvanMvZnRzX2NvbmZpZ3VyYXRpb24uanMKQEAgLTM2Nyw3ICsz NjcsNiBAQCBkZWZpbmUoJ3BnYWRtaW4ubm9kZS5mdHNfY29uZmlndXJhdGlvbicsIFsKICAgICAg ICAgICBzZWxmLiRncmlkLmZpbmQoJy5uZXcnKS5yZW1vdmVDbGFzcygnbmV3Jyk7CiAgICAgICAg ICAgdmFyIG5ld1JvdyA9IHNlbGYuZ3JpZC5ib2R5LnJvd3NbaWR4XS4kZWw7CiAgICAgICAgICAg bmV3Um93LmFkZENsYXNzKCduZXcnKTsKLSAgICAgICAgICAvLyQobmV3Um93KS5wZ01ha2VWaXNp YmxlKCd0YWJsZS1ib3JkZXJlZCcpOwogICAgICAgICAgICQobmV3Um93KS5wZ01ha2VWaXNpYmxl KCdiYWNrZm9ybS10YWInKTsKICAgICAgICAgfQogCmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi9i cm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy9mdW5jdGlvbnMv c3RhdGljL2pzL2Z1bmN0aW9uLmpzIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBz L3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvZnVuY3Rpb25zL3N0YXRpYy9qcy9mdW5jdGlvbi5q cwppbmRleCAyNDIwZmNmMmYuLjlmZWVhMTVlYyAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vYnJv d3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvZnVuY3Rpb25zL3N0 YXRpYy9qcy9mdW5jdGlvbi5qcworKysgYi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91 cHMvc2VydmVycy9kYXRhYmFzZXMvc2NoZW1hcy9mdW5jdGlvbnMvc3RhdGljL2pzL2Z1bmN0aW9u LmpzCkBAIC00OCwxMyArNDgsNyBAQCBkZWZpbmUoJ3BnYWRtaW4ubm9kZS5mdW5jdGlvbicsIFsK ICAgICAgIGlkOiAnYXJndHlwZScsIGxhYmVsOiBnZXR0ZXh0KCdEYXRhIHR5cGUnKSwgY2VsbDoK ICAgICAgICAgJ25vZGUtYWpheC1vcHRpb25zJywgY2VsbEhlYWRlckNsYXNzZXM6ICd3aWR0aF9w ZXJjZW50XzMwJywKICAgICAgIGNvbnRyb2w6ICdub2RlLWFqYXgtb3B0aW9ucycsIHR5cGU6ICd0 ZXh0JywgdXJsOiAnZ2V0X3R5cGVzJywKLSAgICAgIGVkaXRhYmxlOiBmdW5jdGlvbihtKSB7Ci0g ICAgICAgIHZhciBub2RlX2luZm8gPSB0aGlzLmdldCgnbm9kZV9pbmZvJyk7Ci0gICAgICAgIGlm KG5vZGVfaW5mbyAmJiAnY2F0YWxvZycgaW4gbm9kZV9pbmZvKSB7Ci0gICAgICAgICAgcmV0dXJu IGZhbHNlOwotICAgICAgICB9Ci0gICAgICAgIHJldHVybiBfLmlzVW5kZWZpbmVkKG0uaXNOZXcp ID8gdHJ1ZSA6IG0uaXNOZXcoKTsKLSAgICAgIH0sIGZpcnN0X2VtcHR5OiB0cnVlLAorICAgICAg ZWRpdGFibGU6ICdpc0VkaXRhYmxlJywgZmlyc3RfZW1wdHk6IHRydWUsCiAgICAgfSx7CiAgICAg ICBpZDogJ2FyZ21vZGUnLCBsYWJlbDogZ2V0dGV4dCgnTW9kZScpLCB0eXBlOiAnb3B0aW9ucycs CiAgICAgICBjb250cm9sOiAnbm9kZS1hamF4LW9wdGlvbnMnLCBjZWxsSGVhZGVyQ2xhc3Nlczon d2lkdGhfcGVyY2VudF8yMCcsCkBAIC02NiwxMyArNjAsNyBAQCBkZWZpbmUoJ3BnYWRtaW4ubm9k ZS5mdW5jdGlvbicsIFsKICAgICAgICAgeydsYWJlbCc6ICdPVVQnLCAndmFsdWUnOiAnT1VUJ30s CiAgICAgICAgIHsnbGFiZWwnOiAnSU5PVVQnLCAndmFsdWUnOiAnSU5PVVQnfSwKICAgICAgICAg eydsYWJlbCc6ICdWQVJJQURJQycsICd2YWx1ZSc6ICdWQVJJQURJQyd9LAotICAgICAgXSwgZWRp dGFibGU6IGZ1bmN0aW9uKG0pIHsKLSAgICAgICAgdmFyIG5vZGVfaW5mbyA9IHRoaXMuZ2V0KCdu b2RlX2luZm8nKTsKLSAgICAgICAgaWYobm9kZV9pbmZvICYmICdjYXRhbG9nJyBpbiBub2RlX2lu Zm8pIHsKLSAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgICAgIH0KLSAgICAgICAgcmV0dXJu IF8uaXNVbmRlZmluZWQobS5pc05ldykgPyB0cnVlIDogbS5pc05ldygpOwotICAgICAgfSwKKyAg ICAgIF0sIGVkaXRhYmxlOiAnaXNFZGl0YWJsZScsCiAgICAgfSx7CiAgICAgICBpZDogJ2FyZ25h bWUnLCBsYWJlbDogZ2V0dGV4dCgnQXJndW1lbnQgbmFtZScpLCB0eXBlOiAndGV4dCcsCiAgICAg ICBjZWxsOiAnc3RyaW5nJywgZWRpdGFibGU6ICdpc0luQ2F0YWxvZycsIGNlbGxIZWFkZXJDbGFz c2VzOid3aWR0aF9wZXJjZW50XzMwJywKQEAgLTgyLDYgKzcwLDEzIEBAIGRlZmluZSgncGdhZG1p bi5ub2RlLmZ1bmN0aW9uJywgWwogICAgIH0sCiAgICAgXSwKICAgICB0b0pTT046IEJhY2tib25l Lk1vZGVsLnByb3RvdHlwZS50b0pTT04sCisgICAgaXNFZGl0YWJsZTogZnVuY3Rpb24obSkgewor ICAgICAgdmFyIG5vZGVfaW5mbyA9IHRoaXMuZ2V0KCdub2RlX2luZm8nKTsKKyAgICAgIGlmKG5v ZGVfaW5mbyAmJiAnY2F0YWxvZycgaW4gbm9kZV9pbmZvKSB7CisgICAgICAgIHJldHVybiBmYWxz ZTsKKyAgICAgIH0KKyAgICAgIHJldHVybiBfLmlzVW5kZWZpbmVkKG0uaXNOZXcpID8gdHJ1ZSA6 IG0uaXNOZXcoKTsKKyAgICB9LAogICAgIGlzSW5DYXRhbG9nOiBmdW5jdGlvbihtKXsKICAgICAg IHZhciBub2RlX2luZm8gPSB0aGlzLmdldCgnbm9kZV9pbmZvJyk7CiAgICAgICBpZihub2RlX2lu Zm8gJiYgJ2NhdGFsb2cnIGluIG5vZGVfaW5mbykgewpkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4v YnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvZnVuY3Rpb25z L3N0YXRpYy9qcy90cmlnZ2VyX2Z1bmN0aW9uLmpzIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9zZXJ2 ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvZnVuY3Rpb25zL3N0YXRpYy9qcy90 cmlnZ2VyX2Z1bmN0aW9uLmpzCmluZGV4IGE0ODBhOTZiNi4uOTRkOWU5YTdiIDEwMDY0NAotLS0g YS93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2VydmVycy9kYXRhYmFzZXMvc2No ZW1hcy9mdW5jdGlvbnMvc3RhdGljL2pzL3RyaWdnZXJfZnVuY3Rpb24uanMKKysrIGIvd2ViL3Bn YWRtaW4vYnJvd3Nlci9zZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3NjaGVtYXMvZnVu Y3Rpb25zL3N0YXRpYy9qcy90cmlnZ2VyX2Z1bmN0aW9uLmpzCkBAIC00OCwxMiArNDgsNyBAQCBk ZWZpbmUoJ3BnYWRtaW4ubm9kZS50cmlnZ2VyX2Z1bmN0aW9uJywgWwogICAgICAgfSwKICAgICAg IGhhc1NRTDogdHJ1ZSwKICAgICAgIHNob3dNZW51OiBmdW5jdGlvbihpdGVtRGF0YSwgaXRlbSkg ewotICAgICAgICBsZXQgbm9kZSA9IHBnQnJvd3Nlci50cmVlTWVudS5maW5kTm9kZUJ5RG9tRWxl bWVudChpdGVtKTsKLQotICAgICAgICBpZiAoIW5vZGUgfHwgbm9kZS5wYXJlbnROb2RlLmdldERh dGEoKS5fdHlwZSA9PT0gJ3RyaWdnZXInKQotICAgICAgICAgIHJldHVybiBmYWxzZTsKLQotICAg ICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgcmV0dXJuIHRoaXMuY2FuRWRpdChpdGVtRGF0YSwg aXRlbSk7CiAgICAgICB9LAogICAgICAgaGFzRGVwZW5kczogdHJ1ZSwKICAgICAgIGhhc1N0YXRp c3RpY3M6IHRydWUsCmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi9taXNjL2ZpbGVfbWFuYWdlci9f X2luaXRfXy5weSBiL3dlYi9wZ2FkbWluL21pc2MvZmlsZV9tYW5hZ2VyL19faW5pdF9fLnB5Cmlu ZGV4IDZhOThkNGJjZS4uMDk3M2RmNGEyIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9taXNjL2Zp bGVfbWFuYWdlci9fX2luaXRfXy5weQorKysgYi93ZWIvcGdhZG1pbi9taXNjL2ZpbGVfbWFuYWdl ci9fX2luaXRfXy5weQpAQCAtNjA4LDcgKzYwOCw3IEBAIGNsYXNzIEZpbGVtYW5hZ2VyKG9iamVj dCk6CiAgICAgICAgICAgICAgICAgY3JlYXRlZCA9IHRpbWUuY3RpbWUob3MucGF0aC5nZXRjdGlt ZShzeXN0ZW1fcGF0aCkpCiAgICAgICAgICAgICAgICAgbW9kaWZpZWQgPSB0aW1lLmN0aW1lKG9z LnBhdGguZ2V0bXRpbWUoc3lzdGVtX3BhdGgpKQogICAgICAgICAgICAgICAgIGZpbGVfZXh0ZW5z aW9uID0gc3RyKHNwbGl0ZXh0KHN5c3RlbV9wYXRoKSkKLSAgICAgICAgICAgIGV4Y2VwdCBFeGNl cHRpb24gYXMgZToKKyAgICAgICAgICAgIGV4Y2VwdCBFeGNlcHRpb246CiAgICAgICAgICAgICAg ICAgY29udGludWUKIAogICAgICAgICAgICAgIyBzZXQgcHJvdGVjdGVkIHRvIDEgaWYgbm8gd3Jp dGUgb3IgcmVhZCBwZXJtaXNzaW9uCg== --00000000000074df0505bdcc2020--