Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBdR2-0005n0-NG for pgadmin-hackers@arkaria.postgresql.org; Mon, 15 Feb 2021 12:57:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lBdR1-00054n-NH for pgadmin-hackers@arkaria.postgresql.org; Mon, 15 Feb 2021 12:57:03 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lBdR1-00054g-DL for pgadmin-hackers@lists.postgresql.org; Mon, 15 Feb 2021 12:57:03 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lBdQy-0005eA-I3 for pgadmin-hackers@postgresql.org; Mon, 15 Feb 2021 12:57:02 +0000 Received: by mail-pl1-x630.google.com with SMTP id d15so3705033plh.4 for ; Mon, 15 Feb 2021 04:57:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iUbXBUvVSMd21XDYPjU5l+MeHVjbjFy60hge68IJORM=; b=SDtMUOsB6yFhX2NRL2vh37RZwsoaWcs6Am2WgDlLE9hGWkh37szJn/xwn7mo5l/DLP zNJGL4rYnVS5Q02NPmyUt+rk2xDcb1XEE/3HWAcK0eoCJSJk1qAIgOMFvOS07fiKom4k oND4CL/mGdJGYHCxB4C9e21xWJenhtrYBruE+9mmjSQfJrgHRU6gnSqIZ2hViWgthifn VPIUNSKsc/Y6izG87vdpbZBvRlK+SBDRzOSU7obt+5daBmMyJ34xTnBdi5sSP5de9mNu rL+4i/8GKYoVqkcPrXN3Iaje1TT58ejuZd1HZZQFHd3vR5xQJUnVBWZET3oj5xQl2vV2 8LVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iUbXBUvVSMd21XDYPjU5l+MeHVjbjFy60hge68IJORM=; b=UDBk9NEkFFCZSEYsua42+zSVi6ME36Z8wD9K69VA953OHqGG3vziunwgteA8csJ8av YxpzcY4nU5g0XBzwVRUiODqPz66uL2n5uL+JYoeP8JIbVMaP1S64zIvy5GomCfMqCh5C j9CeYiNf4t0Jsr3ahlREAOxKPqbyO2cP4Jo9SvVih66TNjBI/u/obc/Z+Lms9uz6IIAd iCqnvkAkHZVHNYqousZs7Sbr+9OnLcwm+yjcfrjGn6Wm+PC/tqsK8QOfqv20Aou46ZXr LIOPhiO5vzOMV94Voh1+NSL/gk8Sqgk+88GRCiCUNNfJW+3e9+cctINtHUOTPYiJgAFs yAKg== X-Gm-Message-State: AOAM531sUraYJD29otgCYYvjscFGwqZcBbZIhSOCpAHTd8UL7u/uESHz HttrvMbhMc+QyDbSwTAf2KXNurp1azRZCDCOzh7y2lKsXxmgI8t9dFihkWjoIW6xZy85GBWM4aJ AgDdnKOBI9GMa6B3Ht29KOj3I50nC9d6EXazqixzzkNZ0beyF76Pr/7cJ0wxOAkiQ7Nu2/fDpMI 4rQ7/lB5eijLI4PnfNOaLLmWpdqWpRynJef+Qaa2vl3tFQftCi7UXXo6IERQ== X-Google-Smtp-Source: ABdhPJxca0Bkl7oNu/sIXtc3L6fqlJTYss07MnqjTqpfzyObiA3nqHGU8uColzGuASNy+9LpniE5K7Hkh9749rEy3hk= X-Received: by 2002:a17:903:1cc:b029:de:98bb:d46d with SMTP id e12-20020a17090301ccb02900de98bbd46dmr15194175plh.54.1613393819214; Mon, 15 Feb 2021 04:56:59 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Pradip Parkale Date: Mon, 15 Feb 2021 18:26:47 +0530 Message-ID: Subject: Re: [pgAdmin][RM6153]: Add publication and subscription support in Schema Diff. To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000007a615705bb5f85f1" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000007a615705bb5f85f1 Content-Type: multipart/alternative; boundary="0000000000007a615405bb5f85ef" --0000000000007a615405bb5f85ef Content-Type: text/plain; charset="UTF-8" Hi Akshay, Please find the attached patch for API failure. On Mon, Feb 15, 2021 at 4:08 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Mon, Feb 8, 2021 at 3:01 PM Pradip Parkale < > pradip.parkale@enterprisedb.com> wrote: > >> Hi Akshay, >> >> Please find the updated patch. >> >> On Thu, Feb 4, 2021 at 11:54 AM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Pradip >>> >>> I haven't started reviewing your patch but seems you haven't written >>> test cases for schema diff. Please add and then submit the patch again. >>> >>> On Wed, Feb 3, 2021 at 9:51 PM Pradip Parkale < >>> pradip.parkale@enterprisedb.com> wrote: >>> >>>> Hi Hackers, >>>> >>>> Please find the attached patch for publication and subscription support >>>> in Schema Diff. >>>> >>>> Also, added the dependencies for publication and subscription. >>>> >>>> -- >>>> Thanks & Regards, >>>> Pradip Parkale >>>> Software Engineer | EnterpriseDB Corporation >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Principal Software Architect* >>> *EDB Postgres * >>> >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks & Regards, >> Pradip Parkale >> Software Engineer | EnterpriseDB Corporation >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation --0000000000007a615405bb5f85ef Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Akshay,
Please find the attached patch for API fail= ure.

On Mon, Feb 15, 2021 at 4:08 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrot= e:
Thanks, patch applied.
<= br>
On Mon,= Feb 8, 2021 at 3:01 PM Pradip Parkale <pradip.parkale@enterprisedb.com>= ; wrote:
Hi Akshay,

Please find the updated patch.

On Thu, Feb 4, 2021 at 11:54 AM = Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi=C2=A0Pradip

I haven't start= ed reviewing your patch but seems you haven't written test cases for sc= hema diff. Please add and then submit the patch again.

On Wed, Feb 3, = 2021 at 9:51 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:=
Hi Hackers,

= Please find the attached patch for publication and subscription support in = Schema Diff.

Also, added the dependencies for publ= ication and subscription.

--
Thanks & Rega= rds,
Pradip Parkale
Software En= gineer | EnterpriseDB Corporation


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks & Regards,
=
Pradip Parkale
Software Engineer |= EnterpriseDB Corporation


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks & Regards,
Pradip Park= ale
Software Engineer | EnterpriseDB Corporation
--0000000000007a615405bb5f85ef-- --0000000000007a615705bb5f85f1 Content-Type: application/octet-stream; name="API_failure.patch" Content-Disposition: attachment; filename="API_failure.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kl6l056r0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL2Jyb3dzZXIvc2VydmVyX2dyb3Vwcy9zZXJ2ZXJzL2Rh dGFiYXNlcy9zdWJzY3JpcHRpb25zL3RlbXBsYXRlcy9zdWJzY3JpcHRpb25zL3NxbC9kZWZhdWx0 L2RlcGVuZGVuY2llcy5zcWwgYi93ZWIvcGdhZG1pbi9icm93c2VyL3NlcnZlcl9ncm91cHMvc2Vy dmVycy9kYXRhYmFzZXMvc3Vic2NyaXB0aW9ucy90ZW1wbGF0ZXMvc3Vic2NyaXB0aW9ucy9zcWwv ZGVmYXVsdC9kZXBlbmRlbmNpZXMuc3FsCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMC4uYTcxZjBjZDI1Ci0tLSAvZGV2L251bGwKKysrIGIvd2ViL3BnYWRtaW4vYnJvd3Nlci9z ZXJ2ZXJfZ3JvdXBzL3NlcnZlcnMvZGF0YWJhc2VzL3N1YnNjcmlwdGlvbnMvdGVtcGxhdGVzL3N1 YnNjcmlwdGlvbnMvc3FsL2RlZmF1bHQvZGVwZW5kZW5jaWVzLnNxbApAQCAtMCwwICsxLDIgQEAK K1NFTEVDVCBzdWJwdWJsaWNhdGlvbnMgQVMgcHViIEZST00gcGdfc3Vic2NyaXB0aW9uCitXSEVS RSBzdWJuYW1lID0gJ3t7c3VibmFtZX19JzsKZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xz L3NjaGVtYV9kaWZmL3Rlc3RzL3BnLzEyX3BsdXMvc291cmNlLnNxbCBiL3dlYi9wZ2FkbWluL3Rv b2xzL3NjaGVtYV9kaWZmL3Rlc3RzL3BnLzEyX3BsdXMvc291cmNlLnNxbAppbmRleCBkMTc1ZGU2 YWQuLjlmMWM5OTNmZSAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMvc2NoZW1hX2RpZmYv dGVzdHMvcGcvMTJfcGx1cy9zb3VyY2Uuc3FsCisrKyBiL3dlYi9wZ2FkbWluL3Rvb2xzL3NjaGVt YV9kaWZmL3Rlc3RzL3BnLzEyX3BsdXMvc291cmNlLnNxbApAQCAtMTEzOCw5ICsxMTM4LDYgQEAg Q1JFQVRFIFBVQkxJQ0FUSU9OIHdpdGhfb25lX3RhYmxlX2luX3RhcmdldAogICAgIEZPUiBUQUJM RSB0ZXN0X3NjaGVtYV9kaWZmLnRhYmxlX2Zvcl9wdWJsaWNhdGlvbl9pbl90YXJnZXQKICAgICBX SVRIIChwdWJsaXNoID0gJ2luc2VydCwgZGVsZXRlJyk7CiAKLUFMVEVSIFBVQkxJQ0FUSU9OIHdp dGhfb25lX3RhYmxlX2luX3RhcmdldAotICAgIE9XTkVSIFRPIG1hbmFnZXJzOwotCiBBTFRFUiBQ VUJMSUNBVElPTiB3aXRoX29uZV90YWJsZV9pbl90YXJnZXQKICAgICBSRU5BTUUgVE8gd2l0aF9v bmVfdGFibGVfaW5fdGFyZ2V0X2FsdGVyOwogCmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi90b29s cy9zY2hlbWFfZGlmZi90ZXN0cy9wZy8xMl9wbHVzL3RhcmdldC5zcWwgYi93ZWIvcGdhZG1pbi90 b29scy9zY2hlbWFfZGlmZi90ZXN0cy9wZy8xMl9wbHVzL3RhcmdldC5zcWwKaW5kZXggOTU1NGE1 ZmFkLi40MGI5YjRhN2YgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NjaGVtYV9kaWZm L3Rlc3RzL3BnLzEyX3BsdXMvdGFyZ2V0LnNxbAorKysgYi93ZWIvcGdhZG1pbi90b29scy9zY2hl bWFfZGlmZi90ZXN0cy9wZy8xMl9wbHVzL3RhcmdldC5zcWwKQEAgLTEwNjksOSArMTA2OSw2IEBA IENSRUFURSBQVUJMSUNBVElPTiB3aXRoX29uZV90YWJsZV9pbl90YXJnZXQKICAgICBGT1IgVEFC TEUgdGVzdF9zY2hlbWFfZGlmZi50YWJsZV9mb3JfcHVibGljYXRpb25faW5fdGFyZ2V0CiAgICAg V0lUSCAocHVibGlzaCA9ICdpbnNlcnQsIGRlbGV0ZScpOwogCi1BTFRFUiBQVUJMSUNBVElPTiB3 aXRoX29uZV90YWJsZV9pbl90YXJnZXQKLSAgICBPV05FUiBUTyBtYW5hZ2VyczsKLQogQUxURVIg UFVCTElDQVRJT04gd2l0aF9vbmVfdGFibGVfaW5fdGFyZ2V0CiAgICAgUkVOQU1FIFRPIHdpdGhf b25lX3RhYmxlX2luX3RhcmdldF9hbHRlcjsKIAo= --0000000000007a615705bb5f85f1--