public inbox for [email protected]
help / color / mirror / Atom feedFrom: Pradip Parkale <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM5843] [SQL] - Some 'options' values for function not shown in sql
Date: Thu, 1 Oct 2020 14:25:31 +0530
Message-ID: <CAJ9T6SttQZ_OrGsmOueUz_Ub51BSUafy8etHJ5mAAh1jgEOmeg@mail.gmail.com> (raw)
In-Reply-To: <CAJ9T6SvJ1z95nGg+_cnVOmjgZ_6PGVXeuEtfyvPp=6nAb9E_tw@mail.gmail.com>
References: <CAJ9T6Ss_8u-uLrgFxe6xC36a3gLGS2u2mnsG-cjYH1FScrLLvg@mail.gmail.com>
<CANxoLDef3K1D-y_E4O7W=rgT-4+N9-k-WceHaBncQdL_ERSYeA@mail.gmail.com>
<CANxoLDe4WeNos2AfTgfhXH1fdEdU1gNvCJHsS8OU3wywgmZuUQ@mail.gmail.com>
<CAJ9T6SvJ1z95nGg+_cnVOmjgZ_6PGVXeuEtfyvPp=6nAb9E_tw@mail.gmail.com>
Hi Akshay,
Please find the attached patch to allow the user to modify the option
settings of the procedure. This issue was only for PPAS 11 and PPAS 12.
On Wed, Sep 23, 2020 at 11:30 PM Pradip Parkale <
[email protected]> wrote:
> Hi Akshay,
>
> Please find the small patch for the ' Parallel Unsafe' option is missing
> in SQL. It was missing in first patch for PG96 and PG10.
>
>
> On Wed, Sep 23, 2020 at 1:25 PM Akshay Joshi <
> [email protected]> wrote:
>
>> Thanks, patch applied. It's a small fix so I have fixed it.
>>
>> On Wed, Sep 23, 2020 at 12:14 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Hi Pradip
>>>
>>> RESQL tests are failing on EPAS 9.5, 9.6, and 10. Please fix and resend
>>> the patch.
>>>
>>> On Tue, Sep 22, 2020 at 6:41 PM Pradip Parkale <
>>> [email protected]> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> The 'Unsafe' parallel option was not visible in the SQL for function
>>>> and procedure. Attached is the patch to fix this issue.
>>>>
>>>> --
>>>> Thanks & Regards,
>>>> Pradip Parkale
>>>> Software Engineer | EnterpriseDB Corporation
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Sr. Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Sr. Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks & Regards,
> Pradip Parkale
> Software Engineer | EnterpriseDB Corporation
>
--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Attachments:
[application/octet-stream] RM5843_v3.patch (1.3K, 3-RM5843_v3.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/procedures/ppas/sql/11_plus/update.sql b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/procedures/ppas/sql/11_plus/update.sql
index b8df9b933..6e711724d 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/procedures/ppas/sql/11_plus/update.sql
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/templates/procedures/ppas/sql/11_plus/update.sql
@@ -22,8 +22,9 @@ CREATE OR REPLACE PROCEDURE {{ conn|qtIdent(o_data.pronamespace, name) }}({% if
LANGUAGE {{ data.lanname|qtLiteral }} {% else %}
LANGUAGE {{ o_data.lanname|qtLiteral }}
{% endif %}
+{{ data.provolatile }}
{% if ('prosecdef' in data and data.prosecdef) or ('prosecdef' not in data and o_data.prosecdef) %}SECURITY DEFINER{% endif %}
-{% if data.lanname == 'edbspl' %}
+{% if data.lanname == 'edbspl' or (o_data.lanname == 'edbspl' and not 'lanname' in data ) %}
{% if ('proleakproof' in data and data.proleakproof) or ('proleakproof' not in data and o_data.proleakproof) %} LEAKPROOF{% else %} NOT LEAKPROOF{% endif %}
{% if ('proisstrict' in data and data.proisstrict) or ('proisstrict' not in data and o_data.proisstrict) %} STRICT{% endif %}
view thread (8+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM5843] [SQL] - Some 'options' values for function not shown in sql
In-Reply-To: <CAJ9T6SttQZ_OrGsmOueUz_Ub51BSUafy8etHJ5mAAh1jgEOmeg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox