Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0hQ4-00042q-H4 for pgadmin-hackers@arkaria.postgresql.org; Tue, 06 Jul 2021 09:31:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m0hQ3-00075c-FE for pgadmin-hackers@arkaria.postgresql.org; Tue, 06 Jul 2021 09:31:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0hQ2-00075T-T6 for pgadmin-hackers@lists.postgresql.org; Tue, 06 Jul 2021 09:31:07 +0000 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1m0hPw-0006ZG-64 for pgadmin-hackers@postgresql.org; Tue, 06 Jul 2021 09:31:05 +0000 Received: by mail-pj1-x1035.google.com with SMTP id n11so13199525pjo.1 for ; Tue, 06 Jul 2021 02:30:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5gUVFZFGhspqOiR8UPd7nCjW7yEb5EokrTqdk94VXvs=; b=Lum/9uExpRYpcImo8WcaITkiJCFf2sOjbwukfceDZqYej6jsAnCx/D+9aXjbybhc3P 6Dy3ajch0Fn7YZZYLUV8DKqhTqtGWMPy6xS39d7sydSRNkS6CXbKvRI65mo1rXMUIuwe 1eZeQLwMwk7CtIRCtgybFrvOBAv508d+GX1yyQwL5IPr3kFP3wkimHgWMqexPiL4vItN xrGCyGkkQt60em9mwiiZRmQSEmRTdO5nrjGb2oT5GPPCq3ObgXp64XNY46BnXUJ9bn0I bPQEf+YpG9P+r2h5kYl5s04GdWVLswcl9CrC2W/sTTvKQoXAXyCoB8XNQxNp9E3F5VyQ 2SPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5gUVFZFGhspqOiR8UPd7nCjW7yEb5EokrTqdk94VXvs=; b=Xy5f866JX9Rlw2wLEyphy7F8RBZojUFotwgSmKf5xCEiZUxiZj2Z8GLhZEnwtP5G1x zbCj8KLvRtlLIAz0pL6yKRjuyK+IIINw0UF3hY8ViszfQnQ+Q4g3XSIauzKryGrutUGi d+E01aAwXW0ozcOsKt/pSh8Cib/rH2cLoYpN4gYemp9exV3kVyONTcndxK4L9QK4/9lg DF7y09VOEyDIryzM0N0l7FujdQgt82CiscIbr8TX3WTGX2LM6N4tjEjxoojuugSwLII9 o56W7IVLvzTuWDxwHvizuG1cyqUEeNV0jXkOk4xSvmrN+ZV0+rRk6oU92dQFK3MHgzQk USQQ== X-Gm-Message-State: AOAM5300BNJnwF7t6n71GhwXe6sYfXLV8417GWCvi54vPJpc+1XmN0TE kimFxjgHAbe/54UP1+1upmhXLkS80iKFLbwIQ74RF5thnLDntZeuPqIRqbetI3LgYjC2KIXBmBt IqMth+Gt6BVFuTAsvkamjX768qJnEXGJladSxujMeLKZrBcSKGT3JTjt6s2o+UvKBkUW2DI/bWP V5ZN2j1hvYMWj/3oFDmh/O7yA6O3guDoQc5qrl5L4OeDHCUo4l7ElurwL7og== X-Google-Smtp-Source: ABdhPJx7vJxivB/jjDaQ0RjI6yIe0W2UgagiDgyFX8CxdhP4xL0G/Qbid1FE3v/weOu6CdqLueo3q44fbU5ZLa+STXo= X-Received: by 2002:a17:902:b285:b029:128:c9ad:5045 with SMTP id u5-20020a170902b285b0290128c9ad5045mr16339901plr.13.1625563858776; Tue, 06 Jul 2021 02:30:58 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Pradip Parkale Date: Tue, 6 Jul 2021 15:00:47 +0530 Message-ID: Subject: Re: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel. To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000005cf6a205c6711436" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --0000000000005cf6a205c6711436 Content-Type: multipart/alternative; boundary="0000000000005cf6a005c6711434" --0000000000005cf6a005c6711434 Content-Type: text/plain; charset="UTF-8" Hi Akshay, Please find the updated patch. On Fri, Jun 25, 2021 at 11:40 AM Akshay Joshi wrote: > Thanks, the patch applied. > > On Thu, Jun 24, 2021 at 9:16 PM Pradip Parkale < > pradip.parkale@enterprisedb.com> wrote: > >> Hi Akshay, >> Please find the updated patch. I have moved the function into the utility >> file now. >> >> On Thu, Jun 24, 2021 at 7:56 PM Akshay Joshi < >> akshay.joshi@enterprisedb.com> wrote: >> >>> Hi Pradip >>> >>> I have seen that we have duplicated code for resize_the_queryTool, >>> resize_the_erdtool, resize_the_psql, and in debugger_ui.js file. I >>> would suggest making a common function somewhere in the utils and call that >>> function. In the future, if we need to change the code we will have to >>> change it in four different places. >>> >>> Please resend the patch after fixing the above issue. >>> >>> On Thu, Jun 24, 2021 at 7:00 PM Pradip Parkale < >>> pradip.parkale@enterprisedb.com> wrote: >>> >>>> Hi Akshay, >>>> >>>> Please find attached for debugger and ERD tool which was missing in >>>> my previous patch. >>>> >>>> On Wed, Jun 23, 2021 at 11:50 AM Akshay Joshi < >>>> akshay.joshi@enterprisedb.com> wrote: >>>> >>>>> Thanks, the patch applied. >>>>> >>>>> On Wed, Jun 16, 2021 at 11:29 PM Pradip Parkale < >>>>> pradip.parkale@enterprisedb.com> wrote: >>>>> >>>>>> Hi Hackers, >>>>>> >>>>>> Please find the attached patch for #6398.Detaching query editor panel >>>>>> gives a blank white panel. >>>>>> >>>>>> >>>>>> -- >>>>>> Thanks & Regards, >>>>>> Pradip Parkale >>>>>> Software Engineer | EnterpriseDB Corporation >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Thanks & Regards* >>>>> *Akshay Joshi* >>>>> *pgAdmin Hacker | Principal Software Architect* >>>>> *EDB Postgres * >>>>> >>>>> *Mobile: +91 976-788-8246* >>>>> >>>> >>>> >>>> -- >>>> Thanks & Regards, >>>> Pradip Parkale >>>> Software Engineer | EnterpriseDB Corporation >>>> >>> >>> >>> -- >>> *Thanks & Regards* >>> *Akshay Joshi* >>> *pgAdmin Hacker | Principal Software Architect* >>> *EDB Postgres * >>> >>> *Mobile: +91 976-788-8246* >>> >> >> >> -- >> Thanks & Regards, >> Pradip Parkale >> Software Engineer | EnterpriseDB Corporation >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres * > > *Mobile: +91 976-788-8246* > -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation --0000000000005cf6a005c6711434 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Akshay,
Please find the updated patch.=C2=A0
<= /div>
O= n Fri, Jun 25, 2021 at 11:40 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, the patch applied.
On Thu, J= un 24, 2021 at 9:16 PM Pradip Parkale <pradip.parkale@enterprisedb.com>= wrote:
Hi Akshay,
Please fi= nd the updated patch. I have moved the function into the utility file now.<= /div>

On Thu, Jun 24, 2021 at 7:56 PM Akshay Joshi <akshay.joshi@enterprisedb.com= > wrote:
Hi=C2=A0Pradip
I have seen that we have duplicated=C2=A0code for=C2=A0resize_the_queryTool,=C2=A0resize_the_erdtool,=C2=A0resize_the_psql, and in debugger_ui.js file.=C2=A0I wou= ld suggest making a common function somewhere in the utils and call that fu= nction. In the future, if we need to change the code we will have to change= it in four different places.

Please resend th= e patch after fixing the above issue.

On Thu, Jun 24, 2021 at 7:00 PM = Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Akshay,

Please find=C2=A0= attached=C2=A0for debugger and ERD tool which was missing in my=C2=A0previo= us patch.

On Wed, Jun 23, 2021 at 11:50 AM Akshay Joshi <akshay.joshi@en= terprisedb.com> wrote:
Th= anks, the patch applied.

On Wed, Jun 16, 2021 at 11:29 PM Pradip Parkale <= ;pradi= p.parkale@enterprisedb.com> wrote:
Hi Hackers,

Please find the a= ttached patch for #6398.Detaching query editor panel gives a blank white pa= nel.


--
Thanks & Regards,
Pradip Parkale
Software Engineer | Ent= erpriseDB Corporation


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks & Regards,
=
Pradip Parkale
Software Engineer |= EnterpriseDB Corporation


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks & Regards,
=
Pradip Parkale
Software Engineer |= EnterpriseDB Corporation


--
Thank= s & Regards
Akshay Joshi
pgAdmin Hacker | Principal Softw= are Architect
EDB Po= stgres
Mobile: +91 976-788-8246



--
Thanks & Regards,
Pradip Park= ale
Software Engineer | EnterpriseDB Corporation
--0000000000005cf6a005c6711434-- --0000000000005cf6a205c6711436 Content-Type: application/octet-stream; name="RM6398_v4.patch" Content-Disposition: attachment; filename="RM6398_v4.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kqruqlak0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL2RlYnVnZ2VyL3N0YXRpYy9qcy9kZWJ1Z2dl ci5qcyBiL3dlYi9wZ2FkbWluL3Rvb2xzL2RlYnVnZ2VyL3N0YXRpYy9qcy9kZWJ1Z2dlci5qcwpp bmRleCAxM2ZmMWYzYWYuLjY2MzJiODNjMSAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMv ZGVidWdnZXIvc3RhdGljL2pzL2RlYnVnZ2VyLmpzCisrKyBiL3dlYi9wZ2FkbWluL3Rvb2xzL2Rl YnVnZ2VyL3N0YXRpYy9qcy9kZWJ1Z2dlci5qcwpAQCAtNjE0LDYgKzYxNCw3IEBAIGRlZmluZShb CiAgICAgICAgICAgICAgICAgICAgICAgJ2ZybV9kZWJ1Z2dlcicsIHdjRG9ja2VyLkRPQ0suU1RB Q0tFRCwgZGFzaGJvYXJkUGFuZWxbMF0KICAgICAgICAgICAgICAgICAgICAgKSwKICAgICAgICAg ICAgICAgICAgICAgZGJfbGFiZWwgPSBuZXdUcmVlSW5mby5kYXRhYmFzZS5sYWJlbDsKKyAgICAg ICAgICAgICAgICAgIHBnYWRtaW5VdGlscy5yZWdpc3RlckRldGFjaEV2ZW50KHBhbmVsKTsKIAog ICAgICAgICAgICAgICAgICAgaWYoZGF0YSAmJiBkYXRhLmRhdGFfb2JqICYmIGRhdGEuZGF0YV9v YmouZGJfbmFtZSAhPSBuZXdUcmVlSW5mby5kYXRhYmFzZS5sYWJlbCkgewogICAgICAgICAgICAg ICAgICAgICBkYl9sYWJlbCA9IGRhdGEuZGF0YV9vYmouZGJfbmFtZTsKZGlmZiAtLWdpdCBhL3dl Yi9wZ2FkbWluL3Rvb2xzL3NjaGVtYV9kaWZmL3N0YXRpYy9qcy9zY2hlbWFfZGlmZi5qcyBiL3dl Yi9wZ2FkbWluL3Rvb2xzL3NjaGVtYV9kaWZmL3N0YXRpYy9qcy9zY2hlbWFfZGlmZi5qcwppbmRl eCA0ZjEzMmMwNjkuLjJjMjU3Yzg3ZiAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMvc2No ZW1hX2RpZmYvc3RhdGljL2pzL3NjaGVtYV9kaWZmLmpzCisrKyBiL3dlYi9wZ2FkbWluL3Rvb2xz L3NjaGVtYV9kaWZmL3N0YXRpYy9qcy9zY2hlbWFfZGlmZi5qcwpAQCAtOSw5ICs5LDkgQEAKIAog ZGVmaW5lKCdwZ2FkbWluLnNjaGVtYWRpZmYnLCBbCiAgICdzb3VyY2VzL2dldHRleHQnLCAnc291 cmNlcy91cmxfZm9yJywgJ2pxdWVyeScsICd1bmRlcnNjb3JlJywKLSAgJ3NvdXJjZXMvcGdhZG1p bicsICdzb3VyY2VzL2NzcmYnLCAncGdhZG1pbi5hbGVydGlmeWpzJywgJ3BnYWRtaW4uYnJvd3Nl ci5ub2RlJywKKyAgJ3NvdXJjZXMvcGdhZG1pbicsICdzb3VyY2VzL2NzcmYnLCAncGdhZG1pbi5h bGVydGlmeWpzJywgJ3NvdXJjZXMvdXRpbHMnLCAncGdhZG1pbi5icm93c2VyLm5vZGUnLAogXSwg ZnVuY3Rpb24oCi0gIGdldHRleHQsIHVybF9mb3IsICQsIF8sIHBnQWRtaW4sIGNzcmZUb2tlbiwg QWxlcnRpZnksCisgIGdldHRleHQsIHVybF9mb3IsICQsIF8sIHBnQWRtaW4sIGNzcmZUb2tlbiwg QWxlcnRpZnksIGNvbW1vblV0aWxzLAogKSB7CiAKICAgdmFyIHdjRG9ja2VyID0gd2luZG93Lndj RG9ja2VyLApAQCAtMTE5LDYgKzExOSw4IEBAIGRlZmluZSgncGdhZG1pbi5zY2hlbWFkaWZmJywg WwogICAgICAgICB2YXIgcHJvcGVydGllc1BhbmVsID0gcGdCcm93c2VyLmRvY2tlci5maW5kUGFu ZWxzKCdwcm9wZXJ0aWVzJyksCiAgICAgICAgICAgc2NoZW1hRGlmZlBhbmVsID0gcGdCcm93c2Vy LmRvY2tlci5hZGRQYW5lbCgnZnJtX3NjaGVtYWRpZmYnLCB3Y0RvY2tlci5ET0NLLlNUQUNLRUQs IHByb3BlcnRpZXNQYW5lbFswXSk7CiAKKyAgICAgICAgY29tbW9uVXRpbHMucmVnaXN0ZXJEZXRh Y2hFdmVudChzY2hlbWFEaWZmUGFuZWwpOworCiAgICAgICAgIC8vIFJlbmFtZSBzY2hlbWEgZGlm ZiB0YWIKICAgICAgICAgc2NoZW1hRGlmZlBhbmVsLm9uKHdjRG9ja2VyLkVWRU5ULlJFTkFNRSwg ZnVuY3Rpb24ocGFuZWxfZGF0YSkgewogICAgICAgICAgIEFsZXJ0aWZ5LnByb21wdCgnJywgcGFu ZWxfZGF0YS4kdGl0bGVUZXh0WzBdLnRleHRDb250ZW50LAo= --0000000000005cf6a205c6711436--