Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j4Ncc-0000sM-Vr for pgadmin-hackers@arkaria.postgresql.org; Wed, 19 Feb 2020 11:34:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j4Ncb-0006BH-PL for pgadmin-hackers@arkaria.postgresql.org; Wed, 19 Feb 2020 11:34:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j4Ncb-0006B9-D2 for pgadmin-hackers@lists.postgresql.org; Wed, 19 Feb 2020 11:34:29 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1j4NcY-0002LD-Dv for pgadmin-hackers@postgresql.org; Wed, 19 Feb 2020 11:34:27 +0000 Received: by mail-wm1-x341.google.com with SMTP id p9so250172wmc.2 for ; Wed, 19 Feb 2020 03:34:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zNtEHJTpspEnnJRTkTMFTHbFLxgOTUzOfqBeXMwo0GM=; b=VFqQgGaTjkbWD5xd5EeR/0/GF9jV67FnP1WBU7VQAqGY7TwhXRCdNts2EzCgOTG6mH 7mOt+ZJXDO8PeFqLRaKosZg4Q+/jegBEoqaR/K0QltIgh8cYqfO0tEVGBtbyJ1Xf/Cu9 DeC3VritWEuDnkMGvh0JbKgs+Bgt/3ywnzGjr0nwths4nh5tzbZDSLqoOR6ZrI/sULcx TgVigqFvfTr/OimMQdv8AMpGg7Z4cQSpKR0WdtDUjdztUPw/W8di4SnVXSbRLTldfIvY z76jZj0xbbxm4l2ZBZyFsGMk10Yp7PVjPCs265zTPXG8KwpcPgfeOhqDC4sNQtDk3WCC deRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zNtEHJTpspEnnJRTkTMFTHbFLxgOTUzOfqBeXMwo0GM=; b=S4EX2IKt/8EPqxtq+j7nQwNKqQekh/KHqK06gMyxcRk0P3mR0tVDSWP0losz+wn42t YWU6mQ80iRycK5Pe5fj6nkj3n9VUHjOVeFArlfntf8Nryqs2uxk9USO3MGX4/0mCuH+t BsxJfP6kuf/hv6Y4N3VFzyXCquYSomqhGawmLYcvssXrgqaz+OThYFFgNAJ6pNfp2ZDj R9zF+3cfW7+HmZKg6EW30czhc/6gpt1ZiwvnNAKbsJa9mpHN6PgIIhfDbjtArg5rUDis FOZVymhg0EmmTJMOZapp18oBPd6zFDaSC5tJccXnvxiaG4ueNlIH1j7kdJ/RewJT52pW kTTg== X-Gm-Message-State: APjAAAXLcXY72EG9MwAILjd6qdZc/XekqDt3/4kBVGsS3ikNXULhTP59 4l9chKmL6CATfTaqOUSis9W6VL/6n2Y3kdlIg2kwXprB+1PBGl2DjawoBnRvBB64SOalPzFKpXb kKR0wuoFb2tvTvzD8zh09fWyoyqYHv7/BA3ae64CZjLZNmmVQBupivaToEsPAeSN9BsK4rh0+VB oPyDMRcpg0pfpVso0djx+zpueNQR0lJ0MDSusEWX5enqma/3CQlWo= X-Google-Smtp-Source: APXvYqyC240bG8Y08m0QUKSb7vXOhAWmEQWRK/BSJRJnOGjMaJONsGjcj0k3YASr7vVnk09ZGEYPz8MpsfTmFd96A0c= X-Received: by 2002:a1c:7317:: with SMTP id d23mr9822806wmb.165.1582112064883; Wed, 19 Feb 2020 03:34:24 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Pradip Parkale Date: Wed, 19 Feb 2020 17:04:13 +0530 Message-ID: Subject: Re: [pgAdmin][RM5154] [Accessibility] : Alertify To: Ashesh Vashi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000009fb5ba059eec2bf3" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000009fb5ba059eec2bf3 Content-Type: multipart/alternative; boundary="0000000000009fb5b8059eec2bf1" --0000000000009fb5b8059eec2bf1 Content-Type: text/plain; charset="UTF-8" Please find the attached patch. On Wed, Feb 19, 2020 at 5:02 PM Ashesh Vashi wrote: > Forgot to attach the patch? > > On Wed, 19 Feb 2020 at 16:58, Pradip Parkale < > pradip.parkale@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is a patch for accessibility issue related Alertifyjs. >> >> 1. Added hidden label to satisfy accessibility. >> 2. Added label with sr-only class. >> 3. Added tabindex to move the mouse control to the maximize button >> using the tab key. >> >> >> Please note that this patch also includes the fix for the >> RM-5143 Accessibility issue to maximize the panel for backup and restore >> windows and all other places. >> -- >> Thanks & Regards, >> Pradip Parkale >> QMG, EnterpriseDB Corporation >> > -- > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation --0000000000009fb5b8059eec2bf1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Please find the attached patch.

On Wed, Feb 19, 2020 at 5:0= 2 PM Ashesh Vashi <ashe= sh.vashi@enterprisedb.com> wrote:
Forgot to attach the patch?

On Wed, 19 Feb 2020 = at 16:58, Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Atta= ched=C2=A0is a patch=C2=A0for accessibility issue related Alertifyjs.
=
  1. Added hidden label to satisfy accessibility.
  2. Added= label with sr-only class.
  3. Added tabindex to move the mouse con= trol to the maximize button using the tab key.

=
Please note that this patch also includes the fix for the RM-514= 3=C2=A0Accessibility issue to maximize the panel for backup and restore win= dows and all other places.
--
Thanks & Regards,
Pradip Parkale
QMG, EnterpriseDB Corp= oration
--

--

<= span style=3D"font-family:"courier new",monospace">Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi



--
Thanks & Regards,
Pradip Park= ale
QMG, EnterpriseDB Corporation
--0000000000009fb5b8059eec2bf1-- --0000000000009fb5ba059eec2bf3 Content-Type: application/octet-stream; name="RM5154.patch" Content-Disposition: attachment; filename="RM5154.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k6t8metp0 ZGlmZiAtLWdpdCBhL3dlYi9wYWNrYWdlLmpzb24gYi93ZWIvcGFja2FnZS5qc29uCmluZGV4IGFj ZmNiMmVmYS4uODQxNmM1ZjIyIDEwMDY0NAotLS0gYS93ZWIvcGFja2FnZS5qc29uCisrKyBiL3dl Yi9wYWNrYWdlLmpzb24KQEAgLTUxLDcgKzUxLDcgQEAKICAgfSwKICAgImRlcGVuZGVuY2llcyI6 IHsKICAgICAiYWNpdHJlZSI6ICJnaXQraHR0cHM6Ly9naXRodWIuY29tL2ltc3VyaW5kZXI5MC9q cXVlcnktYWNpVHJlZS5naXQjcmMuNyIsCi0gICAgImFsZXJ0aWZ5anMiOiAiMS43LjEiLAorICAg ICJhbGVydGlmeWpzIjogImdpdCtodHRwczovL2dpdGh1Yi5jb20vcHJhZGlwcGFya2FsZTI2OS9B bGVydGlmeUpTLmdpdCNFREItTUFTVEVSIiwKICAgICAiYXhpb3MiOiAiXjAuMTguMSIsCiAgICAg ImJhYmVsLXBsdWdpbi10cmFuc2Zvcm0tZXMyMDE1LW1vZHVsZXMtYW1kIjogIl42LjI0LjEiLAog ICAgICJiYWJlbC1wcmVzZXQtZXMyMDE1LXdpdGhvdXQtc3RyaWN0IjogIn4wLjAuNCIsCmRpZmYg LS1naXQgYS93ZWIvcGdhZG1pbi9zdGF0aWMvanMvYWxlcnRpZnkvZGlhbG9nX3dyYXBwZXIuanMg Yi93ZWIvcGdhZG1pbi9zdGF0aWMvanMvYWxlcnRpZnkvZGlhbG9nX3dyYXBwZXIuanMKaW5kZXgg ODMxODZlNzEwLi44NzZkYWZhNzcgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9h bGVydGlmeS9kaWFsb2dfd3JhcHBlci5qcworKysgYi93ZWIvcGdhZG1pbi9zdGF0aWMvanMvYWxl cnRpZnkvZGlhbG9nX3dyYXBwZXIuanMKQEAgLTY0LDcgKzY0LDcgQEAgZXhwb3J0IGNsYXNzIERp YWxvZ1dyYXBwZXIgewogICAgICQoYWxlcnRpZnlEaWFsb2cuZWxlbWVudHMuZm9vdGVyKS5vbign a2V5ZG93bicsICdidXR0b24nLCBmdW5jdGlvbihldmVudCkgewogICAgICAgaWYgKGV2ZW50Lmtl eUNvZGUgPT0gOSAmJiAkKHRoaXMpLm5leHRBbGwoJ2J1dHRvbjpub3QoW2Rpc2FibGVkXSknKS5s ZW5ndGggPT0gMCkgewogICAgICAgICAvLyBzZXQgZm9jdXMgYmFjayB0byBmaXJzdCBlZGl0YWJs ZSBpbnB1dCBlbGVtZW50IG9mIGN1cnJlbnQgYWN0aXZlIHRhYiBvbmNlIHdlIGN5Y2xlIHRocm91 Z2ggYWxsIGVuYWJsZWQgYnV0dG9ucy4KLSAgICAgICAgY29tbW9uVXRpbHMuZmluZEFuZFNldEZv Y3VzKCQoYWxlcnRpZnlEaWFsb2cuZWxlbWVudHMuYm9keSkuZmluZCgnLnRhYi1jb250ZW50IGRp di5hY3RpdmUnKSk7CisgICAgICAgICQoYWxlcnRpZnlEaWFsb2cuZWxlbWVudHMuZGlhbG9nKS5m aW5kKCdbdGFiaW5kZXhdOm5vdChbdGFiaW5kZXg9Ii0xIl0nKS5maXJzdCgpLmZvY3VzKCk7CiAg ICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgIH0KICAgICB9KTsKZGlmZiAtLWdpdCBhL3dlYi95 YXJuLmxvY2sgYi93ZWIveWFybi5sb2NrCmluZGV4IDI2MjcyNjY4Yi4uNjJhZjI0OTI4IDEwMDY0 NAotLS0gYS93ZWIveWFybi5sb2NrCisrKyBiL3dlYi95YXJuLmxvY2sKQEAgLTkxMCwxMCArOTEw LDkgQEAgYWp2QF42LjEuMCwgYWp2QF42LjEwLjIsIGFqdkBeNi45LjE6CiAgICAganNvbi1zY2hl bWEtdHJhdmVyc2UgIl4wLjQuMSIKICAgICB1cmktanMgIl40LjIuMiIKIAotYWxlcnRpZnlqc0Ax LjcuMToKKyJhbGVydGlmeWpzQGdpdCtodHRwczovL2dpdGh1Yi5jb20vcHJhZGlwcGFya2FsZTI2 OS9BbGVydGlmeUpTLmdpdCNFREItTUFTVEVSIjoKICAgdmVyc2lvbiAiMS43LjEiCi0gIHJlc29s dmVkICJodHRwczovL3JlZ2lzdHJ5Lnlhcm5wa2cuY29tL2FsZXJ0aWZ5anMvLS9hbGVydGlmeWpz LTEuNy4xLnRneiMzYzdiOGFjNjc2MDlhZWE3MzdmZThlMDZkN2ZhYzg4NWNlMThiYThmIgotICBp bnRlZ3JpdHkgc2hhMS1QSHVLeG5ZSnJxYzMvbzRHMS9ySWhjNFl1bzg9CisgIHJlc29sdmVkICJn aXQraHR0cHM6Ly9naXRodWIuY29tL3ByYWRpcHBhcmthbGUyNjkvQWxlcnRpZnlKUy5naXQjMjE1 Mzc4ZTZjYjVhYWJhZDlhODU1ZDNhNWExZTRhZDcxMTFhNmU1ZSIKIAogYWxwaGFudW0tc29ydEBe MS4wLjA6CiAgIHZlcnNpb24gIjEuMC4yIgo= --0000000000009fb5ba059eec2bf3--