Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1j6X2o-0000Ng-PZ for pgadmin-hackers@arkaria.postgresql.org; Tue, 25 Feb 2020 10:02:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j6X2n-0004NG-Ax for pgadmin-hackers@arkaria.postgresql.org; Tue, 25 Feb 2020 10:02:25 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j6X2m-0004Mh-Nj for pgadmin-hackers@lists.postgresql.org; Tue, 25 Feb 2020 10:02:25 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1j6X2e-0001YJ-TH for pgadmin-hackers@postgresql.org; Tue, 25 Feb 2020 10:02:23 +0000 Received: by mail-wm1-x331.google.com with SMTP id c84so2457845wme.4 for ; Tue, 25 Feb 2020 02:02:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qvzd+og+AM+Ei9bhWwYj7piz90+yCKTTy/g//QSxDZI=; b=qvWFm16fyQnP8kDs4tWwXF3DLnO8wdduG4f/byZV5dZ636JOmUL29yUfyRLxg7qE4o j1TJDJdMJDjUsHki6fDBVkXjtB7R3+AUWqFyxH+w2BvhOdIj+b0fUD9JmPvmGYN7byFF AYeMrILWMmy5BHuDlFhS24YKecLFxvOSg6TEb9/KW8rb22H2F3iVT4ya1G3QDctViVYo yHMgJpCz4xmV/ExfIp1Mcnno0vbihoT4+X51Vitt71Fnm6Z5JwM50cBHPo7dbrZpTPn6 fcwwa2CTkv8IXLd8XXqaDvpLwUHF3zukSh3b6JPKUAu4+MC5Sm9Jyw+9+qOvREBAc08T x1xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qvzd+og+AM+Ei9bhWwYj7piz90+yCKTTy/g//QSxDZI=; b=olrr4XZU3DBuD3CHB5/D0WOPj0gq6mn8PyiUNtrvpqTuX1pH+eWRcC+myPIuRLfBYZ HCYqTzMvfr/svJqm23Fb8W4uHutf7649LGBSqeCN+sOcR148vXtAmK+dylU95iELRw4o GqUhhzakja9kbPx23r/29eCLlVqyHMgMshHL2xMRs0va4IUyJpajyiJHQneGkKV+VmtV DI51yuNerW2pbd5QIi966QgF5aUjW0O0MSbYbbFKNzmC8Jmar80Z7yeiCRnprZ3LZMyB TJ4AtwCi8XLy69Li7oHV6ZJx2It54e+QX3nQILIS1laZMCDTM90s99wH4r3Eo/wBN/wO EwHw== X-Gm-Message-State: APjAAAWY+dmiU8TBwscWjls9rQeqBYP2D7DifXQLBJNZZ6xsEt0Rxixb O0gJTS02z2UTbNLnYuc1WO8k4KSqM7WaJoGexVevHBIVv9lhBt0BsARCtLz1Hb01iOmxuUg6aeA u6VTT1gmATMMRFGBKz9vvqJTzKJYoJfcyvh5kEzMj0Gxn4tMOLpfBiPEIC7rjHZjNMa9CQwEyMb F8U0ZSiM54GjxP5gZfIA8520TZV+80FCnLwUh/6Myv40HV1fx8lI0= X-Google-Smtp-Source: APXvYqxjockd7zF2P7MWz+8KJvKYdAOvkPzoI2sttx/WvOalOm7k4yY9bgRT6bCyymS1rX1ACiLgzrvGRpuFoxvl22E= X-Received: by 2002:a1c:2089:: with SMTP id g131mr4150285wmg.63.1582624935376; Tue, 25 Feb 2020 02:02:15 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Pradip Parkale Date: Tue, 25 Feb 2020 15:32:03 +0530 Message-ID: Subject: Re: [pgAdmin][RM5154] [Accessibility] : Alertify To: Akshay Joshi , Aditya Toshniwal Cc: Ashesh Vashi , pgadmin-hackers Content-Type: multipart/mixed; boundary="00000000000016c24f059f63954e" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000016c24f059f63954e Content-Type: multipart/alternative; boundary="00000000000016c24c059f63954c" --00000000000016c24c059f63954c Content-Type: text/plain; charset="UTF-8" Hi Akshay/Aditya, Please find the updated patch. I have accommodated all the changes. On Mon, Feb 24, 2020 at 2:34 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Pradip, > > - > commonUtils.findAndSetFocus($(alertifyDialog.elements.body).find('.tab-content > div.active')); > + > $(alertifyDialog.elements.dialog).find('[tabindex]:not([tabindex="-1"]').first().focus(); > > Use the same common function with > commonUtils.findAndSetFocus(alertifyDialog.elements.dialog)). It will > handle the focus. > Fixed. > Also, make the required changes mentioned on the pull request - > https://github.com/EnterpriseDB/AlertifyJS/pull/1 > Fixed. > > > On Fri, Feb 21, 2020 at 11:19 AM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Hi Aditya >> >> Can you please review this patch. >> >> On Wed, Feb 19, 2020 at 5:04 PM Pradip Parkale < >> pradip.parkale@enterprisedb.com> wrote: >> >>> Please find the attached patch. >>> >>> On Wed, Feb 19, 2020 at 5:02 PM Ashesh Vashi < >>> ashesh.vashi@enterprisedb.com> wrote: >>> >>>> Forgot to attach the patch? >>>> >>>> On Wed, 19 Feb 2020 at 16:58, Pradip Parkale < >>>> pradip.parkale@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached is a patch for accessibility issue related Alertifyjs. >>>>> >>>>> 1. Added hidden label to satisfy accessibility. >>>>> 2. Added label with sr-only class. >>>>> 3. Added tabindex to move the mouse control to the maximize button >>>>> using the tab key. >>>>> >>>>> >>>>> Please note that this patch also includes the fix for the >>>>> RM-5143 Accessibility issue to maximize the panel for backup and restore >>>>> windows and all other places. >>>>> -- >>>>> Thanks & Regards, >>>>> Pradip Parkale >>>>> QMG, EnterpriseDB Corporation >>>>> >>>> -- >>>> >>>> -- >>>> >>>> Thanks & Regards, >>>> >>>> Ashesh Vashi >>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>> >>>> >>>> >>>> *http://www.linkedin.com/in/asheshvashi* >>>> >>>> >>> >>> >>> -- >>> Thanks & Regards, >>> Pradip Parkale >>> QMG, EnterpriseDB Corporation >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation --00000000000016c24c059f63954c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Akshay/Aditya,

Plea= se find the updated patch. I have accommodated=C2=A0all the changes.
<= div>

On Mon, Feb 24, 2020 at 2:34 PM Aditya Toshniwal <aditya.toshniwal@enterprised= b.com> wrote:
Hi Pradip,

- =C2=A0 =C2= =A0commonUtils.findAndSetFocus($(alertifyDialog.elements.body).find('.t= ab-content div.active'));
+ =C2=A0 =C2=A0$(alertifyDialog.elements.d= ialog).find('[tabindex]:not([tabindex=3D"-1"]').first().f= ocus();

Use the same commo= n function with commonUtils.findAndSetFocus(alertifyDialog.elements.dialog)= ). It will handle the focus.
Fixed.=C2=A0
Also, make the required changes mentioned on the pull request -=C2= =A0https://github.com/EnterpriseDB/AlertifyJS/pull/1=
Fixed.=C2=A0

=

On Fri, Feb 21, 2020 at 11:19 AM Aks= hay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Aditya

Can you please review this = patch.

On Wed, Feb 19, 2020 at 5:04 PM Pradip Parkale <pradip.parkale@ent= erprisedb.com> wrote:
Ple= ase find the attached patch.

On Wed, Feb 19, 2020 at 5:02 PM Ashesh Vashi = <ashe= sh.vashi@enterprisedb.com> wrote:
Forgot to attach the patch?

On Wed, 19 Feb 2020 = at 16:58, Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Atta= ched=C2=A0is a patch=C2=A0for accessibility issue related Alertifyjs.
=
  1. Added hidden label to satisfy accessibility.
  2. Added= label with sr-only class.
  3. Added tabindex to move the mouse con= trol to the maximize button using the tab key.

=
Please note that this patch also includes the fix for the RM-514= 3=C2=A0Accessibility issue to maximize the panel for backup and restore win= dows and all other places.
--
Thanks & Regards,
Pradip Parkale
QMG, EnterpriseDB Corp= oration
--

--

<= span style=3D"font-family:"courier new",monospace">Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi



--
Thanks & Regards,
=
Pradip Parkale
QMG, EnterpriseDB C= orporation


--
Thanks & Regards
Akshay Joshi
<= font color=3D"#3333FF">Sr. Software Architect=
<= font color=3D"#000000" face=3D"arial, sans-serif">EnterpriseDB Software = India Private Limited
Mobile: +91 976-788-8246=


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=


--
Thanks & Regards,
Pradip Park= ale
QMG, EnterpriseDB Corporation
--00000000000016c24c059f63954c-- --00000000000016c24f059f63954e Content-Type: application/octet-stream; name="RM5154_v2.patch" Content-Disposition: attachment; filename="RM5154_v2.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k71pxe4m0 ZGlmZiAtLWdpdCBhL3dlYi9wYWNrYWdlLmpzb24gYi93ZWIvcGFja2FnZS5qc29uCmluZGV4IGFj ZmNiMmVmYS4uYmE5MmUyOTFiIDEwMDY0NAotLS0gYS93ZWIvcGFja2FnZS5qc29uCisrKyBiL3dl Yi9wYWNrYWdlLmpzb24KQEAgLTUxLDcgKzUxLDcgQEAKICAgfSwKICAgImRlcGVuZGVuY2llcyI6 IHsKICAgICAiYWNpdHJlZSI6ICJnaXQraHR0cHM6Ly9naXRodWIuY29tL2ltc3VyaW5kZXI5MC9q cXVlcnktYWNpVHJlZS5naXQjcmMuNyIsCi0gICAgImFsZXJ0aWZ5anMiOiAiMS43LjEiLAorICAg ICJhbGVydGlmeWpzIjogImdpdCtodHRwczovL2dpdGh1Yi5jb20vRW50ZXJwcmlzZURCL0FsZXJ0 aWZ5SlMvIzcyYzFkNzk0ZjViNmQ0ZWMxM2E2OGQxMjNjMDhmMTkwMjFhZmUyNjMiLAogICAgICJh eGlvcyI6ICJeMC4xOC4xIiwKICAgICAiYmFiZWwtcGx1Z2luLXRyYW5zZm9ybS1lczIwMTUtbW9k dWxlcy1hbWQiOiAiXjYuMjQuMSIsCiAgICAgImJhYmVsLXByZXNldC1lczIwMTUtd2l0aG91dC1z dHJpY3QiOiAifjAuMC40IiwKZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9hbGVy dGlmeS9kaWFsb2dfd3JhcHBlci5qcyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9hbGVydGlmeS9k aWFsb2dfd3JhcHBlci5qcwppbmRleCA4MzE4NmU3MTAuLjUzNDZiNmEwZCAxMDA2NDQKLS0tIGEv d2ViL3BnYWRtaW4vc3RhdGljL2pzL2FsZXJ0aWZ5L2RpYWxvZ193cmFwcGVyLmpzCisrKyBiL3dl Yi9wZ2FkbWluL3N0YXRpYy9qcy9hbGVydGlmeS9kaWFsb2dfd3JhcHBlci5qcwpAQCAtNjQsNyAr NjQsNyBAQCBleHBvcnQgY2xhc3MgRGlhbG9nV3JhcHBlciB7CiAgICAgJChhbGVydGlmeURpYWxv Zy5lbGVtZW50cy5mb290ZXIpLm9uKCdrZXlkb3duJywgJ2J1dHRvbicsIGZ1bmN0aW9uKGV2ZW50 KSB7CiAgICAgICBpZiAoZXZlbnQua2V5Q29kZSA9PSA5ICYmICQodGhpcykubmV4dEFsbCgnYnV0 dG9uOm5vdChbZGlzYWJsZWRdKScpLmxlbmd0aCA9PSAwKSB7CiAgICAgICAgIC8vIHNldCBmb2N1 cyBiYWNrIHRvIGZpcnN0IGVkaXRhYmxlIGlucHV0IGVsZW1lbnQgb2YgY3VycmVudCBhY3RpdmUg dGFiIG9uY2Ugd2UgY3ljbGUgdGhyb3VnaCBhbGwgZW5hYmxlZCBidXR0b25zLgotICAgICAgICBj b21tb25VdGlscy5maW5kQW5kU2V0Rm9jdXMoJChhbGVydGlmeURpYWxvZy5lbGVtZW50cy5ib2R5 KS5maW5kKCcudGFiLWNvbnRlbnQgZGl2LmFjdGl2ZScpKTsKKyAgICAgICAgY29tbW9uVXRpbHMu ZmluZEFuZFNldEZvY3VzKCQoYWxlcnRpZnlEaWFsb2cuZWxlbWVudHMuZGlhbG9nKSk7CiAgICAg ICAgIHJldHVybiBmYWxzZTsKICAgICAgIH0KICAgICB9KTsKZGlmZiAtLWdpdCBhL3dlYi9wZ2Fk bWluL3N0YXRpYy9qcy91dGlscy5qcyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy91dGlscy5qcwpp bmRleCA5ZjllZjMyYzcuLjg2ZGFlNjk4ZSAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vc3RhdGlj L2pzL3V0aWxzLmpzCisrKyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy91dGlscy5qcwpAQCAtMzcs NiArMzcsNyBAQCBleHBvcnQgZnVuY3Rpb24gZmluZEFuZFNldEZvY3VzKGNvbnRhaW5lcikgewog ICAgICAgICAuZmluZChgCiAgICAgICAgICAgLnBnYWRtaW4tY29udHJvbHM6Zmlyc3QgaW5wdXQ6 ZW5hYmxlZCwKICAgICAgICAgICAucGdhZG1pbi1jb250cm9sczpmaXJzdCAuYnRuOm5vdCgudG9n Z2xlKSwKKyAgICAgICAgICAuYWpzLWNvbW1hbmRzOmZpcnN0LAogICAgICAgICAgIC5Db2RlTWly cm9yLXNjcm9sbGApCiAgICAgICAgIC5maW5kKCcqW3RhYmluZGV4XTpub3QoW3RhYmluZGV4PSIt MSJdKScpOwogICAgIH0KZGlmZiAtLWdpdCBhL3dlYi95YXJuLmxvY2sgYi93ZWIveWFybi5sb2Nr CmluZGV4IDI2MjcyNjY4Yi4uNTEzMzRjY2VlIDEwMDY0NAotLS0gYS93ZWIveWFybi5sb2NrCisr KyBiL3dlYi95YXJuLmxvY2sKQEAgLTkxMCwxMCArOTEwLDkgQEAgYWp2QF42LjEuMCwgYWp2QF42 LjEwLjIsIGFqdkBeNi45LjE6CiAgICAganNvbi1zY2hlbWEtdHJhdmVyc2UgIl4wLjQuMSIKICAg ICB1cmktanMgIl40LjIuMiIKIAotYWxlcnRpZnlqc0AxLjcuMToKKyJhbGVydGlmeWpzQGdpdCto dHRwczovL2dpdGh1Yi5jb20vRW50ZXJwcmlzZURCL0FsZXJ0aWZ5SlMvIzcyYzFkNzk0ZjViNmQ0 ZWMxM2E2OGQxMjNjMDhmMTkwMjFhZmUyNjMiOgogICB2ZXJzaW9uICIxLjcuMSIKLSAgcmVzb2x2 ZWQgImh0dHBzOi8vcmVnaXN0cnkueWFybnBrZy5jb20vYWxlcnRpZnlqcy8tL2FsZXJ0aWZ5anMt MS43LjEudGd6IzNjN2I4YWM2NzYwOWFlYTczN2ZlOGUwNmQ3ZmFjODg1Y2UxOGJhOGYiCi0gIGlu dGVncml0eSBzaGExLVBIdUt4bllKcnFjMy9vNEcxL3JJaGM0WXVvOD0KKyAgcmVzb2x2ZWQgImdp dCtodHRwczovL2dpdGh1Yi5jb20vRW50ZXJwcmlzZURCL0FsZXJ0aWZ5SlMvIzcyYzFkNzk0ZjVi NmQ0ZWMxM2E2OGQxMjNjMDhmMTkwMjFhZmUyNjMiCiAKIGFscGhhbnVtLXNvcnRAXjEuMC4wOgog ICB2ZXJzaW9uICIxLjAuMiIK --00000000000016c24f059f63954e--