Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRbWu-0001sg-Lw for pgadmin-hackers@arkaria.postgresql.org; Wed, 31 Mar 2021 14:09:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lRbWt-0006eO-K4 for pgadmin-hackers@arkaria.postgresql.org; Wed, 31 Mar 2021 14:09:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lRbWt-0006eH-Ce for pgadmin-hackers@lists.postgresql.org; Wed, 31 Mar 2021 14:09:07 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lRbWm-0002fI-8f for pgadmin-hackers@postgresql.org; Wed, 31 Mar 2021 14:09:06 +0000 Received: by mail-pg1-x536.google.com with SMTP id f10so14281876pgl.9 for ; Wed, 31 Mar 2021 07:08:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=CE1ebdyf/y0p4gC3IHmQKIjnrgX+iKphrlis+n4L1MA=; b=GbYslk9zGDkLD2/xJpe1+0wJzWoWH4K8rdd6RdI8oylavKXryQOc9NHLRh8K3tlibX 1eFINAEpQYK1c/ZpcMQXI/qvlo9vpphNIsJ9VEJ5VHag4LtsQ+mLy9eGcBDpTsI1ExHd XF2ijI5ld9RH9onOA3ohkDdKxZUklJq1pZVTUQagvJMQIiq0M0TKBpPKv/dQnB3/KZDN Mi4TxWy8colBt/QEzYswahR7f5rZ7QhZ1jbOu7JzN9ldXPIe4wMcb4YnLswzBtw4xcRJ Z6HZ5YmWefAxqM+SKXuE6jMGO7Ffh/Cm/TeUviPCyZv5xGqT9wuzY562hvJ06Nf/DdxB dyzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=CE1ebdyf/y0p4gC3IHmQKIjnrgX+iKphrlis+n4L1MA=; b=iop5SwhJgjNQMHzjzUzsaMnKz8JC0dK7fo1EGBZOku27bmGGS/7vZLI117TJCYCzLD 6fny+J+JlYfUvIYo7f8KD+W9phwDKnReSAc5WAnpbWNlyxB/vNSkAG69qv4ea2x6u/56 CiCX1xgaAs/PQDhIA8kQC8+f0S3JFTBmDwEH9LXPjKQjVdsKu7nOs3m6fmr2H3rsT0um N3VefG3uxOiTl6aIjrDN38yJZg3qLWsKqMtJI6T9PMqFc9WLRerXpqR7Z0wWyFIj2F5F if2m6swrSyr9P0nXpAtJ+NJ/JYHTA5/kcFofH9jY6aTE2HZGPLzEr/eZk9n4F+SJimd4 TILw== X-Gm-Message-State: AOAM532NakBpSjhI5IcxBpaSQek3XJGQ45kJzaVkjmWLgeaFq9YZvKar wBgJRcYye5H6kBYXGaaSwRJXX09t3aCc6gWXH03BWYKBC1siP1uCIU81GL7ToJxqDbJlDtzxcnH ml6laXXELqpu6TjoFo9lW3JqBSahKHwvPraMa/CHRDhhUHE3kDRhe9RZg/dLfvYTU1SPTY3a7wN 0v+NWFVRAozNHGFQvsiDk0eNT31KMeMwfWaJ/E8UFIukiKUf5e/+Y8oXVv8xGYjUQ= X-Google-Smtp-Source: ABdhPJwHefJtGzjtYMXGO8A0OBYM9LFc+sdCrwieHRDdjNRhOYzxnIlrJudQT0b8DuoQbMcLyjXHoVqnqT9RfuuZHKs= X-Received: by 2002:a63:4763:: with SMTP id w35mr3464489pgk.226.1617199736550; Wed, 31 Mar 2021 07:08:56 -0700 (PDT) MIME-Version: 1.0 From: Pradip Parkale Date: Wed, 31 Mar 2021 19:38:43 +0530 Message-ID: Subject: [pgAdmin][RM5519]: Unable to close tab after disconnecting server. To: pgadmin-hackers Content-Type: multipart/mixed; boundary="000000000000d42b9905bed5a79f" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000d42b9905bed5a79f Content-Type: multipart/alternative; boundary="000000000000d42b9605bed5a79d" --000000000000d42b9605bed5a79d Content-Type: text/plain; charset="UTF-8" Hi Hackers, Please find the attached patch for #5519. Updated the existing confirmation message and also added a new confirmation dialog before closing the query tool if the server is disconnected. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation --000000000000d42b9605bed5a79d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Hackers,
Please find the attached patch for #5519. = Updated the existing confirmation message and also added a new confirmation= dialog before closing the query tool if the server is disconnected.

--
Thanks & Regards,
Pr= adip Parkale
Software Engineer | EnterpriseDB Corporation
--000000000000d42b9605bed5a79d-- --000000000000d42b9905bed5a79f Content-Type: application/octet-stream; name="RM5519.patch" Content-Disposition: attachment; filename="RM5519.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kmxhlr1g0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci9fX2luaXRfXy5weSBiL3dl Yi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci9fX2luaXRfXy5weQppbmRleCAzN2NjODljNTAuLmRl Mzg2NGJlNSAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMvc3FsZWRpdG9yL19faW5pdF9f LnB5CisrKyBiL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci9fX2luaXRfXy5weQpAQCAtMTE5 LDYgKzExOSw3IEBAIGNsYXNzIFNxbEVkaXRvck1vZHVsZShQZ0FkbWluTW9kdWxlKToKICAgICAg ICAgICAgICdzcWxlZGl0b3IuZ2V0X25ld19jb25uZWN0aW9uX2RhdGEnLAogICAgICAgICAgICAg J3NxbGVkaXRvci5nZXRfbmV3X2Nvbm5lY3Rpb25fZGF0YWJhc2UnLAogICAgICAgICAgICAgJ3Nx bGVkaXRvci5nZXRfbmV3X2Nvbm5lY3Rpb25fdXNlcicsCisgICAgICAgICAgICAnc3FsZWRpdG9y Ll9jaGVja19zZXJ2ZXJfY29ubmVjdGlvbl9zdGF0dXMnLAogICAgICAgICAgICAgJ3NxbGVkaXRv ci5nZXRfbmV3X2Nvbm5lY3Rpb25fcm9sZScsCiAgICAgICAgICAgICAnc3FsZWRpdG9yLmNvbm5l Y3Rfc2VydmVyJywKICAgICAgICAgICAgICdzcWxlZGl0b3IuY29ubmVjdF9zZXJ2ZXJfd2l0aF91 c2VyJywKQEAgLTE0NzksNiArMTQ4MCw0OSBAQCBkZWYgZ2V0X2ZpbHRlcl9kYXRhKHRyYW5zX2lk KToKICAgICByZXR1cm4gRmlsdGVyRGlhbG9nLmdldChzdGF0dXMsIGVycm9yX21zZywgY29ubiwg dHJhbnNfb2JqLCBzZXNzaW9uX29iKQogCiAKK0BibHVlcHJpbnQucm91dGUoCisgICAgJy9nZXRf c2VydmVyX2Nvbm5lY3Rpb24vPGludDpzZ2lkPi88aW50OnNpZD4nLAorICAgIG1ldGhvZHM9WyJH RVQiXSwgZW5kcG9pbnQ9J19jaGVja19zZXJ2ZXJfY29ubmVjdGlvbl9zdGF0dXMnCispCitAbG9n aW5fcmVxdWlyZWQKK2RlZiBfY2hlY2tfc2VydmVyX2Nvbm5lY3Rpb25fc3RhdHVzKHNnaWQsIHNp ZD1Ob25lKToKKyAgICAiIiIKKyAgICBUaGlzIGZ1bmN0aW9uIHJldHVybnMgdGhlIHNlcnZlciBj b25uZWN0aW9uIGRldGFpbHMKKyAgICAiIiIKKyAgICB0cnk6CisgICAgICAgIGRyaXZlciA9IGdl dF9kcml2ZXIoUEdfREVGQVVMVF9EUklWRVIpCisgICAgICAgIGZyb20gcGdhZG1pbi5icm93c2Vy LnNlcnZlcl9ncm91cHMuc2VydmVycyBpbXBvcnQgXAorICAgICAgICAgICAgc2VydmVyX2ljb25f YW5kX2JhY2tncm91bmQKKyAgICAgICAgc2VydmVyID0gU2VydmVyLnF1ZXJ5LmZpbHRlcl9ieSgK KyAgICAgICAgICAgIGlkPXNpZCkuZmlyc3QoKQorCisgICAgICAgIG1hbmFnZXIgPSBkcml2ZXIu Y29ubmVjdGlvbl9tYW5hZ2VyKHNlcnZlci5pZCkKKyAgICAgICAgY29ubiA9IG1hbmFnZXIuY29u bmVjdGlvbigpCisgICAgICAgIGNvbm5lY3RlZCA9IGNvbm4uY29ubmVjdGVkKCkKKworICAgICAg ICBtc2cgPSAiU3VjY2VzcyIKKyAgICAgICAgcmV0dXJuIG1ha2VfanNvbl9yZXNwb25zZSgKKyAg ICAgICAgICAgIGRhdGE9eworICAgICAgICAgICAgICAgICdzdGF0dXMnOiBUcnVlLAorICAgICAg ICAgICAgICAgICdtc2cnOiBtc2csCisgICAgICAgICAgICAgICAgJ3Jlc3VsdCc6IHsKKyAgICAg ICAgICAgICAgICAgICAgJ3NlcnZlcic6IGNvbm5lY3RlZAorICAgICAgICAgICAgICAgIH0KKyAg ICAgICAgICAgIH0KKyAgICAgICAgKQorCisgICAgZXhjZXB0IEV4Y2VwdGlvbjoKKyAgICAgICAg cmV0dXJuIG1ha2VfanNvbl9yZXNwb25zZSgKKyAgICAgICAgICAgIGRhdGE9eworICAgICAgICAg ICAgICAgICdzdGF0dXMnOiBGYWxzZSwKKyAgICAgICAgICAgICAgICAnbXNnJzogRVJST1JfRkVU Q0hJTkdfREFUQSwKKyAgICAgICAgICAgICAgICAncmVzdWx0JzogeworICAgICAgICAgICAgICAg ICAgICAnc2VydmVyJzogRmFsc2UKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICB9Cisg ICAgICAgICkKKworCiBAYmx1ZXByaW50LnJvdXRlKAogICAgICcvbmV3X2Nvbm5lY3Rpb25fZGlh bG9nLzxpbnQ6c2dpZD4vPGludDpzaWQ+JywKICAgICBtZXRob2RzPVsiR0VUIl0sIGVuZHBvaW50 PSdnZXRfbmV3X2Nvbm5lY3Rpb25fZGF0YScKZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xz L3NxbGVkaXRvci9zdGF0aWMvanMvc3FsZWRpdG9yLmpzIGIvd2ViL3BnYWRtaW4vdG9vbHMvc3Fs ZWRpdG9yL3N0YXRpYy9qcy9zcWxlZGl0b3IuanMKaW5kZXggYjg3MDUxYmY3Li5jZjJiMGVlYzQg MTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci9zdGF0aWMvanMvc3FsZWRp dG9yLmpzCisrKyBiL3dlYi9wZ2FkbWluL3Rvb2xzL3NxbGVkaXRvci9zdGF0aWMvanMvc3FsZWRp dG9yLmpzCkBAIC00ODA5LDcgKzQ4MDksNyBAQCBkZWZpbmUoJ3Rvb2xzLnF1ZXJ5dG9vbCcsIFsK ICAgICAgICAgZWxzZSBpZiAoIWlnbm9yZV91bnNhdmVkX3F1ZXJ5ICYmIHNlbGYuaXNfcXVlcnlf dG9vbAogICAgICAgICAgICAgICAgICAgICYmIHNlbGYuaXNfcXVlcnlfY2hhbmdlZAogICAgICAg ICAgICAgICAgICAgICYmIHNlbGYucHJlZmVyZW5jZXMucHJvbXB0X3NhdmVfcXVlcnlfY2hhbmdl cykgewotICAgICAgICAgIG1zZyA9IGdldHRleHQoJ1RoZSB0ZXh0IGhhcyBjaGFuZ2VkLiBEbyB5 b3Ugd2FudCB0byBzYXZlIGNoYW5nZXM/Jyk7CisgICAgICAgICAgbXNnID0gZ2V0dGV4dCgnVGhl IHF1ZXJ5IHRleHQgaGFzIGNoYW5nZWQuIERvIHlvdSB3YW50IHRvIHNhdmUgY2hhbmdlcz8nKTsK ICAgICAgICAgICBzZWxmLnVuc2F2ZWRfY2hhbmdlc191c2VyX2NvbmZpcm1hdGlvbihtc2csIGZh bHNlKTsKICAgICAgICAgfSAvLyBJZiBhIHRyYW5zYWN0aW9uIGlzIGN1cnJlbnRseSBvbmdvaW5n CiAgICAgICAgIGVsc2UgaWYgKHNlbGYucHJlZmVyZW5jZXMucHJvbXB0X2NvbW1pdF90cmFuc2Fj dGlvbgpAQCAtNDkzOCwxNCArNDkzOCw0NCBAQCBkZWZpbmUoJ3Rvb2xzLnF1ZXJ5dG9vbCcsIFsK ICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgY2FzZSAxOiAvLyBEb24ndCBT YXZlCiAgICAgICAgICAgICAgICAgc2VsZi5jbG9zZV9vbl9zYXZlID0gZmFsc2U7Ci0gICAgICAg ICAgICAgICAgaWYodGhpcy5pc191bnNhdmVkX2RhdGEpCi0gICAgICAgICAgICAgICAgICBzZWxm Lmlnbm9yZV9vbl9jbG9zZS51bnNhdmVkX2RhdGEgPSB0cnVlOwotICAgICAgICAgICAgICAgIGVs c2UKLSAgICAgICAgICAgICAgICAgIHNlbGYuaWdub3JlX29uX2Nsb3NlLnVuc2F2ZWRfcXVlcnkg PSB0cnVlOwotICAgICAgICAgICAgICAgIC8vIEdvIGJhY2sgdG8gY2hlY2sgZm9yIGFueSBvdGhl ciBuZWVkZWQgY29uZmlybWF0aW9ucyBiZWZvcmUgY2xvc2luZwotICAgICAgICAgICAgICAgIGlm ICghc2VsZi5jaGVja19uZWVkZWRfY29uZmlybWF0aW9uc19iZWZvcmVfY2xvc2luZ19wYW5lbCgp KXsKLSAgICAgICAgICAgICAgICAgIGNsb3NlRXZlbnQuY2FuY2VsID0gdHJ1ZTsKLSAgICAgICAg ICAgICAgICB9CisgICAgICAgICAgICAgICAgJC5hamF4KHsKKyAgICAgICAgICAgICAgICAgIHVy bDogdXJsX2Zvcignc3FsZWRpdG9yLl9jaGVja19zZXJ2ZXJfY29ubmVjdGlvbl9zdGF0dXMnLCB7 CisgICAgICAgICAgICAgICAgICAgICdzaWQnOiBzZWxmLnVybF9wYXJhbXMuc2lkLAorICAgICAg ICAgICAgICAgICAgICAnc2dpZCc6IHNlbGYudXJsX3BhcmFtcy5zZ2lkLAorICAgICAgICAgICAg ICAgICAgfSksCisgICAgICAgICAgICAgICAgICBoZWFkZXJzOiB7CisgICAgICAgICAgICAgICAg ICAgICdDYWNoZS1Db250cm9sJyA6ICduby1jYWNoZScsCisgICAgICAgICAgICAgICAgICB9LAor ICAgICAgICAgICAgICAgIH0pLmRvbmUoZnVuY3Rpb24gKHJlcykgeworICAgICAgICAgICAgICAg ICAgbGV0IHJlc3BvbnNlID0gcmVzLmRhdGEucmVzdWx0LnNlcnZlcjsKKyAgICAgICAgICAgICAg ICAgIGlmKHJlc3BvbnNlKXsKKyAgICAgICAgICAgICAgICAgICAgY2xvc2VFdmVudC5jYW5jZWwg PSB0cnVlOworICAgICAgICAgICAgICAgICAgICBpZih0aGlzLmlzX3Vuc2F2ZWRfZGF0YSkKKyAg ICAgICAgICAgICAgICAgICAgICBzZWxmLmlnbm9yZV9vbl9jbG9zZS51bnNhdmVkX2RhdGEgPSB0 cnVlOworICAgICAgICAgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgICAgICAgc2Vs Zi5pZ25vcmVfb25fY2xvc2UudW5zYXZlZF9xdWVyeSA9IHRydWU7CisgICAgICAgICAgICAgICAg ICAgICAgLy8gR28gYmFjayB0byBjaGVjayBmb3IgYW55IG90aGVyIG5lZWRlZCBjb25maXJtYXRp b25zIGJlZm9yZSBjbG9zaW5nCisgICAgICAgICAgICAgICAgICAgIGlmICghc2VsZi5jaGVja19u ZWVkZWRfY29uZmlybWF0aW9uc19iZWZvcmVfY2xvc2luZ19wYW5lbCgpKXsKKyAgICAgICAgICAg ICAgICAgICAgICBjbG9zZUV2ZW50LmNhbmNlbCA9IHRydWU7CisgICAgICAgICAgICAgICAgICAg IH0KKyAgICAgICAgICAgICAgICAgIH1lbHNleworICAgICAgICAgICAgICAgICAgICBhbGVydGlm eS5jb25maXJtKAorICAgICAgICAgICAgICAgICAgICAgIGdldHRleHQoJ1dhcm5pbmcnKSwKKyAg ICAgICAgICAgICAgICAgICAgICBnZXR0ZXh0KCdDdXJyZW50IHRyYXNhY3Rpb24gaXMgbm90IGNv bW1pdGVkIGJlY2F1c2Ugc2VydmVyIGlzIGRpc2Nvbm5lY3RlZC4nKSwKKyAgICAgICAgICAgICAg ICAgICAgICBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIC8vIENsb3NlIHRo ZSBxdWVyeSB0b29sIGlmIHNlcnZlciBpcyBkaXNjb25uZWN0ZWQuCisgICAgICAgICAgICAgICAg ICAgICAgICBzZXRUaW1lb3V0KCgpID0+IHsgc2VsZi5jbG9zZSgpOyB9LCAyMDApOworICAgICAg ICAgICAgICAgICAgICAgIH0sCisgICAgICAgICAgICAgICAgICAgICAgZnVuY3Rpb24oKSB7Cisg ICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgICAgICAgICAgICAg ICB9CisgICAgICAgICAgICAgICAgICAgICkuc2V0KCdsYWJlbHMnLCB7CisgICAgICAgICAgICAg ICAgICAgICAgb2s6IGdldHRleHQoJ09rJykKKyAgICAgICAgICAgICAgICAgICAgfSk7CisgICAg ICAgICAgICAgICAgICB9CisgICAgICAgICAgICAgICAgfSkuZmFpbChmdW5jdGlvbigpIHsKKyAg ICAgICAgICAgICAgICAgIC8qIGZhaWx1cmUgc2hvdWxkIGJlIGlnbm9yZWQgKi8KKyAgICAgICAg ICAgICAgICB9KTsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgY2FzZSAy OiAvL1NhdmUKICAgICAgICAgICAgICAgICBzZWxmLmNsb3NlX29uX3NhdmUgPSB0cnVlOwo= --000000000000d42b9905bed5a79f--