MIME-Version: 1.0
References: 
 <CAJ9T6SsKmtv8f4kXF=qdzXVWrV9EAB-QhOBFrZ80i0wNcNwRNg@mail.gmail.com>
 <15B16A92-305E-4707-ABA5-E9970DF21B62@free.fr>
In-Reply-To: <15B16A92-305E-4707-ABA5-E9970DF21B62@free.fr>
From: Pradip Parkale <pradip.parkale@enterprisedb.com>
Date: Tue, 22 Jun 2021 16:17:03 +0530
Message-ID: 
 <CAJ9T6SvJk6wW9qrGTURm+iGX=i5QzPoqQ=46950uFeu40AZdaQ@mail.gmail.com>
Subject: Re: [pgAdmin][RM6448]: [search object] error displayed for non
 superuser because of right on pg_catalog.pg_subscription
To: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Cc: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>
Content-Type: multipart/mixed; boundary="00000000000059a7f605c5588354"
Archived-At: 
 <https://www.postgresql.org/message-id/CAJ9T6SvJk6wW9qrGTURm%2BiGX%3Di5QzPoqQ%3D46950uFeu40AZdaQ%40mail.gmail.com>
Precedence: bulk

--00000000000059a7f605c5588354
Content-Type: multipart/alternative; boundary="00000000000059a7f305c5588352"

--00000000000059a7f305c5588352
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Hackers,
Please ignore my previous email and find the attached patch. I have fixed
some review comments given by Aditya.

On Tue, Jun 22, 2021 at 2:21 PM Fred <fred.escallier@free.fr> wrote:

> nice !
> thanks
>
> fred
>
>
> Le 22 juin 2021 09:08:05 GMT+02:00, Pradip Parkale <
> pradip.parkale@enterprisedb.com> a =C3=A9crit :
>>
>> Hi Hackers,
>>
>> Please find the attached patch for # 6448. I have added a check to ignor=
e
>> the subscription when the search type is 'All type' if the user doesn't
>> have access to subscription.
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> Software Engineer | EnterpriseDB Corporation
>>
>

--=20
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation

--00000000000059a7f305c5588352
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Hackers,<br><div>Please ignore my=C2=A0previous email a=
nd find the attached patch. I have fixed some review comments given by Adit=
ya.</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gma=
il_attr">On Tue, Jun 22, 2021 at 2:21 PM Fred &lt;<a href=3D"mailto:fred.es=
callier@free.fr">fred.escallier@free.fr</a>&gt; wrote:<br></div><blockquote=
 class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left-width:=
1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left=
:1ex"><div>nice !<br>thanks<br><br>fred<br><br><br><div class=3D"gmail_quot=
e">Le 22 juin 2021 09:08:05 GMT+02:00, Pradip Parkale &lt;<a href=3D"mailto=
:pradip.parkale@enterprisedb.com" target=3D"_blank">pradip.parkale@enterpri=
sedb.com</a>&gt; a =C3=A9crit=C2=A0:<blockquote class=3D"gmail_quote" style=
=3D"margin:0pt 0pt 0pt 0.8ex;border-left-width:1px;border-left-style:solid;=
border-left-color:rgb(204,204,204);padding-left:1ex">
<div dir=3D"ltr">Hi Hackers,<div><br></div><div>Please find the attached pa=
tch for # 6448. I have added a check to ignore the subscription when the se=
arch type is &#39;All type&#39; if the user doesn&#39;t have access to subs=
cription.<br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"><div dir=
=3D"ltr"><div style=3D"font-size:12.8px">Thanks &amp; Regards,<br></div><di=
v style=3D"font-size:12.8px">Pradip Parkale<br>Software Engineer | Enterpri=
seDB Corporation</div></div></div></div></div>
</blockquote></div></div></blockquote></div><br clear=3D"all"><div><br></di=
v>-- <br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr"><div s=
tyle=3D"font-size:12.8px">Thanks &amp; Regards,<br></div><div style=3D"font=
-size:12.8px">Pradip Parkale<br>Software Engineer | EnterpriseDB Corporatio=
n</div></div></div>

--00000000000059a7f305c5588352--

--00000000000059a7f605c5588354
Content-Type: application/octet-stream; name="RM6448_v2.patch"
Content-Disposition: attachment; filename="RM6448_v2.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_kq7x9k9n0>
X-Attachment-Id: f_kq7x9k9n0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL3NlYXJjaF9vYmplY3RzL3RlbXBsYXRlcy9z
ZWFyY2hfb2JqZWN0cy9zcWwvcGcvMTBfcGx1cy9zZWFyY2guc3FsIGIvd2ViL3BnYWRtaW4vdG9v
bHMvc2VhcmNoX29iamVjdHMvdGVtcGxhdGVzL3NlYXJjaF9vYmplY3RzL3NxbC9wZy8xMF9wbHVz
L3NlYXJjaC5zcWwKaW5kZXggMWE0NzIyMzBiLi5iZTRhNDcxMzYgMTAwNjQ0Ci0tLSBhL3dlYi9w
Z2FkbWluL3Rvb2xzL3NlYXJjaF9vYmplY3RzL3RlbXBsYXRlcy9zZWFyY2hfb2JqZWN0cy9zcWwv
cGcvMTBfcGx1cy9zZWFyY2guc3FsCisrKyBiL3dlYi9wZ2FkbWluL3Rvb2xzL3NlYXJjaF9vYmpl
Y3RzL3RlbXBsYXRlcy9zZWFyY2hfb2JqZWN0cy9zcWwvcGcvMTBfcGx1cy9zZWFyY2guc3FsCkBA
IC0zMzAsNiArMzMwLDcgQEAgRlJPTSAoCiAgICAgVU5JT04KIHslIGVuZGlmICV9CiAKK3slIGlm
ICdzdWJzY3JpcHRpb24nIG5vdCBpbiBza2lwX29ial90eXBlJX0KIHslIGlmIGFsbF9vYmogb3Ig
b2JqX3R5cGUgaW4gWydzdWJzY3JpcHRpb24nXSAlfQogICAgIFNFTEVDVCAnc3Vic2NyaXB0aW9u
Jzo6dGV4dCBBUyBvYmpfdHlwZSwgc3VibmFtZSBBUyBvYmpfbmFtZSwgJzpzdWJzY3JpcHRpb24u
J3x8cHViLm9pZHx8JzovJyB8fCBzdWJuYW1lIEFTIG9ial9wYXRoLCAnJzo6dGV4dCBBUyBzY2hl
bWFfbmFtZSwKICAgICB7eyBzaG93X25vZGVfcHJlZnNbJ3N1YnNjcmlwdGlvbiddIH19IEFTIHNo
b3dfbm9kZSwgTlVMTCBBUyBvdGhlcl9pbmZvCkBAIC0zMzgsNiArMzM5LDcgQEAgRlJPTSAoCiB7
JSBpZiBhbGxfb2JqICV9CiAgICAgVU5JT04KIHslIGVuZGlmICV9Cit7JSBlbmRpZiAlfQogeyUg
aWYgYWxsX29iaiBvciBvYmpfdHlwZSBpbiBbJ2xhbmd1YWdlJ10gJX0KICAgICBTRUxFQ1QgJ2xh
bmd1YWdlJzo6dGV4dCBBUyBvYmpfdHlwZSwgbGFubmFtZSBBUyBvYmpfbmFtZSwgJzpsYW5ndWFn
ZS4nfHxsYW4ub2lkfHwnOi8nIHx8IGxhbm5hbWUgQVMgb2JqX3BhdGgsICcnOjp0ZXh0IEFTIHNj
aGVtYV9uYW1lLAogICAgIHt7IHNob3dfbm9kZV9wcmVmc1snbGFuZ3VhZ2UnXSB9fSBBUyBzaG93
X25vZGUsIE5VTEwgQVMgb3RoZXJfaW5mbwpkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vdG9vbHMv
c2VhcmNoX29iamVjdHMvdGVtcGxhdGVzL3NlYXJjaF9vYmplY3RzL3NxbC9wZy8xMV9wbHVzL3Nl
YXJjaC5zcWwgYi93ZWIvcGdhZG1pbi90b29scy9zZWFyY2hfb2JqZWN0cy90ZW1wbGF0ZXMvc2Vh
cmNoX29iamVjdHMvc3FsL3BnLzExX3BsdXMvc2VhcmNoLnNxbAppbmRleCAyNmZjMjM4YWEuLjk5
MmI1NDdhZSAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMvc2VhcmNoX29iamVjdHMvdGVt
cGxhdGVzL3NlYXJjaF9vYmplY3RzL3NxbC9wZy8xMV9wbHVzL3NlYXJjaC5zcWwKKysrIGIvd2Vi
L3BnYWRtaW4vdG9vbHMvc2VhcmNoX29iamVjdHMvdGVtcGxhdGVzL3NlYXJjaF9vYmplY3RzL3Nx
bC9wZy8xMV9wbHVzL3NlYXJjaC5zcWwKQEAgLTM0Niw3ICszNDYsNyBAQCBGUk9NICgKIHslIGlm
IGFsbF9vYmogJX0KICAgICBVTklPTgogeyUgZW5kaWYgJX0KLQoreyUgaWYgJ3N1YnNjcmlwdGlv
bicgbm90IGluIHNraXBfb2JqX3R5cGUlfQogeyUgaWYgYWxsX29iaiBvciBvYmpfdHlwZSBpbiBb
J3N1YnNjcmlwdGlvbiddICV9CiAgICAgU0VMRUNUICdzdWJzY3JpcHRpb24nOjp0ZXh0IEFTIG9i
al90eXBlLCBzdWJuYW1lIEFTIG9ial9uYW1lLCAnOnN1YnNjcmlwdGlvbi4nfHxwdWIub2lkfHwn
Oi8nIHx8IHN1Ym5hbWUgQVMgb2JqX3BhdGgsICcnOjp0ZXh0IEFTIHNjaGVtYV9uYW1lLAogICAg
IHt7IHNob3dfbm9kZV9wcmVmc1snc3Vic2NyaXB0aW9uJ10gfX0gQVMgc2hvd19ub2RlLCBOVUxM
IEFTIG90aGVyX2luZm8KQEAgLTM1NSw2ICszNTUsNyBAQCBGUk9NICgKIHslIGlmIGFsbF9vYmog
JX0KICAgICBVTklPTgogeyUgZW5kaWYgJX0KK3slIGVuZGlmICV9CiB7JSBpZiBhbGxfb2JqIG9y
IG9ial90eXBlIGluIFsnbGFuZ3VhZ2UnXSAlfQogICAgIFNFTEVDVCAnbGFuZ3VhZ2UnOjp0ZXh0
IEFTIG9ial90eXBlLCBsYW5uYW1lIEFTIG9ial9uYW1lLCAnOmxhbmd1YWdlLid8fGxhbi5vaWR8
fCc6LycgfHwgbGFubmFtZSBBUyBvYmpfcGF0aCwgJyc6OnRleHQgQVMgc2NoZW1hX25hbWUsCiAg
ICAge3sgc2hvd19ub2RlX3ByZWZzWydsYW5ndWFnZSddIH19IEFTIHNob3dfbm9kZSwgTlVMTCBB
UyBvdGhlcl9pbmZvCmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi90b29scy9zZWFyY2hfb2JqZWN0
cy90ZW1wbGF0ZXMvc2VhcmNoX29iamVjdHMvc3FsL3BwYXMvMTBfcGx1cy9zZWFyY2guc3FsIGIv
d2ViL3BnYWRtaW4vdG9vbHMvc2VhcmNoX29iamVjdHMvdGVtcGxhdGVzL3NlYXJjaF9vYmplY3Rz
L3NxbC9wcGFzLzEwX3BsdXMvc2VhcmNoLnNxbAppbmRleCBiNWZjMDFiNTEuLjM1NjUwOWZkNiAx
MDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMvc2VhcmNoX29iamVjdHMvdGVtcGxhdGVzL3Nl
YXJjaF9vYmplY3RzL3NxbC9wcGFzLzEwX3BsdXMvc2VhcmNoLnNxbAorKysgYi93ZWIvcGdhZG1p
bi90b29scy9zZWFyY2hfb2JqZWN0cy90ZW1wbGF0ZXMvc2VhcmNoX29iamVjdHMvc3FsL3BwYXMv
MTBfcGx1cy9zZWFyY2guc3FsCkBAIC0zNzEsNiArMzcxLDcgQEAgRlJPTSAoCiAgICAgVU5JT04K
IHslIGVuZGlmICV9CiAKK3slIGlmICdzdWJzY3JpcHRpb24nIG5vdCBpbiBza2lwX29ial90eXBl
JX0KIHslIGlmIGFsbF9vYmogb3Igb2JqX3R5cGUgaW4gWydzdWJzY3JpcHRpb24nXSAlfQogICAg
IFNFTEVDVCAnc3Vic2NyaXB0aW9uJzo6dGV4dCBBUyBvYmpfdHlwZSwgc3VibmFtZSBBUyBvYmpf
bmFtZSwgJzpzdWJzY3JpcHRpb24uJ3x8cHViLm9pZHx8JzovJyB8fCBzdWJuYW1lIEFTIG9ial9w
YXRoLCAnJzo6dGV4dCBBUyBzY2hlbWFfbmFtZSwKICAgICB7eyBzaG93X25vZGVfcHJlZnNbJ3N1
YnNjcmlwdGlvbiddIH19IEFTIHNob3dfbm9kZSwgTlVMTCBBUyBvdGhlcl9pbmZvCkBAIC0zNzks
NiArMzgwLDcgQEAgRlJPTSAoCiB7JSBpZiBhbGxfb2JqICV9CiAgICAgVU5JT04KIHslIGVuZGlm
ICV9Cit7JSBlbmRpZiAlfQogCiB7JSBpZiBhbGxfb2JqIG9yIG9ial90eXBlIGluIFsnbGFuZ3Vh
Z2UnXSAlfQogICAgIFNFTEVDVCAnbGFuZ3VhZ2UnOjp0ZXh0IEFTIG9ial90eXBlLCBsYW5uYW1l
IEFTIG9ial9uYW1lLCAnOmxhbmd1YWdlLid8fGxhbi5vaWR8fCc6LycgfHwgbGFubmFtZSBBUyBv
YmpfcGF0aCwgJyc6OnRleHQgQVMgc2NoZW1hX25hbWUsCmRpZmYgLS1naXQgYS93ZWIvcGdhZG1p
bi90b29scy9zZWFyY2hfb2JqZWN0cy90ZW1wbGF0ZXMvc2VhcmNoX29iamVjdHMvc3FsL3BwYXMv
MTJfcGx1cy9zZWFyY2guc3FsIGIvd2ViL3BnYWRtaW4vdG9vbHMvc2VhcmNoX29iamVjdHMvdGVt
cGxhdGVzL3NlYXJjaF9vYmplY3RzL3NxbC9wcGFzLzEyX3BsdXMvc2VhcmNoLnNxbAppbmRleCAx
YTYxNjU4MzYuLjYzMjczNDk4YiAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMvc2VhcmNo
X29iamVjdHMvdGVtcGxhdGVzL3NlYXJjaF9vYmplY3RzL3NxbC9wcGFzLzEyX3BsdXMvc2VhcmNo
LnNxbAorKysgYi93ZWIvcGdhZG1pbi90b29scy9zZWFyY2hfb2JqZWN0cy90ZW1wbGF0ZXMvc2Vh
cmNoX29iamVjdHMvc3FsL3BwYXMvMTJfcGx1cy9zZWFyY2guc3FsCkBAIC0zNzgsNiArMzc4LDcg
QEAgRlJPTSAoCiAgICAgVU5JT04KIHslIGVuZGlmICV9CiAKK3slIGlmICdzdWJzY3JpcHRpb24n
IG5vdCBpbiBza2lwX29ial90eXBlJX0KIHslIGlmIGFsbF9vYmogb3Igb2JqX3R5cGUgaW4gWydz
dWJzY3JpcHRpb24nXSAlfQogICAgIFNFTEVDVCAnc3Vic2NyaXB0aW9uJzo6dGV4dCBBUyBvYmpf
dHlwZSwgc3VibmFtZSBBUyBvYmpfbmFtZSwgJzpzdWJzY3JpcHRpb24uJ3x8cHViLm9pZHx8Jzov
JyB8fCBzdWJuYW1lIEFTIG9ial9wYXRoLCAnJzo6dGV4dCBBUyBzY2hlbWFfbmFtZSwKICAgICB7
eyBzaG93X25vZGVfcHJlZnNbJ3N1YnNjcmlwdGlvbiddIH19IEFTIHNob3dfbm9kZSwgTlVMTCBB
UyBvdGhlcl9pbmZvCkBAIC0zODYsNiArMzg3LDcgQEAgRlJPTSAoCiB7JSBpZiBhbGxfb2JqICV9
CiAgICAgVU5JT04KIHslIGVuZGlmICV9Cit7JSBlbmRpZiAlfQogCiB7JSBpZiBhbGxfb2JqIG9y
IG9ial90eXBlIGluIFsnbGFuZ3VhZ2UnXSAlfQogICAgIFNFTEVDVCAnbGFuZ3VhZ2UnOjp0ZXh0
IEFTIG9ial90eXBlLCBsYW5uYW1lIEFTIG9ial9uYW1lLCAnOmxhbmd1YWdlLid8fGxhbi5vaWR8
fCc6LycgfHwgbGFubmFtZSBBUyBvYmpfcGF0aCwgJyc6OnRleHQgQVMgc2NoZW1hX25hbWUsCmRp
ZmYgLS1naXQgYS93ZWIvcGdhZG1pbi90b29scy9zZWFyY2hfb2JqZWN0cy91dGlscy5weSBiL3dl
Yi9wZ2FkbWluL3Rvb2xzL3NlYXJjaF9vYmplY3RzL3V0aWxzLnB5CmluZGV4IGE3ZDU1Njg1My4u
NDA3ZGM4M2YyIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi90b29scy9zZWFyY2hfb2JqZWN0cy91
dGlscy5weQorKysgYi93ZWIvcGdhZG1pbi90b29scy9zZWFyY2hfb2JqZWN0cy91dGlscy5weQpA
QCAtODksNyArODksMjMgQEAgY2xhc3MgU2VhcmNoT2JqZWN0c0hlbHBlcjoKICAgICAgICAgICAg
ICoqa3dhcmdzCiAgICAgICAgICkKIAorICAgIGRlZiBfY2hlY2tfcGVybWlzc2lvbihzZWxmLCBv
YmpfdHlwZSwgY29ubiwgc2tpcF9vYmpfdHlwZSk6CisgICAgICAgICIiIgorICAgICAgICBUaGlz
IGZ1bmN0aW9uIHJldHVybiB3aGV0aGVyIHVzZXIgaGFzIHBlcm1pc3Npb24gdG8gc2VlIHR5cGUK
KyAgICAgICAgOnBhcmFtIG9ial90eXBlOgorICAgICAgICA6cGFyYW0gY29ubjoKKyAgICAgICAg
OnJldHVybjoKKyAgICAgICAgIiIiCisKKyAgICAgICAgaWYgb2JqX3R5cGUgPT0gJ2FsbCc6Cisg
ICAgICAgICAgICBzdGF0dXMsIGVycm9yID0gY29ubi5leGVjdXRlX2RpY3QoJ3NlbGVjdCAqIGZy
b20gcGdfc3Vic2NyaXB0aW9uJykKKyAgICAgICAgICAgIGlmICdwZXJtaXNzaW9uIGRlbmllZCcg
aW4gZXJyb3I6CisgICAgICAgICAgICAgICAgc2tpcF9vYmpfdHlwZS5hcHBlbmQoJ3N1YnNjcmlw
dGlvbicpCisKKyAgICAgICAgcmV0dXJuIHNraXBfb2JqX3R5cGUKKwogICAgIGRlZiBzZWFyY2go
c2VsZiwgdGV4dCwgb2JqX3R5cGU9Tm9uZSk6CisgICAgICAgIHNraXBfb2JqX3R5cGUgPSBbXQog
ICAgICAgICBjb25uID0gc2VsZi5tYW5hZ2VyLmNvbm5lY3Rpb24oZGlkPXNlbGYuZGlkKQogICAg
ICAgICBsYXN0X3N5c3RlbV9vaWQgPSAoc2VsZi5tYW5hZ2VyLmRiX2luZm9bc2VsZi5kaWRdKVsn
ZGF0bGFzdHN5c29pZCddIFwKICAgICAgICAgICAgIGlmIHNlbGYubWFuYWdlci5kYl9pbmZvIGlz
IG5vdCBOb25lIGFuZCBzZWxmLmRpZCBpbiBcCkBAIC05OSw2ICsxMTUsOCBAQCBjbGFzcyBTZWFy
Y2hPYmplY3RzSGVscGVyOgogICAgICAgICBub2RlX2xhYmVscyA9IHNlbGYuZ2V0X3N1cHBvcnRl
ZF90eXBlcyhza2lwX2NoZWNrPVRydWUpCiAgICAgICAgICMgZXNjYXBlIHRoZSBzaW5nbGUgcXVv
dGUgZnJvbSBzZWFyY2ggdGV4dAogICAgICAgICB0ZXh0ID0gdGV4dC5yZXBsYWNlKCInIiwgIicn
IikKKyAgICAgICAgc2tpcF9vYmpfdHlwZSA9IHNlbGYuX2NoZWNrX3Blcm1pc3Npb24ob2JqX3R5
cGUsIGNvbm4sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
IHNraXBfb2JqX3R5cGUpCiAKICAgICAgICAgIyBDb2x1bW4gY2F0YWxvZ19sZXZlbCBoYXMgdmFs
dWVzIGFzCiAgICAgICAgICMgTiAtIE5vdCBhIGNhdGFsb2cgc2NoZW1hCkBAIC0xMDksNyArMTI3
LDggQEAgY2xhc3MgU2VhcmNoT2JqZWN0c0hlbHBlcjoKICAgICAgICAgICAgICAgICAgICAgICAg
ICBzZWFyY2hfdGV4dD10ZXh0Lmxvd2VyKCksIG9ial90eXBlPW9ial90eXBlLAogICAgICAgICAg
ICAgICAgICAgICAgICAgIHNob3dfc3lzdGVtX29iamVjdHM9c2VsZi5zaG93X3N5c3RlbV9vYmpl
Y3RzLAogICAgICAgICAgICAgICAgICAgICAgICAgIHNob3dfbm9kZV9wcmVmcz1zaG93X25vZGVf
cHJlZnMsIF89Z2V0dGV4dCwKLSAgICAgICAgICAgICAgICAgICAgICAgICBsYXN0X3N5c3RlbV9v
aWQ9bGFzdF9zeXN0ZW1fb2lkKQorICAgICAgICAgICAgICAgICAgICAgICAgIGxhc3Rfc3lzdGVt
X29pZD1sYXN0X3N5c3RlbV9vaWQsCisgICAgICAgICAgICAgICAgICAgICAgICAgc2tpcF9vYmpf
dHlwZT1za2lwX29ial90eXBlKQogICAgICAgICApCiAKICAgICAgICAgaWYgbm90IHN0YXR1czoK
--00000000000059a7f605c5588354--