public inbox for [email protected]help / color / mirror / Atom feed
[pgAdmin][RM7296]: Browser tree is not getting refresh after deleting the multiple node from collection properties 4+ messages / 2 participants [nested] [flat]
* [pgAdmin][RM7296]: Browser tree is not getting refresh after deleting the multiple node from collection properties @ 2022-04-08 06:59 Pradip Parkale <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Pradip Parkale @ 2022-04-08 06:59 UTC (permalink / raw) To: pgadmin-hackers Hi Hackers, Please find the attached patch for #7296.I have fixed the issue where the browser tree did not refresh after multiple nodes were deleted. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation Attachments: [application/octet-stream] RM7296.patch (859B, 3-RM7296.patch) download | inline diff: diff --git a/web/pgadmin/misc/properties/CollectionNodeProperties.jsx b/web/pgadmin/misc/properties/CollectionNodeProperties.jsx index 05aeef26d..9d340914d 100644 --- a/web/pgadmin/misc/properties/CollectionNodeProperties.jsx +++ b/web/pgadmin/misc/properties/CollectionNodeProperties.jsx @@ -162,12 +162,13 @@ export function CollectionNodeView({ if (res.success == 0) { pgBrowser.report_error(res.errormsg, res.info); } + pgAdmin.Browser.tree.refresh(selItem); setReload(!reload); }) .catch(function (error) { Notify.alert( gettext('Error dropping %s', selectedItemData._label.toLowerCase()), - error.response.data.errormsg + _.isUndefined(error.response) ? error.message : error.response.data.errormsg ); }); }; ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin][RM7296]: Browser tree is not getting refresh after deleting the multiple node from collection properties @ 2022-04-09 06:36 Akshay Joshi <[email protected]> parent: Pradip Parkale <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Akshay Joshi @ 2022-04-09 06:36 UTC (permalink / raw) To: Pradip Parkale <[email protected]>; +Cc: pgadmin-hackers Thanks, the patch applied. On Fri, Apr 8, 2022 at 12:29 PM Pradip Parkale < [email protected]> wrote: > Hi Hackers, > > Please find the attached patch for #7296.I have fixed the issue where the > browser tree did not refresh after multiple nodes were deleted. > > -- > Thanks & Regards, > Pradip Parkale > Software Engineer | EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres <http://edbpostgres.com>* *Mobile: +91 976-788-8246* ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin][RM7296]: Browser tree is not getting refresh after deleting the multiple node from collection properties @ 2022-04-11 11:52 Pradip Parkale <[email protected]> parent: Akshay Joshi <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Pradip Parkale @ 2022-04-11 11:52 UTC (permalink / raw) To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers Hi Akshay, Please find the attached patch for the issue below. 1. When deleting the constraint from the collection properties nodes, an error occurred 2. The code to refresh the Dashboard after deleted session activities has been improved. On Sat, Apr 9, 2022 at 12:06 PM Akshay Joshi <[email protected]> wrote: > Thanks, the patch applied. > > On Fri, Apr 8, 2022 at 12:29 PM Pradip Parkale < > [email protected]> wrote: > >> Hi Hackers, >> >> Please find the attached patch for #7296.I have fixed the issue where the >> browser tree did not refresh after multiple nodes were deleted. >> >> -- >> Thanks & Regards, >> Pradip Parkale >> Software Engineer | EnterpriseDB Corporation >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres <http://edbpostgres.com>* > > *Mobile: +91 976-788-8246* > -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation Attachments: [application/octet-stream] refresh.patch (2.3K, 3-refresh.patch) download | inline diff: diff --git a/web/pgadmin/dashboard/static/js/Dashboard.jsx b/web/pgadmin/dashboard/static/js/Dashboard.jsx index 4c0d91874..4b7d779cc 100644 --- a/web/pgadmin/dashboard/static/js/Dashboard.jsx +++ b/web/pgadmin/dashboard/static/js/Dashboard.jsx @@ -128,7 +128,7 @@ export default function Dashboard({ const [msg, setMsg] = useState(''); const[infoMsg, setInfo] = useState(''); const [val, setVal] = useState(0); - const [refresh, setRefresh] = useState(); + const [refresh, setRefresh] = useState(false); const [schemaDict, setSchemaDict] = React.useState({}); if (!did) { @@ -235,6 +235,7 @@ export default function Dashboard({ if (res.data == gettext('Success')) { setInfo(txtSuccess); Notify.success(txtSuccess); + setRefresh(!refresh); } else { setInfo(txtError); Notify.error(txtError); @@ -769,9 +770,6 @@ export default function Dashboard({ if (message != '') { setMsg(message); } - return () => { - setRefresh(); - }; }, [nodeData, val, did, preferences, infoMsg, refresh, props.dbConnected]); const RefreshButton = () =>{ @@ -783,7 +781,7 @@ export default function Dashboard({ icon={<CachedIcon />} onClick={(e) => { e.preventDefault(); - setRefresh(true); + setRefresh(!refresh); }} color="default" aria-label="Refresh" diff --git a/web/pgadmin/misc/properties/CollectionNodeProperties.jsx b/web/pgadmin/misc/properties/CollectionNodeProperties.jsx index 9d340914d..5823fed4b 100644 --- a/web/pgadmin/misc/properties/CollectionNodeProperties.jsx +++ b/web/pgadmin/misc/properties/CollectionNodeProperties.jsx @@ -122,8 +122,8 @@ export function CollectionNodeView({ if (selNode && selNode.type && selNode.type == 'coll-constraints') { // In order to identify the constraint type, the type should be passed to the server selRows = selRowModels.map((row) => ({ - id: row.get('oid'), - _type: row.get('_type'), + id: row.original.oid, + _type: row.original._type, })); } else { selRows = selRowModels.map((row) => row.original.oid); ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: [pgAdmin][RM7296]: Browser tree is not getting refresh after deleting the multiple node from collection properties @ 2022-04-11 12:19 Akshay Joshi <[email protected]> parent: Pradip Parkale <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Akshay Joshi @ 2022-04-11 12:19 UTC (permalink / raw) To: Pradip Parkale <[email protected]>; +Cc: pgadmin-hackers Thanks, the patch applied. On Mon, Apr 11, 2022 at 5:22 PM Pradip Parkale < [email protected]> wrote: > Hi Akshay, > > Please find the attached patch for the issue below. > > 1. When deleting the constraint from the collection properties nodes, > an error occurred > 2. The code to refresh the Dashboard after deleted session activities > has been improved. > > > On Sat, Apr 9, 2022 at 12:06 PM Akshay Joshi < > [email protected]> wrote: > >> Thanks, the patch applied. >> >> On Fri, Apr 8, 2022 at 12:29 PM Pradip Parkale < >> [email protected]> wrote: >> >>> Hi Hackers, >>> >>> Please find the attached patch for #7296.I have fixed the issue where >>> the browser tree did not refresh after multiple nodes were deleted. >>> >>> -- >>> Thanks & Regards, >>> Pradip Parkale >>> Software Engineer | EnterpriseDB Corporation >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Principal Software Architect* >> *EDB Postgres <http://edbpostgres.com>* >> >> *Mobile: +91 976-788-8246* >> > > > -- > Thanks & Regards, > Pradip Parkale > Software Engineer | EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres <http://edbpostgres.com>* *Mobile: +91 976-788-8246* ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2022-04-11 12:19 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2022-04-08 06:59 [pgAdmin][RM7296]: Browser tree is not getting refresh after deleting the multiple node from collection properties Pradip Parkale <[email protected]> 2022-04-09 06:36 ` Akshay Joshi <[email protected]> 2022-04-11 11:52 ` Pradip Parkale <[email protected]> 2022-04-11 12:19 ` Akshay Joshi <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox