public inbox for [email protected]
help / color / mirror / Atom feedFrom: Pradip Parkale <[email protected]>
To: Akshay Joshi <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: [pgAdmin][RM4979]: Configuration files for data sources or similar.
Date: Mon, 7 Sep 2020 22:46:59 +0530
Message-ID: <CAJ9T6SvotUdn9azRcUXoj-51wt9_NVm+eHDNkGgz4nei4OzCnw@mail.gmail.com> (raw)
In-Reply-To: <CANxoLDebAswYrWeJg=AA3FduyTgTUAwRM=qmRyzLpLowzQxr8w@mail.gmail.com>
References: <CAJ9T6SvOzSPGyRgVg+8XksV_4=mOSSMoy8RaGKm0O9qFTT_ZQQ@mail.gmail.com>
<CANxoLDcmxQsdmO-8Z9O6=zmuUs5KGkXzCmjqyoatCRCd=xBkdA@mail.gmail.com>
<CAJ9T6SsV50gwjNP3D4YhONhtV6=RfgqE4hUGoDf91aBZMcahsA@mail.gmail.com>
<CANxoLDdVUbL7Eeen5jNX9ZrpvOe1zGqi_XCw8ECFzeJv8oJLCg@mail.gmail.com>
<CAJ9T6Su5LAOO=JW-ZpLs6wGUta7PMZ52wzcQWmSCPbSSR+U8Gw@mail.gmail.com>
<CANxoLDdQP=kHtxrj-TymBd98kemxQvOkthvUoaitbMFRneRHXg@mail.gmail.com>
<CAJ9T6StLHKviij7ZPXC36amgYy=tsMvKqW48oTxzUbkUaFx3gQ@mail.gmail.com>
<CANxoLDdwUHfbrkGOFu12nYYK_arWbJwAW9BHVLQqyc06NEqcFw@mail.gmail.com>
<CAJ9T6SssrE-er-mCBauKBsj1ivCTY1wQWzHYNo4a5C71vMexeg@mail.gmail.com>
<CANxoLDebAswYrWeJg=AA3FduyTgTUAwRM=qmRyzLpLowzQxr8w@mail.gmail.com>
Hi Akshay,
Please find attached for the shared server. The server icon was getting
change to the shared server icon in Desktop mode.
On Thu, Sep 3, 2020 at 2:23 PM Akshay Joshi <[email protected]>
wrote:
> Thanks, patch applied.
>
> On Thu, Sep 3, 2020 at 2:07 PM Pradip Parkale <
> [email protected]> wrote:
>
>> Hi Akshay,
>>
>> Please find the patch.
>>
>> On Thu, Sep 3, 2020 at 1:05 PM Akshay Joshi <
>> [email protected]> wrote:
>>
>>> Thanks, patch applied.
>>>
>>> On Thu, Sep 3, 2020 at 12:25 PM Pradip Parkale <
>>> [email protected]> wrote:
>>>
>>>> Hi Akshay,
>>>> Please find the updated patch.
>>>>
>>>> On Wed, Sep 2, 2020 at 1:48 PM Akshay Joshi <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Pradip
>>>>>
>>>>> Please fix SonarQube issues that introduce with this patch.
>>>>>
>>>>> On Tue, Sep 1, 2020 at 4:47 PM Pradip Parkale <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi Akshay,
>>>>>>
>>>>>> Please find the updated patch.
>>>>>>
>>>>>> On Tue, Aug 25, 2020 at 5:53 PM Akshay Joshi <
>>>>>> [email protected]> wrote:
>>>>>>
>>>>>>> Hi Pradip
>>>>>>>
>>>>>>> Following are the GUI review comments:
>>>>>>> *Testing Scenario*: I have three users U1 and U2 are Admin and U3
>>>>>>> is a normal user. Login from U1 first time and pgAdmin4 discover all the
>>>>>>> local servers. Steps that I perform:
>>>>>>>
>>>>>>> - Shared one server.
>>>>>>> - Create a group 'Test' and move one server to that group.
>>>>>>> - Share the server of the 'Test' group as well.
>>>>>>>
>>>>>>> [image: Screenshot 2020-08-25 at 4.38.32 PM.png]
>>>>>>> *Issues:*
>>>>>>>
>>>>>>> - When login using U2 or U3 PostgreSQL 9.2 and 10 shown twice
>>>>>>> which should not. Refer below screenshot
>>>>>>> [image: Screenshot 2020-08-25 at 4.30.22 PM.png]
>>>>>>>
>>>>>>> Fixed. If the server is auto-discovered and U1 shared the
>>>>>> auto-discovered server(PostgreSQL 9.2 in the above example) and then log in
>>>>>> using U2, in this case, shared server(PostgreSQL 9.2) will not visible to
>>>>>> U2 as the same server will be auto-discovered for U2.
>>>>>>
>>>>>>>
>>>>>>> -
>>>>>>> - When expanding the server or clicking on the 'Connect Server'
>>>>>>> menu of the shared server, it opens the properties dialog.
>>>>>>>
>>>>>>> This is expected. Properties dialogue will open the first time for a
>>>>>> shared server where the user has to enter server details. This will happen
>>>>>> for the user who is not the owner of the server.
>>>>>>
>>>>>>>
>>>>>>> - Try to update the IPAddress, Port it is not updating for the
>>>>>>> shared server. Check other properties too.
>>>>>>>
>>>>>>> Fixed.
>>>>>>
>>>>>>>
>>>>>>> -
>>>>>>> - When we set "Hide shared server?" setting to true/false. A
>>>>>>> complete browser tree should be refreshed. With the current implementation,
>>>>>>> each group needs to be refreshed individually and the server group still
>>>>>>> visible while refreshing the complete page Browser Tree looks perfect.
>>>>>>>
>>>>>>> Fixed.
>>>>>>
>>>>>>>
>>>>>>> - When there is only one server in a group and we expanded the
>>>>>>> group 'Connect to server' dialog appears which should not. (*This may be an
>>>>>>> old issue)
>>>>>>>
>>>>>>> This is expected and its an old behavior.
>>>>>>
>>>>>>>
>>>>>>> -
>>>>>>> - Schema Diff shared servers are not visible inside the
>>>>>>> appropriate group in the source and target server list.
>>>>>>>
>>>>>>> Fixed
>>>>>>
>>>>>>>
>>>>>>> - Documentation changes required (Create a new Redmine).
>>>>>>>
>>>>>>> Done.
>>>>>>
>>>>>>>
>>>>>>> -
>>>>>>> - SonarQube shows 1 new Bug and 4 new code smell. (Fixed the
>>>>>>> Bug, code smell can be fixed later)
>>>>>>>
>>>>>>> Fixed.
>>>>>>
>>>>>>>
>>>>>>> - 'pgAdmin4_test_non_admin_credentials' should be added in '
>>>>>>> test_config.json.in' file.
>>>>>>>
>>>>>>> Fixed.
>>>>>>
>>>>>>>
>>>>>>> - For Desktop mode shared server test cases should be skipped.
>>>>>>> It is failing at the moment.
>>>>>>>
>>>>>>> Fixed.
>>>>>>
>>>>>>> Code review still remains :)
>>>>>>>
>>>>>>> On Fri, Aug 21, 2020 at 6:00 PM Pradip Parkale <
>>>>>>> [email protected]> wrote:
>>>>>>>
>>>>>>>> Hi Akshay,
>>>>>>>> Please find the updated patch.
>>>>>>>>
>>>>>>>> On Fri, Aug 21, 2020 at 1:55 PM Akshay Joshi <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi Pradip
>>>>>>>>>
>>>>>>>>> The patch is not applied, can you please rebase and send it again.
>>>>>>>>>
>>>>>>>>> On Thu, Aug 20, 2020 at 3:58 PM Pradip Parkale <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>> Hi Hackers,
>>>>>>>>>>
>>>>>>>>>> Please find the attached patch for the shared server
>>>>>>>>>> implementation.
>>>>>>>>>>
>>>>>>>>>> Few key points:
>>>>>>>>>>
>>>>>>>>>> 1. The admin who is the owner of the server user can share
>>>>>>>>>> the server with other users.
>>>>>>>>>> 2. This option will be available only for admin users.
>>>>>>>>>> 3. If the user doesn't want to see the shared server then the
>>>>>>>>>> option to hide the shared server is available in preferences.
>>>>>>>>>> 4. The user who is not the owner of the server, can't delete
>>>>>>>>>> the shared server and server group.
>>>>>>>>>> 5. This option is only available in server mode.
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Thanks & Regards,
>>>>>>>>>> Pradip Parkale
>>>>>>>>>> Software Engineer | EnterpriseDB Corporation
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> *Thanks & Regards*
>>>>>>>>> *Akshay Joshi*
>>>>>>>>> *pgAdmin Hacker | Sr. Software Architect*
>>>>>>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>>>>>>
>>>>>>>>> *Mobile: +91 976-788-8246*
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Thanks & Regards,
>>>>>>>> Pradip Parkale
>>>>>>>> Software Engineer | EnterpriseDB Corporation
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> *Thanks & Regards*
>>>>>>> *Akshay Joshi*
>>>>>>> *pgAdmin Hacker | Sr. Software Architect*
>>>>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>>>>
>>>>>>> *Mobile: +91 976-788-8246*
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Thanks & Regards,
>>>>>> Pradip Parkale
>>>>>> Software Engineer | EnterpriseDB Corporation
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Thanks & Regards*
>>>>> *Akshay Joshi*
>>>>> *pgAdmin Hacker | Sr. Software Architect*
>>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>>
>>>>> *Mobile: +91 976-788-8246*
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanks & Regards,
>>>> Pradip Parkale
>>>> Software Engineer | EnterpriseDB Corporation
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>> *pgAdmin Hacker | Sr. Software Architect*
>>> *EDB Postgres <http://edbpostgres.com>*
>>>
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> Thanks & Regards,
>> Pradip Parkale
>> Software Engineer | EnterpriseDB Corporation
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
> *pgAdmin Hacker | Sr. Software Architect*
> *EDB Postgres <http://edbpostgres.com>*
>
> *Mobile: +91 976-788-8246*
>
--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Attachments:
[image/png] Screenshot 2020-08-25 at 4.30.22 PM.png (70.2K, 3-Screenshot%202020-08-25%20at%204.30.22%20PM.png)
download | view image
[image/png] Screenshot 2020-08-25 at 4.38.32 PM.png (52.9K, 4-Screenshot%202020-08-25%20at%204.38.32%20PM.png)
download | view image
[application/octet-stream] shared-server-icon-issue.patch (2.0K, 5-shared-server-icon-issue.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/static/js/server.js b/web/pgadmin/browser/server_groups/servers/static/js/server.js
index e48524924..e361c3839 100644
--- a/web/pgadmin/browser/server_groups/servers/static/js/server.js
+++ b/web/pgadmin/browser/server_groups/servers/static/js/server.js
@@ -238,7 +238,7 @@ define('pgadmin.node.server', [
d = t.itemData(i);
t.removeIcon(i);
d.connected = false;
- if (d.shared){
+ if (d.shared && pgAdmin.server_mode == 'True'){
d.icon = 'icon-shared-server-not-connected';
}else{
d.icon = 'icon-server-not-connected';
@@ -1238,7 +1238,7 @@ define('pgadmin.node.server', [
// Let's not change the status of the tree node now.
if (!_wasConnected) {
tree.setInode(_item);
- if (data.shared){
+ if (data.shared && pgAdmin.server_mode == 'True'){
tree.addIcon(_item, {icon: 'icon-shared-server-not-connected'});
}else{
tree.addIcon(_item, {icon: 'icon-server-not-connected'});
@@ -1400,7 +1400,7 @@ define('pgadmin.node.server', [
_tree.unload(_item);
_tree.setInode(_item);
_tree.removeIcon(_item);
- if (_data.shared){
+ if (_data.shared && pgAdmin.server_mode == 'True'){
_tree.addIcon(_item, {icon: 'icon-shared-server-not-connected'});
}else{
_tree.addIcon(_item, {icon: 'icon-server-not-connected'});
@@ -1470,7 +1470,7 @@ define('pgadmin.node.server', [
})
.fail(function(xhr, status, error) {
tree.setInode(item);
- if (data.shared){
+ if (data.shared && pgAdmin.server_mode == 'True'){
tree.addIcon(item, {icon: 'icon-shared-server-not-connected'});
}else{
tree.addIcon(item, {icon: 'icon-server-not-connected'});
view thread (13+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: [pgAdmin][RM4979]: Configuration files for data sources or similar.
In-Reply-To: <CAJ9T6SvotUdn9azRcUXoj-51wt9_NVm+eHDNkGgz4nei4OzCnw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox