Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bx6Li-0007E6-Ep for pgadmin-hackers@arkaria.postgresql.org; Thu, 20 Oct 2016 05:57:06 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bx6Lh-0003oX-W6 for pgadmin-hackers@arkaria.postgresql.org; Thu, 20 Oct 2016 05:57:06 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bx6LT-0003a3-3w for pgadmin-hackers@postgresql.org; Thu, 20 Oct 2016 05:56:51 +0000 Received: from mail-lf0-x231.google.com ([2a00:1450:4010:c07::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bx6LN-0001iw-M2 for pgadmin-hackers@postgresql.org; Thu, 20 Oct 2016 05:56:49 +0000 Received: by mail-lf0-x231.google.com with SMTP id x79so68738848lff.0 for ; Wed, 19 Oct 2016 22:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=WAPR8ULkPYo8kVZ1JGpL/IuI2iydKf4fzGIzwln6dh4=; b=zyrh21FcDbe8NrIP4rmAkOn3ruSKxEGj0zsFGbjtUTTbMLSIs/g3HtTcnrVbfs7QFa prXAVdpcfY1HIJS84a0MhuHrlMXAtaNw0F3gk6vEaMT+Nc5TL6oLFCtdjy/T7miBnUxP lsqrMsol4mfQxW5SR8baFZ+SIMsmtXcPyrtAkvHVgXN7p3LBHG/CjlmIn/6y4qT4ZDSV TfJgKvjpaTyRvP9RLe8qzy/15IHB+A07x+OSHSY7EADUEMM2o5wTHtUUXFgrWPhdt8la My/IG5aoaJKjgEBlRZD4xJ+Tv2SJ38dEbYK2J7asNLZdEGKlhJa5STWeyPl5xSJZb9oE LJlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WAPR8ULkPYo8kVZ1JGpL/IuI2iydKf4fzGIzwln6dh4=; b=a6ipuf9bxT/tqXlSYZUNzW+IdRJSMDaZJKpIvO2vaFBhPDDvBlhXGv5fjap4KakRTy rpsyFcvVja2yl/isz5QEUl4WBZBSKlVqAmF6Ak4HhPrzcQ4Kzr2MDIrgqQdOklxcHNvU tSqrb+j7baCMc+98YyqPvBZDItDbB2ieifxL/dZcLoUS9DHghEPm7Upi1PXI/YsO5lY8 TK5LY7+YqrRZEVveQhHZIn90w3bSOAcb96KWc+QXcn/Y5j++qM9S3PgYnLvOCXScVFu1 7FnTf+rDU1Qpfw2VmDkwm5R8DK4T3Qpx7ugRZ+9goDlz0DThhaHWbUvUtp5YEgC2zEXO tlCw== X-Gm-Message-State: AA6/9RmI35vSS73CX1Xd/Cr/boZavkEYNyUs5E6cLHqwGzymCwMFetmK/iqp/NGENQgBnioDvJMRJJABZDiZk8XZ X-Received: by 10.25.12.78 with SMTP id 75mr10097750lfm.177.1476943003615; Wed, 19 Oct 2016 22:56:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.92.219 with HTTP; Wed, 19 Oct 2016 22:56:42 -0700 (PDT) In-Reply-To: References: From: Fahar Abbas Date: Thu, 20 Oct 2016 10:56:42 +0500 Message-ID: Subject: Re: RM1849: Auto-generating security keys To: Murtuza Zabuawala Cc: Dave Page , Ashesh Vashi , pgadmin-hackers , Josh Berkus , =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= , Magnus Hagander , Sandeep Thakkar , Hamid Quddus Akhtar Content-Type: multipart/alternative; boundary=001a113eb1fc158faa053f45970d X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113eb1fc158faa053f45970d Content-Type: text/plain; charset=UTF-8 Murtaza, I have applied this patch and there is no success on new pgAdmin4 setup as well as existing pgAdmin4 setup. On Thu, Oct 20, 2016 at 10:45 AM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hi, > > PFA patch to fix the issue for Pyhton3. > RM#1849 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Thu, Oct 20, 2016 at 11:03 AM, Fahar Abbas < > fahar.abbas@enterprisedb.com> wrote: > >> Hi Dave, >> >> I have reopened following RM: >> ================================ >> https://redmine.postgresql.org/issues/1849 >> >> On Wed, Oct 19, 2016 at 6:04 PM, Dave Page wrote: >> >>> Patch applied. >>> >>> On Wed, Oct 19, 2016 at 11:55 AM, Ashesh Vashi < >>> ashesh.vashi@enterprisedb.com> wrote: >>> >>>> Hi Fahar, >>>> >>>> Please log the case on redmine. >>>> Please find the attached patch, please apply it locally, and test it. >>>> >>>> And, please update the case, and this mail chain accordingly. >>>> >>>> -- >>>> >>>> Thanks & Regards, >>>> >>>> Ashesh Vashi >>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>> >>>> >>>> >>>> *http://www.linkedin.com/in/asheshvashi* >>>> >>>> >>>> On Wed, Oct 19, 2016 at 3:47 PM, Fahar Abbas < >>>> fahar.abbas@enterprisedb.com> wrote: >>>> >>>>> Here is the output of if we copy config_local.py and execute python >>>>> setup.py >>>>> pgAdmin 4 - Application Initialisation >>>>> ====================================== >>>>> >>>>> >>>>> The configuration database - '/home/fahar/.pgadmin/pgadmin4.db' does >>>>> not exist. >>>>> Entering initial setup mode... >>>>> NOTE: Configuring authentication for SERVER mode. >>>>> >>>>> >>>>> Enter the email address and password to use for the initial >>>>> pgAdmin user account: >>>>> >>>>> Email address: fahar.abbas@enterprisedb.com >>>>> Password: >>>>> Retype password: >>>>> Traceback (most recent call last): >>>>> File "setup.py", line 449, in >>>>> do_setup(app) >>>>> File "setup.py", line 96, in do_setup >>>>> password = encrypt_password(p1) >>>>> File "/home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.py", >>>>> line 150, in encrypt_password >>>>> signed = get_hmac(password).decode('ascii') >>>>> File "/home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.py", >>>>> line 108, in get_hmac >>>>> 'set to "%s"' % _security.password_hash) >>>>> RuntimeError: The configuration value `SECURITY_PASSWORD_SALT` must >>>>> not be None when the value of `SECURITY_PASSWORD_HASH` is set to >>>>> "pbkdf2_sha512" >>>>> python setup.py >>>>> pgAdmin 4 - Application Initialisation >>>>> ====================================== >>>>> >>>>> User can not do any setup for web based now. >>>>> >>>>> >>>>> The configuration database - '/home/fahar/.pgadmin/pgadmin4.db' does >>>>> not exist. >>>>> Entering initial setup mode... >>>>> NOTE: Configuring authentication for SERVER mode. >>>>> >>>>> >>>>> Enter the email address and password to use for the initial >>>>> pgAdmin user account: >>>>> >>>>> Email address: fahar.abbas@enterprisedb.com >>>>> Password: >>>>> Retype password: >>>>> Traceback (most recent call last): >>>>> File "setup.py", line 449, in >>>>> do_setup(app) >>>>> File "setup.py", line 96, in do_setup >>>>> password = encrypt_password(p1) >>>>> File "/home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.py", >>>>> line 150, in encrypt_password >>>>> signed = get_hmac(password).decode('ascii') >>>>> File "/home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.py", >>>>> line 108, in get_hmac >>>>> 'set to "%s"' % _security.password_hash) >>>>> RuntimeError: The configuration value `SECURITY_PASSWORD_SALT` must >>>>> not be None when the value of `SECURITY_PASSWORD_HASH` is set to >>>>> "pbkdf2_sha512" >>>>> >>>>> On Wed, Oct 19, 2016 at 3:03 PM, Fahar Abbas < >>>>> fahar.abbas@enterprisedb.com> wrote: >>>>> >>>>>> Dave, >>>>>> >>>>>> Testing Environment >>>>>> >>>>>> Ubuntu 16.04 Linux 64: >>>>>> -------------------------------- >>>>>> >>>>>> pg-AdminIV Development Environment Setup for Ubuntu : >>>>>> >>>>>> >>>>>> 1) Install GIT >>>>>> >>>>>> sudo apt-get install git >>>>>> >>>>>> 2) Install pip3 >>>>>> >>>>>> sudo apt-get install python3-pip >>>>>> >>>>>> 3) Install virtualenv >>>>>> >>>>>> sudo pip3 install virtualenv >>>>>> >>>>>> 4) install below dependency as it is required for psycopg2 & pycrypto >>>>>> module >>>>>> >>>>>> sudo apt-get install libpq-dev >>>>>> >>>>>> sudo apt-get install python3-dev >>>>>> >>>>>> 5) Create virtual environment >>>>>> >>>>>> virtualenv -p python3 venv >>>>>> >>>>>> 6) Create mkdir Projects >>>>>> >>>>>> 7) Clone git repo in Projects >>>>>> >>>>>> git clone http://git.postgresql.org/git/pgadmin4.git >>>>>> >>>>>> 8) activate virtual environment >>>>>> >>>>>> source venv/bin/activate >>>>>> >>>>>> 9) Install modules >>>>>> >>>>>> pip3 install -r requirements_py3.txt >>>>>> >>>>>> *10) Edit the config.py file to config_local.py resides in >>>>>> Projects\pgAdmin4\web * >>>>>> >>>>>> 11)Now run setup.py file (\Projects\pgAdmin4\web) >>>>>> python setup.py >>>>>> >>>>>> If user does not create config_local.py and do Python setup.py for >>>>>> new Development then SECURITY_PASSWORD_SALT message is also displayed: >>>>>> >>>>>> Here is the output: >>>>>> ------------------------- >>>>>> >>>>>> python setup.py >>>>>> pgAdmin 4 - Application Initialisation >>>>>> ====================================== >>>>>> >>>>>> >>>>>> The configuration database - '/home/fahar/.pgadmin/pgadmin4.db' does >>>>>> not exist. >>>>>> Entering initial setup mode... >>>>>> NOTE: Configuring authentication for SERVER mode. >>>>>> >>>>>> >>>>>> Enter the email address and password to use for the initial >>>>>> pgAdmin user account: >>>>>> >>>>>> Email address: fahar.abbas@enterprisedb.com >>>>>> Password: >>>>>> Retype password: >>>>>> Traceback (most recent call last): >>>>>> File "setup.py", line 449, in >>>>>> do_setup(app) >>>>>> File "setup.py", line 96, in do_setup >>>>>> password = encrypt_password(p1) >>>>>> File "/home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.py", >>>>>> line 150, in encrypt_password >>>>>> signed = get_hmac(password).decode('ascii') >>>>>> File "/home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.py", >>>>>> line 108, in get_hmac >>>>>> 'set to "%s"' % _security.password_hash) >>>>>> RuntimeError: The configuration value `SECURITY_PASSWORD_SALT` must >>>>>> not be None when the value of `SECURITY_PASSWORD_HASH` is set to >>>>>> "pbkdf2_sha512" >>>>>> (venv) fahar@fahar-virtual-machine:~/Projects/pgadmin4/web$ >>>>>> >>>>>> >>>>>> Is this expected? >>>>>> >>>>>> On Wed, Oct 19, 2016 at 1:37 PM, Fahar Abbas < >>>>>> fahar.abbas@enterprisedb.com> wrote: >>>>>> >>>>>>> Sure, >>>>>>> >>>>>>> Will test this thoroughly after complete investigation. >>>>>>> >>>>>>> Kind Regards, >>>>>>> >>>>>>> On Wed, Oct 19, 2016 at 1:27 PM, Dave Page >>>>>>> wrote: >>>>>>> >>>>>>>> Patch applied. >>>>>>>> >>>>>>>> Fahar, can you please test this thoroughly in desktop and server >>>>>>>> modes, with both fresh and upgraded installations? >>>>>>>> >>>>>>>> https://redmine.postgresql.org/issues/1849 >>>>>>>> >>>>>>>> Packagers: This change means that packages are no longer forced to >>>>>>>> create a config_local.py file, and there is no longer any need to >>>>>>>> explicitly set SECURITY_PASSWORD_SALT, SECURITY_KEY >>>>>>>> and CSRF_SESSION_KEY in the config (in fact, they should be removed for new >>>>>>>> installations, if you have included them in 1.0) >>>>>>>> >>>>>>>> Thanks. >>>>>>>> >>>>>>>> >>>>>>>> On Wed, Oct 19, 2016 at 6:46 AM, Ashesh Vashi < >>>>>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi Dave, >>>>>>>>> >>>>>>>>> On Sat, Oct 15, 2016 at 8:02 AM, Dave Page >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Friday, October 14, 2016, Dave Page wrote: >>>>>>>>>> >>>>>>>>>>> Hi >>>>>>>>>>> >>>>>>>>>>> On Thursday, October 13, 2016, Ashesh Vashi < >>>>>>>>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Dave, >>>>>>>>>>>> >>>>>>>>>>>> On Tue, Oct 11, 2016 at 9:10 PM, Dave Page >>>>>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi Ashesh, >>>>>>>>>>>>> >>>>>>>>>>>>> Can you please review the attached patch, and apply if you're >>>>>>>>>>>>> happy with it? >>>>>>>>>>>>> >>>>>>>>>>>> Overall the patch looked good to me. >>>>>>>>>>>> But - I encounter an issue in 'web' mode, which wont happen >>>>>>>>>>>> with 'runtime'. >>>>>>>>>>>> >>>>>>>>>>>> Steps for reproduction on existing pgAdmin 4 environment with >>>>>>>>>>>> 'web' mode. >>>>>>>>>>>> - Apply the patch >>>>>>>>>>>> - Start the pgAdmin4 application (stand alone application). >>>>>>>>>>>> - Open pgAdmin home page. >>>>>>>>>>>> - Log out (if already login). >>>>>>>>>>>> >>>>>>>>>>>> And, you will see an exception. >>>>>>>>>>>> >>>>>>>>>>>> I have figure out the issue with the patch. >>>>>>>>>>>> We were setting the SECURITY_PASSWORD_SALT, after initializing >>>>>>>>>>>> the Security object. >>>>>>>>>>>> Hence - it could not set the SECURITY_KEY, and >>>>>>>>>>>> SECURITY_PASSWORD_SALT properly. >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Hmm. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> I had moved the Security object initialization after fetching >>>>>>>>>>>> these configurations from the database. >>>>>>>>>>>> I have attached a addon patch for the same. >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> OK, thanks. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Now - I run into another issue. >>>>>>>>>>>> Because - the existing password was hashed using the old >>>>>>>>>>>> SECURITY_PASSWORD_SALT, I am no more able to login to pgAdmin 4. >>>>>>>>>>>> >>>>>>>>>>>> I think - we need to think about different strategy for >>>>>>>>>>>> upgrading the configuration file in the 'web' mode. >>>>>>>>>>>> I was thinking - we can store the existing security >>>>>>>>>>>> configurations in the database during upgrade process in 'web' mode. >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> My concern with that is that we'll likely be storing the default >>>>>>>>>>> config values in many cases, thus for those users, perpetuating the problem. >>>>>>>>>>> >>>>>>>>>>> I guess what we need to do is re-encrypt the password during the >>>>>>>>>>> upgrade - however, that makes me think; we then have both the key and the >>>>>>>>>>> encrypted passwords in the same database which is clearly not a good idea. >>>>>>>>>>> Sigh... Needs more thought. >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> OK, so I've been thinking about this and experimenting for a >>>>>>>>>> couple of hours, as well as annoying the crap out of Magnus by thinking out >>>>>>>>>> loud in his general direction, and it looks like this isn't a major problem >>>>>>>>>> as from what I can see, SECURITY_PASSWORD_SALT is (aside from really being >>>>>>>>>> a key not a salt) not the only salting that's done. >>>>>>>>>> >>>>>>>>>> It looks like it's used system-wide as the key to generate an >>>>>>>>>> HMAC of the users password, which is then passed to passlib which salts and >>>>>>>>>> hashes it. I did some testing, and found that two users with the same >>>>>>>>>> password end up with different hashes in the database, so clearly there is >>>>>>>>>> also per-user salting happening. I also created two users, then dropped the >>>>>>>>>> database and created the same user accounts with the same passwords again, >>>>>>>>>> and found that the resulting hashes were different in both databases - thus >>>>>>>>>> there is something else ensuring the hashes are unique across different >>>>>>>>>> installations/databases. >>>>>>>>>> >>>>>>>>>> So, I believe we can do as you suggest and migrate existing >>>>>>>>>> values for SECURITY_PASSWORD_SALT, given that there's clearly some other >>>>>>>>>> per user and per installation/database salting going on anyway. New >>>>>>>>>> installations can have the random value for SECURITY_PASSWORD_SALT. >>>>>>>>>> >>>>>>>>> We do not need to generate the random SECURITY_PASSWORD_SALT >>>>>>>>> during upgrade mode, which was wrong added in my addon patch. >>>>>>>>> >>>>>>>>> Please find the updated patch. >>>>>>>>> >>>>>>>>> Otherwise - looks good to me. >>>>>>>>> Please commit the new patch (if you're ok with the change). >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> >>>>>>>>> Thanks & Regards, >>>>>>>>> >>>>>>>>> Ashesh Vashi >>>>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>>>>> >>>>>>>>> >>>>>>>>>> >>>>>>>>>> I don't believe SECURITY_KEY and CSRF_SESSION_KEY are issues >>>>>>>>>> either, as they're used for purposes that are essentially ephemeral, and >>>>>>>>>> thus can be changed during an upgrade. >>>>>>>>>> >>>>>>>>>> Adding Magnus as I'd appreciate any thoughts he may have. >>>>>>>>>> >>>>>>>>>> Patch attached - please review (Ashesh, but others too would be >>>>>>>>>> appreciated)! >>>>>>>>>> >>>>>>>>>> Thanks. >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Dave Page >>>>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>>>> Twitter: @pgsnake >>>>>>>>>> >>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>>>> The Enterprise PostgreSQL Company >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>> Twitter: @pgsnake >>>>>>>> >>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Syed Fahar Abbas >>>>>>> Quality Management Group >>>>>>> >>>>>>> EnterpriseDB Corporation >>>>>>> Phone Office: +92-51-835-8874 >>>>>>> Phone Direct: +92-51-8466803 >>>>>>> Mobile: +92-333-5409707 >>>>>>> Skype ID: syed.fahar.abbas >>>>>>> Website: www.enterprisedb.com >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Syed Fahar Abbas >>>>>> Quality Management Group >>>>>> >>>>>> EnterpriseDB Corporation >>>>>> Phone Office: +92-51-835-8874 >>>>>> Phone Direct: +92-51-8466803 >>>>>> Mobile: +92-333-5409707 >>>>>> Skype ID: syed.fahar.abbas >>>>>> Website: www.enterprisedb.com >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Syed Fahar Abbas >>>>> Quality Management Group >>>>> >>>>> EnterpriseDB Corporation >>>>> Phone Office: +92-51-835-8874 >>>>> Phone Direct: +92-51-8466803 >>>>> Mobile: +92-333-5409707 >>>>> Skype ID: syed.fahar.abbas >>>>> Website: www.enterprisedb.com >>>>> >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> >> -- >> Syed Fahar Abbas >> Quality Management Group >> >> EnterpriseDB Corporation >> Phone Office: +92-51-835-8874 >> Phone Direct: +92-51-8466803 >> Mobile: +92-333-5409707 >> Skype ID: syed.fahar.abbas >> Website: www.enterprisedb.com >> > > -- Syed Fahar Abbas Quality Management Group EnterpriseDB Corporation Phone Office: +92-51-835-8874 Phone Direct: +92-51-8466803 Mobile: +92-333-5409707 Skype ID: syed.fahar.abbas Website: www.enterprisedb.com --001a113eb1fc158faa053f45970d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Murtaza,

I have applied this patch and t= here is no success on new pgAdmin4 setup as well as existing pgAdmin4 setup= .

On Thu= , Oct 20, 2016 at 10:45 AM, Murtuza Zabuawala <murtuza.za= buawala@enterprisedb.com> wrote:
Hi,

PFA patch to fix the issue fo= r Pyhton3.
RM#1849

--
<= span style=3D"color:rgb(136,136,136)">Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com=
The Enterprise PostgreSQL Company

On Thu, Oct 20, 2016 at 11:03 AM, Fahar Abba= s <fahar.abbas@enterprisedb.com> wrote:
Hi Dave,

I have reopened f= ollowing RM:
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
https://redmine.postgresql.or= g/issues/1849

On Wed, Oct 19, 2016 at 6:04 PM, Dave Page <dpage@pgadmin= .org> wrote:
Patch applied.
<= div class=3D"gmail_extra">
On Wed, Oct 19, 20= 16 at 11:55 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Fahar,

Please log the case on redmine.
Ple= ase find the attached patch, please apply it locally, and test it.

And, please update the case, and this mail chain according= ly.

--

Thanks & Regards,

Ashesh Vashi<= /span>
Ent= erpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Wed, Oct 19, 2016 at 3= :47 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Here is th= e output of if we copy config_local.py and execute python setup.pypgAdmin 4 - Application Initialisation
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D


The configuration database - '/home/fahar/.p= gadmin/pgadmin4.db' does not exist.
Entering initial setup mode= ...
NOTE: Configuring authentication for SERVER mode.


=C2=A0= =C2=A0=C2=A0 Enter the email address and password to use for the initial pg= Admin user=C2=A0=C2=A0=C2=A0=C2=A0 account:

Email address: fahar.abbas@ente= rprisedb.com
Password:
Retype password:
Traceback (most recen= t call last):
=C2=A0 File "setup.py", line 449, in <module&= gt;
=C2=A0=C2=A0=C2=A0 do_setup(app)
=C2=A0 File "setup.py"= , line 96, in do_setup
=C2=A0=C2=A0=C2=A0 password =3D encrypt_password(= p1)
=C2=A0 File "/home/fahar/venv/lib/python3.5/site-packages/= flask_security/utils.py", line 150, in encrypt_password
=C2=A0= =C2=A0=C2=A0 signed =3D get_hmac(password).decode('ascii')
= =C2=A0 File "/home/fahar/venv/lib/python3.5/site-packages/flask_s= ecurity/utils.py", line 108, in get_hmac
=C2=A0=C2=A0=C2=A0 &#= 39;set to "%s"' % _security.password_hash)
RuntimeError: T= he configuration value `SECURITY_PASSWORD_SALT` must not be None when the v= alue of `SECURITY_PASSWORD_HASH` is set to "pbkdf2_sha512"
pyt= hon setup.py
pgAdmin 4 - Application Initialisation
=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D

User can not do any setup= for web based now.


The configuration database - '= ;/home/fahar/.pgadmin/pgadmin4.db' does not exist.
Entering ini= tial setup mode...
NOTE: Configuring authentication for SERVER mode.
=

=C2=A0=C2=A0=C2=A0 Enter the email address and password to use for = the initial pgAdmin user=C2=A0=C2=A0=C2=A0=C2=A0 account:

Email addr= ess: faha= r.abbas@enterprisedb.com
Password:
Retype password:
Traceback= (most recent call last):
=C2=A0 File "setup.py", line 449, in= <module>
=C2=A0=C2=A0=C2=A0 do_setup(app)
=C2=A0 File "se= tup.py", line 96, in do_setup
=C2=A0=C2=A0=C2=A0 password =3D encry= pt_password(p1)
=C2=A0 File "/home/fahar/venv/lib/python3.5/si= te-packages/flask_security/utils.py", line 150, in encrypt_passwo= rd
=C2=A0=C2=A0=C2=A0 signed =3D get_hmac(password).decode('asc= ii')
=C2=A0 File "/home/fahar/venv/lib/python3.5/site-pack= ages/flask_security/utils.py", line 108, in get_hmac
=C2=A0=C2= =A0=C2=A0 'set to "%s"' % _security.password_hash)
Run= timeError: The configuration value `SECURITY_PASSWORD_SALT` must not be Non= e when the value of `SECURITY_PASSWORD_HASH` is set to "pbkdf2_sha512&= quot;

On= Wed, Oct 19, 2016 at 3:03 PM, Fahar Abbas <fahar.abbas@enterpr= isedb.com> wrote:
Dave,

Testing Environment
=C2= =A0
Ubuntu 16.04 Linux 64:
-------------------------------= -

pg-AdminIV Developmen= t Environment Setup for Ubuntu=C2=A0 :


1) Install GIT

sudo apt-get install git

2) Install pip3=

sudo apt-get insta= ll python3-pip

3) Install virtualenv

sudo pip3 install virtualenv

4) install below dependency as it is required= for psycopg2 & pycrypto module

sudo apt-get install libpq-dev

=

= sudo apt-get install python3-= dev

5) Creat= e virtual environment

virtualenv -p python3 venv

6) Create mkdir Projects

7) Clone git repo in Projects

git clone http://git.pos= tgresql.org/git/pgadmin4.git

8) activate virtual environment=

source venv/bin/ac= tivate

9) In= stall modules

pip3 install -r requirements_py3.txt

10) Edit the con= fig.py file to config_local.py =C2=A0resides in Projects\pgAdmin= 4\web=C2=A0=C2=A0

11)= Now run setup.py file =C2=A0(\Projects\pgAdmin4\web)

=C2=A0 =C2=A0 python set= up.py

If user does not create config_local.py and do= Python setup.py for new Development then SECURITY_PASSWORD_SALT message is= also displayed:

Here is the output:
-----------------= --------

python setup.py
pgAdmin 4 - Application Init= ialisation
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D


The = configuration database - '/home/fahar/.pgadmin/pgadmin4.db' do= es not exist.
Entering initial setup mode...
NOTE: Configuring authen= tication for SERVER mode.


=C2=A0=C2=A0=C2=A0 Enter the email add= ress and password to use for the initial pgAdmin user=C2=A0=C2=A0=C2=A0=C2= =A0 account:

Email address: fahar.abbas@enterprisedb.com
Password: Retype password:
Traceback (most recent call last):
=C2=A0 File &quo= t;setup.py", line 449, in <module>
=C2=A0=C2=A0=C2=A0 do_setu= p(app)
=C2=A0 File "setup.py", line 96, in do_setup
=C2=A0= =C2=A0=C2=A0 password =3D encrypt_password(p1)
=C2=A0 File "/home/f= ahar/venv/lib/python3.5/site-packages/flask_security/utils.py&quo= t;, line 150, in encrypt_password
=C2=A0=C2=A0=C2=A0 signed =3D get_hmac= (password).decode('ascii')
=C2=A0 File "/home/fahar/ve= nv/lib/python3.5/site-packages/flask_security/utils.py", lin= e 108, in get_hmac
=C2=A0=C2=A0=C2=A0 'set to "%s"' % = _security.password_hash)
RuntimeError: The configuration value `SECURITY= _PASSWORD_SALT` must not be None when the value of `SECURITY_PASSWORD_HASH`= is set to "pbkdf2_sha512"
(venv) fahar@fahar-virtual-machine:= ~/Projects/pgadmin4/web$


=
Is this expected?

On Wed, Oct 19, 2016 at 1:37 PM, Fahar Abbas <fahar.abbas@enterprisedb.com> wrote:
Sure,

Will test th= is thoroughly after complete investigation.

Kind Regards,
<= /div>

On Wed, Oc= t 19, 2016 at 1:27 PM, Dave Page <dpage@pgadmin.org> wrote:<= br>
Patch applied.

<= /div>
Fahar, can you please test this thoroughly in desktop and server = modes, with both fresh and upgraded installations?

h= ttps://redmine.postgresql.org/issues/1849

Packagers: This change means that packages are no longer forced to create = a config_local.py file, and there is no longer any need to explicitly set= =C2=A0SECURITY_PASSWORD_SALT,=C2=A0= SECURITY_KEY and=C2=A0CSRF_SESSION_KE= Y in the config (in fact, they should be removed for new installations, if = you have included them in 1.0)

Thanks.
=


On Wed, Oct 19, 2016 at 6:46 AM, Ashesh Vashi <<= a href=3D"mailto:ashesh.vashi@enterprisedb.com" target=3D"_blank">ashesh.va= shi@enterprisedb.com> wrote:
Hi Dave,

On Sat, Oct 15, 2016 at 8:02 AM, Dave Page <dpage@p= gadmin.org> wrote:
Hi


On Friday, October 14, 2016, Dave Page <dpage@pgadmin.org> w= rote:
Hi

On Thu= rsday, October 13, 2016, Ashesh Vashi <ashesh.vashi@enterprisedb.com<= /a>> wrote:
Hi Dave,

On Tue, Oct 11, 2016 at 9:10 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi Ashesh,

Can you please re= view the attached patch, and apply if you're happy with it?
Overall the patch looked good to me.
But - I encounte= r an issue in 'web' mode, which wont happen with 'runtime'.=

Steps for reproduction on existing pgAdmin 4 envi= ronment with 'web' mode.
- Apply the patch
- St= art the pgAdmin4 application (stand alone application).
- Open pg= Admin home page.
- Log out (if already login).

And, you will see an exception.

I have figu= re out the issue with the patch.
We were setting the SECURITY_PAS= SWORD_SALT, after initializing the Security object.
Hence - it co= uld not set the SECURITY_KEY, and SECURITY_PASSWORD_SALT properly.

Hmm.
=C2=A0
=

I had mov= ed the Security object initialization after fetching these configurations f= rom the database.
I have attached a addon patch for the same.

OK, thanks.
= =C2=A0

Now - I run into another issue.
Because - the existing passwor= d was hashed using the old SECURITY_PASSWORD_SALT, I am no more able to log= in to pgAdmin 4.

I think - we need to think about = different strategy for upgrading the configuration file in the 'web'= ; mode.
I was thinking - we can store the existing security confi= gurations in the database during upgrade process in 'web' mode.

My concern with that i= s that we'll likely be storing the default config values in many cases,= thus for those users, perpetuating the problem.

I= guess what we need to do is re-encrypt the password during the upgrade - h= owever, that makes me think; we then have both the key and the encrypted pa= sswords in the same database which is clearly not a good idea. Sigh... Need= s more thought.=C2=A0

OK,= so I've been thinking about this and experimenting for a couple of hou= rs, as well as annoying the crap out of Magnus by thinking out loud in his = general direction, and it looks like this isn't a major problem as from= what I can see, =C2=A0SECURITY_PASSWORD_SALT is (aside from really being a= key not a salt) not the only salting that's done.=C2=A0

=
It looks like it's used system-wide as the key to generate a= n HMAC of the users password, which is then passed to passlib which salts a= nd hashes it. I did some testing, and found that two users with the same pa= ssword end up with different hashes in the database, so clearly there is al= so per-user salting happening. I also created two users, then dropped the d= atabase and created the same user accounts with the same passwords again, a= nd found that the resulting hashes were different in both databases - thus = there is something else ensuring the hashes are unique across different ins= tallations/databases.

So, I believe we can do as y= ou suggest and migrate existing values for SECURITY_PASSWORD_SALT, given th= at there's clearly some other per user and per installation/database sa= lting going on anyway. New installations can have the random value for SECU= RITY_PASSWORD_SALT.
We do not need to ge= nerate the random SECURITY_PASSWORD_SALT during upgrade mode, which was wro= ng added in my addon patch.

Please find the update= d patch.

Otherwise - looks good to me.
P= lease commit the new patch (if you're ok with the change).


--<= /p>

Thanks & Regards,

Ashesh= Vashi
EnterpriseDB INDIA:=C2=A0Enterprise PostgreSQL Company



I don't believe SECURITY_KEY and=C2=A0CSRF_SESSION_KEY= are issues either, as they're used for purposes that are essentially e= phemeral, and thus can be changed during an upgrade.

Adding Magnus as I'd appreciate any thoughts he may have.
=
Patch attached - please review (Ashesh, but others too would= be appreciated)!

Thanks.


--
Dave= Page
Blog: ht= tp://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: = http://www.enterp= risedb.com
The Enterprise PostgreSQL Company





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterp= rise PostgreSQL Company



--
Syed Fahar Abbas
Quality Managem= ent Group

EnterpriseDB Corporation
Phone Office: +92-51-835= -8874
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com



--
Syed Fahar Abbas
= Quality Management Group

EnterpriseDB Corporation
Phone Off= ice: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-33= 3-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com



--
Syed Fahar Abbas
Quality Management Gr= oup

EnterpriseDB Corporation
Phone Office: +92-51-835-8874=
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Skyp= e ID: syed.fahar.abbas
Website: www.enterprisedb.com




--
Dave Page
Blog: http://pgsnake.blogspot.com
Tw= itter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Po= stgreSQL Company


--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
P= hone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: = +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com
<= /div>




--
Syed Fahar= Abbas
Quality Management Group

EnterpriseDB Cor= poration
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com=
--001a113eb1fc158faa053f45970d--