Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQogz-0000nd-2t for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jun 2018 06:46:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fQogx-0001Kh-Pv for pgadmin-hackers@arkaria.postgresql.org; Thu, 07 Jun 2018 06:46:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fQogx-0001KX-Jc for pgadmin-hackers@lists.postgresql.org; Thu, 07 Jun 2018 06:46:39 +0000 Received: from mail-lf0-x236.google.com ([2a00:1450:4010:c07::236]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fQogp-0003NI-2j for pgadmin-hackers@postgresql.org; Thu, 07 Jun 2018 06:46:38 +0000 Received: by mail-lf0-x236.google.com with SMTP id y20-v6so12916750lfy.0 for ; Wed, 06 Jun 2018 23:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=iFR1vRsVWiTfK4AO0w7WixaTfZ+IgghYAVczu00lUNk=; b=GWi1vlAXh4+vCyNBJvhTSd9xohtfrKuBgLfHAi0SlFqlMWQu/v/FaJMm1FxsOycoRa zacmvwI4p4/Mt1T9lWDLEBKgnIEnN2OqbsmaR4kLkjMYd+e1hjVSu7wxoVuuqV7r4War mo1zGahy2DKQKTLqMh0O51e5jSunBy1TPREhyA8HT40VThWnEvkQQMm8Ot258gRg/cQx +TGpyvT9bL6tpIV02+1SpmkkC5XNIXnwQi6ne258yIsulHQbgnS9kpyVMJayJdqI2SAp zw18+ecI1Vq2JMboP285wT1Bh5u/BQBLxCt9VcOr1J5urLLMoAn+Sxcn5KcCrbY9W5ty HCuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=iFR1vRsVWiTfK4AO0w7WixaTfZ+IgghYAVczu00lUNk=; b=MSbHe/pEY3OZqsvxKMeiV7M2W9Ip3UEpoNbErfnvVzBxvmhS8w2NR+UbAeorlJtDaW erNDD8o+w27U1DyQSdSsWnAYoHEHBpAqYaabDaSR2ibbKjhRx7FhjOkwrLrG4AjrTJLZ f2G3aZNbNlzygvYxeXjYFj1advKQltnq/XdTg4KvFOQclNk3azdG59ZXwkr0MPYym7bi Sfr4DnZ3kjifB8/sHiXW1dvuPmdAD9OPs31yXxkBRqzhjEDS2F6gzaB0TLD7ReYAMN/B 5CuOrcS5SPvFzpP0hvypPGWEzZNi9HVVMUYdGy+DTTOZpSxIWkU/lrRhHL+6hkOg3zZv BNxg== X-Gm-Message-State: APt69E2uQzVEHfxHsY3Q2Cd+GxUfnVlNEmY1F00Lq+yxZTwipLxv4Ezc aHa+G7BBLD7qN9qykNKT16aty9zoF5FgdXFbV1oy3g== X-Google-Smtp-Source: ADUXVKJ83YTt9lad6rTpjLBt4oOO/G/YRrVeaIZx8viz/xwhX8L4f1NxCU2zSLQAxf0Jc7ePPFZ+93p5JQfxNqXuo3k= X-Received: by 2002:a2e:1092:: with SMTP id 18-v6mr513866ljq.115.1528353989830; Wed, 06 Jun 2018 23:46:29 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:978b:0:0:0:0:0 with HTTP; Wed, 6 Jun 2018 23:46:29 -0700 (PDT) In-Reply-To: References: From: Fahar Abbas Date: Thu, 7 Jun 2018 11:46:29 +0500 Message-ID: Subject: Re: pgAgent 4.0 patch To: Paresh More Cc: Ashesh Vashi , pgadmin-hackers , Dave Page Content-Type: multipart/alternative; boundary="000000000000a7c480056e07a41b" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000a7c480056e07a41b Content-Type: text/plain; charset="UTF-8" Hi Paresh, Thanks for sharing pgagent linux64 installers. On Thu, Jun 7, 2018 at 11:39 AM, Paresh More wrote: > Hello Fahar, > > File, pgagent-4.0.0-1-linux-x64.run is uploaded @ https://uploads. > enterprisedb.com/download.php?file=bd89aec08d73ceae21cf560c391598f6 > > On Tue, Jun 5, 2018 at 3:10 PM, Dave Page wrote: > >> Thanks, committed with those changes. >> >> Paresh; can you please create some pgAgent 4.0 installers (PG not EPAS >> Bitrock installers) from git head for Fahar to test? >> >> Once he's happy with them, I'll tag and build the community packages. >> >> Thanks! >> >> On Tue, Jun 5, 2018 at 5:07 AM, Ashesh Vashi < >> ashesh.vashi@enterprisedb.com> wrote: >> >>> On Mon, Jun 4, 2018 at 10:04 PM, Dave Page wrote: >>> >>>> Hi >>>> >>>> Can you review the attached please Ashesh? >>>> >>> Hi Dave, >>> >>> Due to the wrong pattern in '.gitignore', it was ignoring the new file >>> 'sql/pgagent--3.4--4.0.sql'. >>> We should ignore only the '*.sql' in the root directory. >>> Something like this. >>> >>> *$ git diff .gitignore* >>> *diff --git a/.gitignore b/.gitignore* >>> *index 9883354..40fe7a9 100644* >>> *--- a/.gitignore* >>> *+++ b/.gitignore* >>> *@@ -6,7 +6,12 @@ CPackSourceConfig.cmake* >>> * Makefile* >>> * cmake_install.cmake* >>> * install_manifest.txt* >>> *-pgagent* >>> *+# Ignore 'pgagent' & 'pgagent.control' in root directory only.* >>> *+/pgagent* >>> *+!/*/pgagent* >>> * pgagent.control* >>> *+!/*/pgagent.control* >>> * *.log* >>> *-*.sql* >>> *+# Ignore '*.sql' files in root directory only.* >>> *+/*.sql* >>> *+!/*/*.sql* >>> >>> >>> And, I am getting the following warning applying the patch. >>> >>> *$ git apply ~/Downloads/pgagent-4.0-update.diff* >>> */Users/asheshvashi/Downloads/pgagent-4.0-update.diff:320: trailing >>> whitespace.* >>> *//* >>> *warning: 1 line adds whitespace errors.* >>> >>> >>> Otherwise - it looks good to me. >>> >>> -- >>> >>> Thanks & Regards, >>> >>> Ashesh Vashi >>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>> >>> >>> >>> *http://www.linkedin.com/in/asheshvashi >>> * >>> >>>> >>>> Thanks. >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > > Thanks & Regards > > *Paresh More* > > [image: NEW-EDB-logo-4c] > > Pune, India. > Cell : +919922000564 | www.enterprisedb.com > -- Fahar Abbas QMG EnterpriseDB Corporation Phone Office: +92-51-835-8874 Phone Direct: +92-51-8466803 Mobile: +92-333-5409707 Skype ID: syed.fahar.abbas Website: www.enterprisedb.com --000000000000a7c480056e07a41b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Paresh,

Thanks for sharin= g pgagent linux64 installers.
On Thu, Jun 7, 2018 at 11:39 AM, Paresh More <paresh.more@enterprisedb.com> wrote:
Hello Fahar,

File= , pgagent-4.0.0-1-linux-x64.run is uploaded @=C2=A0=C2=A0https://uploads.enterprisedb.com/download.php?fi= le=3Dbd89aec08d73ceae21cf560c391598f6

O= n Tue, Jun 5, 2018 at 3:10 PM, Dave Page <dpage@pgadmin= .org> wrote:
Thanks, committed with those changes.

Paresh; can you= please create some pgAgent 4.0 installers (PG not EPAS Bitrock installers)= from git head for Fahar to test?

Once he's ha= ppy with them, I'll tag and build the community packages.
Thanks!

On Tue, Ju= n 5, 2018 at 5:07 AM, Ashesh Vashi <ashesh.= vashi@enterprisedb.com> wrote:
On Mon, Jun 4, 2018 at 10:04 PM, Dave = Page <dpage@pgadmin.org> wrote:
=
Hi

= Can you review the attached please Ashesh?
Hi Dave,

Due to the wrong pattern in '.gitignore', it was ignoring t= he new file 'sql/pgagent--3.4--4.0.sql'.
We should ignore only the '*.sql' in the root di= rectory.
Something like this.<= /div>
$=C2=A0git di= ff .gitignore
di= ff --git a/.gitignore b/.gitignore
index 9883354..40fe7a9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -6,7 +6,12 @@ CPackSourceConfig.cmake=
=C2=A0Makefile<= /font>
=C2=A0cmake_inst= all.cmake
=C2=A0= install_manifest.txt
-pgagent
+#= Ignore 'pgagent' & 'pgagent.control' in root directory= only.
+/pgagent=
+!/*/pgagent
=C2=A0pgagent.cont= rol
+!/*/pgagent= .control
=C2=A0*= .log
-*.sql
+# Ignore '*.sql= ' files in root directory only.
+/*.sql
+!/*/*.sql

A= nd, I am getting the following warning applying the patch.
$=C2=A0git apply ~/Downloads/= pgagent-4.0-update.diff
/Users/asheshva= shi/Downloads/p<= wbr>gagent-4.0-update.diff:320: trailing whitespace.
//
<= div>warning: 1 line adds whitespace errors.

Otherwise - it looks= good to me.

=
--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA:=C2= =A0Enterprise PostgreSQL Co= mpany


http://www.link= edin.com/in/asheshvashi=C2=A0


Thanks.
=

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsna= ke

EnterpriseDB UK: http://www.enterprisedb.com
The Enterpr= ise PostgreSQL Company




--
Dave Page
Blog: http://pg= snake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http:= //www.enterprisedb.com
The Enterprise PostgreSQL Company



<= /div>--

Thanks & Regards

Paresh More

3D"NEW-EDB-logo=

Pune, India.

Cell : =C2=A0+919922000564 | =C2=A0www.enterprisedb.com


--
Fahar Abbas
QMG
EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile:= +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com
--000000000000a7c480056e07a41b--