Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwpGU-0007um-K1 for pgadmin-hackers@arkaria.postgresql.org; Wed, 19 Oct 2016 11:42:34 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bwpGU-0006yU-1u for pgadmin-hackers@arkaria.postgresql.org; Wed, 19 Oct 2016 11:42:34 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bwpGR-0006xr-P3 for pgadmin-hackers@postgresql.org; Wed, 19 Oct 2016 11:42:32 +0000 Received: from mail-lf0-x233.google.com ([2a00:1450:4010:c07::233]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bwpGJ-0006Tf-9D for pgadmin-hackers@postgresql.org; Wed, 19 Oct 2016 11:42:30 +0000 Received: by mail-lf0-x233.google.com with SMTP id l131so19622753lfl.2 for ; Wed, 19 Oct 2016 04:42:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=FEzoC7c+WW4s1d07AYZbf6ZDTAvNF6xvEtsl4iCssCc=; b=KUOKz30G4VAAiyyToKV0MoqZz3KeZB7oKvidBo0dbLSuJ+boz9bg701DcRybXRomBk TLXt+lYWn1ycfB8+0jq489CvbfndV0XHU0ux2CXqP6MR8EE/otu52D0wIEw43zccuXPB hKgynA1gICKcEGI9DzpJyM99bneGU5B0f5lgr6mz/gHyxhVdbnupIAds5YbmeaMfwSIC E7h2pylrNzWFQ6zu1Ms5TsLhT928V3wxfEzm42u9/iMQuaxRtSeniH7vQdVolzOUSuzX 3zPo5+bo8RIS86ysUwLrQWH/td7o5Xb3i/TmjeMbeDV6To2w1yf0/mLrmzKzfD60NC+a swww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=FEzoC7c+WW4s1d07AYZbf6ZDTAvNF6xvEtsl4iCssCc=; b=jadT6wCoU7o2J6eCLKJis/llPdbZKS596/wdgizuFuc8UB6LZnIKsIKqo4xlLn8+TM pP8l9arAGrJFkpC10SFoFMjbdavFGbLfSxRX4LHj5BoHcQnaWGWNpF6MpYjBE0MMN7r/ c4KFLbsvv3aWeXXIuIibng9Aao1F7pxspHcfTZnCKEGS8CHKHNVm3CRdSjDqrPK9KEc+ eNDsUDQPKViiTdxACa6UivR4+2dnfM5P0qqN4Xjlg6C1Dggqk4nfWx4iTTJlmU1KOacX THaRpFop34kjJILtuTSU/el28BurNzLy+f8lpgKfVmZuSJaGwyyWvZJG9HVsPvQ1PX+C xJfg== X-Gm-Message-State: AA6/9Rmb+U43vD64SXh5WRWpNGiUOfwV9agE+peeh2pkvTfOAaixIptoETfBaQ9WSoTK4gyB23/afJkLKErlJ8jG X-Received: by 10.25.198.209 with SMTP id w200mr4543977lff.175.1476877337410; Wed, 19 Oct 2016 04:42:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.92.219 with HTTP; Wed, 19 Oct 2016 04:42:16 -0700 (PDT) In-Reply-To: References: From: Fahar Abbas Date: Wed, 19 Oct 2016 16:42:16 +0500 Message-ID: Subject: Re: RM1849: Auto-generating security keys To: Ashesh Vashi Cc: Dave Page , pgadmin-hackers , Josh Berkus , =?UTF-8?B?RGV2cmltIEfDnE5Ew5xa?= , Magnus Hagander , Sandeep Thakkar , Hamid Quddus Akhtar Content-Type: multipart/alternative; boundary=94eb2c1a089e12d5ee053f364d8e X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --94eb2c1a089e12d5ee053f364d8e Content-Type: text/plain; charset=UTF-8 On Wed, Oct 19, 2016 at 4:03 PM, Fahar Abbas wrote: > > > On Wed, Oct 19, 2016 at 3:55 PM, Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> Hi Fahar, >> >> Please log the case on redmine. >> > https://redmine.postgresql.org/issues/1871 > >> Please find the attached patch, please apply it locally, and test it. >> >> And, please update the case, and this mail chain accordingly. >> > This is resolved now and no error message displayed when we apply the patch that is already shared. > >> Sure Will test the patch and update the status accordingly. > >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> >> >> On Wed, Oct 19, 2016 at 3:47 PM, Fahar Abbas < >> fahar.abbas@enterprisedb.com> wrote: >> >>> Here is the output of if we copy config_local.py and execute python >>> setup.py >>> pgAdmin 4 - Application Initialisation >>> ====================================== >>> >>> >>> The configuration database - '/home/fahar/.pgadmin/pgadmin4.db' does >>> not exist. >>> Entering initial setup mode... >>> NOTE: Configuring authentication for SERVER mode. >>> >>> >>> Enter the email address and password to use for the initial pgAdmin >>> user account: >>> >>> Email address: fahar.abbas@enterprisedb.com >>> Password: >>> Retype password: >>> Traceback (most recent call last): >>> File "setup.py", line 449, in >>> do_setup(app) >>> File "setup.py", line 96, in do_setup >>> password = encrypt_password(p1) >>> File "/home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.py", >>> line 150, in encrypt_password >>> signed = get_hmac(password).decode('ascii') >>> File "/home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.py", >>> line 108, in get_hmac >>> 'set to "%s"' % _security.password_hash) >>> RuntimeError: The configuration value `SECURITY_PASSWORD_SALT` must not >>> be None when the value of `SECURITY_PASSWORD_HASH` is set to "pbkdf2_sha512" >>> python setup.py >>> pgAdmin 4 - Application Initialisation >>> ====================================== >>> >>> User can not do any setup for web based now. >>> >>> >>> The configuration database - '/home/fahar/.pgadmin/pgadmin4.db' does >>> not exist. >>> Entering initial setup mode... >>> NOTE: Configuring authentication for SERVER mode. >>> >>> >>> Enter the email address and password to use for the initial pgAdmin >>> user account: >>> >>> Email address: fahar.abbas@enterprisedb.com >>> Password: >>> Retype password: >>> Traceback (most recent call last): >>> File "setup.py", line 449, in >>> do_setup(app) >>> File "setup.py", line 96, in do_setup >>> password = encrypt_password(p1) >>> File "/home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.py", >>> line 150, in encrypt_password >>> signed = get_hmac(password).decode('ascii') >>> File "/home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.py", >>> line 108, in get_hmac >>> 'set to "%s"' % _security.password_hash) >>> RuntimeError: The configuration value `SECURITY_PASSWORD_SALT` must not >>> be None when the value of `SECURITY_PASSWORD_HASH` is set to "pbkdf2_sha512" >>> >>> On Wed, Oct 19, 2016 at 3:03 PM, Fahar Abbas < >>> fahar.abbas@enterprisedb.com> wrote: >>> >>>> Dave, >>>> >>>> Testing Environment >>>> >>>> Ubuntu 16.04 Linux 64: >>>> -------------------------------- >>>> >>>> pg-AdminIV Development Environment Setup for Ubuntu : >>>> >>>> >>>> 1) Install GIT >>>> >>>> sudo apt-get install git >>>> >>>> 2) Install pip3 >>>> >>>> sudo apt-get install python3-pip >>>> >>>> 3) Install virtualenv >>>> >>>> sudo pip3 install virtualenv >>>> >>>> 4) install below dependency as it is required for psycopg2 & pycrypto >>>> module >>>> >>>> sudo apt-get install libpq-dev >>>> >>>> sudo apt-get install python3-dev >>>> >>>> 5) Create virtual environment >>>> >>>> virtualenv -p python3 venv >>>> >>>> 6) Create mkdir Projects >>>> >>>> 7) Clone git repo in Projects >>>> >>>> git clone http://git.postgresql.org/git/pgadmin4.git >>>> >>>> 8) activate virtual environment >>>> >>>> source venv/bin/activate >>>> >>>> 9) Install modules >>>> >>>> pip3 install -r requirements_py3.txt >>>> >>>> *10) Edit the config.py file to config_local.py resides in >>>> Projects\pgAdmin4\web * >>>> >>>> 11)Now run setup.py file (\Projects\pgAdmin4\web) >>>> python setup.py >>>> >>>> If user does not create config_local.py and do Python setup.py for new >>>> Development then SECURITY_PASSWORD_SALT message is also displayed: >>>> >>>> Here is the output: >>>> ------------------------- >>>> >>>> python setup.py >>>> pgAdmin 4 - Application Initialisation >>>> ====================================== >>>> >>>> >>>> The configuration database - '/home/fahar/.pgadmin/pgadmin4.db' does >>>> not exist. >>>> Entering initial setup mode... >>>> NOTE: Configuring authentication for SERVER mode. >>>> >>>> >>>> Enter the email address and password to use for the initial pgAdmin >>>> user account: >>>> >>>> Email address: fahar.abbas@enterprisedb.com >>>> Password: >>>> Retype password: >>>> Traceback (most recent call last): >>>> File "setup.py", line 449, in >>>> do_setup(app) >>>> File "setup.py", line 96, in do_setup >>>> password = encrypt_password(p1) >>>> File "/home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.py", >>>> line 150, in encrypt_password >>>> signed = get_hmac(password).decode('ascii') >>>> File "/home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.py", >>>> line 108, in get_hmac >>>> 'set to "%s"' % _security.password_hash) >>>> RuntimeError: The configuration value `SECURITY_PASSWORD_SALT` must not >>>> be None when the value of `SECURITY_PASSWORD_HASH` is set to "pbkdf2_sha512" >>>> (venv) fahar@fahar-virtual-machine:~/Projects/pgadmin4/web$ >>>> >>>> >>>> Is this expected? >>>> >>>> On Wed, Oct 19, 2016 at 1:37 PM, Fahar Abbas < >>>> fahar.abbas@enterprisedb.com> wrote: >>>> >>>>> Sure, >>>>> >>>>> Will test this thoroughly after complete investigation. >>>>> >>>>> Kind Regards, >>>>> >>>>> On Wed, Oct 19, 2016 at 1:27 PM, Dave Page wrote: >>>>> >>>>>> Patch applied. >>>>>> >>>>>> Fahar, can you please test this thoroughly in desktop and server >>>>>> modes, with both fresh and upgraded installations? >>>>>> >>>>>> https://redmine.postgresql.org/issues/1849 >>>>>> >>>>>> Packagers: This change means that packages are no longer forced to >>>>>> create a config_local.py file, and there is no longer any need to >>>>>> explicitly set SECURITY_PASSWORD_SALT, SECURITY_KEY >>>>>> and CSRF_SESSION_KEY in the config (in fact, they should be removed for new >>>>>> installations, if you have included them in 1.0) >>>>>> >>>>>> Thanks. >>>>>> >>>>>> >>>>>> On Wed, Oct 19, 2016 at 6:46 AM, Ashesh Vashi < >>>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Dave, >>>>>>> >>>>>>> On Sat, Oct 15, 2016 at 8:02 AM, Dave Page >>>>>>> wrote: >>>>>>> >>>>>>>> Hi >>>>>>>> >>>>>>>> >>>>>>>> On Friday, October 14, 2016, Dave Page wrote: >>>>>>>> >>>>>>>>> Hi >>>>>>>>> >>>>>>>>> On Thursday, October 13, 2016, Ashesh Vashi < >>>>>>>>> ashesh.vashi@enterprisedb.com> wrote: >>>>>>>>> >>>>>>>>>> Hi Dave, >>>>>>>>>> >>>>>>>>>> On Tue, Oct 11, 2016 at 9:10 PM, Dave Page >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Ashesh, >>>>>>>>>>> >>>>>>>>>>> Can you please review the attached patch, and apply if you're >>>>>>>>>>> happy with it? >>>>>>>>>>> >>>>>>>>>> Overall the patch looked good to me. >>>>>>>>>> But - I encounter an issue in 'web' mode, which wont happen with >>>>>>>>>> 'runtime'. >>>>>>>>>> >>>>>>>>>> Steps for reproduction on existing pgAdmin 4 environment with >>>>>>>>>> 'web' mode. >>>>>>>>>> - Apply the patch >>>>>>>>>> - Start the pgAdmin4 application (stand alone application). >>>>>>>>>> - Open pgAdmin home page. >>>>>>>>>> - Log out (if already login). >>>>>>>>>> >>>>>>>>>> And, you will see an exception. >>>>>>>>>> >>>>>>>>>> I have figure out the issue with the patch. >>>>>>>>>> We were setting the SECURITY_PASSWORD_SALT, after initializing >>>>>>>>>> the Security object. >>>>>>>>>> Hence - it could not set the SECURITY_KEY, and >>>>>>>>>> SECURITY_PASSWORD_SALT properly. >>>>>>>>>> >>>>>>>>> >>>>>>>>> Hmm. >>>>>>>>> >>>>>>>>> >>>>>>>>>> >>>>>>>>>> I had moved the Security object initialization after fetching >>>>>>>>>> these configurations from the database. >>>>>>>>>> I have attached a addon patch for the same. >>>>>>>>>> >>>>>>>>> >>>>>>>>> OK, thanks. >>>>>>>>> >>>>>>>>> >>>>>>>>>> >>>>>>>>>> Now - I run into another issue. >>>>>>>>>> Because - the existing password was hashed using the old >>>>>>>>>> SECURITY_PASSWORD_SALT, I am no more able to login to pgAdmin 4. >>>>>>>>>> >>>>>>>>>> I think - we need to think about different strategy for upgrading >>>>>>>>>> the configuration file in the 'web' mode. >>>>>>>>>> I was thinking - we can store the existing security >>>>>>>>>> configurations in the database during upgrade process in 'web' mode. >>>>>>>>>> >>>>>>>>> >>>>>>>>> My concern with that is that we'll likely be storing the default >>>>>>>>> config values in many cases, thus for those users, perpetuating the problem. >>>>>>>>> >>>>>>>>> I guess what we need to do is re-encrypt the password during the >>>>>>>>> upgrade - however, that makes me think; we then have both the key and the >>>>>>>>> encrypted passwords in the same database which is clearly not a good idea. >>>>>>>>> Sigh... Needs more thought. >>>>>>>>> >>>>>>>> >>>>>>>> OK, so I've been thinking about this and experimenting for a couple >>>>>>>> of hours, as well as annoying the crap out of Magnus by thinking out loud >>>>>>>> in his general direction, and it looks like this isn't a major problem as >>>>>>>> from what I can see, SECURITY_PASSWORD_SALT is (aside from really being a >>>>>>>> key not a salt) not the only salting that's done. >>>>>>>> >>>>>>>> It looks like it's used system-wide as the key to generate an HMAC >>>>>>>> of the users password, which is then passed to passlib which salts and >>>>>>>> hashes it. I did some testing, and found that two users with the same >>>>>>>> password end up with different hashes in the database, so clearly there is >>>>>>>> also per-user salting happening. I also created two users, then dropped the >>>>>>>> database and created the same user accounts with the same passwords again, >>>>>>>> and found that the resulting hashes were different in both databases - thus >>>>>>>> there is something else ensuring the hashes are unique across different >>>>>>>> installations/databases. >>>>>>>> >>>>>>>> So, I believe we can do as you suggest and migrate existing values >>>>>>>> for SECURITY_PASSWORD_SALT, given that there's clearly some other per user >>>>>>>> and per installation/database salting going on anyway. New installations >>>>>>>> can have the random value for SECURITY_PASSWORD_SALT. >>>>>>>> >>>>>>> We do not need to generate the random SECURITY_PASSWORD_SALT during >>>>>>> upgrade mode, which was wrong added in my addon patch. >>>>>>> >>>>>>> Please find the updated patch. >>>>>>> >>>>>>> Otherwise - looks good to me. >>>>>>> Please commit the new patch (if you're ok with the change). >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> Thanks & Regards, >>>>>>> >>>>>>> Ashesh Vashi >>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company >>>>>>> >>>>>>> >>>>>>> >>>>>>> *http://www.linkedin.com/in/asheshvashi* >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> I don't believe SECURITY_KEY and CSRF_SESSION_KEY are issues >>>>>>>> either, as they're used for purposes that are essentially ephemeral, and >>>>>>>> thus can be changed during an upgrade. >>>>>>>> >>>>>>>> Adding Magnus as I'd appreciate any thoughts he may have. >>>>>>>> >>>>>>>> Patch attached - please review (Ashesh, but others too would be >>>>>>>> appreciated)! >>>>>>>> >>>>>>>> Thanks. >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>> Twitter: @pgsnake >>>>>>>> >>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Syed Fahar Abbas >>>>> Quality Management Group >>>>> >>>>> EnterpriseDB Corporation >>>>> Phone Office: +92-51-835-8874 >>>>> Phone Direct: +92-51-8466803 >>>>> Mobile: +92-333-5409707 >>>>> Skype ID: syed.fahar.abbas >>>>> Website: www.enterprisedb.com >>>>> >>>> >>>> >>>> >>>> -- >>>> Syed Fahar Abbas >>>> Quality Management Group >>>> >>>> EnterpriseDB Corporation >>>> Phone Office: +92-51-835-8874 >>>> Phone Direct: +92-51-8466803 >>>> Mobile: +92-333-5409707 >>>> Skype ID: syed.fahar.abbas >>>> Website: www.enterprisedb.com >>>> >>> >>> >>> >>> -- >>> Syed Fahar Abbas >>> Quality Management Group >>> >>> EnterpriseDB Corporation >>> Phone Office: +92-51-835-8874 >>> Phone Direct: +92-51-8466803 >>> Mobile: +92-333-5409707 >>> Skype ID: syed.fahar.abbas >>> Website: www.enterprisedb.com >>> >> >> > > > -- > Syed Fahar Abbas > Quality Management Group > > EnterpriseDB Corporation > Phone Office: +92-51-835-8874 > Phone Direct: +92-51-8466803 > Mobile: +92-333-5409707 > Skype ID: syed.fahar.abbas > Website: www.enterprisedb.com > -- Syed Fahar Abbas Quality Management Group EnterpriseDB Corporation Phone Office: +92-51-835-8874 Phone Direct: +92-51-8466803 Mobile: +92-333-5409707 Skype ID: syed.fahar.abbas Website: www.enterprisedb.com --94eb2c1a089e12d5ee053f364d8e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Wed, Oct 19, 2016 at 4:03 PM, Fahar Abbas <fahar.abbas@e= nterprisedb.com> wrote:


On Wed, Oct 19, 2016 at 3:55 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Fahar,

Please log the case on redmine.
<= div>https://redmine.postgresql.org/issues/1871
Please find the attached patch, please apply it locally, and test it.

And, please update the case, and this mail chain acc= ordingly.
This is resolved now and no error message displayed when we apply the pat= ch that is already shared.

Sure Will test the patch and update the st= atus accordingly.

--

<= p style=3D"margin:0pt">Thanks & Regards,
Ashesh Vashi
<= span style=3D"font-style:italic">EnterpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Wed, Oct 19, 2016 at 3:47 PM, Fahar Abbas <faha= r.abbas@enterprisedb.com> wrote:
Here is the output of if we = copy config_local.py and execute python setup.py
pgAdmin 4 - Appli= cation Initialisation
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=

The configuration database - '/home/fahar/.pgadmin/pgadmin4.db' does not exist.
Entering initial setup mode...
NOTE: Config= uring authentication for SERVER mode.


=C2=A0=C2=A0=C2=A0 Enter t= he email address and password to use for the initial pgAdmin user=C2=A0=C2= =A0=C2=A0=C2=A0 account:

Email address: fahar.abbas@enterprisedb.com
P= assword:
Retype password:
Traceback (most recent call last):
=C2= =A0 File "setup.py", line 449, in <module>
=C2=A0=C2=A0= =C2=A0 do_setup(app)
=C2=A0 File "setup.py", line 96, in do_se= tup
=C2=A0=C2=A0=C2=A0 password =3D encrypt_password(p1)
=C2=A0 File = "/home/fahar/venv/lib/python3.5/site-packages/flask_security= /utils.py", line 150, in encrypt_password
=C2=A0=C2=A0=C2=A0 signed= =3D get_hmac(password).decode('ascii')
=C2=A0 File "/= home/fahar/venv/lib/python3.5/site-packages/flask_security/utils.= py", line 108, in get_hmac
=C2=A0=C2=A0=C2=A0 'set to "%s&= quot;' % _security.password_hash)
RuntimeError: The configuration va= lue `SECURITY_PASSWORD_SALT` must not be None when the value of `SECURITY_P= ASSWORD_HASH` is set to "pbkdf2_sha512"
python setup.py
pgA= dmin 4 - Application Initialisation
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D

User can not do any setup for web based now.<= span>


The configuration database - '/home/fahar/.pgadmi= n/pgadmin4.db' does not exist.
Entering initial setup mode...NOTE: Configuring authentication for SERVER mode.


=C2=A0=C2=A0= =C2=A0 Enter the email address and password to use for the initial pgAdmin = user=C2=A0=C2=A0=C2=A0=C2=A0 account:

Email address: fahar.abbas@enterprisedb= .com
Password:
Retype password:
Traceback (most recent call l= ast):
=C2=A0 File "setup.py", line 449, in <module>
= =C2=A0=C2=A0=C2=A0 do_setup(app)
=C2=A0 File "setup.py", line = 96, in do_setup
=C2=A0=C2=A0=C2=A0 password =3D encrypt_password(p1)
= =C2=A0 File "/home/fahar/venv/lib/python3.5/site-packages/flask_s= ecurity/utils.py", line 150, in encrypt_password
=C2=A0=C2=A0= =C2=A0 signed =3D get_hmac(password).decode('ascii')
=C2=A0= File "/home/fahar/venv/lib/python3.5/site-packages/flask_securit= y/utils.py", line 108, in get_hmac
=C2=A0=C2=A0=C2=A0 'set= to "%s"' % _security.password_hash)
RuntimeError: The con= figuration value `SECURITY_PASSWORD_SALT` must not be None when the value o= f `SECURITY_PASSWORD_HASH` is set to "pbkdf2_sha512"

On Wed, Oct 19, 201= 6 at 3:03 PM, Fahar Abbas <fahar.abbas@enterprisedb.com>= wrote:
Dave,

Testing Environment
= =C2=A0
Ubuntu 16.04 Linux 64:
--------------------------------

pg-AdminIV Develop= ment Environment Setup for= Ubuntu=C2=A0 :

=

=

1) Install GIT

sudo apt-get install git<= /font>

2) Install pip3

sudo apt-get in= stall python3-pip

3) Install virtualenv

sudo pip3 install virtualenv

4) install below dependency as it is re= quired for psycopg2 & pycrypto module

sudo apt-get install libpq-dev =

sudo apt-get install pyth= on3-dev

5) C= reate virtual environment

virtualenv -p python3 venv

6) Create mkdir Projects

7) Clone git repo in Projects

git clone = http://g= it.postgresql.org/git/pgadmi= n4.git

8) activate virtual environment

source venv/bin/activate

9) Install modules

pip3 install -r requirements= _py3.txt

10) Edit the config.py file to config_local.py= =C2=A0resides in Projects\= pgAdmin4\web=C2=A0=C2=A0

11)Now run setup.py file =C2=A0(\Projects\pgAdmin4\web)

=C2=A0 =C2=A0 python <= span class=3D"m_3537455806921197709gmail-m_-1620282619331950935m_-636616641= 4894557042m_8579966991770304932gmail-il">setup.py

If= user does not create config_local.py and do Python setup.py for new Develo= pment then SECURITY_PASSWORD_SALT message is also displayed:

<= div>Here is the output:
-------------------------

pyth= on setup.py
pgAdmin 4 - Application Initialisation
=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D


The configuration database - '= /home/fahar/.pgadmin/pgadmin4.db' does not exist.
Entering init= ial setup mode...
NOTE: Configuring authentication for SERVER mode.
<= br>
=C2=A0=C2=A0=C2=A0 Enter the email address and password to use for t= he initial pgAdmin user=C2=A0=C2=A0=C2=A0=C2=A0 account:

Email addre= ss: fahar= .abbas@enterprisedb.com
Password:
Retype password:
Traceback = (most recent call last):
=C2=A0 File "setup.py", line 449, in = <module>
=C2=A0=C2=A0=C2=A0 do_setup(app)
=C2=A0 File "set= up.py", line 96, in do_setup
=C2=A0=C2=A0=C2=A0 password =3D encryp= t_password(p1)
=C2=A0 File "/home/fahar/venv/lib/python3.5/sit= e-packages/flask_security/utils.py", line 150, in encrypt_passwor= d
=C2=A0=C2=A0=C2=A0 signed =3D get_hmac(password).decode('asci= i')
=C2=A0 File "/home/fahar/venv/lib/python3.5/site-packa= ges/flask_security/utils.py", line 108, in get_hmac
=C2=A0=C2= =A0=C2=A0 'set to "%s"' % _security.password_hash)
Run= timeError: The configuration value `SECURITY_PASSWORD_SALT` must not be Non= e when the value of `SECURITY_PASSWORD_HASH` is set to "pbkdf2_sha512&= quot;
(venv) fahar@fahar-virtual-machine:~/Projects/pgadmin4/web$ <= br>

Is this expected?

On Wed, Oct 19, 2016 at 1:37 PM, Fahar Abbas= <fahar.abbas@enterprisedb.com> wrote:
Sure,=

Will test this thoroughly after complete investigation.
Kind Regards,

On Wed, Oct 19, 201= 6 at 1:27 PM, Dave Page <dpage@pgadmin.org> wrote:
Patch applied.=

Fahar, can you please test this thoroughly in desktop a= nd server modes, with both fresh and upgraded installations?

=

=
Packagers: This change means that packages are no longer forced = to create a config_local.py file, and there is no longer any need to explic= itly set=C2=A0SECURITY_PASSWORD_SALT,=C2= =A0SECURITY_KEY and=C2=A0CSRF_= SESSION_KEY in the config (in fact, they should be removed for new installa= tions, if you have included them in 1.0)

Th= anks.


On Wed, Oct 19, 2016 = at 6:46 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
<= div dir=3D"ltr">Hi Dave,

On Sat, Oct 15, 2016 at 8:02 AM, Dave Page = <dpage@pgadmin.org> wrote:
Hi


On F= riday, October 14, 2016, Dave Page <dpage@pgadmin.org> wrote:
Hi

On Thursday, October 13, 2016, Ashe= sh Vashi <ashesh.vashi@enterprisedb.com> wrote:
<= div>






We do not need to generate the random SECURITY_PA= SSWORD_SALT during upgrade mode, which was wrong added in my addon patch.

Please find the updated patch.

=
Otherwise - looks good to me.
Please commit the new patch (i= f you're ok with the change).


--

Thanks &a= mp; Regards,

Ashesh Vashi
EnterpriseDB IND= IA:=C2=A0= Enterprise PostgreSQL Company



I don't believe SECURITY_KEY and=C2=A0CSRF_= SESSION_KEY are issues either, as they're used for purposes that are es= sentially ephemeral, and thus can be changed during an upgrade.
<= br>
Adding Magnus as I'd appreciate any thoughts he may have.=

Patch attached - please review (Ashesh, but other= s too would be appreciated)!

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Ent= erpriseDB UK: htt= p://www.enterprisedb.com
The Enterprise PostgreSQL Company





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

Enterpr= iseDB UK: http://= www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Syed = Fahar Abbas
Quality Management Group

EnterpriseD= B Corporation
Phone Office: +92-51-835-8874
Phone Direct: +92-51-84668= 03
Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Web= site: www.enterpr= isedb.com



--
Syed Fahar Abbas
Quality Management Group

EnterpriseDB Corporation
Phone = Office: +92-51-835-8874
Phone Direct: +92-51-8466803
Mobile: +92-= 333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com
=


--
Syed Fahar Abbas
Quality Management= Group

EnterpriseDB Corporation
Phone Office: +92-51-835-88= 74
Phone Direct: +92-51-8466803
Mobile: +92-333-5409707
Sk= ype ID: syed.fahar.abbas
Website: www.enterprisedb.com




--
Syed Fahar Abbas
Quality Management Group

<= /div>EnterpriseDB Corporation
Phone Office: +92-51-835-8874
Phone Dir= ect: +92-51-8466803
Mobile: +92-333-5409707
Skype ID: syed.= fahar.abbas
Website: www.enterprisedb.com



--
Syed Fahar= Abbas
Quality Management Group

EnterpriseDB Cor= poration
Phone Office: +92-51-835-8874
Phone Direct: +92-51-8466803Mobile: +92-333-5409707
Skype ID: syed.fahar.abbas
Website: www.enterprisedb.com=
--94eb2c1a089e12d5ee053f364d8e--