MIME-Version: 1.0
References: 
 <CAK6syAppD_do9JQkdyQA96vsFQys97d5p3D_Ud_eCfvpoCp=Vg@mail.gmail.com>
 <CAFOhELdWQuOJ8pdcPD7FxsZrLf9HnL8Eoiw5-U9GV5goU_nzQQ@mail.gmail.com>
In-Reply-To: 
 <CAFOhELdWQuOJ8pdcPD7FxsZrLf9HnL8Eoiw5-U9GV5goU_nzQQ@mail.gmail.com>
From: Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.com>
Date: Thu, 26 Mar 2020 10:30:22 +0530
Message-ID: 
 <CAK6syAoHoF3iQdd53_acRnx+6b9+MOEK=sq7AbaqeVf5aCKERQ@mail.gmail.com>
Subject: Re: Fix in switch cell tab navigation
To: Khushboo Vashi <khushboo.vashi@enterprisedb.com>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000022a87705a1bade8d"
Precedence: bulk

--00000000000022a87705a1bade8d
Content-Type: multipart/alternative; boundary="00000000000022a87405a1bade8b"

--00000000000022a87405a1bade8b
Content-Type: text/plain; charset="UTF-8"

Hi Khushboo,

I have removed the condition added for subgrid-cell. Please find the
attached updated patch

Regards,
Ganesh Jaybhay

On Wed, Mar 25, 2020 at 5:39 PM Khushboo Vashi <
khushboo.vashi@enterprisedb.com> wrote:

> Hi Ganesh,
>
> You have put a check on *subgrid-cell* class, which does not exist in the
> entire source code.
> Also, can you please let me know of any module which you have tested, so I
> can test accordingly though the code for the same looks good to me.
>
> Thanks,
> Khushboo
>
>
> On Wed, Mar 25, 2020 at 3:21 PM Ganesh Jaybhay <
> ganesh.jaybhay@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch for below minor fix in the switch cell tab
>> navigation:
>>
>> After pressing the tab key on switch cell, sometimes focus doesn't go to
>> the immediate next editable cell. It goes to the different cell for
>> fraction of seconds and again comes to the next editable cell.
>>
>> Please review.
>>
>> Regards,
>> Ganesh Jaybhay
>>
>

--00000000000022a87405a1bade8b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Khushboo,<div><br><div>I have removed the condition add=
ed for subgrid-cell. Please find the attached updated patch</div><div><br><=
/div><div>Regards,</div><div>Ganesh Jaybhay</div></div></div><br><div class=
=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Mar 25, 2020=
 at 5:39 PM Khushboo Vashi &lt;<a href=3D"mailto:khushboo.vashi@enterprised=
b.com">khushboo.vashi@enterprisedb.com</a>&gt; wrote:<br></div><blockquote =
class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px sol=
id rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi Ganesh,<div><br><=
/div><div>You have put a check on=C2=A0<i>subgrid-cell</i> class, which doe=
s not exist in the entire source code.</div><div>Also, can you please let m=
e know of any module which you have tested, so I can test accordingly thoug=
h the code for the same looks good to me.</div><div><br></div><div>Thanks,<=
/div><div>Khushboo</div><div><br></div></div><br><div class=3D"gmail_quote"=
><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Mar 25, 2020 at 3:21 PM Gane=
sh Jaybhay &lt;<a href=3D"mailto:ganesh.jaybhay@enterprisedb.com" target=3D=
"_blank">ganesh.jaybhay@enterprisedb.com</a>&gt; wrote:<br></div><blockquot=
e class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px s=
olid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr">H=
i Hackers,<div><br></div><div>Attached is the patch for below minor fix in =
the switch cell tab navigation:</div><div><br></div><div>After pressing the=
 tab key on switch cell, sometimes focus doesn&#39;t go to the immediate ne=
xt editable cell. It goes to the different cell for fraction of seconds and=
 again comes to the next editable cell.</div><div><br></div><div>Please rev=
iew.</div><div><br></div><div>Regards,</div><div>Ganesh Jaybhay</div></div>=
</div>
</blockquote></div>
</blockquote></div>

--00000000000022a87405a1bade8b--

--00000000000022a87705a1bade8d
Content-Type: application/octet-stream;
	name="switch_cell_navigation_v1.patch"
Content-Disposition: attachment; filename="switch_cell_navigation_v1.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_k88a0as80>
X-Attachment-Id: f_k88a0as80

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9iYWNrZ3JpZC5wZ2FkbWluLmpzIGIv
d2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tncmlkLnBnYWRtaW4uanMKaW5kZXggMjMwZDdjZTU2
Li5iMDVlMTQyMmYgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9iYWNrZ3JpZC5w
Z2FkbWluLmpzCisrKyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9iYWNrZ3JpZC5wZ2FkbWluLmpz
CkBAIC03MTcsNyArNzE3LDExIEBAIGRlZmluZShbCiAgICAgICAgICAgZ290b0NlbGwgPSBlLnNo
aWZ0S2V5ID8gc2VsZi4kZWwucHJldigpIDogc2VsZi4kZWwubmV4dCgpOwogICAgICAgICB9CiAK
LSAgICAgICAgaWYgKGdvdG9DZWxsKSB7CisgICAgICAgIGlmIChnb3RvQ2VsbCAmJiBnb3RvQ2Vs
bC5sZW5ndGggPiAwKSB7CisgICAgICAgICAgaWYoZ290b0NlbGwuaGFzQ2xhc3MoJ2VkaXRhYmxl
JykpeworICAgICAgICAgICAgZS5wcmV2ZW50RGVmYXVsdCgpOworICAgICAgICAgICAgZS5zdG9w
UHJvcGFnYXRpb24oKTsKKyAgICAgICAgICB9CiAgICAgICAgICAgbGV0IGNvbW1hbmQgPSBuZXcg
QmFja2dyaWQuQ29tbWFuZCh7CiAgICAgICAgICAgICBrZXk6ICdUYWInLAogICAgICAgICAgICAg
a2V5Q29kZTogOSwKQEAgLTcyNywxMiArNzMxLDggQEAgZGVmaW5lKFsKICAgICAgICAgICBzZXRU
aW1lb3V0KGZ1bmN0aW9uKCkgewogICAgICAgICAgICAgLy8gV2hlbiB3ZSBoYXZlIEVkaXRhYmxl
IENlbGwKICAgICAgICAgICAgIGlmIChnb3RvQ2VsbC5oYXNDbGFzcygnZWRpdGFibGUnKSAmJiBn
b3RvQ2VsbC5oYXNDbGFzcygnZWRpdC1jZWxsJykpIHsKLSAgICAgICAgICAgICAgZS5wcmV2ZW50
RGVmYXVsdCgpOwotICAgICAgICAgICAgICBlLnN0b3BQcm9wYWdhdGlvbigpOwogICAgICAgICAg
ICAgICBnb3RvQ2VsbC50cmlnZ2VyKCdmb2N1cycpOwogICAgICAgICAgICAgfSBlbHNlIGlmIChn
b3RvQ2VsbC5oYXNDbGFzcygnZWRpdGFibGUnKSkgewotICAgICAgICAgICAgICBlLnByZXZlbnRE
ZWZhdWx0KCk7Ci0gICAgICAgICAgICAgIGUuc3RvcFByb3BhZ2F0aW9uKCk7CiAgICAgICAgICAg
ICAgIHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CiAgICAgICAgICAgICAgICAgc2VsZi5tb2RlbC50
cmlnZ2VyKCdiYWNrZ3JpZDplZGl0ZWQnLCBzZWxmLm1vZGVsLAogICAgICAgICAgICAgICAgICAg
c2VsZi5jb2x1bW4sIGNvbW1hbmQpOwo=
--00000000000022a87705a1bade8d--