MIME-Version: 1.0
References: 
 <CAM9w-_=fMWu5Ch23QKB_qC61yJGT0e_r94wg_kbyxfRpu_epwA@mail.gmail.com>
 <CANxoLDe77dWL5NOGpqbxJnDoRwU54rAAPMKRkdk25686-jy5Wg@mail.gmail.com>
In-Reply-To: 
 <CANxoLDe77dWL5NOGpqbxJnDoRwU54rAAPMKRkdk25686-jy5Wg@mail.gmail.com>
From: Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.com>
Date: Wed, 11 Mar 2020 14:43:20 +0530
Message-ID: 
 <CAK6syAogA1GAyqK1w9XquNLHActrDfjV9ZOc2AVOwbEbbD6EYA@mail.gmail.com>
Subject: Re: [pgAdmin][RM4764][Accessibility] Allow screen-reader to read
 relationship attributes in nested elements
To: Akshay Joshi <akshay.joshi@enterprisedb.com>
Cc: Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>,
	pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000065433905a090a66b"
Precedence: bulk

--00000000000065433905a090a66b
Content-Type: multipart/alternative; boundary="00000000000065433805a090a669"

--00000000000065433805a090a669
Content-Type: text/plain; charset="UTF-8"

Hi Hackers,

Attached is the patch on top of initial patch for:

   - screen reader to read elements in radio modern control
   - minor accessibility(aria-label) additions at few missing places
   - Radiocontrol to have different ids for each options

Please review.

Regards,
Ganesh Jaybhay

On Tue, Dec 17, 2019 at 1:25 PM Akshay Joshi <akshay.joshi@enterprisedb.com>
wrote:

> Thanks, patch applied.
>
> On Fri, Dec 13, 2019 at 12:09 PM Aditya Toshniwal <
> aditya.toshniwal@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to:
>> 1) Read relationship for tab, tabpanels and tables under it. Similar
>> changes are done for subnode controls.
>> 2) Add role="img" for font icons, per -
>> https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA24.html
>>
>> Kindly review.
>>
>> --
>> Thanks and Regards,
>> Aditya Toshniwal
>> Sr. Software Engineer | EnterpriseDB India | Pune
>> "Don't Complain about Heat, Plant a TREE"
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--00000000000065433805a090a669
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi Hackers,<div><br></div><div>Attached=
=C2=A0is the patch on top of initial patch for:</div><div><ul><li>screen re=
ader to read elements in radio modern control=C2=A0</li><li>minor accessibi=
lity(aria-label) additions at few missing places</li><li>Radiocontrol to ha=
ve different ids for each options</li></ul></div><div>Please review.<br><di=
v><br></div><div>Regards,</div><div>Ganesh Jaybhay</div></div></div></div><=
br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Tue,=
 Dec 17, 2019 at 1:25 PM Akshay Joshi &lt;<a href=3D"mailto:akshay.joshi@en=
terprisedb.com">akshay.joshi@enterprisedb.com</a>&gt; wrote:<br></div><bloc=
kquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:=
1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Thanks, patch=
 applied.</div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gma=
il_attr">On Fri, Dec 13, 2019 at 12:09 PM Aditya Toshniwal &lt;<a href=3D"m=
ailto:aditya.toshniwal@enterprisedb.com" target=3D"_blank">aditya.toshniwal=
@enterprisedb.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote"=
 style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);p=
adding-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_default" style=3D"fon=
t-family:verdana,sans-serif">Hi Hackers,</div><div class=3D"gmail_default" =
style=3D"font-family:verdana,sans-serif"><br></div><div class=3D"gmail_defa=
ult" style=3D"font-family:verdana,sans-serif">Attached is the patch to:</di=
v><div class=3D"gmail_default" style=3D"font-family:verdana,sans-serif">1) =
Read relationship for tab, tabpanels and tables under it. Similar changes a=
re done for subnode controls.</div><div class=3D"gmail_default" style=3D"fo=
nt-family:verdana,sans-serif">2) Add role=3D&quot;img&quot; for font icons,=
 per -=C2=A0<a href=3D"https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA24=
.html" style=3D"font-family:Arial,Helvetica,sans-serif" target=3D"_blank">h=
ttps://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA24.html</a></div><div clas=
s=3D"gmail_default" style=3D"font-family:verdana,sans-serif"><br></div><div=
 class=3D"gmail_default" style=3D"font-family:verdana,sans-serif">Kindly re=
view.</div><div><br></div>-- <br><div dir=3D"ltr"><div dir=3D"ltr"><div><di=
v dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><font size=3D"2" =
color=3D"#000000" face=3D"verdana, sans-serif">Thanks and Regards,</font><d=
iv><span style=3D"background-color:rgb(255,255,255)"><font size=3D"2" color=
=3D"#000000" face=3D"verdana, sans-serif">Aditya Toshniwal</font></span></d=
iv><div><font face=3D"verdana, sans-serif"><span style=3D"background-color:=
rgb(255,255,255)"><font size=3D"2" color=3D"#000000">Sr. Software Engineer =
|=C2=A0EnterpriseDB India |=C2=A0</font></span><span style=3D"color:rgb(0,0=
,0)">Pune</span></font></div><div><font color=3D"#38761d" face=3D"verdana, =
sans-serif" size=3D"1">&quot;Don&#39;t Complain about Heat, Plant a TREE&qu=
ot;</font></div></div></div></div></div></div></div></div></div></div>
</blockquote></div><br clear=3D"all"><div><br></div>-- <br><div dir=3D"ltr"=
><div dir=3D"ltr"><div><div dir=3D"ltr"><div><div dir=3D"ltr"><div dir=3D"l=
tr"><div dir=3D"ltr"><div><font color=3D"#3333FF"><b><span style=3D"color:r=
gb(0,0,0);font-family:arial,sans-serif;font-size:13px;border-collapse:colla=
pse">Thanks &amp; Regards</span></b></font></div><div><font color=3D"#3333F=
F"><b><span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;font-siz=
e:13px;border-collapse:collapse">Akshay Joshi</span></b></font></div><div><=
font color=3D"#3333FF"><b><span style=3D"color:rgb(0,0,0);font-family:arial=
,sans-serif;font-size:13px;border-collapse:collapse">Sr. Software Architect=
<br></span></b></font></div><div><span style=3D"border-collapse:collapse"><=
font color=3D"#000000" face=3D"arial, sans-serif"><b>EnterpriseDB Software =
India Private Limited</b></font><br></span></div><div><b style=3D"color:rgb=
(51,51,255)"><span style=3D"color:rgb(0,0,0);font-family:arial,sans-serif;f=
ont-size:13px;border-collapse:collapse">Mobile: +91 976-788-8246</span></b>=
<br></div></div></div></div></div></div></div></div></div>
</blockquote></div>

--00000000000065433805a090a669--

--00000000000065433905a090a66b
Content-Type: application/octet-stream; name="RM4764_v1.patch"
Content-Disposition: attachment; filename="RM4764_v1.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_k7n3rk3x0>
X-Attachment-Id: f_k7n3rk3x0

ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9iYWNrZm9ybS5wZ2FkbWluLmpzIGIv
d2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tmb3JtLnBnYWRtaW4uanMKaW5kZXggMzA5MGZkMjU0
Li5hMWM4OTg4OTAgMTAwNjQ0Ci0tLSBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9iYWNrZm9ybS5w
Z2FkbWluLmpzCisrKyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9iYWNrZm9ybS5wZ2FkbWluLmpz
CkBAIC00OTYsMTMgKzQ5NiwxMyBAQCBkZWZpbmUoWwogICAgICAgZS5zdG9wUHJvcGFnYXRpb24o
KTsKICAgICB9LAogICAgIHRlbXBsYXRlOiBfLnRlbXBsYXRlKFsKLSAgICAgICc8bGFiZWwgY2xh
c3M9IjwlPWNvbnRyb2xMYWJlbENsYXNzTmFtZSU+Ij48JT1sYWJlbCU+PC9sYWJlbD4nLAorICAg
ICAgJzxsYWJlbCBjbGFzcz0iPCU9Y29udHJvbExhYmVsQ2xhc3NOYW1lJT4iIGlkPSI8JT1jSWQl
Pl9ncnBsYWJlbCI+PCU9bGFiZWwlPjwvbGFiZWw+JywKICAgICAgICc8ZGl2IGNsYXNzPSI8JT1j
b250cm9sc0NsYXNzTmFtZSU+IDwlPWV4dHJhQ2xhc3Nlcy5qb2luKFwnIFwnKSU+Ij4nLAotICAg
ICAgJyA8ZGl2IGNsYXNzPSJidG4tZ3JvdXAgcGdhZG1pbi1jb250cm9scy1yYWRpby1ub25lPCUg
aWYgKGRpc2FibGVkKSB7JT4gZGlzYWJsZWQgPCV9JT4iID4nLAorICAgICAgJyA8ZGl2IGNsYXNz
PSJidG4tZ3JvdXAgcGdhZG1pbi1jb250cm9scy1yYWRpby1ub25lPCUgaWYgKGRpc2FibGVkKSB7
JT4gZGlzYWJsZWQgPCV9JT4iIHJvbGU9InJhZGlvZ3JvdXAiIGFyaWEtbGFiZWxsZWRieT0iPCU9
Y0lkJT5fZ3JwbGFiZWwiPicsCiAgICAgICAnICA8JSBmb3IgKHZhciBpPTA7IGkgPCBvcHRpb25z
Lmxlbmd0aDsgaSsrKSB7ICU+JywKICAgICAgICcgIDwlIHZhciBvcHRpb24gPSBvcHRpb25zW2ld
OyAlPicsCi0gICAgICAnICA8bGFiZWwgY2xhc3M9ImJ0biBidG4tcmFkaW9tb2Rlcm4gPCUgaWYg
KG9wdGlvbi52YWx1ZSA9PSB2YWx1ZSkgeyAlPiBidG4tcHJpbWFyeSA8JX0gZWxzZSB7JT4gYnRu
LXNlY29uZGFyeSA8JX0lPiA8JSBpZiAoIW9wdGlvbi5kaXNhYmxlZCAmJiAhZGlzYWJsZWQpIHsg
JT4iIHRhYmluZGV4PSIwIjwlIH0gZWxzZSB7ICU+IGRpc2FibGVkIjwlIH0gJT4+JywKLSAgICAg
ICcgICAgPGkgY2xhc3M9ImZhIGZhLWNoZWNrICA8JSBpZiAob3B0aW9uLnZhbHVlICE9IHZhbHVl
KSB7ICU+dmlzaWJpbGl0eS1oaWRkZW4gPCV9JT4iPjwvaT4nLAorICAgICAgJyAgPGxhYmVsIHJv
bGU9InJhZGlvIiBjbGFzcz0iYnRuIGJ0bi1yYWRpb21vZGVybiA8JSBpZiAob3B0aW9uLnZhbHVl
ID09IHZhbHVlKSB7ICU+IGJ0bi1wcmltYXJ5IDwlfSBlbHNlIHslPiBidG4tc2Vjb25kYXJ5IDwl
fSU+IDwlIGlmICghb3B0aW9uLmRpc2FibGVkICYmICFkaXNhYmxlZCkgeyAlPiIgdGFiaW5kZXg9
IjAiPCUgfSBlbHNlIHsgJT4gZGlzYWJsZWQiPCUgfSAlPj4nLAorICAgICAgJyAgICA8aSBjbGFz
cz0iZmEgZmEtY2hlY2sgIDwlIGlmIChvcHRpb24udmFsdWUgIT0gdmFsdWUpIHsgJT52aXNpYmls
aXR5LWhpZGRlbiA8JX0lPiIgcm9sZT0iaW1nIj48L2k+JywKICAgICAgICcgICAgPGlucHV0IHR5
cGU9InJhZGlvIiBuYW1lPSI8JT1uYW1lJT4iIGF1dG9jb21wbGV0ZT0ib2ZmIiB2YWx1ZT08JS1m
b3JtYXR0ZXIuZnJvbVJhdyhvcHRpb24udmFsdWUpJT4gPCUgaWYgKG9wdGlvbi52YWx1ZSA9PSB2
YWx1ZSkgeyAlPiBjaGVja2VkPCV9JT4gPCUgaWYgKG9wdGlvbi5kaXNhYmxlZCB8fCBkaXNhYmxl
ZCkgeyAlPiBkaXNhYmxlZCA8JX0lPj4gPCUtb3B0aW9uLmxhYmVsJT4nLAogICAgICAgJyAgPC9s
YWJlbD4nLAogICAgICAgJyAgPCUgfSAlPicsCkBAIC01NDAsNiArNTQwLDcgQEAgZGVmaW5lKFsK
ICAgICAgICAgcmVxdWlyZWQ6IGV2YWxGKGRhdGEucmVxdWlyZWQsIGRhdGEsIHRoaXMubW9kZWwp
LAogICAgICAgfSk7IC8vIENsZWFuIHVwIGZpcnN0CiAKKyAgICAgIGRhdGEuY0lkID0gZGF0YS5j
SWQgfHwgXy51bmlxdWVJZCgncGdDXycpOwogICAgICAgZGF0YS5vcHRpb25zID0gXy5pc0Z1bmN0
aW9uKGRhdGEub3B0aW9ucykgPwogICAgICAgICBkYXRhLm9wdGlvbnMuYXBwbHkoZGF0YSwgW3Ro
aXMubW9kZWxdKSA6IGRhdGEub3B0aW9uczsKIApkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vc3Rh
dGljL2pzL2JhY2tncmlkLnBnYWRtaW4uanMgYi93ZWIvcGdhZG1pbi9zdGF0aWMvanMvYmFja2dy
aWQucGdhZG1pbi5qcwppbmRleCBiYjI0OTI2OGUuLmU4MmRhOGJlYyAxMDA2NDQKLS0tIGEvd2Vi
L3BnYWRtaW4vc3RhdGljL2pzL2JhY2tncmlkLnBnYWRtaW4uanMKKysrIGIvd2ViL3BnYWRtaW4v
c3RhdGljL2pzL2JhY2tncmlkLnBnYWRtaW4uanMKQEAgLTQzMiw3ICs0MzIsNyBAQCBkZWZpbmUo
WwogCiAgICAgICAgIGlmIChlZGl0YWJsZSkgewogICAgICAgICAgIHRoaXMuJGVsLmh0bWwoCi0g
ICAgICAgICAgICAnPGkgY2xhc3M9XCdmYSBmYS1wZW5jaWwtc3F1YXJlIHN1Ym5vZGUtZWRpdC1p
bi1wcm9jZXNzXCcgdGl0bGU9XCcnICsgXygnRWRpdCByb3cnKSArICdcJz48L2k+JworICAgICAg
ICAgICAgJzxpIGNsYXNzPVwnZmEgZmEtcGVuY2lsLXNxdWFyZSBzdWJub2RlLWVkaXQtaW4tcHJv
Y2Vzc1wnIHRpdGxlPVwnJyArIF8oJ0VkaXQgcm93JykgKyAgJ1wnIGFyaWEtbGFiZWw9XCcnICsg
XygnRWRpdCByb3cnKSArICAnXCc+PC9pPicKICAgICAgICAgICApOwogICAgICAgICAgIGxldCBi
b2R5ID0gJCh0aGlzLiRlbCkucGFyZW50cygpWzFdLAogICAgICAgICAgICAgY29udGFpbmVyID0g
JChib2R5KS5maW5kKCcudGFiLWNvbnRlbnQ6Zmlyc3QgPiAudGFiLXBhbmUuYWN0aXZlOmZpcnN0
Jyk7CkBAIC00NTEsNyArNDUxLDcgQEAgZGVmaW5lKFsKICAgICB9LAogICAgIHJlbmRlcjogZnVu
Y3Rpb24oKSB7CiAgICAgICB0aGlzLiRlbC5lbXB0eSgpOwotICAgICAgdGhpcy4kZWwuaHRtbCgn
PGkgY2xhc3M9XCdmYSBmYS1wZW5jaWwtc3F1YXJlLW9cJyB0aXRsZT1cJycgKyBfKCdFZGl0IHJv
dycpICsgJ1wnPjwvaT4nKTsKKyAgICAgIHRoaXMuJGVsLmh0bWwoJzxpIGNsYXNzPVwnZmEgZmEt
cGVuY2lsLXNxdWFyZS1vXCcgdGl0bGU9XCcnICsgXygnRWRpdCByb3cnKSArICdcJyBhcmlhLWxh
YmVsPVwnJyArIF8oJ0VkaXQgcm93JykgKyAgJ1wnPjwvaT4nKTsKICAgICAgIHRoaXMuZGVsZWdh
dGVFdmVudHMoKTsKICAgICAgIGlmICh0aGlzLmdyYWJGb2N1cykKICAgICAgICAgdGhpcy4kZWwu
dHJpZ2dlcignZm9jdXMnKTsKQEAgLTYwMyw5ICs2MDMsMTMgQEAgZGVmaW5lKFsKICAgICAgIC8v
IEhlcmUsIHdlIHdpbGwgYWRkIGN1c3RvbSBjbGFzc2VzIHRvIGhlYWRlciBjZWxsCiAgICAgICBC
YWNrZ3JpZC5IZWFkZXJDZWxsLnByb3RvdHlwZS5pbml0aWFsaXplLmFwcGx5KHRoaXMsIGFyZ3Vt
ZW50cyk7CiAgICAgICB2YXIgZ2V0Q2xhc3NOYW1lID0gdGhpcy5jb2x1bW4uZ2V0KCdjZWxsSGVh
ZGVyQ2xhc3NlcycpOworICAgICAgdmFyIGdldEFyaWFMYWJlbCA9IHRoaXMuY29sdW1uLmdldCgn
Y2VsbEFyaWFMYWJlbCcpOwogICAgICAgaWYgKGdldENsYXNzTmFtZSkgewogICAgICAgICB0aGlz
LiRlbC5hZGRDbGFzcyhnZXRDbGFzc05hbWUpOwogICAgICAgfQorICAgICAgaWYgKGdldEFyaWFM
YWJlbCkgeworICAgICAgICB0aGlzLiRlbC5hdHRyKCdhcmlhLWxhYmVsJywgZ2V0QXJpYUxhYmVs
KTsKKyAgICAgIH0KICAgICB9LAogICB9KTsKIApkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vc3Rh
dGljL3ZlbmRvci9iYWNrZm9ybS9iYWNrZm9ybS5qcyBiL3dlYi9wZ2FkbWluL3N0YXRpYy92ZW5k
b3IvYmFja2Zvcm0vYmFja2Zvcm0uanMKaW5kZXggNjQ2MTY3ZjM5Li5iNTk4ZmQ2MGUgMTAwNjQ0
Ci0tLSBhL3dlYi9wZ2FkbWluL3N0YXRpYy92ZW5kb3IvYmFja2Zvcm0vYmFja2Zvcm0uanMKKysr
IGIvd2ViL3BnYWRtaW4vc3RhdGljL3ZlbmRvci9iYWNrZm9ybS9iYWNrZm9ybS5qcwpAQCAtNTgx
LDggKzU4MSw4IEBACiAgICAgICAnICAgIDwlIHZhciBvcHRpb24gPSBvcHRpb25zW2ldOyAlPics
CiAgICAgICAnICAgIDwlIHZhciBpZCA9IF8udW5pcXVlSWQoImJmXyIpOyAlPicsCiAgICAgICAn
ICA8ZGl2IGNsYXNzPSJjdXN0b20tY29udHJvbCBjdXN0b20tcmFkaW8iPicsCi0gICAgICAnICAg
IDxpbnB1dCB0eXBlPSI8JT10eXBlJT4iIGNsYXNzPSJjdXN0b20tY29udHJvbC1pbnB1dCA8JT1l
eHRyYUNsYXNzZXMuam9pbihcJyBcJyklPiIgaWQ9IjwlPWNJZCU+IiBuYW1lPSI8JT1uYW1lJT4i
IHZhbHVlPSI8JS1mb3JtYXR0ZXIuZnJvbVJhdyhvcHRpb24udmFsdWUpJT4iIDwlPXJhd1ZhbHVl
ID09IG9wdGlvbi52YWx1ZSA/ICJjaGVja2VkPVwnY2hlY2tlZFwnIiA6ICIiJT4gPCU9ZGlzYWJs
ZWQgPyAiZGlzYWJsZWQiIDogIiIlPiA8JT1yZWFkb25seSA/ICJkaXNhYmxlZCIgOiAiIiU+IDwl
PXJlcXVpcmVkID8gInJlcXVpcmVkIiA6ICIiJT4gLz4nLAotICAgICAgJyAgICA8bGFiZWwgY2xh
c3M9ImN1c3RvbS1jb250cm9sLWxhYmVsIiBmb3I9IjwlPWNJZCU+Ij48JS1vcHRpb24ubGFiZWwl
PjwvbGFiZWw+JywKKyAgICAgICcgICAgPGlucHV0IHR5cGU9IjwlPXR5cGUlPiIgY2xhc3M9ImN1
c3RvbS1jb250cm9sLWlucHV0IDwlPWV4dHJhQ2xhc3Nlcy5qb2luKFwnIFwnKSU+IiBpZD0iPCU9
Y0lkJT48JT1pJT4iIG5hbWU9IjwlPW5hbWUlPiIgdmFsdWU9IjwlLWZvcm1hdHRlci5mcm9tUmF3
KG9wdGlvbi52YWx1ZSklPiIgPCU9cmF3VmFsdWUgPT0gb3B0aW9uLnZhbHVlID8gImNoZWNrZWQ9
XCdjaGVja2VkXCciIDogIiIlPiA8JT1kaXNhYmxlZCA/ICJkaXNhYmxlZCIgOiAiIiU+IDwlPXJl
YWRvbmx5ID8gImRpc2FibGVkIiA6ICIiJT4gPCU9cmVxdWlyZWQgPyAicmVxdWlyZWQiIDogIiIl
PiAvPicsCisgICAgICAnICAgIDxsYWJlbCBjbGFzcz0iY3VzdG9tLWNvbnRyb2wtbGFiZWwiIGZv
cj0iPCU9Y0lkJT48JT1pJT4iPjwlLW9wdGlvbi5sYWJlbCU+PC9sYWJlbD4nLAogICAgICAgJyAg
PC9kaXY+JywKICAgICAgICcgIDwlIH0gJT4nLAogICAgICAgJyAgPCUgaWYgKGhlbHBNZXNzYWdl
ICYmIGhlbHBNZXNzYWdlLmxlbmd0aCkgeyAlPicsCg==
--00000000000065433905a090a66b--