public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ganesh Jaybhay <[email protected]>
To: [email protected]
Subject: [pgAdmin4][patch] Few UI improvements and fixes
Date: Mon, 21 Jan 2019 16:29:04 +0530
Message-ID: <CAK6syAqy8YJocgFe-ZSL_oeTP3Oqcj-1CQ-xK3c8uyFnGMc5oQ@mail.gmail.com> (raw)

Hi Hackers,

Attached is the patch for below minor fixes:
1. Proper alignment of help message with date time control
2. Added help-block class for helpMessageClassName

Kindly review.

Regards,
Ganesh Jaybhay


Attachments:

  [application/octet-stream] fix_help_message.patch (1.1K, 3-fix_help_message.patch)
  download | inline diff:
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index f5783151..5de46af0 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -41,6 +41,7 @@ define([
     accordianGroupClassName: 'accordian-group pg-el-12',
     accordianContentClassName: 'accordian-content pg-el-12',
     hiddenClassName: 'd-none',
+    helpMessageClassName: 'form-text text-muted help-block',
   });
 
   Backform.controlMapper = {
@@ -2500,12 +2501,10 @@ define([
         ' <div class="input-group-append">',
         '   <span class="input-group-text fa fa-calendar"></span>',
         ' </div>',
-        '</div>',
         '<% if (helpMessage && helpMessage.length) { %>',
-        ' <div class="<%=Backform.controlsClassName%>">',
         '   <span class="<%=Backform.helpMessageClassName%>"><%=helpMessage%></span>',
-        ' </div>',
         '<% } %>',
+        '</div>',
       ].join('\n')),
       render: function() {
         var field = _.defaults(this.field.toJSON(), this.defaults),

view thread (2+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4][patch] Few UI improvements and fixes
  In-Reply-To: <CAK6syAqy8YJocgFe-ZSL_oeTP3Oqcj-1CQ-xK3c8uyFnGMc5oQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox