Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hlej0-0006n9-Ll for pgadmin-hackers@arkaria.postgresql.org; Thu, 11 Jul 2019 19:27:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hleiy-0007tp-Of for pgadmin-hackers@arkaria.postgresql.org; Thu, 11 Jul 2019 19:27:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hldzQ-0006zG-Dg for pgadmin-hackers@lists.postgresql.org; Thu, 11 Jul 2019 18:40:20 +0000 Received: from mail-yb1-xb41.google.com ([2607:f8b0:4864:20::b41]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hldzH-0005KB-T7 for pgadmin-hackers@postgresql.org; Thu, 11 Jul 2019 18:40:19 +0000 Received: by mail-yb1-xb41.google.com with SMTP id x32so2986425ybh.1 for ; Thu, 11 Jul 2019 11:40:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A0e4b6yxX0uqK/bdV+XmHiLqLbiPm0QOkAvbo6vaKp8=; b=hWJgMiZb8GkNknb8ECCou3D0pwbyFkePbZzjcW/kTwQ693VSYAod4fg46lwKGVibpx 99neG0raqqfPujIlYYCuf7eSZXXgcPeVyK9Dx/TlnmXLagbtjYLG/7lP0EDEumU6tWcR C8kin+Lu90aN1NhrRrA1BasJSRU5vAvGRASRIzL3Nfv1ZVapuub2ynJyJ066hGerpymf zARZ1bdr9lUH/8j/D1bc0Oi8bv0/kWzEdp6CvJCff84fzxNe8E7/D3EH45Uew+/2vZED zwFKYmcoL36vr24UuAnT3oNuwzgMgYngG1xFjP8e8SztsgzTXrX0eK4PoySVzDdRQphs c2Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A0e4b6yxX0uqK/bdV+XmHiLqLbiPm0QOkAvbo6vaKp8=; b=t3twZtEMie4T/oKufwJfYS7OJclhqSl93Fn+BTUkXjvgEIRbowST3Gll3f4dAf9683 h76+GvoDG75QgV1kkHjJfewTAJ8eJZJIrHfZsy3Xhm0HfKQuLD5Df0oQbz5rLOkuE/yT LFlwvG/kHPq7gOnhJsLVlSDhhSBsGvofud56amEBK/9WcjjbY7Kimk5PCsvMJ+z/aSvQ eISs6qJVPLcDJRxZba1gkHezbJCKkDdt+p1FSquz8Gtl/CWendsdJz2QRYrjLw4bagbK QzHPM5uzAwmvgbZsIJk1hxLP8tt0qvpSSF0WgTmS7h1lWTY3HkCu46C7nUY3B0i7CEWr oJCg== X-Gm-Message-State: APjAAAUGHtngBUt6dlp8szBkqZ+fAh3kPugdH5mr5cdBZsVXMbp7DP3U 5s70Y6F1XZog0xk0mKUPjhdjYZ4dH7fEKVPUMIYbOsLJItQ= X-Google-Smtp-Source: APXvYqxHP5/0pZrAU2ip/o1LpQaw0MeI8Les1wVYFss3OZwZRfhE1jaGBqwbdqMEZS+JUcV083dvXf/2XNJcC5j+e/s= X-Received: by 2002:a5b:c08:: with SMTP id f8mr3360800ybq.265.1562870408894; Thu, 11 Jul 2019 11:40:08 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ganesh Jaybhay Date: Fri, 12 Jul 2019 00:09:56 +0530 Message-ID: Subject: Re: [pgAdmin4][patch] Keyboard accessibility for sub-node control To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="0000000000008d94cd058d6c1f55" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000008d94cd058d6c1f55 Content-Type: multipart/alternative; boundary="0000000000008d94ca058d6c1f53" --0000000000008d94ca058d6c1f53 Content-Type: text/plain; charset="UTF-8" Hi Dave, Please find the attached patch for jasmine tests fix. Patch also includes fixes for edit/delete cell focus on IE by Murtuza. Regards, Ganesh Jaybhay On Thu, Jul 11, 2019 at 3:49 PM Dave Page wrote: > Hi Ganesh, > > It looks like this has broken the Jasmine tests (which I admit I forgot to > run before committing). Can you fix ASAP please? > > Thanks. > > On Thu, Jul 11, 2019 at 10:14 AM Dave Page wrote: > >> Thanks - patch applied with some doc tweaks. >> >> No need for a new ticket! >> >> On Thu, Jul 11, 2019 at 7:00 AM Ganesh Jaybhay < >> ganesh.jaybhay@enterprisedb.com> wrote: >> >>> Hi Dave, >>> >>> Ticket number 3919 refers to keyboard accessibility issues for sub-node >>> control and back grid but this patch covers only sub-node control. Should I >>> create new one? >>> I have added the screenshot having newly added shortcut and updated >>> keyboard shortcut rst file. Also moved the code changes from backgrid.js to >>> backgrid.pgadmin.js. >>> >>> Please find the attached updated patch. >>> >>> Regards, >>> Ganesh Jaybhay >>> >>> On Tue, Jul 9, 2019 at 9:28 PM Dave Page wrote: >>> >>>> Hi, >>>> >>>> What's the ticket number for this? That's a fair amount of code for a >>>> one-line description. There are also no doc changes describing how to >>>> navigate the sub-node control that I can see. >>>> >>>> Also; instead of changing the repo used for backgrid, can we not >>>> un-vendorise it? >>>> >>>> On Mon, Jul 8, 2019 at 4:49 PM Ganesh Jaybhay < >>>> ganesh.jaybhay@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached is the patch for keyboard accessibility of sub-node control. >>>>> It also covers sub-node dialog forward/backward tab navigation with >>>>> shortcuts. >>>>> >>>>> Kindly review. >>>>> >>>>> Regards, >>>>> Ganesh Jaybhay >>>>> >>>> >>>> >>>> -- >>>> Dave Page >>>> Blog: http://pgsnake.blogspot.com >>>> Twitter: @pgsnake >>>> >>>> EnterpriseDB UK: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --0000000000008d94ca058d6c1f53 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave,

Please find the attached patch= for jasmine tests fix. Patch also includes fixes for edit/delete cell focu= s on IE by Murtuza.

Regards,

<= div>Ganesh Jaybhay

On Thu, Jul 11, 2019 at 3:49 PM Dave Page <dpage@pgadmin.org>= wrote:
Hi Ganesh,

It looks like this has broken the Jasmine tests (which I admit I forg= ot to run before committing). Can you fix ASAP please?

=
Thanks.

On Thu, Jul 11, 2019 at 10:14 AM Dave Page <dpage@pgadmin.org> wrot= e:
Thanks - patch applied with s= ome doc tweaks.

No need for a new ticket!
On Thu, J= ul 11, 2019 at 7:00 AM Ganesh Jaybhay <ganesh.jaybhay@enterprisedb.com>= wrote:
Hi Dave= ,

Ticket number 3919 refers to keyboard accessibility is= sues for sub-node control and back grid but this patch covers only sub-node= control. Should I create new one?
I have added the screenshot ha= ving newly added shortcut and updated keyboard shortcut rst file. Also move= d the code changes from backgrid.js to backgrid.pgadmin.js.

<= /div>
Please find the attached updated patch.

= Regards,
Ganesh Jaybhay

On Tue, Jul 9, 2019 at 9:28 PM Dave = Page <dpage@pgadm= in.org> wrote:
Hi,
What's the ticket number for this? That's a fair amoun= t of code for a one-line description. There are also no doc changes describ= ing how to navigate the sub-node control that I can see.

Also; instead of changing the repo used for backgrid, can we not un-= vendorise it?

On Mon, Jul 8, 2019 at 4:49 PM Ganesh Jaybhay <ganesh.jaybh= ay@enterprisedb.com> wrote:
Hi Hackers,

Attached is the patch fo= r keyboard accessibility of sub-node control. It also covers sub-node dialo= g forward/backward tab navigation with shortcuts.

= Kindly review.

Regards,
Ganesh Jaybhay


--
Dave Page
Blog: http://pgsnake.blogspot.com=
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterpr= ise PostgreSQL Company


--
Dave Page
= Blog: http://pgsn= ake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.= com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twit= ter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Post= greSQL Company
--0000000000008d94ca058d6c1f53-- --0000000000008d94cd058d6c1f55 Content-Type: application/x-patch; name="jasmine_test_fix.patch" Content-Disposition: attachment; filename="jasmine_test_fix.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jxz0jw3o0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9qcy9iYWNrZ3JpZC5wZ2FkbWluLmpzIGIv d2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tncmlkLnBnYWRtaW4uanMKaW5kZXggMGQ5NjhhYS4u ODI3NTEzOCAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tncmlkLnBnYWRt aW4uanMKKysrIGIvd2ViL3BnYWRtaW4vc3RhdGljL2pzL2JhY2tncmlkLnBnYWRtaW4uanMKQEAg LTIwNiw2ICsyMDYsMTEgQEAgZGVmaW5lKFsKICAgICAgICAgICAgIGlmKGNlbGwgJiYgY2VsbC4k ZWwuaGFzQ2xhc3MoJ2VkaXQtY2VsbCcpICYmCiAgICAgICAgICAgICAgICFjZWxsLiRlbC5oYXND bGFzcygncHJpdmlsZWdlcycpIHx8IGNlbGwuJGVsLmhhc0NsYXNzKCdkZWxldGUtY2VsbCcpKSB7 CiAgICAgICAgICAgICAgIG1vZGVsLnRyaWdnZXIoJ2JhY2tncmlkOm5leHQnLCBtLCBuLCBmYWxz ZSk7CisgICAgICAgICAgICAgIGlmKGNlbGwuJGVsLmhhc0NsYXNzKCdkZWxldGUtY2VsbCcpKSB7 CisgICAgICAgICAgICAgICAgc2V0VGltZW91dChmdW5jdGlvbigpeworICAgICAgICAgICAgICAg ICAgJChjZWxsLiRlbCkudHJpZ2dlcignZm9jdXMnKTsKKyAgICAgICAgICAgICAgICB9LCA1MCk7 CisgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgICAgICB9IGVs c2UgaWYgKHJlbmRlcmFibGUgJiYgZWRpdGFibGUpIHsKICAgICAgICAgICAgICAgY2VsbC5lbnRl ckVkaXRNb2RlKCk7CmRpZmYgLS1naXQgYS93ZWIvcGdhZG1pbi9zdGF0aWMvc2Nzcy9fcGdhZG1p bi5zdHlsZS5zY3NzIGIvd2ViL3BnYWRtaW4vc3RhdGljL3Njc3MvX3BnYWRtaW4uc3R5bGUuc2Nz cwppbmRleCA4ZjFlMjQ4Li4wODJlODJjIDEwMDY0NAotLS0gYS93ZWIvcGdhZG1pbi9zdGF0aWMv c2Nzcy9fcGdhZG1pbi5zdHlsZS5zY3NzCisrKyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9zY3NzL19w Z2FkbWluLnN0eWxlLnNjc3MKQEAgLTc0MSw2ICs3NDEsMTcgQEAgdGFibGUgdHIgdGQgewogICB9 CiB9CiAKKy8qIFNwZWNpZmljIHRvIElFMTEgd2hlcmUgd2Ugd2FudCB0byBoaWdobGlnaHQgdGhl IGZvY3VzIG9uIGdyaWQgYnV0dG9ucyAqLworQG1lZGlhIGFsbCBhbmQgKC1tcy1oaWdoLWNvbnRy YXN0OiBub25lKSwgKC1tcy1oaWdoLWNvbnRyYXN0OiBhY3RpdmUpIHsKKyAgdGFibGUgdHIgdGQg eworICAgIHRkLmVkaXQtY2VsbDpmb2N1cywKKyAgICB0ZC5kZWxldGUtY2VsbDpmb2N1cywKKyAg ICB0ZC5zdHJpbmctY2VsbDpmb2N1cyB7CisgICAgICBib3JkZXI6IDJweCBzb2xpZCAkaW5wdXQt Zm9jdXMtYm9yZGVyLWNvbG9yICFpbXBvcnRhbnQ7OworICAgIH0KKyAgfQorfQorCiAucHJpdmls ZWdlX2xhYmVsewogICBmb250LXNpemU6IDEwcHghaW1wb3J0YW50OwogfQpkaWZmIC0tZ2l0IGEv d2ViL3JlZ3Jlc3Npb24vamF2YXNjcmlwdC9kaWFsb2dfdGFiX25hdmlnYXRvcl9zcGVjLmpzIGIv d2ViL3JlZ3Jlc3Npb24vamF2YXNjcmlwdC9kaWFsb2dfdGFiX25hdmlnYXRvcl9zcGVjLmpzCmlu ZGV4IDhlODZmYzguLjYwZTRiZGQgMTAwNjQ0Ci0tLSBhL3dlYi9yZWdyZXNzaW9uL2phdmFzY3Jp cHQvZGlhbG9nX3RhYl9uYXZpZ2F0b3Jfc3BlYy5qcworKysgYi93ZWIvcmVncmVzc2lvbi9qYXZh c2NyaXB0L2RpYWxvZ190YWJfbmF2aWdhdG9yX3NwZWMuanMKQEAgLTExLDcgKzExLDcgQEAgaW1w b3J0ICQgZnJvbSAnanF1ZXJ5JzsKIGltcG9ydCAnYm9vdHN0cmFwJzsKIAogZGVzY3JpYmUoJ2Rp YWxvZ1RhYk5hdmlnYXRvcicsIGZ1bmN0aW9uICgpIHsKLSAgbGV0IGRpYWxvZywgdGFiTmF2aWdh dG9yLCBiYWNrd2FyZF9zaG9ydGN1dCwgZm9yd2FyZF9zaG9ydGN1dDsKKyAgbGV0IGRpYWxvZywg dGFiTmF2aWdhdG9yLCBiYWNrd2FyZF9zaG9ydGN1dCwgZm9yd2FyZF9zaG9ydGN1dCwgZmFrZUV2 ZW50OwogCiAgIGJlZm9yZUVhY2goKCkgPT4gewogICAgIGRpYWxvZyA9ICQoJzxkaXYgdGFiaW5k ZXg9IjEiIGNsYXNzPSJiYWNrZm9ybS10YWIiIHJvbGU9InRhYnBhbmVsIj4nKwpAQCAtNjgsNiAr NjgsOSBAQCBkZXNjcmliZSgnZGlhbG9nVGFiTmF2aWdhdG9yJywgZnVuY3Rpb24gKCkgewogCiAg ICAgdGFiTmF2aWdhdG9yID0gbmV3IGRpYWxvZ1RhYk5hdmlnYXRvci5kaWFsb2dUYWJOYXZpZ2F0 b3IoCiAgICAgICBkaWFsb2csIGJhY2t3YXJkX3Nob3J0Y3V0LCBmb3J3YXJkX3Nob3J0Y3V0KTsK KworICAgIGZha2VFdmVudCA9IHsgc3RvcFByb3BhZ2F0aW9uOiAoKSA9PiB0cnVlIH07CisKICAg fSk7CiAKICAgZGVzY3JpYmUoJ25hdmlnYXRlJywgZnVuY3Rpb24gKCkgewpAQCAtNzksNyArODIs NyBAQCBkZXNjcmliZSgnZGlhbG9nVGFiTmF2aWdhdG9yJywgZnVuY3Rpb24gKCkgewogICAgIH0p OwogCiAgICAgaXQoJ25hdmlnYXRlIGJhY2t3YXJkJywgZnVuY3Rpb24gKCkgewotICAgICAgdGFi TmF2aWdhdG9yLm9uS2V5Ym9hcmRFdmVudCh7fSwgJ3NoaWZ0K2N0cmwrWycpOworICAgICAgdGFi TmF2aWdhdG9yLm9uS2V5Ym9hcmRFdmVudChmYWtlRXZlbnQsICdzaGlmdCtjdHJsK1snKTsKIAog ICAgICAgZXhwZWN0KHRhYk5hdmlnYXRvci5uYXZpZ2F0ZUJhY2t3YXJkKS50b0hhdmVCZWVuQ2Fs bGVkKCk7CiAKQEAgLTg4LDcgKzkxLDcgQEAgZGVzY3JpYmUoJ2RpYWxvZ1RhYk5hdmlnYXRvcics IGZ1bmN0aW9uICgpIHsKICAgICB9KTsKIAogICAgIGl0KCduYXZpZ2F0ZSBmb3J3YXJkJywgZnVu Y3Rpb24gKCkgewotICAgICAgdGFiTmF2aWdhdG9yLm9uS2V5Ym9hcmRFdmVudCh7fSwgJ3NoaWZ0 K2N0cmwrXScpOworICAgICAgdGFiTmF2aWdhdG9yLm9uS2V5Ym9hcmRFdmVudChmYWtlRXZlbnQs ICdzaGlmdCtjdHJsK10nKTsKIAogICAgICAgZXhwZWN0KHRhYk5hdmlnYXRvci5uYXZpZ2F0ZUZv cndhcmQpLnRvSGF2ZUJlZW5DYWxsZWQoKTsKIApAQCAtOTcsNyArMTAwLDcgQEAgZGVzY3JpYmUo J2RpYWxvZ1RhYk5hdmlnYXRvcicsIGZ1bmN0aW9uICgpIHsKICAgICB9KTsKIAogICAgIGl0KCdz aG91bGQgbm90IG5hdmlnYXRlJywgZnVuY3Rpb24gKCkgewotICAgICAgdGFiTmF2aWdhdG9yLm9u S2V5Ym9hcmRFdmVudCh7fSwgJ3NoaWZ0K2N0cmwrYScpOworICAgICAgdGFiTmF2aWdhdG9yLm9u S2V5Ym9hcmRFdmVudChmYWtlRXZlbnQsICdzaGlmdCtjdHJsK2EnKTsKIAogICAgICAgZXhwZWN0 KHRhYk5hdmlnYXRvci5uYXZpZ2F0ZUZvcndhcmQpLm5vdC50b0hhdmVCZWVuQ2FsbGVkKCk7CiAK QEAgLTExNSw3ICsxMTgsOCBAQCBkZXNjcmliZSgnZGlhbG9nVGFiTmF2aWdhdG9yJywgZnVuY3Rp b24gKCkgewogCiAgICAgICBuYXZpZ2F0ZUZvcndhcmRSZXN1bHQgPSB0YWJOYXZpZ2F0b3IubmF2 aWdhdGVGb3J3YXJkKAogICAgICAgICBkaWFsb2cuZmluZCgndWwubmF2LXRhYnM6Zmlyc3QnKSwK LSAgICAgICAgZGlhbG9nLmZpbmQoJ2RpdiMxJykKKyAgICAgICAgZGlhbG9nLmZpbmQoJ2RpdiMx JyksCisgICAgICAgIGZha2VFdmVudAogICAgICAgKTsKICAgICB9KTsKIApAQCAtMTQxLDcgKzE0 NSw4IEBAIGRlc2NyaWJlKCdkaWFsb2dUYWJOYXZpZ2F0b3InLCBmdW5jdGlvbiAoKSB7CiAKICAg ICAgIG5hdmlnYXRlRm9yd2FyZFJlc3VsdCA9IHRhYk5hdmlnYXRvci5uYXZpZ2F0ZUZvcndhcmQo CiAgICAgICAgIGRpYWxvZy5maW5kKCd1bC5uYXYtdGFiczpmaXJzdCcpLAotICAgICAgICBkaWFs b2cuZmluZCgnZGl2IzEnKQorICAgICAgICBkaWFsb2cuZmluZCgnZGl2IzEnKSwKKyAgICAgICAg ZmFrZUV2ZW50CiAgICAgICApOwogICAgIH0pOwogCkBAIC0xNjUsNyArMTcwLDggQEAgZGVzY3Jp YmUoJ2RpYWxvZ1RhYk5hdmlnYXRvcicsIGZ1bmN0aW9uICgpIHsKIAogICAgICAgbmF2aWdhdGVC YWNrd2FyZFJlc3VsdCA9IHRhYk5hdmlnYXRvci5uYXZpZ2F0ZUJhY2t3YXJkKAogICAgICAgICBk aWFsb2cuZmluZCgndWwubmF2LXRhYnM6Zmlyc3QnKSwKLSAgICAgICAgZGlhbG9nLmZpbmQoJ2Rp diMxJykKKyAgICAgICAgZGlhbG9nLmZpbmQoJ2RpdiMxJyksCisgICAgICAgIGZha2VFdmVudAog ICAgICAgKTsKICAgICB9KTsKIApAQCAtMTg0LDcgKzE5MCw4IEBAIGRlc2NyaWJlKCdkaWFsb2dU YWJOYXZpZ2F0b3InLCBmdW5jdGlvbiAoKSB7CiAKICAgICAgIG5hdmlnYXRlQmFja3dhcmRSZXN1 bHQgPSB0YWJOYXZpZ2F0b3IubmF2aWdhdGVCYWNrd2FyZCgKICAgICAgICAgZGlhbG9nLmZpbmQo J3VsLm5hdi10YWJzOmZpcnN0JyksCi0gICAgICAgIGRpYWxvZy5maW5kKCdkaXYjMScpCisgICAg ICAgIGRpYWxvZy5maW5kKCdkaXYjMScpLAorICAgICAgICBmYWtlRXZlbnQKICAgICAgICk7CiAg ICAgfSk7CiAK --0000000000008d94cd058d6c1f55--