Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMYxj-0004Up-5x for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jul 2016 11:01:19 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bMYxi-0004QS-Gn for pgadmin-hackers@arkaria.postgresql.org; Mon, 11 Jul 2016 11:01:18 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bMYxh-0004QL-Tz for pgadmin-hackers@postgresql.org; Mon, 11 Jul 2016 11:01:18 +0000 Received: from mail-qt0-x22c.google.com ([2607:f8b0:400d:c0d::22c]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1bMYxe-00012u-8a for pgadmin-hackers@postgresql.org; Mon, 11 Jul 2016 11:01:16 +0000 Received: by mail-qt0-x22c.google.com with SMTP id w38so12018231qtb.0 for ; Mon, 11 Jul 2016 04:01:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+BYsGlbDKHqtxW9Aj4V3DwKGa08HJyt7CUKEZuhIn+g=; b=rp+EcAyXZisj4GQVryhCtVWElt525+oWrIGEC4Mwyn5YIxiQeXvw1JcnJ6HSFvVcti PubSqlVKfLANkVwlkEHqONEuHV3mfbNG01D/lPaGFs1irh6KvAHEl6fS51mZYerzxNpY ISPOea3JytAjCgMgl+Zqv6Oc16cw3w4ThLHY2jkL1RJlx9MpaXvQeVxfH65sFZ4bsrm1 fQZoXT3PT+jzz4yqRs4o2pHi6s1JlQq+7qz5dPbfSiblBHUXC0U97krFzWkKTA2xbHsd 7cOQA1R/lNJ+L1B71hKzPVeALmayH+8H6vafTccBbxE+UhAYS04sj5przCRJC79he9Nx C7Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+BYsGlbDKHqtxW9Aj4V3DwKGa08HJyt7CUKEZuhIn+g=; b=UdE6vzA6jMbJeVwWb4REh6WR+etAJ2x/ZKoj1lxcMVRFKtt3+9UyPya8tryxxtT/9F yTqZC/fwF0twR55d4tZvVKjbs2Ly3jUdOxxOQBuMQd2jIbOcbug6M9uyfVMby15PvXZv GYeL5LI6bD1t7/1jqLwOQTzPIFGZ/aL/LEhRtv6fJQZHl+i4qb3vjzXsCwMe/FDcNI+5 cHF3+qQluIoDlnPZSdZsjhRHVDS2Ugwn5kHfehHfMFtxodcJmc7dHZTXW7HVCdUdgDsl OFt6A4ap5LXkri5Q4W+OAzxpJGNAHJ3iybvZueC0ac3ktBuuGkp7HOI//jw1V8LTjbM2 YEgQ== X-Gm-Message-State: ALyK8tKYmmGVuIewja7+v0lHVewp1vzL6bHkDwkwnM5FSX4mdOzckwZmPpgp6adx8FjSmvEPJF+KrNKnFexecFhs X-Received: by 10.200.43.97 with SMTP id 30mr28410211qtv.2.1468234873086; Mon, 11 Jul 2016 04:01:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.8.3 with HTTP; Mon, 11 Jul 2016 04:00:53 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Mon, 11 Jul 2016 16:30:53 +0530 Message-ID: Subject: Re: PATCH: To fix salt generation in session.py To: Ashesh Vashi Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary=001a113f183a0ed8ae05375a12df X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a113f183a0ed8ae05375a12df Content-Type: text/plain; charset=UTF-8 Hi, Tested, I'm able to login now. Thanks, Murtuza -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jul 11, 2016 at 4:05 PM, Ashesh Vashi wrote: > Hi Murtuza, > > Can you please test this patch for the same? > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > > > > *http://www.linkedin.com/in/asheshvashi* > > > On Mon, Jul 11, 2016 at 12:44 PM, Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> Hi, >> >> Please hold on in this patch, Need additional changes. >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> On Mon, Jul 11, 2016 at 12:41 PM, Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi, >>> >>> With latest pull session.py fails with below error with python3 because >>> in python3 strings 'lowercase' method has been renamed to >>> 'ascii_lowercase', PFA patch to fix the issue. >>> >>> Issue: >>> ---------- >>> * File "../pgadmin4/web/pgadmin/utils/session.py", line 59, in sign* >>> * self.randval = >>> ''.join(random.sample(string.lowercase+string.digits, 20))* >>> *AttributeError: module 'string' has no attribute 'lowercase'* >>> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > --001a113f183a0ed8ae05375a12df Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi,

Tested, I'm able to login now.<= /div>


Thanks,
Murtuza

--
Regards,
Murtuza Zabuawala
Enter= priseDB:=C2=A0http://www.enterpris= edb.com
The Enterprise PostgreSQL Company

On Mon, Jul 11, 2016 at 4:05 PM, Ashesh Vash= i <ashesh.vashi@enterprisedb.com> wrote:
Hi Murtuza,

= Can you please test this patch for the same?

--

Thanks & Regards,

Ashesh Vashi<= /span>
Ent= erpriseDB INDIA: Enterprise PostgreSQL Company

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Mon, Jul 11, 2016 at 12:44 PM, Murtuza Za= buawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

Please hold on in this patch, Need additional changes.
<= div class=3D"gmail_extra">
--
<= font color=3D"#888888">Murtuza Zabuawala
EnterpriseDB:=C2=A0<= a href=3D"http://www.enterprisedb.com/" rel=3D"noreferrer" style=3D"color:r= gb(17,85,204)" target=3D"_blank">http://www.enterprisedb.com
The Ente= rprise PostgreSQL Company

On Mon, Jul 11, 2016 at 12:= 41 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.= com> wrote:
Hi,

With latest pull session.py fails with below error= with python3 because in python3 strings 'lowercase' method has bee= n renamed to 'ascii_lowercase', PFA patch to fix the issue.

Issue:
----------
=C2=A0 File= "../pgadmin4/web/pgadmin/utils/session.py", line 59, in sign=
=C2=A0 =C2=A0 self.randval =3D ''.join(random.sample(= string.lowercase+string.digits, 20))
AttributeError: modul= e 'string' has no attribute 'lowercase'

<= /div>

--
Regards,
Murtuza Zabuawala
EnterpriseD= B:=C2=A0http://www.enterprisedb.co= m
The Enterprise PostgreSQL Company



--001a113f183a0ed8ae05375a12df--