Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ercMy-0003CD-JX for pgadmin-hackers@arkaria.postgresql.org; Fri, 02 Mar 2018 04:32:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ercMx-0004sy-Il for pgadmin-hackers@arkaria.postgresql.org; Fri, 02 Mar 2018 04:32:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ercMx-0004so-CR for pgadmin-hackers@lists.postgresql.org; Fri, 02 Mar 2018 04:32:31 +0000 Received: from mail-ot0-x22e.google.com ([2607:f8b0:4003:c0f::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ercMs-0005zh-Fz for pgadmin-hackers@postgresql.org; Fri, 02 Mar 2018 04:32:30 +0000 Received: by mail-ot0-x22e.google.com with SMTP id l12so7716677otj.7 for ; Thu, 01 Mar 2018 20:32:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=3etDw2UYBqQN3J9bIiSRE/Wk7QFN5gp9z1z9n1Vq6Xg=; b=oyh66i1FM0P1ep46gruxI5DQ5W3gABgrLv0ajg3gr+ho6NNutUfmKgj6t2tnn/ibz7 7OJVU1ywFXC9ET9oM9FuqZ0r5v9iJ+lcTSxMVbKlGUxOPyHl7f+wheVBGSfX0YqXKsxg 5Acv9jv3lm72PJ0EsuKzMngSAkw80UY3g4Na+bnOo/4xwlhNTUKycH/sx+IOVahm/Hij FBxxd711cv/t738/03GSsuT+IqkKWDAspXRFAt0kawXzWlm3doaWv2K/IlOm5zs5rpus AM3psWUcI2wJmMFR+FbIWu6dRVo1RRfUSP38Y3skLRi7+9SSOIfrH3+3pehnqCreV2SE SSlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=3etDw2UYBqQN3J9bIiSRE/Wk7QFN5gp9z1z9n1Vq6Xg=; b=k3diHi0wuFQahi6qdqVMqUXEhdun3wuL990OG3r/psiZ5uVAoTHAQMT/xeO6e7hzN4 qJl4Nq1FTNQfrhyQgOXvrxNeiSiiXzPNMQWU+K8iPUDMB/pEbwGh2nEYE4xA8tD9EmuM N6mwSBe8K2DUQJCWWPz3sD+eV6tztSlT+hQbNStinYAbtFKuW79F6t/+DdLspLg4kWE0 9KDCZvvyn5aLPc6AQLrlE+6AcnfuZA9NdwcTyr3vXesQmv10IiofjyaYWd8V2m5Y65BX LnUxH5r1Rw1Rp+lK1tRsaqC6xZM2bpgZQFv3yxiSquCMEplNvuNICNAcCUSN8zRatKwo 3IXg== X-Gm-Message-State: APf1xPDnzK0dEZKy7XYcm8461WPkI0tewu0CTLtGitg0uYP7YiqV3HNf 1+C0yJuDbuqBoF/VMZ62YrafaIQ6XN6OnMO7VRp9Lg== X-Google-Smtp-Source: AG47ELv4MJNEzGax6kB16OcGsNZhVvoxYBJgm/PEhc4udI8bHpDUUhi4juQ/ThfLq3yFwm9VnKzF3MqDWvv7ToZZvhM= X-Received: by 10.157.22.233 with SMTP id s38mr3083724ots.97.1519965143460; Thu, 01 Mar 2018 20:32:23 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.8.150 with HTTP; Thu, 1 Mar 2018 20:32:03 -0800 (PST) In-Reply-To: References: From: Murtuza Zabuawala Date: Fri, 2 Mar 2018 10:02:03 +0530 Message-ID: Subject: Re: Feature #3061 To: Neethu Mariya Joy Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="001a114790ea7284b10566667675" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a114790ea7284b10566667675 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, On Fri, Mar 2, 2018 at 3:33 AM, Neethu Mariya Joy wrote: > Hi, > > Thanks for the reply. I had a look at the commit and tried out the first > part. > > I have a few doubts. > a. Now that we are adding options for each individual graph, should we > remove the previous show graphs option or keep it as an override when it = is > false? > =E2=80=8BI think we should keep that what if user wants to disable all the = graphs on dashboards including the user defined custom graphs=E2=80=8B, User has g= o and disable each every graphs, if we provide a single option to turn off all the graphs then it will be more user friendly. b. Do widgets include tables or just the graphs? > =E2=80=8BYes, It may include Table as you can see in "Server Activity" sect= ion but in custom table we will only display it in terms of plain HTML table and we won't use Backgrid.=E2=80=8B > > Sincerely, > Neethu > > On Thu, Mar 1, 2018 at 10:39 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hello, >> >> First of all I'm assuming that you have some degree of knowledge about >> Python, HTML, JS & Git. >> >> We have had added similar feature recently. >> Check: https://redmine.postgresql.org/issues/2951 for more details. >> Code location of Dashboard module in git repository: >> ../pgadmin4/web/pgadmin/dashboard >> >> There are 3 requirments in the ticket, >> 1) disable/enable some widgets (widget - Server Sessions | Transactions >> per second | Tuples in etc) >> We have done this for all the graphs in one shot, now user can >> enable/disable all the graphs via preferences dialog. >> You can refer the commit >> >> as a reference if you want to add this functionality for each >> individual graphs. >> >> 2) add custom/user specify widgets >> - First of all, You need to provide an option to Create new dashboard >> dialog, Update existing dashboard dialog option and also to delete those >> existing custom dashboards on dashboard page. >> - You have to create a separate table in sqlite3 database to store the >> data for that user defined dashboards like Dashboard name, SQL etc. >> - You also have to provide option to use to choose what type of graph >> user wants (Line chart, Pie chart, Table etc) >> - Size & location of the graph/table. >> >> 3) add user role with access only to dashboard >> This needs further discussion with community members if we really need >> this or not. >> >> You can refer README for more information regarding how to run pgAdmin4. >> >> Let us know if you need any help. >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> >> On Wed, Feb 28, 2018 at 6:29 PM, Neethu Mariya Joy < >> neethumariyajoy@gmail.com> wrote: >> >>> Hi, >>> >>> I am Neethu Mariya Joy, an undergraduate sophomore pursuing BE(Hons) in >>> Computer Engineering from BITS Pilani, India. >>> >>> I would like to work on the feature #3061, "Dashboard Customisation". >>> Kindly provide suggestions for the same. >>> >>> Sincerely, >>> Neethu Mariya Joy >>> GitHub | Linkedin >>> >>> >> >> > --001a114790ea7284b10566667675 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

On Fri, Mar 2, 2018 at 3:33 AM, Neethu Mariy= a Joy <neethumariyajoy@gmail.com> wrote:
Hi,

Thanks for t= he reply. I had a look at the commit and tried out the first part.

I have a few doubts.
a. Now that we are adding o= ptions for each individual graph, should we remove the previous show graphs= option or keep it as an override when it is false?

=E2=80=8BI think we should keep that what if user wants to disa= ble all the graphs on dashboards including the user defined custom graphs= =E2=80=8B, User has go and disable each every graphs, if we provide a singl= e option to turn off all the graphs then it will be more user friendly.

b. Do widgets include tables or just t= he graphs?

=
=E2=80=8BYes, It may include= Table as you can see in "Server Activity" section but in custom = table we will only display it in terms of plain HTML table and we won't= use Backgrid.=E2=80=8B
=C2=A0

Sincerely,
Neethu

On Thu, = Mar 1, 2018 at 10:39 AM, Murtuza Zabuawala <murtuza.zabua= wala@enterprisedb.com> wrote:
Hello,

First of all I'm assuming that you have some degree= of knowledge about Python, HTML, JS & Git.

We have had added similar feat= ure recently.
Check:=C2=A0https://redmine.post= gresql.org/issues/2951 for more details.
Code location of Dashboard module in git repos= itory: ../pgadmin4/web/pg= admin/dashboard

There are 3 requirments in the ticket,
<= font color=3D"#444444" face=3D"verdana, sans-serif">1) disable/enable some = widgets (widget - Server Sessions | Transactions per second | Tuples in etc= )=C2=A0
We have done this for all the graphs in one shot, now user can enable/di= sable all the graphs via preferences dialog.
You can refer the commit as a reference if you want to add this fu= nctionality=C2=A0for each individual=C2=A0graphs.

2) add custom/user specify wid= gets=C2=A0
- First of all, You need to provide an option to Create new dashboard= dialog, Update existing dashboard dialog option and also to delete those e= xisting custom dashboards on dashboard page.
= - You have to create a separate=C2=A0table in sqlite3 database to store the= data for that user defined dashboards like Dashboard name, SQL etc.=
- You also = have to provide option to use to choose what type of graph user wants (Line= chart, Pie chart, Table etc)
- Size & location of the graph/table.

This needs further=C2=A0dis= cussion with community members if we really need this or not.
<= div>
<= div>
You can refer README for more information regarding= how to run pgAdmin4.

Let us know if you need any help.

<= /div>

--
Regards,Mur= tuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Wed, Feb 28, 2018 at 6:29 PM, Neethu Mari= ya Joy <neethumariyajoy@gmail.com> wrote:
Hi,=C2=A0

I am = Neethu Mariya Joy,=C2=A0an undergraduate sophomo= re pursuing BE(Hons) in Computer Engineering from BITS Pilani, India.=C2=A0=

I would like to work on the feature #3061, "Dashboa= rd Customisation". Kindly provide suggestions for the same.

Sincerely,
Neethu Mariy= a Joy
GitHub=C2=A0|=C2=A0Linkedin



--001a114790ea7284b10566667675--