public inbox for [email protected]  
help / color / mirror / Atom feed
From: Murtuza Zabuawala <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4)
Date: Thu, 14 Jul 2016 11:30:55 +0530
Message-ID: <CAKKotZQ4mpJFGeVnRUCbRCO0YDoQsg2AmrL1WYTrJg4xRbz3Fw@mail.gmail.com> (raw)
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi,

PFA patch to fix the issue in timestamp datatype(s) displaying with time as
00:00
(RM#1437)

The issue was with backgrid datetime cell which do not fully support ISO-8601
datetime format.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers


Attachments:

  [application/octet-stream] RM_1437.patch (1.1K, 3-RM_1437.patch)
  download | inline diff:
diff --git a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
index 965d56e..8b2d8dd 100644
--- a/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
+++ b/web/pgadmin/tools/sqleditor/templates/sqleditor/js/sqleditor.js
@@ -1556,9 +1556,17 @@ define(
                     case "numeric":
                       col_cell = 'number';
                       break;
+                    case "date":
+                    case "reltime":
+                    case "abstime":
                     case "timestamp without time zone":
                     case "timestamp with time zone":
-                      col_cell = 'datetime';
+                    case "time with time zone":
+                    case "time without time zone":
+                    case "interval":
+                      col_cell = Backgrid.DatetimeCell.extend({
+                        formatter: Backgrid.StringFormatter,
+                      });
                       break;
                     case "json":
                     case "json[]":


view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: PATCH: To fix Timestamps displaying with time as 00:00 (pgAdmin4)
  In-Reply-To: <CAKKotZQ4mpJFGeVnRUCbRCO0YDoQsg2AmrL1WYTrJg4xRbz3Fw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox