Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f4MAs-0005bH-CN for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 Apr 2018 07:52:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f4MAr-0001lH-9K for pgadmin-hackers@arkaria.postgresql.org; Fri, 06 Apr 2018 07:52:41 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f4MAq-0001l6-PW for pgadmin-hackers@lists.postgresql.org; Fri, 06 Apr 2018 07:52:41 +0000 Received: from mail-oi0-x22e.google.com ([2607:f8b0:4003:c06::22e]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f4MAn-000610-Bu for pgadmin-hackers@postgresql.org; Fri, 06 Apr 2018 07:52:39 +0000 Received: by mail-oi0-x22e.google.com with SMTP id f63-v6so258052oic.4 for ; Fri, 06 Apr 2018 00:52:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=juZWAK0+US94JA2ZhoTEKE55ImlEjKQlJqh3FWtx31Q=; b=KhKc8engPQHWjBXElwfmikIho802ArqKjYk++zfBWewMceC77FYUf7IlSNzDhxRYdv eSChBpOVB82SBVBg3QORj+jyMbwdEiFRShiZCvr/4q2c2VTWuO3x9K4zp4kRPj2O+Zla yoLOn28/57P7XcxxHMTV11vOe90ib366cD1+3jHxXeiPKTQYNFzODaZVqxQ8JKGVAtN1 qk1dg4On6DcCrjqDga81eqVLpjbPE8OVBCnwkKURwp3lqljLiOibF0CD1ceqln9yo9Rz 1RWGtYJ6eYfj4MfAN52MnSpcUZgLaSSDVL+N9pmBl8aXgPzcSEiZuHNKAPXQWkh5Moop YDpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=juZWAK0+US94JA2ZhoTEKE55ImlEjKQlJqh3FWtx31Q=; b=T5YSsOtdRJMIsLSBfZBfrEIcB7fdM+zPLcTeYIVaaLm0XM2JOar/SfYEWyOT+gtEF7 kt32Sy1sssPUxkgtPI33ZVaebOP2K5qG2ZUWIkWLixu3ae9l/tInpEbFUFNtakkENCP0 tPquctvzhhMCUJVdFgoUUrC6AgaCHM7b2+67Jutz+RldyFktVfQgGhVuXG+ns8XaG51t dVUI6HsrZGv/jrrYDxE4RSPG5vcMZeJ7hr21MLMeLMPQBOLU/1nSENNa1OsbE8jkaqJP LfUk11wR39gCWNTZdssq3lqjWHYT26LRU63/7GV9ZxFzLNHOjrJ9Pn25v7s4HT9j4mRy rRoQ== X-Gm-Message-State: ALQs6tCmDT8ObxiB0H4Jh23vLzYD0XeHUexJR5wrB7/H1BOzzxpPgcdv zFhkaigIL6HytagLGIYTgmfzSF7/MhGs3KaTxraUXQ== X-Google-Smtp-Source: AIpwx49Hd/u/6J5Nk6xv2RtBMKIanREtwq0aPntQBPOEx/8pe5S0zjOQlfeT2hVbm3QQoESh1AXgjFHrmzHD7OKLd4g= X-Received: by 2002:aca:ce43:: with SMTP id e64-v6mr15341795oig.342.1523001156253; Fri, 06 Apr 2018 00:52:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.138.6.138 with HTTP; Fri, 6 Apr 2018 00:52:15 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Fri, 6 Apr 2018 13:22:15 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#3154] Update modules to latest version To: Dave Page Cc: Joao De Almeida Pereira , pgadmin-hackers Content-Type: multipart/alternative; boundary="000000000000e950d6056929564e" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --000000000000e950d6056929564e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Dave, I checked and found that the issue was in wcDocker which was causing problem while opening query tool, I have logged an issue on github: https://github.com/WebCabin/wcDocker/issues/124 Query tool, Debugger etc are working properly when open in new Browser Tab and not in Panel. I'm also able to fix the issue which I was facing while running Jasmine test by correctting the path for *jquery.event.drag* library from jquery.event.drag-2.2 to jquery.event.drag-2.3.0. Let's wait for author's reply on the issue. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Apr 4, 2018 at 3:20 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > On Wed, Apr 4, 2018 at 3:19 PM, Dave Page wrote: > >> >> >> On Wed, Apr 4, 2018 at 8:24 AM, Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi Joao, >>> >>> Yes it bundles latest version but I doubt that is not using it, If we >>> upgrade the jQuery to 3.3.1 then it's breaking the SlickGrid. >>> I have tried that and I started getting jQuery related errors when >>> trying to run query tool or when running jasmine tests. >>> >> >> Can you spend some time trying to figure it out please? We need to get o= n >> to 3.x as older versions are no longer receiving updates which could pos= e a >> security risk. >> > =E2=80=8BSure Dave.=E2=80=8B > > >> >> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >>> On Wed, Apr 4, 2018 at 1:39 AM, Joao De Almeida Pereira < >>> jdealmeidapereira@pivotal.io> wrote: >>> >>>> Hi Murtuza, >>>> >>>> The patches look good and they pass all tests in CI. >>>> One think that we realized was the SlickGrid as a npm package now: >>>> https://www.npmjs.com/package/slickgrid >>>> Also Slickgrid comes packaged with jquery 3.1 not sure if it is fully >>>> supported or not...... >>>> >>>> Thanks >>>> Victoria & Joao >>>> >>>> On Tue, Apr 3, 2018 at 11:50 AM Murtuza Zabuawala < >>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>> >>>>> =E2=80=8BHi Dave, >>>>> >>>>> Reverted back jQuery version to 1.x because of SlickGrid dependancy. >>>>> Please find updated patch. >>>>> >>>>> -- >>>>> Regards, >>>>> Murtuza Zabuawala >>>>> EnterpriseDB: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>>> >>>>> On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabuawala < >>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>> >>>>>> Please hold on my previous patch. >>>>>> >>>>>> We can't use latest jQuery version as SlickGrid has dependancy on >>>>>> older version. >>>>>> I'll send updated patch again. >>>>>> >>>>>> On Tue, Apr 3, 2018 at 8:20 PM, Murtuza Zabuawala < >>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Dave, >>>>>>> >>>>>>> Please find updated patches, there are two patches attached one is >>>>>>> for the story and another is for changes required as per new module= s. >>>>>>> >>>>>>> >>>>>>> On Tue, Apr 3, 2018 at 6:27 PM, Dave Page wrote= : >>>>>>> >>>>>>>> Hi >>>>>>>> >>>>>>>> On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala < >>>>>>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> PFA patch to update the modules to latest version. >>>>>>>>> >>>>>>>>> >>>>>>>> - Why isn't jQuery updated to 3.3.1? >>>>>>>> >>>>>>> =E2=80=8BDone=E2=80=8B >>>>>>> >>>>>>> >>>>>>>> =E2=80=8B >>>>>>>> >>>>>>>> >>>>>>> >>>>>>>> - Shouldn't pkg/pip/setup_pip.py be updated with changes to >>>>>>>> psycopg2 and pycrypto etc? >>>>>>>> >>>>>>> =E2=80=8BDone=E2=80=8B >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> We are not able to update some of the modules to latest version >>>>>>>>> due to dependancy on other modules, For example >>>>>>>>> - Python: Flask-Security has dependancy on flask-babelex which >>>>>>>>> causes conflict with flask_babel >>>>>>>>> >>>>>>>> >>>>>>>> Hmm, flask-babelex might be a better option anyway; in particular, >>>>>>>> it avoids loading catalogs with every request which seems desirabl= e given >>>>>>>> the size of ours. On the other hand, it hasn't been updated so rec= ently. >>>>>>>> >>>>>>> =E2=80=8BI have removed flask-babel and used flask_babelex instead.= =E2=80=8B >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> - JS: Can't update to Bootstrap4 because Bootstrap Switch & >>>>>>>>> Bootstrap Datetime picker has dependancy on Bootstrap3. >>>>>>>>> >>>>>>>> >>>>>>>> OK. >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Dave Page >>>>>>>> Blog: http://pgsnake.blogspot.com >>>>>>>> Twitter: @pgsnake >>>>>>>> >>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>>>>> The Enterprise PostgreSQL Company >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --000000000000e950d6056929564e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Dave,

I checked and found that the issue was in wcDocker which was cau= sing problem while opening query tool,
I have logged an= issue on github:=C2=A0https://github.com/WebCabin/wcDocker/issues/124

Query tool, Debugger etc are working properly= when open in new Browser Tab and not in Panel.

I'm also able to fix the issue which I was facing whi= le running Jasmine test by correctting the path for=C2=A0jquery.event.dr= ag library from=C2=A0= jquery.event.drag-2.2 to=C2=A0jquery.event.drag-2.3.0.

Let&= #39;s wait for author's reply on the issue.


--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0<= a href=3D"http://www.enterprisedb.com/" rel=3D"noreferrer" target=3D"_blank= ">http://www.enterprisedb.com
The Enterprise PostgreSQL Company

=

On Wed, Apr 4, 2018 at 3:20 PM, Murtuza Zabu= awala <murtuza.zabuawala@enterprisedb.com> = wrote:
On Wed, Apr 4, 201= 8 at 3:19 PM, Dave Page <dpage@pgadmin.org> wrote:
=


On Wed, Apr 4, 2018 at 8:24 AM, Murtuza Zabuawala <= ;mu= rtuza.zabuawala@enterprisedb.com> wrote:
Hi Joao,

Yes it bundles latest version but I doubt that is not using = it, If we upgrade the jQuery to 3.3.1 then it's breaking the SlickGrid.=
I have tr= ied that and I started getting jQuery related errors when trying to run que= ry tool or when running jasmine tests.

Can you spend some time trying to figure it out please? We need to = get on to 3.x as older versions are no longer receiving updates which could= pose a security risk.
=E2=80=8BSure Dave.=E2=80=8B
=C2=A0
=C2=A0

--
Reg= ards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company
<= /div>
<= br>

On Wed, Apr 4, 2018 at 1:39 AM, Joao De Almeid= a Pereira <jdealmeidapereira@pivotal.io> wrote:
Hi Murtuza,

The patches look good and they pass all tests in CI.
One th= ink that we realized was the SlickGrid as a npm package now:=C2=A0https://www.= npmjs.com/package/slickgrid=C2=A0
Also Slickgrid comes p= ackaged with jquery 3.1 not sure if it is fully supported or not......

Thanks
Victoria & Joao

On Tue, Apr 3, 2018 at 11:50 AM Murtuza= Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
=E2=80=8BHi Dave,

Reverted back jQue= ry version to 1.x because of SlickGrid dependancy.
= Please find updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0h= ttp://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Tue, Apr 3, 2018 at 8:50 PM, Murtuza Zabu= awala <murtuza.zabuawala@enterprisedb.com> wrote:
Please hold on my previou= s patch.=C2=A0

= We can't use latest jQuery version as SlickGrid has dependancy on older= version.
= I'll send updated patch again.

On Tue, Apr 3, 2018 at 8:20 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wro= te:
Hi Dave,

Please find updated patches, there are tw= o patches attached one is for the story and another is for changes required= as per new modules.

<= /div>

On Tue, Apr 3, 2018 at 6:27 PM, Dave Page <= dpage@pgadmin.org> wrote:
<= div dir=3D"ltr">Hi

On Fri, Mar 30, 2018 at 8:01 AM, Murtuza Zabuawala &= lt;= murtuza.zabuawala@enterprisedb.com> wrote:
Hi,

PFA patch to update the modules to latest version.


- Why isn't jQuery updated to 3.3.1?
=E2=80=8BDone=E2=80=8B
= =C2=A0
=E2=80=8B
=C2=A0

- Shouldn't pkg/pip/setup_pip.py be updated with changes to psycopg2= and pycrypto etc?=C2=A0
=E2=80=8BDone=E2=80=8B
=C2=A0
<= div dir=3D"ltr">
=
=C2=A0
=
We are not able to updat= e some of the modules to latest version due to dependancy on other modules,= For example
- Python: Flask-Security has dependancy on flask-babelex which causes co= nflict with flask_babel

Hmm, fl= ask-babelex might be a better option anyway; in particular, it avoids loadi= ng catalogs with every request which seems desirable given the size of ours= . On the other hand, it hasn't been updated so recently.
=E2=80=8BI have removed flask-babel and us= ed flask_babelex instead.=E2=80=8B
=C2=A0
=C2=A0
- JS: Can't updat= e to Bootstrap4 because Bootstrap Switch & = Bootstrap=C2=A0Datetime picker has dependancy on Bootstrap3.

OK.=C2=A0
=


--
Dave Page
Blog: http://pgsnake.blogspot.= com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The = Enterprise PostgreSQL Company
=







--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB= UK: http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company


--000000000000e950d6056929564e--