public inbox for [email protected]
help / color / mirror / Atom feedFrom: Murtuza Zabuawala <[email protected]>
To: Dave Page <[email protected]>
Cc: George Gelashvili <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Subject: Re: feature test timeouts
Date: Tue, 30 May 2017 16:13:51 +0530
Message-ID: <CAKKotZQBJmZrYBbuvi3G=gFyiixFxzv3jUDWy4u5jJkrOhv9pA@mail.gmail.com> (raw)
In-Reply-To: <CA+OCxowRJo7a8m4K3-ZK+TtscZV++4d0bnHe+hmyGY3KCkF-2Q@mail.gmail.com>
References: <CAHowoHbxP5Y6cN+0tYMe9M13m0vaupqOwoUdKnoUuZm5qzSH2Q@mail.gmail.com>
<CA+OCxowDqkgj2G0SoUhKgu1U1P6uHRcoqDz6t=7H2VUCC4hn0w@mail.gmail.com>
<CAKKotZRJUrMDTOdOVJ4ouZCLG4MSu3EDmd7PVKDA=EAvsjRRpg@mail.gmail.com>
<CA+OCxowRJo7a8m4K3-ZK+TtscZV++4d0bnHe+hmyGY3KCkF-2Q@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgadmin-hackers>
Hi Dave,
I didn't look into the code for it but every time I run the tests it stays
on below screen and fails.
@Khushboo,
Any suggestion?
[image: Inline image 1]
--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Tue, May 30, 2017 at 2:15 PM, Dave Page <[email protected]> wrote:
> Hi
>
> OK. Do you know why? What's it waiting for? It was working for me (I
> always run tests multiple times before committing them, to try to
> ensure they're reliable).
>
> On Mon, May 29, 2017 at 7:23 AM, Murtuza Zabuawala
> <[email protected]> wrote:
> > Hi Dave,
> >
> > With latest pull, PG data-type test fails on my system,
> >
> > ======================================================================
> > ERROR: runTest
> > (pgadmin.feature_tests.pg_datatype_validation_test.PGDataypeFeatureTest)
> > Test checks for PG data-types output
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> > File
> > "/Users/edb/Documents/projects/pgadmin4/web/pgadmin/
> feature_tests/pg_datatype_validation_test.py",
> > line 44, in runTest
> > self._check_datatype()
> > File
> > "/Users/edb/Documents/projects/pgadmin4/web/pgadmin/
> feature_tests/pg_datatype_validation_test.py",
> > line 97, in _check_datatype
> > self.page.fill_codemirror_area_with(query)
> > File
> > "/Users/edb/Documents/projects/pgadmin4/web/regression/feature_utils/
> pgadmin_page.py",
> > line 122, in fill_codemirror_area_with
> >
> > "//pre[contains(@class,'CodeMirror-line')]/../../../*[
> contains(@class,'CodeMirror-code')]").click()
> > File
> > "/Users/edb/Documents/projects/pgadmin4/web/regression/feature_utils/
> pgadmin_page.py",
> > line 87, in find_by_xpath
> > return self.wait_for_element(lambda driver:
> > driver.find_element_by_xpath(xpath))
> > File
> > "/Users/edb/Documents/projects/pgadmin4/web/regression/feature_utils/
> pgadmin_page.py",
> > line 152, in wait_for_element
> > return self._wait_for("element to exist", element_if_it_exists)
> > File
> > "/Users/edb/Documents/projects/pgadmin4/web/regression/feature_utils/
> pgadmin_page.py",
> > line 188, in _wait_for
> > "Timed out waiting for " + waiting_for_message)
> > File
> > "/Users/edb/Documents/projects/venv_pg4/lib/python3.
> 5/site-packages/selenium/webdriver/support/wait.py",
> > line 80, in until
> > raise TimeoutException(message, screen, stacktrace)
> > selenium.common.exceptions.TimeoutException: Message: Timed out waiting
> for
> > element to exist
> >
> >
> > ----------------------------------------------------------------------
> > Ran 6 tests in 170.026s
> >
> > FAILED (errors=1)
> >
> > ======================================================================
> > Test Result Summary
> > ======================================================================
> >
> > PG_95:
> >
> > 5 tests passed
> > 1 test failed:
> > PGDataypeFeatureTest (Test checks for PG data-types output)
> > 0 tests skipped
> >
> > ======================================================================
> >
> > Please check output in file:
> > /Users/edb/Documents/projects/pgadmin4/web/regression/regression.log
> >
> >
> > --
> > Regards,
> > Murtuza Zabuawala
> > EnterpriseDB: http://www.enterprisedb.com
> > The Enterprise PostgreSQL Company
> >
> > On Sat, May 27, 2017 at 11:47 PM, Dave Page <[email protected]> wrote:
> >>
> >> Thanks, patch applied.
> >>
> >> On Fri, May 26, 2017 at 6:26 PM, George Gelashvili
> >> <[email protected]> wrote:
> >> > Hello Hackers,
> >> >
> >> > We are running tests including feature tests in Circle CI, and have
> been
> >> > seeing some flakiness due to what we believe are insufficient wait-for
> >> > timeouts.
> >> >
> >> > This shouldn't increase the overall test time, but only allow waiting
> >> > longer
> >> > for an element to appear, if needed.
> >> >
> >> > We've also split out the app start timeout since that seemed to need
> >> > more
> >> > time on CI.
> >> >
> >> > Patch attached.
> >> >
> >> > Thanks!
> >> > Joao, Matt, and George
> >> >
> >> >
> >> > --
> >> > Sent via pgadmin-hackers mailing list ([email protected]
> )
> >> > To make changes to your subscription:
> >> > http://www.postgresql.org/mailpref/pgadmin-hackers
> >> >
> >>
> >>
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >>
> >>
> >> --
> >> Sent via pgadmin-hackers mailing list ([email protected])
> >> To make changes to your subscription:
> >> http://www.postgresql.org/mailpref/pgadmin-hackers
> >
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
Attachments:
[image/png] image.png (353.2K, 3-image.png)
download | view image
view thread (9+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: feature test timeouts
In-Reply-To: <CAKKotZQBJmZrYBbuvi3G=gFyiixFxzv3jUDWy4u5jJkrOhv9pA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox