Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jEor9-0007oq-EE for pgadmin-hackers@arkaria.postgresql.org; Thu, 19 Mar 2020 06:40:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jEor8-0006fh-5d for pgadmin-hackers@arkaria.postgresql.org; Thu, 19 Mar 2020 06:40:38 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jEor7-0006fZ-I2 for pgadmin-hackers@lists.postgresql.org; Thu, 19 Mar 2020 06:40:37 +0000 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jEor4-0000Qd-3U for pgadmin-hackers@postgresql.org; Thu, 19 Mar 2020 06:40:36 +0000 Received: by mail-ot1-x342.google.com with SMTP id 39so1293737otu.3 for ; Wed, 18 Mar 2020 23:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FQ8hXNb1PigJB+dXaM+a+Gu6smcxy3400PpjUmwIQVo=; b=i6vg3vYpNbYWAp0AlF3ascw25WFHZ2jm96o/m9xzoCOirso73A7WjdaqzpJOsxy8k5 m3ihoanRwOKcZszyiqGhaC4sftAzxch/uYeuAW0cHCVft9Zsv1T3pLSXrTuSq2SZmkHD /V8q+dcvIGcXR7CTKPXjYucKIvZnNR70ydnHsGwtwLigz28TiXO1SzdvFFS0GM65HrKw 5XHjzpJfYvJ4c+xGYMp3ZdWe+0GmMk5KBmh/jQyXhdPrMa4enIDdfXyrdlEK350wZ9lw JaJrVb35nIUG/vo7moRmVdsL+dYpOMwyW2gkK3Gf6A2rLc+KPRx6iPgnioAJHauqmzey nTmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FQ8hXNb1PigJB+dXaM+a+Gu6smcxy3400PpjUmwIQVo=; b=Y3wabS7nCg7sJzstzjPyJxuYfDJLM7fdvF2HFFWcx9xsVxIFHhDo2vCPVOZAbEqrlJ 9Lk0QqOYlaeC6tngwAEatZIRNbc+MXl6liMWeSPekcvhY7KrT6IhX734PRgSdsVDfilS p7pWfuh4uzfj3xITJNgN0clFiw3cy7cLGNSKh8Hq0zFpD+fpiBKK5nDL8ZCL/3bJ+7CD aR9gedPwyQ8Z9tmRG5Jn1Gc4nOALvO5cK5Awpha3SqzBPzFlMxBRxthvy3FNAwjt8Xep Q/4eaqpu7bcPfW6Ns58ZpR4RW8T2ou5k0wwC74/LLzWADHxa6hq7LXr4P61qPkeWjQL/ YJiw== X-Gm-Message-State: ANhLgQ2AXR59vvDgU6fjenPY/hU0Lm1A5KfWfkX8rluQE41iJqE7/1K5 M/uoc6+rA3J9UtkkAnbvfuT5nSkgRQ1VP/GW6xKlDjQPoU3r724aWHsTefrur/aCrwAd496x/Dz iZyBPXYkCJC/ECtAUgMcHdlgr3p73tE2Tfwa4zW3d07ysc9lNGSE62THPwaDE0Irw3HxC46/iuf N7RF5zvQXjlf9cfCxlflF7nOatebseDOV+gNS1biBWZycL7lyi/xQ= X-Google-Smtp-Source: ADFU+vv4rNANUnzdygBViX50CURtlz0unICZZodzOkFiy8M3t6wiSWX+qE5nWAh7DSBEhRwjUmtKn72N6sj01zEZi0E= X-Received: by 2002:a9d:30c7:: with SMTP id r7mr1045454otg.289.1584600033361; Wed, 18 Mar 2020 23:40:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Murtuza Zabuawala Date: Thu, 19 Mar 2020 12:10:17 +0530 Message-ID: Subject: Re: [pgAdmin4][RM 5271] To change the switch control colors To: Aditya Toshniwal Cc: Chethana Kumar , pgadmin-hackers Content-Type: multipart/mixed; boundary="00000000000019b00d05a12f7254" X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000019b00d05a12f7254 Content-Type: multipart/alternative; boundary="00000000000019b00a05a12f7252" --00000000000019b00a05a12f7252 Content-Type: text/plain; charset="UTF-8" Hello, PFA updated patch with new colors provided by Chethana, As discussed we will be using the same primary success color in both theme so we don't have add new variable. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Wed, Mar 18, 2020 at 2:27 PM Aditya Toshniwal < aditya.toshniwal@enterprisedb.com> wrote: > Hi Murtuza/Chethana, > > Irrespective of what color you suggest, there is no need to add new > variables for switch buttons. It should use success for on and ternary for > off. > Having a separate green color for each and every control is absurd. If the > green changes, it should change for all. > > On Wed, Mar 18, 2020 at 2:24 PM Chethana Kumar < > chethana.kumar@enterprisedb.com> wrote: > >> Let us discuss on a call for better clarity and the conclusion part we >> can put it on mail. >> >> --- >> Chethana kumar >> >> On Wed, Mar 18, 2020 at 2:12 PM Murtuza Zabuawala < >> murtuza.zabuawala@enterprisedb.com> wrote: >> >>> Hi Chethana, >>> >>> No it is not, As per current dark theme implementation we have used >>> primary color '#1a522b' for switch but the color you suggested is '#43A047' >>> for both theme. >>> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >>> >>> On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar < >>> chethana.kumar@enterprisedb.com> wrote: >>> >>>> Hi Murtuza, >>>> >>>> The changes are already incorporated so no worries :) >>>> >>>> Thanks, >>>> >>>> --- >>>> Chethana kumar >>>> >>>> On Wed, Mar 18, 2020 at 12:43 PM Murtuza Zabuawala < >>>> murtuza.zabuawala@enterprisedb.com> wrote: >>>> >>>>> Hello, >>>>> >>>>> As per discussion with Chethana, We need to make switch box color >>>>> change for light and dark theme, Color details provided by Chethana is >>>>> updated on ticket. >>>>> >>>>> >>>>> -- >>>>> Regards, >>>>> Murtuza Zabuawala >>>>> EnterpriseDB: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>>> >>>> >>>> -- >>>> Chethana Kumar >>>> Principal UI/UX Designer >>>> EnterpriseDB Corporation >>>> >>>> The Postgres Database Company >>>> >>>> P: +91 86981 57146 >>>> www.enterprisedb.com >>>> >>> >> >> -- >> Chethana Kumar >> Principal UI/UX Designer >> EnterpriseDB Corporation >> >> The Postgres Database Company >> >> P: +91 86981 57146 >> www.enterprisedb.com >> > > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > --00000000000019b00a05a12f7252 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

PFA updat= ed patch with new colors provided by Chethana, As discussed we will be usin= g the same primary success=C2=A0color in both theme so we don't have ad= d new variable.


--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com=
The Enterprise PostgreSQL Company

<= /font>


On Wed, Mar 18, 2020 at 2:27 PM Aditya Toshn= iwal <aditya.toshni= wal@enterprisedb.com> wrote:
H= i Murtuza/Chethana,

Irrespective of what color you suggest, there is n= o need to add new variables for switch buttons. It should use success for o= n and ternary for off.
Having a separate green color for each and every con= trol is absurd. If the green changes, it should change for all.
=
On Wed= , Mar 18, 2020 at 2:24 PM Chethana Kumar <chethana.kumar@enterprisedb.com&= gt; wrote:
Let us discuss on a c= all for better clarity and the conclusion part we can put it on mail.
<= br>
---
Chethana kumar

On Wed, Mar 18, 2020 at 2:1= 2 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Chethana,

<= div class=3D"gmail_default">No it is not, As per current dark theme implementation=C2=A0we have u= sed primary color '#1a522b' for switch but the color you suggested = is '#43A047= ' for both theme.


--
Regards,
Murtuza Zabuawa= la
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterpri= se PostgreSQL Company

<= /div>


On Wed, Mar 18, 2020 at 2:06 PM Chethana Kumar &= lt;che= thana.kumar@enterprisedb.com> wrote:
Hi Murtuza,

The changes are already incorpor= ated so no worries :)

Thanks,

=
---
Chethana kumar

On Wed, Mar 18, 2020 at 12:43 PM Mur= tuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
=
Hello,

As per discussion with Cheth= ana, We need to make switch box color change for light and dark theme, Colo= r details provided by Chethana is updated on ticket.
=C2=A0

=
--=
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.enter= prisedb.com
The Enterprise PostgreSQL Company

=


--
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation

The Postgres Database Company

P: +91 86981= 57146
=


--
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation

The Postgres Database Company

P: +91 86981= 57146
=


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer |=C2=A0Ent= erpriseDB India |=C2=A0Pune<= /span>
"Don't Complain about Heat, Plant a TREE"=
--00000000000019b00a05a12f7252-- --00000000000019b00d05a12f7254 Content-Type: application/octet-stream; name="RM_5271_v1.diff" Content-Disposition: attachment; filename="RM_5271_v1.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k7ydwlph0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9zY3NzL3Jlc291cmNlcy9fZGVmYXVsdC52 YXJpYWJsZXMuc2NzcyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9zY3NzL3Jlc291cmNlcy9fZGVmYXVs dC52YXJpYWJsZXMuc2NzcwppbmRleCAxNGRiOTEyZjAuLjlmZTMwY2I5ZSAxMDA2NDQKLS0tIGEv d2ViL3BnYWRtaW4vc3RhdGljL3Njc3MvcmVzb3VyY2VzL19kZWZhdWx0LnZhcmlhYmxlcy5zY3Nz CisrKyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9zY3NzL3Jlc291cmNlcy9fZGVmYXVsdC52YXJpYWJs ZXMuc2NzcwpAQCAtMjUsNyArMjUsNyBAQCAkY29sb3ItZGFuZ2VyLWxpZ2h0ZXI6ICNGQUVDRUMg IWRlZmF1bHQ7CiAKICRjb2xvci1zdWNjZXNzOiAjNDNhMDQ3ICFkZWZhdWx0OwogJGNvbG9yLXN1 Y2Nlc3MtZmc6ICRibGFjayAhZGVmYXVsdDsKLSRjb2xvci1zdWNjZXNzLWxpZ2h0OiAjRERGMURF ICFkZWZhdWx0OworJGNvbG9yLXN1Y2Nlc3MtbGlnaHQ6ICNEOUVDREEgIWRlZmF1bHQ7CiAKICRj b2xvci13YXJuaW5nOiAjZWVhMjM2ICFkZWZhdWx0OwogJGNvbG9yLXdhcm5pbmctZmc6ICRibGFj ayAhZGVmYXVsdDsKZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9zY3NzL3Jlc291cmNl cy9kYXJrL190aGVtZS52YXJpYWJsZXMuc2NzcyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9zY3NzL3Jl c291cmNlcy9kYXJrL190aGVtZS52YXJpYWJsZXMuc2NzcwppbmRleCBlODI2NDBlYmEuLjg3MmZl NmY2MiAxMDA2NDQKLS0tIGEvd2ViL3BnYWRtaW4vc3RhdGljL3Njc3MvcmVzb3VyY2VzL2Rhcmsv X3RoZW1lLnZhcmlhYmxlcy5zY3NzCisrKyBiL3dlYi9wZ2FkbWluL3N0YXRpYy9zY3NzL3Jlc291 cmNlcy9kYXJrL190aGVtZS52YXJpYWJsZXMuc2NzcwpAQCAtMTcsOSArMTcsOSBAQCAkY29sb3It ZGFuZ2VyLWZnOiAkd2hpdGU7CiAkY29sb3ItZGFuZ2VyLWxpZ2h0OiAjOTE0NjQ5OwogJGNvbG9y LWRhbmdlci1saWdodGVyOiAjMjEyMTIxOwogCi0kY29sb3Itc3VjY2VzczogIzFhNTIyYjsKKyRj b2xvci1zdWNjZXNzOiAjNDNhMDQ3OwogJGNvbG9yLXN1Y2Nlc3MtZmc6ICRibGFjazsKLSRjb2xv ci1zdWNjZXNzLWxpZ2h0OiAjNWE3ODYzOworJGNvbG9yLXN1Y2Nlc3MtbGlnaHQ6ICMyQjQ3MkM7 CiAKICRjb2xvci13YXJuaW5nOiAjZWVhMjM2OwogJGNvbG9yLXdhcm5pbmctZmc6ICRibGFjazsK --00000000000019b00d05a12f7254--