Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1boV1k-0003wT-HA for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Sep 2016 12:28:56 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1boV1k-0000JE-0X for pgadmin-hackers@arkaria.postgresql.org; Mon, 26 Sep 2016 12:28:56 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1boV1V-0008VW-K7 for pgadmin-hackers@postgresql.org; Mon, 26 Sep 2016 12:28:41 +0000 Received: from mail-qk0-x235.google.com ([2607:f8b0:400d:c09::235]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1boV1R-0007mg-Kz for pgadmin-hackers@postgresql.org; Mon, 26 Sep 2016 12:28:40 +0000 Received: by mail-qk0-x235.google.com with SMTP id t7so160978837qkh.2 for ; Mon, 26 Sep 2016 05:28:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=9FuUhvEQDE6mTNbNKlt/IiZkB7It/MEHmZFCcosFdcQ=; b=aVGEJj3NZZST8wZw9DbPUJAcJCWfxo5dVAEOfl0IWeqMT0oN4uI31ND2QAiDNuVUS/ TDzkWqa8q+PzkHmy5vKGTcBsq7rRgDvCSDX4NGHGvM95b0gDCjTonpqOHuUEge8qhhQ2 uR/4UoiZyorApi/AODolL3yPHTXyVdq6nEfz/F4CSjUxMtDqqVYxb0Q378NQu6nnhbbL sWDEiAUVLmOprjgTpmfzpzVOXblPxFa59B6CmNILbBDySwlfXtxspITg9sUbiO8B7AN0 4ufPZPmEVcurW1tx83fMTihv2LVR10S42UfRd9RKMkh8Euyo4bv3zddDBr/Ye00lg3AX Vpjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=9FuUhvEQDE6mTNbNKlt/IiZkB7It/MEHmZFCcosFdcQ=; b=YdcH+B2/Vix0sHOqWPf8XsjBoUOkR7uWJ7b3Fx9bTttTYcoAcOpBxeDCQV6FHAuggk anfK5UR+4UOFGcx+m/tCBo9/c5v/ay5bTBW4xzgCTekp7xbvp8zcNVGdg/e+zFrDGb6B /nesmpRLIbkJqydZ4UJitflulQaA9GC/2qst5ojFgg0FRgZsH9yeW5qTF4glXt9BZso9 4nC9xLVfPi59zVr6lueOEGnu5uNolzZX56pei1MJanPA5YGkLy/K6Yob2wCOi2hAFNAy LloYDOpeqXHUE4yBVHEk9pCy/0k7R0jBjgo2iXOQIoIfsKmFij6OtTZcrJC9qe2hn6mS e8AQ== X-Gm-Message-State: AA6/9RkfwjEaOp4OHvmkhaW6XvOGWdLNyDRZhZ5iLIeoDm3xcOvgtvAlugRtFnGZk1/udclmWz3NFMtfiE9nRoa0 X-Received: by 10.55.20.78 with SMTP id e75mr9404236qkh.267.1474892916626; Mon, 26 Sep 2016 05:28:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.55.129.194 with HTTP; Mon, 26 Sep 2016 05:28:16 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Mon, 26 Sep 2016 17:58:16 +0530 Message-ID: Subject: Re: PATCH: To fix the issue in Debugger module (pgAdmin4) To: Dave Page Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary=001a1144c42e614563053d684496 X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgadmin-hackers Precedence: bulk Sender: pgadmin-hackers-owner@postgresql.org --001a1144c42e614563053d684496 Content-Type: multipart/alternative; boundary=001a1144c42e614561053d684494 --001a1144c42e614561053d684494 Content-Type: text/plain; charset=UTF-8 Hi Dave, PFA updated patch to fix `
` tag display. Please clear cache & try again with this updated patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Sep 26, 2016 at 5:44 PM, Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > > > On Mon, Sep 26, 2016 at 5:08 PM, Dave Page wrote: > >> Hi >> >> On Mon, Sep 26, 2016 at 11:09 AM, Murtuza Zabuawala >> wrote: >> > Hi, >> > >> > PFA patch to fix the issue where it was not disabling buttons after >> > execution gets finished. >> > RM#1227 >> > >> > Issue: >> > If user clicks on buttons after execution is complete then it was >> throwing >> > error, expected behaviour was all button should gets disabled except >> execute >> > button. >> >> This is an improvement I think, but not complete: >> >> - The info messages are now shown, but: >> - Not until execution ends, which limits their usefulness for >> additional debugging. Not sure if that's easily changeable though. > > - The line breaks in messages are displaying like this: "INFO: >> Employee 1 not found
SELECT 1" >> > It's showing properly on my side, Please clear browser cache & try again. > >> - The first execution of the function worked OK, but following the >> second execution, I again saw: "Debugger: Step into execution error" >> as I stepped out of the RETURN statement on line 18. >> > This is transient issue, so need more debugging. > > >> >> Thanks. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > --001a1144c42e614561053d684494 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Dave,

PFA updated patch to fix `<= br>` tag display.
Please clear cache & try again with this= updated patch.

--
Regards,Murtu= za Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Company
=

On Mon, Sep 26, 2016 at 5:44 PM, Murtuza Zab= uawala <murtuza.zabuawala@enterprisedb.com>= wrote:

<= /div>

On Mon, Sep 26, 2016 at 5:08 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
= Hi

On Mon, Sep 26, 2016 at 11:09 AM, Murtuza Zabuawala
<murtuza.zabuawala@enterprisedb.com> wrote:
> Hi,
>
> PFA patch to fix the issue where it was not disabling buttons after
> execution gets finished.
> RM#1227
>
> Issue:
> If user clicks on buttons after execution is complete then it was thro= wing
> error, expected behaviour was all button should gets disabled except e= xecute
> button.

This is an improvement I think, but not complete:

- The info messages are now shown, but:
=C2=A0 - Not until execution ends, which limits their usefulness for
additional debugging. Not sure if that's easily changeable though.=C2= =A0
=C2=A0 - The line breaks in messages are displaying like this: "INFO:<= br> Employee 1 not found <br>SELECT 1"=C2=A0
It= 's showing properly on my side, Please clear browser cache & try ag= ain.=C2=A0
- The first execution of the function worked OK, but following the
second execution, I again saw: "Debugger: Step into execution error&qu= ot;
as I stepped out of the RETURN statement on line 18.
T= his is transient issue, so need more debugging.
=C2=A0

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--001a1144c42e614561053d684494-- --001a1144c42e614563053d684496 Content-Type: application/octet-stream; name="RM_1227_v1.patch" Content-Disposition: attachment; filename="RM_1227_v1.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_itk12ywb0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3Rvb2xzL2RlYnVnZ2VyL19faW5p dF9fLnB5IGIvd2ViL3BnYWRtaW4vdG9vbHMvZGVidWdnZXIvX19pbml0X18u cHkKaW5kZXggZjdkMGU3Yi4uYWIyMjAyMyAxMDA2NDQKLS0tIGEvd2ViL3Bn YWRtaW4vdG9vbHMvZGVidWdnZXIvX19pbml0X18ucHkKKysrIGIvd2ViL3Bn YWRtaW4vdG9vbHMvZGVidWdnZXIvX19pbml0X18ucHkKQEAgLTEzNDMsOCAr MTM0MywxNCBAQCBkZWYgcG9sbF9lbmRfZXhlY3V0aW9uX3Jlc3VsdCh0cmFu c19pZCk6CiAgICAgaWYgY29ubi5jb25uZWN0ZWQoKToKICAgICAgICAgc3Rh dHVzbXNnID0gY29ubi5zdGF0dXNfbWVzc2FnZSgpCiAgICAgICAgIHN0YXR1 cywgcmVzdWx0LCBjb2xfaW5mbyA9IGNvbm4ucG9sbCgpCi0gICAgICAgIGlm IHN0YXR1cyA9PSBBU1lOQ19PSyBhbmQgc2Vzc2lvblsnZnVuY3Rpb25EYXRh J11bc3RyKHRyYW5zX2lkKV1bJ2xhbmd1YWdlJ10gPT0gJ2VkYnNwbCc6Cisg ICAgICAgIGlmIHN0YXR1cyA9PSBBU1lOQ19PSyBhbmQgXAorICAgICAgICAg ICAgICAgIG5vdCBzZXNzaW9uWydmdW5jdGlvbkRhdGEnXVtzdHIodHJhbnNf aWQpXVsnaXNfZnVuYyddIGFuZCBcCisgICAgICAgICAgICAgICAgc2Vzc2lv blsnZnVuY3Rpb25EYXRhJ11bc3RyKHRyYW5zX2lkKV1bJ2xhbmd1YWdlJ10g PT0gJ2VkYnNwbCc6CiAgICAgICAgICAgICBzdGF0dXMgPSAnU3VjY2VzcycK KyAgICAgICAgICAgIGFkZGl0aW9uYWxfbXNncyA9IGNvbm4ubWVzc2FnZXMo KQorICAgICAgICAgICAgaWYgbGVuKGFkZGl0aW9uYWxfbXNncykgPiAwOgor ICAgICAgICAgICAgICAgIHN0YXR1c21zZyA9ICI8YnI+Ii5qb2luKGFkZGl0 aW9uYWxfbXNncykgKyAiPGJyPiIgKyBzdGF0dXNtc2cKKwogICAgICAgICAg ICAgcmV0dXJuIG1ha2VfanNvbl9yZXNwb25zZShzdWNjZXNzPTEsIGluZm89 Z2V0dGV4dCgiRXhlY3V0aW9uIENvbXBsZXRlZC4iKSwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgZGF0YT17J3N0YXR1cyc6IHN0 YXR1cywgJ3N0YXR1c19tZXNzYWdlJzogc3RhdHVzbXNnfSkKICAgICAgICAg aWYgcmVzdWx0OgpAQCAtMTM1NCw2ICsxMzYwLDEwIEBAIGRlZiBwb2xsX2Vu ZF9leGVjdXRpb25fcmVzdWx0KHRyYW5zX2lkKToKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGRhdGE9eydzdGF0dXMnOiBz dGF0dXMsICdzdGF0dXNfbWVzc2FnZSc6IHJlc3VsdH0pCiAgICAgICAgICAg ICBlbHNlOgogICAgICAgICAgICAgICAgIHN0YXR1cyA9ICdTdWNjZXNzJwor ICAgICAgICAgICAgICAgIGFkZGl0aW9uYWxfbXNncyA9IGNvbm4ubWVzc2Fn ZXMoKQorICAgICAgICAgICAgICAgIGlmIGxlbihhZGRpdGlvbmFsX21zZ3Mp ID4gMDoKKyAgICAgICAgICAgICAgICAgICAgc3RhdHVzbXNnID0gIjxicj4i LmpvaW4oYWRkaXRpb25hbF9tc2dzKSArICI8YnI+IiArIHN0YXR1c21zZwor CiAgICAgICAgICAgICAgICAgY29sdW1ucyA9IFtdCiAgICAgICAgICAgICAg ICAgIyBDaGVjayBjb2x1bW4gaW5mbyBpcyBhdmFpbGFibGUgb3Igbm90CiAg ICAgICAgICAgICAgICAgaWYgY29sX2luZm8gaXMgbm90IE5vbmUgYW5kIGxl bihjb2xfaW5mbykgPiAwOgpkaWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vdG9v bHMvZGVidWdnZXIvdGVtcGxhdGVzL2RlYnVnZ2VyL2pzL2RpcmVjdC5qcyBi L3dlYi9wZ2FkbWluL3Rvb2xzL2RlYnVnZ2VyL3RlbXBsYXRlcy9kZWJ1Z2dl ci9qcy9kaXJlY3QuanMKaW5kZXggN2VjNWU5NS4uNjhiNTU4OSAxMDA2NDQK LS0tIGEvd2ViL3BnYWRtaW4vdG9vbHMvZGVidWdnZXIvdGVtcGxhdGVzL2Rl YnVnZ2VyL2pzL2RpcmVjdC5qcworKysgYi93ZWIvcGdhZG1pbi90b29scy9k ZWJ1Z2dlci90ZW1wbGF0ZXMvZGVidWdnZXIvanMvZGlyZWN0LmpzCkBAIC00 MDUsNyArNDA1LDggQEAgZGVmaW5lKAogICAgICAgICAgICAgICAgICk7CiAK ICAgICAgICAgICAgICAgICAvLyBVcGRhdGUgdGhlIG1lc3NhZ2UgdGFiIG9m IHRoZSBkZWJ1Z2dlcgotICAgICAgICAgICAgICAgIHBnVG9vbHMuRGlyZWN0 RGVidWcuZGJtc01lc3NhZ2VzLiRlbGVtLnRleHQocmVzLmRhdGEuc3RhdHVz X21lc3NhZ2UpOworICAgICAgICAgICAgICAgIGlmKHJlcy5kYXRhLnN0YXR1 c19tZXNzYWdlKQorICAgICAgICAgICAgICAgICAgcGdUb29scy5EaXJlY3RE ZWJ1Zy5tZXNzYWdlc19wYW5lbC4kY29udGFpbmVyLmZpbmQoJy5tZXNzYWdl cycpLmh0bWwocmVzLmRhdGEuc3RhdHVzX21lc3NhZ2UpOwogCiAgICAgICAg ICAgICAgICAgLy8gRXhlY3V0aW9uIGNvbXBsZXRlZCBzbyBkaXNhYmxlIHRo ZSBidXR0b25zIG90aGVyIHRoYW4gIkNvbnRpbnVlL1N0YXJ0IiBidXR0b24g YmVjYXVzZSB1c2VyIGNhbiBzdGlsbAogICAgICAgICAgICAgICAgIC8vIHN0 YXJ0IHRoZSBzYW1lIGV4ZWN1dGlvbiBhZ2Fpbi4KQEAgLTQzMyw3ICs0MzQs NyBAQCBkZWZpbmUoCiAgICAgICAgICAgICAgICAgICApOwogCiAgICAgICAg ICAgICAgICAgICAvLyBVcGRhdGUgdGhlIG1lc3NhZ2UgdGFiIG9mIHRoZSBk ZWJ1Z2dlcgotICAgICAgICAgICAgICAgICAgcGdUb29scy5EaXJlY3REZWJ1 Zy5tZXNzYWdlc19wYW5lbC4kY29udGFpbmVyLmZpbmQoJy5tZXNzYWdlcycp LnRleHQocmVzLmRhdGEuc3RhdHVzX21lc3NhZ2UpOworICAgICAgICAgICAg ICAgICAgcGdUb29scy5EaXJlY3REZWJ1Zy5tZXNzYWdlc19wYW5lbC4kY29u dGFpbmVyLmZpbmQoJy5tZXNzYWdlcycpLmh0bWwocmVzLmRhdGEuc3RhdHVz X21lc3NhZ2UpOwogCiAgICAgICAgICAgICAgICAgICAvLyBFeGVjdXRpb24g Y29tcGxldGVkIHNvIGRpc2FibGUgdGhlIGJ1dHRvbnMgb3RoZXIgdGhhbiAi Q29udGludWUvU3RhcnQiIGJ1dHRvbiBiZWNhdXNlIHVzZXIgY2FuIHN0aWxs CiAgICAgICAgICAgICAgICAgICAvLyBzdGFydCB0aGUgc2FtZSBleGVjdXRp b24gYWdhaW4uCkBAIC00NjcsNyArNDY4LDcgQEAgZGVmaW5lKAogICAgICAg ICAgICAgICAgIGZ1bmN0aW9uKCkgeyB9CiAgICAgICAgICAgICAgICk7CiAK LSAgICAgICAgICAgICAgcGdUb29scy5EaXJlY3REZWJ1Zy5tZXNzYWdlc19w YW5lbC4kY29udGFpbmVyLmZpbmQoJy5tZXNzYWdlcycpLnRleHQocmVzLmRh dGEuc3RhdHVzX21lc3NhZ2UpOworICAgICAgICAgICAgICBwZ1Rvb2xzLkRp cmVjdERlYnVnLm1lc3NhZ2VzX3BhbmVsLiRjb250YWluZXIuZmluZCgnLm1l c3NhZ2VzJykuaHRtbChyZXMuZGF0YS5zdGF0dXNfbWVzc2FnZSk7CiAgICAg ICAgICAgICAgIHBnVG9vbHMuRGlyZWN0RGVidWcubWVzc2FnZXNfcGFuZWwu Zm9jdXMoKTsKIAogICAgICAgICAgICAgICAvLyBFeGVjdXRpb24gY29tcGxl dGVkIHNvIGRpc2FibGUgdGhlIGJ1dHRvbnMgb3RoZXIgdGhhbiAiQ29udGlu dWUvU3RhcnQiIGJ1dHRvbiBiZWNhdXNlIHVzZXIgY2FuIHN0aWxsCg== --001a1144c42e614563053d684496 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers --001a1144c42e614563053d684496--