Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kkhTU-0006aQ-0I for pgadmin-hackers@arkaria.postgresql.org; Thu, 03 Dec 2020 05:48:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kkhTS-0006zI-VJ for pgadmin-hackers@arkaria.postgresql.org; Thu, 03 Dec 2020 05:48:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kkhTS-0006zB-LM for pgadmin-hackers@lists.postgresql.org; Thu, 03 Dec 2020 05:48:14 +0000 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kkhTN-000196-MJ for pgadmin-hackers@lists.postgresql.org; Thu, 03 Dec 2020 05:48:13 +0000 Received: by mail-ot1-x342.google.com with SMTP id h19so748884otr.1 for ; Wed, 02 Dec 2020 21:48:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e8LMaGnbIi1KYj1ywYKKBrhK5Pq28cRtr9KooRVrvHM=; b=GstyJEVfsKGp1bIyoBKFo/GspeckkAPG9KbLmYvc2f0stp4LgREdUhehIm1ZD/6XoV PuE1PtTXWjZDvVYUeZ3/EHDCp6YN3Pc5cd8D1GxhKU7QMIVhLfwV1cVoiVL43r/oQjSM HHOehNvW4sfyypmjw2gQUroRE0GoTUoO8crqncmDIx6AuE8x6SeXp8q3A/WQNfoiZN59 fNBl9TBc7JcA3qkzwrt2X0U1kCL6hP+CrnsAU30CdvqY/xbhc4wR+qu+sSg911e74HbD 68dIxicXdXQgSUQ5V7k6XpCvzVcj90uGOSiNq4MX8BEERRWUaA5GFyjmywSZewA62byF N/kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e8LMaGnbIi1KYj1ywYKKBrhK5Pq28cRtr9KooRVrvHM=; b=nzywY5a5OBYElcDm2nOgZlUVwji7e0pDUT+MMopOD3UsF8cbJDf+TLGxT5kuCgeFDn r6GdobUSX6OktEJcgp0h4pn2HAPXV0aRi7t0oYTKZ+432aOhLaIegyxti5RcpAvH9Suc HSUC35PNBbZcL2Sj4VhOQ8zLZgoy9PsHukG/r5M74gd63A2+a+hL96RIGaWqyyqrvXw6 /aRZ81ranYKMpf6pUOGx1Iw1NmL2kImUR3BFJ9BSfQwF2UMLRgaersbaui4FGaPiD/Eo 45RQ1eUFGmDxOD1fhRIxAKjSlyZXgQjo5eQNVwQ3bh7iXsB/L3BnZta5VvzbwcZRjSoy 4XlA== X-Gm-Message-State: AOAM5329NOATMOEgmE6Yde/nAeNSjMNuhrmCU00YP9J4yZbLVALfEKxu NXKbe5/oifYLT2CeXgxjw6+71ETtfk6dzOrpXasmQulWu5E3szELfo/OG1003QVwmPHEOyw/W5+ dlw9yFEvvMx3S4SL88zGxF/c8EhjoQO2oCSf17ToK1p2mmDhvfErBq176SqLiXogSNHf8eoqt+u DmWrg/nxu7OkEOUQ47PrRU76AcZjKQZKrsVJjuHSMNVBMT0w5EX9y+yZS0f6E9GZGrSNXuyZKRW Q== X-Google-Smtp-Source: ABdhPJym5+yCAdbPJnGzNblgeXfNQQSitkxSqokxalbZqSMeKxHS6eKE3t3arn6VfRE8ylYApFPjzByDezTg6keHSM8= X-Received: by 2002:a05:6830:1018:: with SMTP id a24mr1044924otp.205.1606974488631; Wed, 02 Dec 2020 21:48:08 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Murtuza Zabuawala Date: Thu, 3 Dec 2020 11:17:52 +0530 Message-ID: Subject: Re: pgAdmin 4 commit: Fixed an issue where the validation error message is To: Akshay Joshi , Rahul Shirsat Cc: pgadmin-hackers , Dave Page Content-Type: multipart/alternative; boundary="0000000000008ef59e05b588e707" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000008ef59e05b588e707 Content-Type: text/plain; charset="UTF-8" Hello, Another observation, + if(msg && handler) { + msg = msg || _.values(handler.errorModel.attributes)[0]; + + handler.trigger('pgadmin-session:model:invalid', msg, handler); + $(parentTr).addClass('error-in-grid'); + } + return this; + }, 120); + }, Here we are only making the model invalid, there is no logic to make it valid again. On Thu, Dec 3, 2020 at 11:09 AM Murtuza Zabuawala < murtuza.zabuawala@enterprisedb.com> wrote: > Hello, > > What is the reason for adding delay *setTimeout(, 120)*? > > This is causing issues in automation testing and makes buttons > enable/disable with slight delay. > > -- > Regards, > Murtuza Zabuawala > *EDB* > *POWER TO POSTGRES* > https://www.edbpostgres.com > > > On Fri, Oct 30, 2020 at 3:10 PM Akshay Joshi < > akshay.joshi@enterprisedb.com> wrote: > >> Fixed an issue where the validation error message is shown twice. Fixes >> #5736 >> >> Branch >> ------ >> master >> >> Details >> ------- >> >> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=183c83f0d2b2cb8dd33f9e8c41a030bc4cdaa4b2 >> Author: Rahul Shirsat >> >> Modified Files >> -------------- >> docs/en_US/release_notes_4_28.rst | 1 + >> web/pgadmin/browser/static/js/datamodel.js | 75 >> +++++++++++++++++++++++++++++- >> web/pgadmin/static/js/backform.pgadmin.js | 24 ++++------ >> web/pgadmin/static/scss/_alert.scss | 6 +++ >> 4 files changed, 90 insertions(+), 16 deletions(-) >> >> --0000000000008ef59e05b588e707 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

Another observation,

+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if= (msg=C2=A0&&=C2=A0handler)=C2=A0{
= +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0msg=C2=A0=3D= =C2=A0msg=C2=A0||=C2=A0_.values(handler.errorModel.attributes)[0];
+
+=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0handler.trigger('pgadmi= n-session:model:invalid',=C2=A0msg,=C2=A0handler);
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0$= (parentTr).addClass('error-in-grid');
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0}
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return=C2=A0t= his;
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= },=C2=A0120);
+=C2=A0=C2=A0=C2=A0=C2=A0},

Here we are only= making the model invalid, there is no logic to make it valid again.=


On Thu, Dec 3, 2020 at 11:09 AM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com<= /a>> wrote:


On Fri, Oct 30, 2020 at 3:10 PM Aks= hay Joshi <akshay.joshi@enterprisedb.com> wrote:
Fixed an issue where the validation error message is shown twice. Fixes #= 5736

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcommitdi= ff;h=3D183c83f0d2b2cb8dd33f9e8c41a030bc4cdaa4b2
Author: Rahul Shirsat <rahul.shirsat@enterprisedb.com>

Modified Files
--------------
docs/en_US/release_notes_4_28.rst=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0= 1 +
web/pgadmin/browser/static/js/datamodel.js | 75 +++++++++++++++++++++++++++= ++-
web/pgadmin/static/js/backform.pgadmin.js=C2=A0 | 24 ++++------
web/pgadmin/static/scss/_alert.scss=C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 6 ++= +
4 files changed, 90 insertions(+), 16 deletions(-)

--0000000000008ef59e05b588e707--