MIME-Version: 1.0
In-Reply-To: 
 <CAE+jjakiOhWWPTUxLMGGCuVhL=3pKuZjFfya5WVj0snegCZ-kQ@mail.gmail.com>
References: 
 <CAE+jjakiOhWWPTUxLMGGCuVhL=3pKuZjFfya5WVj0snegCZ-kQ@mail.gmail.com>
From: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
Date: Thu, 27 Apr 2017 12:09:36 +0530
Message-ID: 
 <CAKKotZQNrt0v2Mp+1bPSu67GS6fvqo7DwaBjvw9KYK-hDzSbwQ@mail.gmail.com>
Subject: Re: Issue with SlickGrid
To: Joao Pedro De Almeida Pereira <jdealmeidapereira@pivotal.io>
Cc: pgadmin-hackers <pgadmin-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary=f403045e9cd0afae92054e2039f8
Precedence: bulk
Sender: pgadmin-hackers-owner@postgresql.org

--f403045e9cd0afae92054e2039f8
Content-Type: text/plain; charset=UTF-8

Hello Joao,

Yes, We made some changes in SlickGrid library when we integrated it into
Query tool.

*Issue:* Last row from the query result set was not displaying correctly in
query tool when we have scrollbar in grid.

The row hight/width pixel size calculations is done inside SlickGrid
javascript code, Though we tried solve it through CSS but we had no luck,
so we had no other choice but to do it in library it self.

The changes were,
1) "getDataLengthIncludingAddNew()" function (slick.grid.js) to add two new
rows instead of one when user add values into row (one row is dummy & not
visible to user so that it displays last row correctly)
2) Other change was done into "appendRowHtml()" function to calculating the
correct number of rows in SlickGrid result as we have added our own custom
row as mentioned earlier.
3) Abbreviated long CSS classes as mentioed in README file.

Apologies we missed to update this change in README.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Apr 27, 2017 at 2:23 AM, Joao Pedro De Almeida Pereira <
jdealmeidapereira@pivotal.io> wrote:

> Hello Hackers,
>
> While doing some changes to the Query Results we found out that there was
> a issue with Slick grid.
>
> The issue that we found was with the CellSelectModel, behaved differently
> when pressing Ctrl and Command(Mac). We created a PR
> <https://github.com/6pac/SlickGrid/pull/100> with the change to changes
> the behavior of the plugin.
>
> When this PR is applied to the SlickGrid library we need to apply it to
> the current version of SlickGrid that we have vendorized.
> According to the libraries.txt file we are in version 2.2.4 of the library
> but a diff between our code and the libraries version 2.2.4 shows
> differences in the code.
>
> Did we do any change to SlickGrid library that is vendorized? Or is just
> the information in libraries.txt that is incorrect?
> Does anyone know any problem if we bump the version of SlickGrid to the
> newer version after the PR is applied?
>
> Thanks
> Joao
>

--f403045e9cd0afae92054e2039f8
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hello Joao,<div><br></div><div>Yes, We made some changes i=
n SlickGrid library when we integrated it into Query tool.</div><div><br></=
div><div><u>Issue:</u> Last row from the query result set was not displayin=
g correctly in query tool when we have scrollbar in grid.<br></div><div><br=
></div><div><div>The row hight/width pixel size calculations is done inside=
 SlickGrid javascript code, Though we tried solve it through CSS but we had=
 no luck, so we had no other choice but to do it in library it self.</div><=
/div><div>=C2=A0=C2=A0<br></div><div>The changes were,</div><div>1) &quot;g=
etDataLengthIncludingAddNew(<wbr>)&quot; function (slick.grid.js) to add tw=
o new rows instead of one when user add values into row (one row is dummy &=
amp; not visible to user so that it displays last row correctly)</div><div>=
2) Other change was done into &quot;appendRowHtml()&quot; function to calcu=
lating the correct number of rows in SlickGrid result as we have added our =
own custom row as mentioned earlier.</div><div>3) Abbreviated long CSS clas=
ses as mentioed in README file.</div><div>=C2=A0</div><div><div>Apologies w=
e missed to update this change in README.</div></div><div><br></div></div><=
div class=3D"gmail_extra"><br clear=3D"all"><div><div class=3D"gmail_signat=
ure" data-smartmail=3D"gmail_signature"><div dir=3D"ltr"><span style=3D"col=
or:rgb(136,136,136)"><font size=3D"2" face=3D"tahoma, sans-serif">--</font>=
</span><div><span style=3D"color:rgb(136,136,136)"><font size=3D"2" face=3D=
"tahoma, sans-serif">Regards,</font></span><div><font size=3D"2" face=3D"ta=
homa, sans-serif"><font color=3D"#888888">Murtuza Zabuawala</font><br style=
=3D"color:rgb(136,136,136)"><span style=3D"color:rgb(136,136,136)">Enterpri=
seDB:=C2=A0</span><a href=3D"http://www.enterprisedb.com/" rel=3D"noreferre=
r" style=3D"color:rgb(17,85,204)" target=3D"_blank">http://www.enterprisedb=
.com</a><br style=3D"color:rgb(136,136,136)"><span style=3D"color:rgb(136,1=
36,136)">The Enterprise PostgreSQL Company</span></font><br style=3D"color:=
rgb(136,136,136);font-size:12.8px"></div></div></div></div></div>
<br><div class=3D"gmail_quote">On Thu, Apr 27, 2017 at 2:23 AM, Joao Pedro =
De Almeida Pereira <span dir=3D"ltr">&lt;<a href=3D"mailto:jdealmeidapereir=
a@pivotal.io" target=3D"_blank">jdealmeidapereira@pivotal.io</a>&gt;</span>=
 wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bor=
der-left:1px #ccc solid;padding-left:1ex"><div dir=3D"ltr">Hello Hackers,<d=
iv><br></div><div>While doing some changes to the Query Results we found ou=
t that there was a issue with Slick grid.=C2=A0</div><div><br></div><div>Th=
e issue that we found was with the CellSelectModel, behaved differently whe=
n pressing Ctrl and Command(Mac). We created a <a href=3D"https://github.co=
m/6pac/SlickGrid/pull/100" target=3D"_blank">PR</a> with the change to chan=
ges the behavior of the plugin.</div><div><br></div><div>When this PR is ap=
plied to the SlickGrid library we need to apply it to the current version o=
f SlickGrid that we have vendorized.</div><div>According to the libraries.t=
xt file we are in version 2.2.4 of the library but a diff between our code =
and the libraries version 2.2.4 shows differences in the code.</div><div><b=
r></div><div>Did we do any change to SlickGrid library that is vendorized? =
Or is just the information in libraries.txt that is incorrect?</div><div>Do=
es anyone know any problem if we bump the version of SlickGrid to the newer=
 version after the PR is applied?</div><div><br></div><div>Thanks</div><spa=
n class=3D"HOEnZb"><font color=3D"#888888"><div>Joao</div></font></span></d=
iv>
</blockquote></div><br></div>

--f403045e9cd0afae92054e2039f8--