Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewS1l-0001UJ-4d for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Mar 2018 12:30:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ewS1j-0005gB-Jg for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Mar 2018 12:30:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewS1j-0005g1-8Z for pgadmin-hackers@lists.postgresql.org; Thu, 15 Mar 2018 12:30:35 +0000 Received: from mail-ot0-x22e.google.com ([2607:f8b0:4003:c0f::22e]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ewS1e-0002RE-19 for pgadmin-hackers@postgresql.org; Thu, 15 Mar 2018 12:30:33 +0000 Received: by mail-ot0-x22e.google.com with SMTP id 108-v6so6672662otv.3 for ; Thu, 15 Mar 2018 05:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=fLX0bvJ2JP7jmetElxeXdbPHeDXJ7soO0wCPRvh2Q+Q=; b=puWxcgkvl3CY/TnrWGh3wzfIjv4ztPzxyhXz37wYLOPh9PYiHKzvFse+2Xqg4ivYJq 0CjooivYDXIoEjXx4/leLCHsvxn6TEbLQruHIiy6/E4z6i+u2qicmLo7F1YI44mSOH9r Pmy8vfyCzgmdCsP1/E6jx4EFQJeHLBqjpT4b2JRMwwuaZPVmjBTDgtnwlAXRDjSIXdCP fBSy73STvVouUYBsOr//SF55AQZVrW3LzrFGw/3XdE6uitQB2C6qyZkzSWd9VUcL0Z/C XEmllbKrZZsc8d4+JoAGnG/WK0cMcgL+B8PZ3XTwsQ0Lh7Oe6xDpQ/FY3bV15Kvtp04u nyQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fLX0bvJ2JP7jmetElxeXdbPHeDXJ7soO0wCPRvh2Q+Q=; b=K9Wuw+76acMtzaLcKdP/terLLqnLwQh1ZvZfatYOLILUGAg2iamsfOYCB3dBI0nKeQ A1/0cHjBA7s1UAEzu8/1mp/66sMoHcOa745ZqbmnSCx7/owokbrppAFCLogY6J/sfU30 FzDtRf8z/jZKa7JkAJlVS8AwslmOmYyFB6TZqcryIsIF7p5oC/D9fWgnozyzBLLFVuXb 3Uvm1AVzw32wCZGMZNQSq2Jq/MJdeSulGre+7ocSIJl84TJ7jJrQNDAi/WXp8dtA0DVS 7gT9QV41C3o2eJO6NegExkGMNAbx3ZZA+1+MLJubyXKasEApT30/FYXFo6CLfU6SVzeg tsgA== X-Gm-Message-State: AElRT7HVXytY/qR++phqOVtnbk5fFIIfbQKhe/53NHmMQkQZ59VMAIUn YvRuzt5hzbNtPSsSPFtPCOXIlRDHFmuIpgfHOaDwjA== X-Google-Smtp-Source: AG47ELs4qIdCHJSYaL65rfLBdxzMMQgZB2MQGBS3msjCFBrpqEVuqwErohR6jMiQynAfu3+ETRRhAiin5loCAz3H55k= X-Received: by 10.157.31.82 with SMTP id x18mr5128729otx.291.1521117027596; Thu, 15 Mar 2018 05:30:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.8.150 with HTTP; Thu, 15 Mar 2018 05:30:07 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Thu, 15 Mar 2018 18:00:07 +0530 Message-ID: Subject: Re: pgAdmin 4 commit: Ignore config_local.py and config_distro.py when runn To: Dave Page Cc: Ashesh Vashi , pgadmin-hackers Content-Type: multipart/alternative; boundary="001a113dd2de179e71056772a89b" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --001a113dd2de179e71056772a89b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 15, 2018 at 4:53 PM, Dave Page wrote: > Hi > > On Thu, Mar 15, 2018 at 7:14 AM, Ashesh Vashi < > ashesh.vashi@enterprisedb.com> wrote: > >> Hi, >> >> I have just noticed, we're ignoring migrations directory too. >> Should we not also check code styling for migrations directory? >> > > Yeah, I was going to ask about that :-). Is there a specific reason why > we're ignoring the migrations Murtuza? > =E2=80=8BTo ease writing long SQL's. > > >> >> -- >> >> Thanks & Regards, >> >> Ashesh Vashi >> EnterpriseDB INDIA: Enterprise PostgreSQL Company >> >> >> >> *http://www.linkedin.com/in/asheshvashi* >> >> >> On Thu, Mar 15, 2018 at 4:40 PM, Dave Page wrote: >> >>> Ignore config_local.py and config_distro.py when running PEP-8 checks. >>> >>> Branch >>> ------ >>> master >>> >>> Details >>> ------- >>> https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcommitdif >>> f;h=3D53ae960aeba0dde6109b91c171f22758b1b04ebe >>> >>> Modified Files >>> -------------- >>> web/.pycodestyle | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > --001a113dd2de179e71056772a89b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Thu, Mar 15, 2018 at 4:53 PM, Dave Page <dpage@pgadmin.org&g= t; = wrote:
Hi

On Thu, Mar 15, 2018 at 7:14 AM, Ash= esh Vashi <ashesh.vashi@enterprisedb.com> w= rote:
Hi,

=
I have just noticed, we're ignoring migrations directory too.
Should we not also check code styling for migrations directory?

Yeah, I was going to ask about t= hat :-). Is there a specific reason why we're ignoring the migrations M= urtuza?
=E2=80=8BTo ease writing long SQL's.
=C2=A0
=C2=A0

--<= /span>

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL C= ompany

<= br>

<= a href=3D"http://www.linkedin.com/in/asheshvashi" target=3D"_blank">http= ://www.linkedin.com/in/asheshvashi


On Thu, Mar 15, 2018 at 4:40 PM, Dave Page <= span dir=3D"ltr"><dpage@pgadmin.org> wrote:
= Ignore config_local.py and config_distro.py when running PEP-8 checks.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcom= mitdiff;h=3D53ae960aeba0dde6109b91c171f22758b1b04ebe

Modified Files
--------------
web/.pycodestyle | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)





--
Dave Page
= Blog: http://pgsn= ake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.= com
The Enterprise PostgreSQL Company

--001a113dd2de179e71056772a89b--