Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kD2Wt-0006wv-LM for pgadmin-hackers@arkaria.postgresql.org; Tue, 01 Sep 2020 09:24:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kD2Ws-0007X8-KX for pgadmin-hackers@arkaria.postgresql.org; Tue, 01 Sep 2020 09:24:38 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kD2Ws-0007Wz-AA for pgadmin-hackers@lists.postgresql.org; Tue, 01 Sep 2020 09:24:38 +0000 Received: from mail-ot1-x32e.google.com ([2607:f8b0:4864:20::32e]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kD2Wp-00062A-0j for pgadmin-hackers@postgresql.org; Tue, 01 Sep 2020 09:24:37 +0000 Received: by mail-ot1-x32e.google.com with SMTP id 37so579648oto.4 for ; Tue, 01 Sep 2020 02:24:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DN9sWYB/UkoVrwYROZImIkCignMyhscorKqtF7whi4g=; b=fJJWKFfAmJXTrDaHYbHBPWyimdFvvFUKEmydG1dOZq7QvFeZxTJ9zJonz/CpWkoSkO gUAWOxPPxoB0876vWvKmCJbVkAGfIY0+DcFQVb2IHxPUoN4ER3ksQ3uqKmwJQtaBGFYu 53/uUjydmswe7iDF+fvTVmB+RjVX5baBlEPd5/01kSWWsqvFebyAEWGMvg/5FnsrbYrx T1CZNxHNycqx0OEGmAkaeQfy1alq1bKp4EK9ppAstXJUDCsxnt0iVbevwTM1uxYIT6XC 3LDzvHEfKTvdfz+PiwB0+ALft4oZ79YnhjOr2qg8KZU94vrqxUG5z1r1schpDKk6Qgml AzUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DN9sWYB/UkoVrwYROZImIkCignMyhscorKqtF7whi4g=; b=C/e3miabXRb1UGGFwSCJinWyECp8R5ge2qSgp3+CXlQb4yMlAU6gp4GGt8ZEXGJDKS U5BNi8k270RbMl1WjFBZ7N3cM0ZOMwPzUSLm0xvr56CYLExxjn1pX3YCuS7etlFF2UUX soY0OwZBPJxQmremgx4BF/geSYgT/bHwgpopc3qGHz2AyuYhK2NjgjAi3O/WGUkIrCSB uuhGZQJUXfIOCK9iroGzxI2rf4aSab8fkPVnX3VGUwN9L13lihkykWj1Th9Dr9BrUMGu wiBT7RJz9NPmC3c9MlzQvU19FY3G7DNMbY6Xg4M/+Z/yPL6TQeJjDUrBr6JSPtBj9Xzy 7E7w== X-Gm-Message-State: AOAM5339YvUnYr1tSTxsRTono7zfbVQOTLnaQzsG/C38Uu1vJo57FVUz yzURaY2siMtEq89gvWwM/eeBzere3v95bPdYBetHMXt4nZnNnYlDDG013tE7gtxHQT1YiznxqkP vrDxS6akGC208EA48tdB1ljzqZkQ07AZ68BfFknxCgsYX9JxjrcHwc7ce3dYZJyp8RmIDLibXr+ mbOGtGiyfaGM0pvQiFTo9hzCgedMa1biBqJkKLjYRaiwHxF0xrZhhIBj/4cw== X-Google-Smtp-Source: ABdhPJxP4e7hWtp+ZAqjKv37MMT5YTSh5S3ZyeCDiOmkale/TPxUFHfg38AMdTnxuCDijkSHoXNtJXTxwWWURhntT6E= X-Received: by 2002:a9d:6c43:: with SMTP id g3mr713104otq.82.1598952274085; Tue, 01 Sep 2020 02:24:34 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Murtuza Zabuawala Date: Tue, 1 Sep 2020 14:54:18 +0530 Message-ID: Subject: Re: More idiomatic python3 + fix some tests To: Cyril Jouve Cc: Akshay Joshi , pgadmin-hackers Content-Type: multipart/alternative; boundary="0000000000004f617805ae3d1662" X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --0000000000004f617805ae3d1662 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, On Tue, Sep 1, 2020 at 2:36 PM Cyril Jouve wrote: > thanks :) > > and sure, I'll run the linter next time! > > have you thought of automatic code formatters instead like yapf or black? > AFAIK, yapf is not consistent with formatting & black is non-configurable. I tried both sometime back and not found useful at that time but we can give it a shot with the new release. -- Murtuza > > > > Le lun. 31 ao=C3=BBt 2020 =C3=A0 13:18, Akshay Joshi > a =C3=A9crit : > >> Hi Cyril >> >> Thanks, patch applied. Please make sure to run "yarn run pep8" before >> sending the patch. >> >> On Sat, Aug 29, 2020 at 2:28 AM Cyril Jouve wrote: >> >>> Hello, >>> >>> patch 1 to 6 generated mostly using 2to3: >>> 0001: https://docs.python.org/3.8/library/2to3.html#2to3fixer-asserts >>> 0002: https://docs.python.org/3.8/library/2to3.html#2to3fixer-filter >>> 0003: https://docs.python.org/3.8/library/2to3.html#2to3fixer-idioms >>> 0004: https://docs.python.org/3.8/library/2to3.html#2to3fixer-metaclass >>> 0005: https://docs.python.org/3.8/library/2to3.html#2to3fixer-xrange >>> 0006: https://docs.python.org/3.8/library/2to3.html#2to3fixer-unicode >>> >>> patch 7 fixes change_password tests: >>> Less that min length : min is 8 instead of 6 >>> Valid password : use an user different than admin user / mock mail modu= le >>> >>> patch 8 fixes ConstraintDeleteMultipleTestCase on py3.10 (using >>> simplejson like in all other modules). >>> >>> Regards, >>> Cyril >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> *pgAdmin Hacker | Sr. Software Architect* >> *EDB Postgres * >> >> *Mobile: +91 976-788-8246* >> > --0000000000004f617805ae3d1662 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

On Tue, Sep 1, 2020 at = 2:36 PM Cyril Jouve <jv.cyril@gmail.com> wrote:
thanks :)

=
and sure, I'll run the linter next time!

= have you thought of automatic code formatters instead like yapf or black?

AFAIK, yapf is no= t consistent with formatting & black is non-configurable.
I tried both sometime back and not found useful at that time b= ut we can give it a shot with the new release.

=
-- Murtuza


<= /div>

Le=C2=A0lun. 31 ao=C3=BBt 2020 =C3=A0=C2=A013:18, Akshay Joshi <akshay.josh= i@enterprisedb.com> a =C3=A9crit=C2=A0:
Hi Cyril
<= br>
Thanks, patch applied. Please make sure to run "yarn run= pep8" before sending the patch.

On Sat, Aug 29, 2020 at 2:28= AM Cyril Jouve <jv.cyril@gmail.com> wrote:

patch 7 fixes change_password tests:
Less that min length := min is 8 instead of 6
Valid password : use an user different tha= n admin user / mock mail module

<= /div>
patch 8 fixes ConstraintDeleteMultipleTestCase on py3.10 (using s= implejson like in all other modules).

Regards,=
Cyril


--
Thanks & R= egards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect=
= EDB Postgres
Mobile: +91 976-788-8246

--0000000000004f617805ae3d1662--