Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewQCv-0002Rl-A2 for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Mar 2018 10:34:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ewQCu-00058z-BR for pgadmin-hackers@arkaria.postgresql.org; Thu, 15 Mar 2018 10:34:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewQCu-00058p-5o for pgadmin-hackers@lists.postgresql.org; Thu, 15 Mar 2018 10:34:00 +0000 Received: from mail-oi0-x229.google.com ([2607:f8b0:4003:c06::229]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ewQCp-0008Hq-Gv for pgadmin-hackers@postgresql.org; Thu, 15 Mar 2018 10:33:59 +0000 Received: by mail-oi0-x229.google.com with SMTP id p9so1420864oic.6 for ; Thu, 15 Mar 2018 03:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7LGTXJhGaJgTKHH7VpEBQs4MWhPcWDBVC5l07USXiAk=; b=JZ4cjYZI30LYvcqvl8mP/cpwfRKhPTDYhMQat/fXc39W6NnEqYspeFcUuvhUHhdH3i 8NEa6WUrqyoDrfyoSuv3iJxdL/vgxhROvg1MTLJRv+lcGYP287NWcvdHFZMOAtGsEAeP o1L2ufZU3XQf2fIxjYycoUgPpgzLPagJKnOOQUdqXcBVkohkuc+bH6AT4j6Fs271GwTM U7MegnPeqvdCK0MrTK8HGvQyx1MD8wgCsyXJ9tg1GWHbKADvB+GutsVF1iZknbDEbwkt hIXQqB4fpJiRUI/q2XHcjnNk2fRIN6bylLmw8oYSu9RXiWJWuz6uc9lsKXNMJf82fisW KTxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7LGTXJhGaJgTKHH7VpEBQs4MWhPcWDBVC5l07USXiAk=; b=nUVStd7bvtRYDSX3yhwR1ZhdvayqHNZBgzfDWrTZk6WcUrOs55TicJIoyL3FsFsvjJ pxbQs7hxKaa5C2bP1915ChnLDbSn5WtRnDz+vEPRj29FApl783evgxXUEtm1Y9HOColE Wk1B1osq7bnEt5xA2BfGDfkaf61U0zFaA0lEmGc5tTw4/jr8qOYp/hzzfbbdmqOF8rQM MF8vXcHVhZYB9cVEqw6p9KyQUxy4jhXmYZquWXcbYcLsk85NxpZCNWnkdQrS5yMpqAkA iXMN49odyFxRF585sudt8OsmGhOlp99ltZarABzZoaOd97+JQBh8u0Jzr3W6+zO/W2lo 3sig== X-Gm-Message-State: AElRT7E6pZ66xkqJTMk+Wb9ipXmE+T205ny7IWeIQdgkW7vhSU4yuv45 KX1R7EiQ67YxNWKBzNP6BjmPp2qvmUpcVcT/Mg6FKw== X-Google-Smtp-Source: AG47ELslQdzzenMi/wd308hx72Piq8GhqdiQvnVJ9P2/knqGuCLE0E4zUyNSIvUzgTHLh5Zt9RDTY6R5KXRaI8HQDJ4= X-Received: by 10.202.242.4 with SMTP id q4mr404374oih.61.1521110033338; Thu, 15 Mar 2018 03:33:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.8.150 with HTTP; Thu, 15 Mar 2018 03:33:32 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Thu, 15 Mar 2018 16:03:32 +0530 Message-ID: Subject: Re: pgAdmin 4 commit: Sporadically crashes on Windows when exit. Fixes #317 To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="94eb2c05b1da33cc9a0567710753" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --94eb2c05b1da33cc9a0567710753 Content-Type: multipart/alternative; boundary="94eb2c05b1da33cc950567710751" --94eb2c05b1da33cc950567710751 Content-Type: text/plain; charset="UTF-8" Hi Akshay, Given commit introduce PEP8 issue, PFA minor patch to fix the issue. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Thu, Mar 15, 2018 at 1:27 PM, Akshay Joshi wrote: > Sporadically crashes on Windows when exit. Fixes #3177 > 1) Shutdown the python server properly. > 2) Disabled "Shutdown server" menu till server is not successfully > started. > > Initial patch sent by Maxim, modified by Akshay Joshi. > > Branch > ------ > master > > Details > ------- > https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h= > 54b1a79cb6f90ac9b26db57e616dc750fb2c6b54 > Author: Maxim Zakharov > > Modified Files > -------------- > runtime/Server.cpp | 11 +++++++++++ > runtime/Server.h | 3 +++ > runtime/TrayIcon.cpp | 11 +++++++++++ > runtime/TrayIcon.h | 4 ++++ > runtime/pgAdmin4.cpp | 46 ++++++++++++++++++++++++++++++ > ++++++++++++++ > runtime/pgAdmin4.h | 1 + > web/pgadmin/misc/__init__.py | 16 ++++++++++++++- > 7 files changed, 91 insertions(+), 1 deletion(-) > > --94eb2c05b1da33cc950567710751 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Akshay,

Given= commit introduce PEP8 issue, PFA minor patch to fix the issue.
=

--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://= www.enterprisedb.com
The Enterprise PostgreSQL Company=

<= /div>

On Thu, Mar 15, 2018 at 1:27 PM, Akshay Josh= i <akshay.joshi@enterprisedb.com> wrote:
Sporadically crashes on Windows when exit. Fixes= #3177
=C2=A0 1) Shutdown the python server properly.
=C2=A0 2) Disabled "Shutdown server" menu till server is not succ= essfully started.

Initial patch sent by Maxim, modified by Akshay Joshi.

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=3Dpgadmin4.git;a=3Dcommitdiff;h=3D54b1a79cb6f90ac9b26db57e616dc750fb2c6b54
Author: Maxim Zakharov <dp.maxime= @gmail.com>

Modified Files
--------------
runtime/Server.cpp=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 11 +++++++++++=
runtime/Server.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 3 += ++
runtime/TrayIcon.cpp=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 11 +++++++++++
runtime/TrayIcon.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 4 ++++ runtime/pgAdmin4.cpp=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 46 ++++++++++++++++= ++++++++++++++++++++++++++++
runtime/pgAdmin4.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 1 +
web/pgadmin/misc/__init__.py | 16 ++++++++++++++-
7 files changed, 91 insertions(+), 1 deletion(-)


--94eb2c05b1da33cc950567710751-- --94eb2c05b1da33cc9a0567710753 Content-Type: application/octet-stream; name="fix_PEP8.diff" Content-Disposition: attachment; filename="fix_PEP8.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jesdmcqg0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL21pc2MvX19pbml0X18ucHkgYi93ZWIvcGdhZG1pbi9t aXNjL19faW5pdF9fLnB5CmluZGV4IDg0OGU2ZWUuLjE5ZTE4MjggMTAwNjQ0Ci0tLSBhL3dlYi9w Z2FkbWluL21pc2MvX19pbml0X18ucHkKKysrIGIvd2ViL3BnYWRtaW4vbWlzYy9fX2luaXRfXy5w eQpAQCAtMTE3LDYgKzExNyw3IEBAIGRlZiBleHBsYWluX2pzKCk6CiAgICAgICAgIG1pbWV0eXBl PSJhcHBsaWNhdGlvbi9qYXZhc2NyaXB0IgogICAgICkKIAorCiAjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIwog IyBBIHNwZWNpYWwgVVJMIHVzZWQgdG8gc2h1dGRvd24gdGhlIHNlcnZlcgogIyMjIyMjIyMjIyMj IyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMjIyMj IyMjIyMK --94eb2c05b1da33cc9a0567710753--