public inbox for [email protected]  
help / color / mirror / Atom feed
From: Murtuza Zabuawala <[email protected]>
To: Matthew Kleiman <[email protected]>
Cc: pgadmin-hackers <[email protected]>
Cc: Shruti B Iyer <[email protected]>
Subject: Re: [pgAdmin4] [PATCH] History Tab rewrite in React
Date: Thu, 18 May 2017 11:43:57 +0530
Message-ID: <CAKKotZQSTtJVkBKMeFi9vTrPugBEbEE38dhbbn-hr+hpd0Qzbw@mail.gmail.com> (raw)
In-Reply-To: <CAFS4TJYDRi6fs+wrhkj89gFe3xaFOkoApCK+AU2O4DfU2XfXog@mail.gmail.com>
References: <CAFS4TJYDRi6fs+wrhkj89gFe3xaFOkoApCK+AU2O4DfU2XfXog@mail.gmail.com>
List-Unsubscribe:  <mailto:[email protected]?body=unsub%20pgadmin-hackers>

Hi Matt,

I'm on macOS(10.10.5) & not able to run pgAdmin4 through console/terminal
(with virtual environment activated), earlier it used to work properly but
after applying given two patches it started throwing error.

*After applying the patch*

(venv_pg4) murtuza@Laptop217:*~/Documents/projects/pgadmin4*$ python
web/pgAdmin4.py

Starting pgAdmin 4. Please navigate to http://0.0.0.0:5050 in your browser.

/Library/Frameworks/Python.framework/Versions/3.5/Resources/Python.app/Contents/MacOS/Python:
can't open file 'web/pgAdmin4.py': [Errno 2] No such file or directory

(venv_pg4) murtuza@Laptop217:*~/Documents/projects/pgadmin4*$ python
--version

Python 3.5.0

(venv_pg4) murtuza@Laptop217:*~/Documents/projects/pgadmin4*$ python
web/pgAdmin4.py

Starting pgAdmin 4. Please navigate to http://0.0.0.0:5050 in your browser.

/Library/Frameworks/Python.framework/Versions/3.5/Resources/Python.app/Contents/MacOS/Python:
can't open file 'web/pgAdmin4.py': [Errno 2] No such file or directory

(venv_pg4) murtuza@Laptop217:*~/Documents/projects/pgadmin4*$


 And when I removed the patch and try again then it started properly.

*After removing the patch*

(venv_pg4) murtuza@Laptop217:~/Documents/projects/pgadmin4$ git pull

Already up-to-date.

(venv_pg4) murtuza@Laptop217:~/Documents/projects/pgadmin4$ python
web/pgAdmin4.py

Starting pgAdmin 4. Please navigate to http://0.0.0.0:5050 in your browser.

Starting pgAdmin 4. Please navigate to http://0.0.0.0:5050 in your browser.


Let me know if I missed anything here.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, May 16, 2017 at 3:07 AM, Matthew Kleiman <[email protected]>
wrote:

> Hi Hackers!
>
> *Don't panic, this patch is for AFTER 1.5 release. ;-)*
>
>
> 0001-Bring-React-into-the-codebase.patch is an infrastructural change.
> This patch brings in the React.js library and all of the tools that are
> needed for us to use React code in this project. It includes a webpack
> bundler to package and minify our javascript, a js linter to help keep the
> javascript code clean, and the Grunt taskrunner to manage these tasks.
>
> 0002-Creates-query-history-list.patch replaces the existing history tab
> with a React-based history component. The current patch brings us to
> feature-parity with the current application. However, we plan on continuing
> work on the History tab as we discussed. This is the smallest digestible
> chunk of work that we could send as a committable patch *after 1.5 is cut*
> .
>
> *Next Steps for History Tab*
> We are continuing to improve the user experience of the history tab. We
> have a series of stories lined up that lead us towards a further redesigned
> history tab. As we add the right hand panel and each query metadata item to
> it, we will be removing each query metadata item from the list view
> accordingly.
>
> Here is the design from one of the later stories:
> [image: Inline image 1]
>
> Regards,
> Shruti & Matt
>
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>


Attachments:

  [image/png] image.png (419.0K, 3-image.png)
  download | view image

view thread (45+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [pgAdmin4] [PATCH] History Tab rewrite in React
  In-Reply-To: <CAKKotZQSTtJVkBKMeFi9vTrPugBEbEE38dhbbn-hr+hpd0Qzbw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox