public inbox for [email protected]  

help / color / mirror / Atom feed
From: Murtuza Zabuawala <[email protected]>
To: pgadmin-hackers <[email protected]>
Subject: [pgAdmin4[RM#3948] Fix backform note control style
Date: Wed, 30 Jan 2019 15:52:00 +0530
Message-ID: <CAKKotZQ_05r3Az6pJYjs60PC+ARswhHz=sEZPnUfST7gfDaqtA@mail.gmail.com> (raw)

Hi,

PFA minor patch to fix the style, changed the background colour and text
colour so that it can be readable.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Attachments:

  [application/octet-stream] RM_3948.diff (1.2K, 3-RM_3948.diff)
  download | inline diff:
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index d313541b..6e8a3bdb 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -2348,7 +2348,7 @@ define([
     },
     template: _.template([
       '<div class="<%=noteClass%> pg-el-12 <%=extraClasses.join(\' \')%>">',
-      '<label class="control-label"><%=label%>:</label>',
+      '<strong><%=label%>:</strong>&nbsp;',
       '<span><%=text%></span></div>',
     ].join('\n')),
   });
diff --git a/web/pgadmin/static/scss/_backform.overrides.scss b/web/pgadmin/static/scss/_backform.overrides.scss
index 0a413e37..668e6eab 100644
--- a/web/pgadmin/static/scss/_backform.overrides.scss
+++ b/web/pgadmin/static/scss/_backform.overrides.scss
@@ -50,11 +50,11 @@
 .backform_control_notes {
 	border: $panel-border;
 	border-radius: $border-radius;
-	font-family: $font-family-editor;
-	font-size: 0.8rem;
+	font-size: 0.850rem;
 	margin: 0 0 10px;
-	padding: 5px 10px;
 	word-wrap: break-word;
+	color: $color-gray-dark;
+	background: $color-gray-lighter;
 }
 div.backform_control_notes label.control-label {
 	min-width: 0px;


view thread (6+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: [pgAdmin4[RM#3948] Fix backform note control style
  In-Reply-To: <CAKKotZQ_05r3Az6pJYjs60PC+ARswhHz=sEZPnUfST7gfDaqtA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox