Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewgNV-0007aB-3Q for pgadmin-hackers@arkaria.postgresql.org; Fri, 16 Mar 2018 03:50:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ewgNU-0003Tk-1g for pgadmin-hackers@arkaria.postgresql.org; Fri, 16 Mar 2018 03:50:00 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewgNT-0003OE-PF for pgadmin-hackers@lists.postgresql.org; Fri, 16 Mar 2018 03:49:59 +0000 Received: from mail-ot0-x231.google.com ([2607:f8b0:4003:c0f::231]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ewgNQ-0007zC-2M for pgadmin-hackers@postgresql.org; Fri, 16 Mar 2018 03:49:58 +0000 Received: by mail-ot0-x231.google.com with SMTP id l5-v6so9101851otf.9 for ; Thu, 15 Mar 2018 20:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=J9qQNJQlBu958FcELbESvXly4P+40xNwNuagZ6zANjU=; b=s1qWqcYhZfl4Avqx9yjzmJvvfF+Bwvz4rn3Wev94jkUc4AGhOC/6VtI2zdZ/oyPKRq 3vLXMwMWwlYE4xM9pJf0t0F9JjMw7vAxVA5sNC8Nt23NTfgvLsAgRoXFGokkXy006m0e 09mPX5zesmqonbA0+CDIzGwKc9G7KaRQGz70m8KaSjmXd0OcnyVFfas/46wTfBhvClQi wP+aFEpQ+kUcG0YzAdPS5pQVviBIQLo536Q+b8kpxcsNcbLUsOGAwy/zTWvw9xNMHQ/X Ia/+PaZ1QltkC0OwbdqV3NU2hxSZlsCNKNpDm70fTyWEoYcesd8fMDGSi6V4kJ2tEjlE ZoeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=J9qQNJQlBu958FcELbESvXly4P+40xNwNuagZ6zANjU=; b=cOoOIfNOTfwgq5fo0QfpB9PVpgcCzeaTTX58QPtFT0zBvMn3fAKfvSV4XoRMb13kAK L4+aVV0uDM+QLWnAj14Od0FUxtNmf8i0WEIJbTJutbYpvl6f02Sfj1qTYn92bqi7VJA2 6IZxb/+5pAq08Os1DJoVsEexvETom/cTQjv9Bj+0dQz1//K/gZgk9cTCQT9Ug5K6LPXd 4SQJsdTT/zDu+PM6OvqtA6GYgGXaUqcQ3yjpDH6FPDK82jXIeWJYYGHiMbXH6FSB8Jx4 4VprJE6Fdwqzqf+0pDiP8Uk7YdBlTUZifm006TB4GMV6eymC6fUKtbviAThyTS6oA542 GqJw== X-Gm-Message-State: AElRT7GMtQ9dGw2/TRR+lbZec+QGJn3llgbRJAc1xmw4x9zsXHVw4qYd OksRlCuamX9ry///OiUH8AIiG/Y5m8KTSj/mw0e7yg== X-Google-Smtp-Source: AG47ELv/DwSioOv23G09I/eiUBSnOjJTGtWb+y3qs2Z4EUgItfMDza00yqTjL1gRcFdEmB34td8WmdVPJU4FTxCGT44= X-Received: by 2002:a9d:5022:: with SMTP id a34-v6mr173069oth.79.1521172195430; Thu, 15 Mar 2018 20:49:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.8.150 with HTTP; Thu, 15 Mar 2018 20:49:35 -0700 (PDT) In-Reply-To: References: From: Murtuza Zabuawala Date: Fri, 16 Mar 2018 09:19:35 +0530 Message-ID: Subject: Re: [pgAdmin4][RM#3195] Include service name when executing Backup, Restore etc tools To: Victoria Henry Cc: pgadmin-hackers Content-Type: multipart/alternative; boundary="00000000000059ee8e05677f80fd" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000059ee8e05677f80fd Content-Type: text/plain; charset="UTF-8" Thanks Joao and Victoria for reviewing. As Khushboo mentioned in her previous email we already have RM for the same( https://redmine.postgresql.org/issues/3206), We will send separate patch. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Fri, Mar 16, 2018 at 2:25 AM, Victoria Henry wrote: > Hey Murtuza, > > This patch passed our test pipelines and it looks good. > Do we have any tests around this behavior? > > Joao and Victoria > --00000000000059ee8e05677f80fd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks=C2=A0Joao and Victoria for reviewing= .

As Khushboo mentioned in her= previous email we already have=C2=A0RM for the same(https://redmine.pos= tgresql.org/issues/3206), We will send separate patch.

=
--
Regards,
Murtuza Zabuawala
EnterpriseDB:=C2=A0http://www.e= nterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Mar 16, 2018 at 2:25 AM, Victoria He= nry <vhenry@pivotal.io> wrote:
Hey Murtuza,

This patch passed our= test pipelines and it looks good.
Do we have any tests around th= is behavior?

Joao and Victoria

--00000000000059ee8e05677f80fd--