Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1go34e-0002pj-FU for pgadmin-hackers@arkaria.postgresql.org; Mon, 28 Jan 2019 09:19:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1go34c-0005rj-ML for pgadmin-hackers@arkaria.postgresql.org; Mon, 28 Jan 2019 09:19:22 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1go34c-0005rc-Dq for pgadmin-hackers@lists.postgresql.org; Mon, 28 Jan 2019 09:19:22 +0000 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1go34V-0006nk-9w for pgadmin-hackers@postgresql.org; Mon, 28 Jan 2019 09:19:21 +0000 Received: by mail-oi1-x241.google.com with SMTP id v6so12461109oif.2 for ; Mon, 28 Jan 2019 01:19:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q44a65pGDoeVEk/6Wuwdrt8EbHTZcwl8Mwa+xLsB6g0=; b=grvbAQCS+4hwyH20mU7By/IknixMUM0TfWYmOXf3cl6Y/oabpbhUfG9VHXoVzQV3cD 4amMPdkjGR3FCj/lM5XIcpv4HSkMITe4zpw1PkDmlF2NSAi9nWep37x18BulnW1LNxDK swgbHAJaGKovCHtX8PliHyzDSSs91xV+P4u5e8Ha68iB5YtVlEF7PtU365u6o1qVDCZX PRAfyFpCLEoM1hLrdge8P+xaKTyorJNcnPz8RDM1sy9+x/LpExNOo/WvdE1bUnGn30CL iwwTwKr9Ko+V9rY0xWs04RNK8QHUyepdH0Yni/mcXoIgB8UMA95M+SDUBrb/IDOHUS69 ZX2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q44a65pGDoeVEk/6Wuwdrt8EbHTZcwl8Mwa+xLsB6g0=; b=OYXMVVjfZss8v1TBcOh7ObVPp09YOgvEJr2mRGj+eKvnsZ8jEZv2jnujO6XZ1wRZkI YYLxxy7R8LJHz6KyhsR+Jq+Fu2njsKGN83cFH7w/FPU/48FcKw3A0D+MZ4A4bIwF4oo5 jtPr49e0SjRscgMV8wpKGWrZ1+Cr+pLaLVto/C6bcEBmexGIndhzD9gB76+Au/sU0Zgy t/dMTwjIFCKNNR230Ln+Fl3F+8m83zg8waWjrdrXlZem/YoNWjiVv9VAZv5gZLXuAoRM aLru7reZLKQcFFlsq8UgXmRGRFRWcEoKTeRpRYz4pGjSDkr1kjFu39Vn4ZjKL4nEl/Y0 +Jjw== X-Gm-Message-State: AJcUukfwKv61zGMv358KDS3f19DuuepSA91EmECTcr61yPnamROn6m4v msaDse3DKewUBnrnHNzjr+yjb1aEljNfkntLhNhT5w== X-Google-Smtp-Source: AHgI3IZIT8R+ddHz5R+7PR2LaSoZWrXgxUG70iCZQALCCWWyJq3bG0BI4TZ+7MgY5X1ylkXOIxeYnUfVq6yhhGKJoVk= X-Received: by 2002:aca:844:: with SMTP id 65mr5326485oii.333.1548667151745; Mon, 28 Jan 2019 01:19:11 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Murtuza Zabuawala Date: Mon, 28 Jan 2019 14:49:00 +0530 Message-ID: Subject: Re: [pgAdmin4[RM#3935] Grant wizard fails to list down functions To: Akshay Joshi Cc: pgadmin-hackers Content-Type: multipart/mixed; boundary="00000000000074f30d0580812bc5" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --00000000000074f30d0580812bc5 Content-Type: multipart/alternative; boundary="00000000000074f30a0580812bc3" --00000000000074f30a0580812bc3 Content-Type: text/plain; charset="UTF-8" Hi, PFA minor patch, To display an error on UI when there is a backend error for the grant wizard request. Please review. -- Regards, Murtuza Zabuawala EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company On Mon, Jan 28, 2019 at 12:48 PM Akshay Joshi wrote: > Thanks patch applied. > > On Mon, Jan 28, 2019 at 12:01 PM Murtuza Zabuawala < > murtuza.zabuawala@enterprisedb.com> wrote: > >> Hi, >> >> PFA patch to fix the issue where EPAS DB instance running with >> *no-redwood-compat* mode fails to list down functions objects in grant >> wizard due to 'char' -> 'int' type cast error. >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> > > -- > *Akshay Joshi* > > *Sr. Software Architect * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* > --00000000000074f30a0580812bc3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

PFA minor pa= tch, To display an error on UI when there is a backend error for the grant= =C2=A0wizard request.
Please review.

=
<= div dir=3D"ltr">
--
Regards,
<= font size=3D"2">Murtuz= a Zabuawala
EnterpriseDB:=C2=A0http://www.enterprisedb.com
The= Enterprise PostgreSQL Company

<= /div>


On Mon, Jan 28, 2019 at 12:48 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:<= br>
Thanks patch applied.

On Mon, Jan 28, 2019 at 1= 2:01 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote= :
Hi,

PFA patch to fix the issue where EPAS DB=C2=A0instance running wit= h no-redwood-compat=C2= =A0mode fails to list down functions objects in grant wizard due to 'ch= ar' -> 'int' type cast=C2=A0error.

<= /div>

=
--
Regards,
Murtuza Zabuawala
EnterpriseD= B:=C2=A0http://www.enterprisedb.com
The Enterprise PostgreSQL Co= mpany



--
Akshay Joshi
Sr. Software Architect
<= div>

Phone: +91 20-3058-9517
Mobi= le: +91 976-788-8246
--00000000000074f30a0580812bc3-- --00000000000074f30d0580812bc5 Content-Type: application/octet-stream; name="RM_3935_show_error_on_UI.diff" Content-Disposition: attachment; filename="RM_3935_show_error_on_UI.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jrg4d81c0 ZGlmZiAtLWdpdCBhL3dlYi9wZ2FkbWluL3N0YXRpYy9zY3NzL19hbGVydC5zY3NzIGIvd2ViL3Bn YWRtaW4vc3RhdGljL3Njc3MvX2FsZXJ0LnNjc3MKaW5kZXggZTg2NzZiOGMuLmY1MDgyYzM3IDEw MDY0NAotLS0gYS93ZWIvcGdhZG1pbi9zdGF0aWMvc2Nzcy9fYWxlcnQuc2NzcworKysgYi93ZWIv cGdhZG1pbi9zdGF0aWMvc2Nzcy9fYWxlcnQuc2NzcwpAQCAtMjEsNyArMjEsOCBAQAogICBkaXNw bGF5OiBpbmxpbmUtYmxvY2s7CiB9CiAKLS5hbGVydC5hbGVydC1pbmZvIHsKKy5hbGVydC5hbGVy dC1pbmZvLAorLmFsZXJ0LmFsZXJ0LWRhbmdlciB7CiAgIHBhZGRpbmc6IDAuNXJlbTsKIH0KIApk aWZmIC0tZ2l0IGEvd2ViL3BnYWRtaW4vdG9vbHMvZ3JhbnRfd2l6YXJkL3N0YXRpYy9qcy9ncmFu dF93aXphcmQuanMgYi93ZWIvcGdhZG1pbi90b29scy9ncmFudF93aXphcmQvc3RhdGljL2pzL2dy YW50X3dpemFyZC5qcwppbmRleCA4NWQ3OGRhMi4uZWU5ZTBjNDUgMTAwNjQ0Ci0tLSBhL3dlYi9w Z2FkbWluL3Rvb2xzL2dyYW50X3dpemFyZC9zdGF0aWMvanMvZ3JhbnRfd2l6YXJkLmpzCisrKyBi L3dlYi9wZ2FkbWluL3Rvb2xzL2dyYW50X3dpemFyZC9zdGF0aWMvanMvZ3JhbnRfd2l6YXJkLmpz CkBAIC02MTIsNiArNjEyLDE4IEBAIGRlZmluZShbCiAgICAgICAgICAgICAgICAgICAkKCcud2l6 YXJkLXByb2dyZXNzLWJhciBwJykuaHRtbCgnJyk7CiAgICAgICAgICAgICAgICAgICAkKCcud2l6 YXJkLXByb2dyZXNzLWJhcicpLmhpZGUoKTsKICAgICAgICAgICAgICAgICB9LAorICAgICAgICAg ICAgICAgIGVycm9yOiBmdW5jdGlvbihtLCB4aHIpIHsKKyAgICAgICAgICAgICAgICAgIGxldCBt c2c7CisgICAgICAgICAgICAgICAgICBpZiAoeGhyICYmIHhoci5yZXNwb25zZUpTT04gJiYgeGhy LnJlc3BvbnNlSlNPTi5lcnJvcm1zZykgeworICAgICAgICAgICAgICAgICAgICBtc2cgPSB4aHIu cmVzcG9uc2VKU09OLmVycm9ybXNnOworICAgICAgICAgICAgICAgICAgfQorCisgICAgICAgICAg ICAgICAgICBpZighbXNnKSB7CisgICAgICAgICAgICAgICAgICAgIG1zZyA9IGdldHRleHQoJ1Vu YWJsZSB0byBmZXRjaCB0aGUgZGF0YWJhc2Ugb2JqZWN0cyBkdWUgdG8gYW4gZXJyb3InKTsKKyAg ICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICAgICQoJy53aXphcmQtcHJvZ3Jlc3Mt YmFyIHAnKS5yZW1vdmVDbGFzcygnYWxlcnQtaW5mbycpLmFkZENsYXNzKCdhbGVydC1kYW5nZXIn KTsKKyAgICAgICAgICAgICAgICAgICQoJy53aXphcmQtcHJvZ3Jlc3MtYmFyIHAnKS50ZXh0KG1z Zyk7CisgICAgICAgICAgICAgICAgfSwKICAgICAgICAgICAgICAgICByZXNldDogdHJ1ZSwKICAg ICAgICAgICAgICAgfSwgdGhpcyk7CiAK --00000000000074f30d0580812bc5--